[hibernate-commits] [hibernate/hibernate-search] 09cd09: HSEARCH-3478 Fix an NPE detected by Sonar

Branch: refs/heads/master Home: https://github.com/hibernate/hibernate-search Commit: 09cd09917cd3ee77658b75142e6e8ebeab3a8550 https://github.com/hibernate/hibernate-search/commit/09cd09917cd3ee77658b... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2019-02-08 (Fri, 08 Feb 2019) Changed paths: M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/types/predicate/impl/LuceneTextFieldPredicateBuilderFactory.java Log Message: ----------- HSEARCH-3478 Fix an NPE detected by Sonar Commit: 378de42003ab198e30ca8f9ad86bf2767009133a https://github.com/hibernate/hibernate-search/commit/378de42003ab198e30ca... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2019-02-08 (Fri, 08 Feb 2019) Changed paths: M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/work/impl/AbstractSimpleBulkableElasticsearchWork.java M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/work/impl/AbstractSimpleElasticsearchWork.java M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/work/impl/ClearScrollWork.java M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/work/impl/CloseIndexWork.java M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/work/impl/CountWork.java M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/work/impl/CreateIndexWork.java M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/work/impl/DeleteByQueryWork.java M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/work/impl/DeleteWork.java M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/work/impl/DropIndexWork.java M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/work/impl/ExplainWork.java M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/work/impl/FlushWork.java M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/work/impl/GetIndexSettingsWork.java M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/work/impl/GetIndexTypeMappingWork.java M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/work/impl/IndexExistsWork.java M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/work/impl/IndexWork.java M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/work/impl/OpenIndexWork.java M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/work/impl/OptimizeWork.java M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/work/impl/PutIndexSettingsWork.java M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/work/impl/PutIndexTypeMappingWork.java M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/work/impl/RefreshWork.java M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/work/impl/ScrollWork.java M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/work/impl/SearchWork.java M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/work/impl/WaitForIndexStatusWork.java Log Message: ----------- HSEARCH-3478 Sonar: Class names should not shadow interfaces or superclasses Commit: ec339682ccdd163f820da0db70ac996cd86dcbe8 https://github.com/hibernate/hibernate-search/commit/ec339682ccdd163f820d... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2019-02-08 (Fri, 08 Feb 2019) Changed paths: M integrationtest/showcase/library/src/main/java/org/hibernate/search/integrationtest/showcase/library/bridge/AccountBorrowalSummaryBridge.java M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/dirtiness/impl/PojoImplicitReindexingResolverMarkingNode.java Log Message: ----------- HSEARCH-3478 Sonar: Methods should not be empty Commit: 178999f4080110e464355a152061ec3af425face https://github.com/hibernate/hibernate-search/commit/178999f4080110e46435... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2019-02-08 (Fri, 08 Feb 2019) Changed paths: M util/internal/common/src/main/java/org/hibernate/search/util/impl/common/ToStringTreeBuilder.java Log Message: ----------- HSEARCH-3478 Sonar: "switch" statements should have "default" clauses ... the rule also accepts switches where we define a case for each enum constants. Commit: ad0c42eb4d1a34261fdef59d7d17f7a8ba8337bd https://github.com/hibernate/hibernate-search/commit/ad0c42eb4d1a34261fde... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2019-02-08 (Fri, 08 Feb 2019) Changed paths: M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/search/predicate/impl/AbstractElasticsearchSearchPredicateBuilder.java M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/search/predicate/impl/ElasticsearchBooleanJunctionPredicateBuilder.java M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/search/predicate/impl/ElasticsearchMatchAllPredicateBuilder.java M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/search/predicate/impl/ElasticsearchMatchIdPredicateBuilder.java M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/search/predicate/impl/ElasticsearchMatchPredicateBuilder.java M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/search/predicate/impl/ElasticsearchNestedPredicateBuilder.java M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/search/predicate/impl/ElasticsearchRangePredicateBuilder.java M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/search/sort/impl/ElasticsearchDistanceSortBuilder.java M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/search/sort/impl/ElasticsearchFieldSortBuilder.java M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/types/predicate/impl/ElasticsearchGeoPointSpatialWithinBoundingBoxPredicateBuilder.java M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/types/predicate/impl/ElasticsearchGeoPointSpatialWithinCirclePredicateBuilder.java M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/types/predicate/impl/ElasticsearchGeoPointSpatialWithinPolygonPredicateBuilder.java Log Message: ----------- HSEARCH-3478 Sonar: Methods and field names should not be the same or differ only by capitalization Commit: af944bd126812950eceef96391872dc062fae9f5 https://github.com/hibernate/hibernate-search/commit/af944bd126812950ecee... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2019-02-08 (Fri, 08 Feb 2019) Changed paths: M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/gson/impl/AbstractConfiguredExtraPropertiesJsonAdapterFactory.java M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/index/admin/impl/ElasticsearchSchemaValidatorImpl.java M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/search/predicate/impl/AbstractLuceneSpatialWithinBoundingBoxPredicateBuilder.java M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/search/predicate/impl/AbstractLuceneSpatialWithinCirclePredicateBuilder.java M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/search/predicate/impl/AbstractLuceneSpatialWithinPolygonPredicateBuilder.java M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/types/predicate/impl/LuceneGeoPointSpatialWithinBoundingBoxPredicateBuilder.java M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/types/predicate/impl/LuceneGeoPointSpatialWithinCirclePredicateBuilder.java M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/types/predicate/impl/LuceneGeoPointSpatialWithinPolygonPredicateBuilder.java Log Message: ----------- HSEARCH-3478 Sonar: Unused type parameters should be removed Commit: 8871bc23eaf9bceb11464a6636a31a2655b9e483 https://github.com/hibernate/hibernate-search/commit/8871bc23eaf9bceb1146... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2019-02-08 (Fri, 08 Feb 2019) Changed paths: M engine/src/main/java/org/hibernate/search/engine/mapper/mapping/building/impl/IndexSchemaFilter.java Log Message: ----------- HSEARCH-3478 Sonar: Collapsible "if" statements should be merged Commit: bd879ec21a4a17367e306a1204011443f15dc81c https://github.com/hibernate/hibernate-search/commit/bd879ec21a4a17367e30... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2019-02-08 (Fri, 08 Feb 2019) Changed paths: M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/index/impl/ElasticsearchIndexWorkPlan.java Log Message: ----------- HSEARCH-3478 Sonar: Methods should not have identical implementations Commit: 1a104b87221510d1a6cc9e03e14806f1f6bda198 https://github.com/hibernate/hibernate-search/commit/1a104b87221510d1a6cc... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2019-02-08 (Fri, 08 Feb 2019) Changed paths: M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/impl/ElasticsearchBackendFactory.java Log Message: ----------- HSEARCH-3478 Sonar: Unused "private" methods should be removed Commit: a7f2302899df77d513f4e3b71bbbb1fb24743c74 https://github.com/hibernate/hibernate-search/commit/a7f2302899df77d513f4... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2019-02-08 (Fri, 08 Feb 2019) Changed paths: M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/gson/impl/AbstractConfiguredExtraPropertiesJsonAdapterFactory.java M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/index/admin/impl/ValidationErrorCollector.java M build-config/src/main/java/org/hibernate/checkstyle/checks/regexp/DoubleSpacesCheck.java M build-config/src/main/java/org/hibernate/checkstyle/checks/regexp/IllegalImport.java M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/massindexing/impl/BatchIndexingWorkspace.java M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/massindexing/impl/IdentifierProducer.java M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/massindexing/impl/MassIndexerImpl.java M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/massindexing/impl/ProducerConsumerQueue.java M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/model/impl/HibernateOrmBootstrapIntrospector.java Log Message: ----------- HSEARCH-3478 Sonar: The diamond operator ("<>") should be used Commit: 7778c377b53e7e3be5dd4324d7dd43c90af7b634 https://github.com/hibernate/hibernate-search/commit/7778c377b53e7e3be5dd... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2019-02-08 (Fri, 08 Feb 2019) Changed paths: M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/client/impl/GsonHttpEntity.java M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/gson/impl/JsonElementType.java M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/types/predicate/impl/LuceneTextRangePredicateBuilder.java M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/massindexing/impl/IdentifierProducer.java Log Message: ----------- HSEARCH-3478 Sonar: Boolean literals should not be redundant Commit: 56ab8960a273f9938800459b797b332cffd2c268 https://github.com/hibernate/hibernate-search/commit/56ab8960a273f9938800... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2019-02-08 (Fri, 08 Feb 2019) Changed paths: M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/search/reader/impl/MultiReaderFactory.java M engine/src/main/java/org/hibernate/search/engine/common/impl/ErrorContextImpl.java M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/massindexing/impl/BatchCoordinator.java M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/massindexing/impl/BatchIndexingWorkspace.java Log Message: ----------- HSEARCH-3478 Sonar: Collection.isEmpty() should be used to test for emptiness Commit: bbe20445b7ae082c2b792f3fd499619b3e11e5fb https://github.com/hibernate/hibernate-search/commit/bbe20445b7ae082c2b79... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2019-02-08 (Fri, 08 Feb 2019) Changed paths: M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/cfg/HibernateOrmIndexingStrategyName.java M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/dirtiness/impl/NoOpPojoImplicitReindexingResolver.java M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/dirtiness/impl/NoOpPojoImplicitReindexingResolverNode.java M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/processing/impl/NoOpPojoIndexingProcessor.java Log Message: ----------- HSEARCH-3478 Sonar: Static non-final field names should comply with a naming convention Commit: 5cc352fc8d79469d320740493f323593bc277c90 https://github.com/hibernate/hibernate-search/commit/5cc352fc8d79469d3207... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2019-02-08 (Fri, 08 Feb 2019) Changed paths: M build-config/src/main/java/org/hibernate/checkstyle/filters/ExcludeTestPackages.java M engine/src/main/java/org/hibernate/search/engine/spatial/ImmutableGeoPolygon.java Log Message: ----------- HSEARCH-3478 Sonar: Return of boolean expressions should not be wrapped into an "if-then-else" statement Commit: b4fd85bee8f0b25eea0fd46bc86e5b6b65d2b82c https://github.com/hibernate/hibernate-search/commit/b4fd85bee8f0b25eea0f... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2019-02-08 (Fri, 08 Feb 2019) Changed paths: M integrationtest/showcase/library/src/main/java/org/hibernate/search/integrationtest/showcase/library/model/AbstractEntity.java Log Message: ----------- HSEARCH-3478 Sonar: Type parameter names should comply with a naming convention Commit: fb697677ae2033de1becffb0d6e46e15e4ba3895 https://github.com/hibernate/hibernate-search/commit/fb697677ae2033de1bec... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2019-02-08 (Fri, 08 Feb 2019) Changed paths: M mapper/javabean/src/main/java/org/hibernate/search/mapper/javabean/impl/JavaBeanEntityTypeContributor.java M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/mapping/impl/HibernateOrmAssociationEmbeddedMetadataContributor.java M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/mapping/impl/HibernateOrmAssociationInverseSideMetadataContributor.java M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/mapping/impl/HibernateOrmEntityTypeMetadataContributor.java M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/mapping/building/spi/ErrorCollectingPojoPropertyMetadataContributor.java M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/mapping/building/spi/ErrorCollectingPojoTypeMetadataContributor.java M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/mapping/building/spi/PojoMetadataContributor.java M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/mapping/definition/programmatic/impl/AbstractPropertyFieldMappingContext.java M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/mapping/definition/programmatic/impl/AssociationInverseSideMappingContextImpl.java M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/mapping/definition/programmatic/impl/IndexingDependencyMappingContextImpl.java M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/mapping/definition/programmatic/impl/InitialPropertyMappingContext.java M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/mapping/definition/programmatic/impl/MarkerMappingContributor.java M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/mapping/definition/programmatic/impl/PropertyBridgeMappingContributor.java M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/mapping/definition/programmatic/impl/PropertyDocumentIdMappingContextImpl.java M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/mapping/definition/programmatic/impl/PropertyIndexedEmbeddedMappingContextImpl.java M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/mapping/definition/programmatic/impl/RoutingKeyBridgeMappingContributor.java M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/mapping/definition/programmatic/impl/TypeBridgeMappingContributor.java M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/mapping/definition/programmatic/impl/TypeMappingContextImpl.java M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/model/additionalmetadata/building/impl/PojoTypeAdditionalMetadataProvider.java Log Message: ----------- HSEARCH-3478 Fix obsolete names detected by Sonar ("Model" => "AdditionalMetadata") Commit: ba9b1f128882749c4cc3582104f6b3cdd6abf695 https://github.com/hibernate/hibernate-search/commit/ba9b1f128882749c4cc3... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2019-02-08 (Fri, 08 Feb 2019) Changed paths: M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/impl/FullTextQueryImpl.java Log Message: ----------- HSEARCH-3478 Sonar: "Collections.EMPTY_LIST", "EMPTY_MAP", and "EMPTY_SET" should not be used Commit: b0578cfbbcbb2f3b1216f81b225ff680cd9f7e7b https://github.com/hibernate/hibernate-search/commit/b0578cfbbcbb2f3b1216... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2019-02-08 (Fri, 08 Feb 2019) Changed paths: M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/work/impl/DefaultElasticsearchRequestSuccessAssessor.java Log Message: ----------- HSEARCH-3478 Sonar: Parentheses should be removed from a single lambda input parameter when its type is inferred Commit: f7fb7b9d7e3297b6dd35e1cfb2c26bcb6ced7eae https://github.com/hibernate/hibernate-search/commit/f7fb7b9d7e3297b6dd35... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2019-02-08 (Fri, 08 Feb 2019) Changed paths: M engine/src/main/java/org/hibernate/search/engine/cfg/ConfigurationPropertySource.java R engine/src/main/java/org/hibernate/search/engine/cfg/impl/PropertiesConfigurationPropertySource.java Log Message: ----------- HSEARCH-3478 Remove the unused, deprecated PropertiesConfigurationPropertySource detected by Sonar Commit: 27b73071870a1d13ffa396063c55fed50d6a8d01 https://github.com/hibernate/hibernate-search/commit/27b73071870a1d13ffa3... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2019-02-08 (Fri, 08 Feb 2019) Changed paths: M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/dialect/impl/ElasticsearchDialectFactory.java Log Message: ----------- HSEARCH-3478 Sonar: Optional value should only be accessed after calling isPresent() Commit: 5faf64264bbb31ca588af3bf9224623aae374328 https://github.com/hibernate/hibernate-search/commit/5faf64264bbb31ca588a... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2019-02-08 (Fri, 08 Feb 2019) Changed paths: M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/search/extraction/impl/DistanceCollector.java Log Message: ----------- HSEARCH-3425 Remove an unnecessary mask Commit: 046b48424b75ca908d05209d0ec99591e508086d https://github.com/hibernate/hibernate-search/commit/046b48424b75ca908d05... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2019-02-08 (Fri, 08 Feb 2019) Changed paths: M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/cfg/ElasticsearchIndexLifecycleStrategyName.java M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/cfg/ElasticsearchIndexStatus.java M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/cfg/MultiTenancyStrategyName.java M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/cfg/MultiTenancyStrategyName.java M engine/src/main/java/org/hibernate/search/engine/common/spi/LogErrorHandler.java M engine/src/main/java/org/hibernate/search/engine/spatial/DistanceUnit.java M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/cfg/HibernateOrmIndexingStrategyName.java Log Message: ----------- HSEARCH-3425 Warnings: unnecessary modifiers Commit: 44e90b834e7343f0ae867379ef4c6036895a5725 https://github.com/hibernate/hibernate-search/commit/44e90b834e7343f0ae86... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2019-02-08 (Fri, 08 Feb 2019) Changed paths: M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/document/model/impl/esnative/DynamicType.java M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/index/admin/impl/ValidationContextType.java M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/work/result/impl/CreateIndexResult.java M util/internal/integrationtest/common/src/main/java/org/hibernate/search/util/impl/integrationtest/common/stub/backend/document/model/StubIndexSchemaNode.java Log Message: ----------- HSEARCH-3425 Unnecessary semicolons Commit: 1c5d36fd39c7bb54be16fc17bdddd73d774b8657 https://github.com/hibernate/hibernate-search/commit/1c5d36fd39c7bb54be16... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2019-02-08 (Fri, 08 Feb 2019) Changed paths: M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/impl/ElasticsearchBackendImpl.java M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/index/impl/ElasticsearchIndexManagerImpl.java M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/impl/LuceneBackendImpl.java M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/index/impl/LuceneIndexManagerImpl.java M engine/src/main/java/org/hibernate/search/engine/environment/classpath/spi/ClassLoaderHelper.java M engine/src/main/java/org/hibernate/search/engine/search/dsl/predicate/impl/RangePredicateFieldSetContextImpl.java M integrationtest/backend/elasticsearch/src/test/java/org/hibernate/search/integrationtest/backend/elasticsearch/testsupport/util/ElasticsearchClientSubmitCall.java M integrationtest/mapper/pojo/src/test/java/org/hibernate/search/integrationtest/mapper/pojo/mapping/definition/FieldContainerExtractorExplicitIT.java M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/impl/FullTextQueryImpl.java M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/impl/HibernateSearchContextService.java M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/bridge/impl/AnnotationInitializingBeanDelegatingBridgeBuilder.java M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/bridge/impl/AnnotationInitializingBeanDelegatingMarkerBuilder.java M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/dirtiness/impl/PojoImplicitReindexingResolverPropertyNode.java M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/mapping/building/impl/PojoIndexModelBinderImpl.java M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/model/additionalmetadata/impl/PojoEntityTypeAdditionalMetadata.java M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/model/impl/PojoModelPropertyElementAccessor.java M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/model/spi/GenericContextAwarePojoGenericTypeModel.java M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/processing/impl/PojoIndexingProcessorPropertyNode.java M util/internal/integrationtest/common/src/main/java/org/hibernate/search/util/impl/integrationtest/common/assertion/SearchResultAssert.java M util/internal/integrationtest/common/src/main/java/org/hibernate/search/util/impl/integrationtest/common/stub/backend/index/impl/StubIndexManager.java M util/internal/integrationtest/common/src/main/java/org/hibernate/search/util/impl/integrationtest/common/stub/backend/types/dsl/impl/StubIndexFieldTypeFactoryContext.java M util/internal/integrationtest/common/src/main/java/org/hibernate/search/util/impl/integrationtest/common/stub/mapper/StubMapperUtils.java Log Message: ----------- HSEARCH-3425 Warnings: unchecked casts Commit: fc1d0671d0d092811ec8ceed646af711774bdaf5 https://github.com/hibernate/hibernate-search/commit/fc1d0671d0d092811ec8... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2019-02-08 (Fri, 08 Feb 2019) Changed paths: M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/document/model/impl/esnative/ElasticsearchFormatJsonAdapter.java M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/index/impl/ElasticsearchIndexWorkPlan.java M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/orchestration/impl/ElasticsearchSerialChangesetsWorkOrchestrator.java M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/index/impl/LuceneIndexWorkPlan.java M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/event/impl/FullTextIndexEventListener.java M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/massindexing/impl/MassIndexerImpl.java M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/dirtiness/building/impl/PojoIndexingDependencyCollectorValueNode.java M util/internal/common/src/main/java/org/hibernate/search/util/impl/common/SearchThreadFactory.java M util/internal/integrationtest/common/src/main/java/org/hibernate/search/util/impl/integrationtest/common/stub/backend/search/projection/impl/StubCompositeBiFunctionSearchProjection.java M util/internal/integrationtest/common/src/main/java/org/hibernate/search/util/impl/integrationtest/common/stub/backend/search/projection/impl/StubCompositeTriFunctionSearchProjection.java Log Message: ----------- HSEARCH-3425 Warnings: redundant local variables Commit: 072e704ad0fd24596d3f081257ebc90d93939478 https://github.com/hibernate/hibernate-search/commit/072e704ad0fd24596d3f... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2019-02-08 (Fri, 08 Feb 2019) Changed paths: M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/index/admin/gson/impl/AnalysisParameterEquivalenceRegistry.java M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/search/predicate/impl/ElasticsearchMatchIdPredicateBuilder.java M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/work/impl/CreateIndexWork.java M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/work/impl/OptimizeWork.java M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/work/impl/RefreshWork.java M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/analysis/model/dsl/impl/InitialLuceneAnalysisDefinitionContainerContext.java M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/search/extraction/impl/DistanceCollector.java M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/search/extraction/impl/LuceneCollectorsBuilder.java M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/search/extraction/impl/LuceneDocumentStoredFieldVisitorBuilder.java M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/search/predicate/impl/LuceneMatchIdPredicateBuilder.java M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/types/codec/impl/LuceneFieldFieldCodec.java M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/types/sort/impl/AbstractLuceneStandardFieldSortBuilder.java M engine/src/main/java/org/hibernate/search/engine/environment/bean/impl/BeanConfigurationContextImpl.java M engine/src/main/java/org/hibernate/search/engine/search/dsl/projection/impl/CompositeProjectionContextImpl.java M engine/src/main/java/org/hibernate/search/engine/search/dsl/projection/impl/DocumentReferenceProjectionContextImpl.java M engine/src/main/java/org/hibernate/search/engine/search/dsl/projection/impl/FieldProjectionContextImpl.java M engine/src/main/java/org/hibernate/search/engine/search/dsl/projection/impl/ObjectProjectionContextImpl.java M engine/src/main/java/org/hibernate/search/engine/search/dsl/projection/impl/ReferenceProjectionContextImpl.java M engine/src/main/java/org/hibernate/search/engine/search/dsl/projection/impl/ScoreProjectionContextImpl.java M engine/src/main/java/org/hibernate/search/engine/spatial/DistanceUnit.java M engine/src/main/java/org/hibernate/search/engine/spatial/ImmutableGeoBoundingBox.java M integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/DocumentModelDslIT.java M integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/MultiTenancyIT.java M integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/search/SearchQueryIT.java M integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/work/IndexWorkExecutorIT.java M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/cfg/HibernateOrmIndexingStrategyName.java M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/dirtiness/building/impl/PojoImplicitReindexingResolverBuilder.java M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/dirtiness/building/impl/PojoImplicitReindexingResolverMarkingNodeBuilder.java M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/dirtiness/building/impl/PojoImplicitReindexingResolverPropertyNodeBuilder.java M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/dirtiness/building/impl/PojoIndexingDependencyCollectorValueNode.java M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/extractor/builtin/BuiltinContainerExtractor.java M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/extractor/impl/ContainerExtractorBinder.java M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/mapping/building/impl/PojoIndexedTypeManagerBuilder.java M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/processing/building/impl/PojoIndexingProcessorPropertyNodeBuilder.java M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/work/impl/PojoMappingWorkExecutorImpl.java M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/work/impl/PojoSessionWorkExecutorImpl.java M util/internal/integrationtest/common/src/main/java/org/hibernate/search/util/impl/integrationtest/common/stub/backend/StubBackendBehavior.java M util/internal/integrationtest/common/src/main/java/org/hibernate/search/util/impl/integrationtest/common/stub/backend/document/model/impl/StubIndexSchemaObjectFieldNodeBuilder.java M util/internal/integrationtest/common/src/main/java/org/hibernate/search/util/impl/integrationtest/common/stub/mapper/StubMapperUtils.java M util/internal/test/src/main/java/org/hibernate/search/util/impl/test/rule/ExpectedLog4jLog.java M util/internal/test/src/main/java/org/hibernate/search/util/impl/test/rule/StaticCounters.java Log Message: ----------- HSEARCH-3425 Warnings: Declaration can have final modifier Commit: dba2ed24a9456e9a2215fff10ecd00f53d045fd6 https://github.com/hibernate/hibernate-search/commit/dba2ed24a9456e9a2215... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2019-02-08 (Fri, 08 Feb 2019) Changed paths: M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/orchestration/impl/ElasticsearchDefaultWorkSequenceBuilder.java Log Message: ----------- HSEARCH-3425 Warnings: method always return null Commit: 303b3a2b7a1d544ae24cbe542794745dbf4882f6 https://github.com/hibernate/hibernate-search/commit/303b3a2b7a1d544ae24c... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2019-02-08 (Fri, 08 Feb 2019) Changed paths: M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/client/impl/GsonHttpEntity.java M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/client/impl/ProgressiveCharBufferWriter.java M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/orchestration/impl/ElasticsearchBatchingSharedWorkOrchestrator.java M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/analysis/impl/HibernateSearchResourceLoader.java M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/search/extraction/impl/DistanceCollector.java M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/search/extraction/impl/ReusableDocumentStoredFieldVisitor.java M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/search/reader/impl/ManagedMultiReader.java M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/massindexing/impl/IdentifierConsumerDocumentProducer.java M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/massindexing/impl/IdentifierProducer.java Log Message: ----------- HSEARCH-3425 Warnings: declared exception is never thrown Commit: aea58cb1ac469a33dcdf94ca8c35059196f65b65 https://github.com/hibernate/hibernate-search/commit/aea58cb1ac469a33dcdf... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2019-02-08 (Fri, 08 Feb 2019) Changed paths: M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/document/model/impl/esnative/ElasticsearchFormatJsonAdapter.java Log Message: ----------- HSEARCH-3425 Warnings: unnecessary use of streams Commit: 6e7c406722253e634f1b60c13a44e7ead3719b64 https://github.com/hibernate/hibernate-search/commit/6e7c406722253e634f1b... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2019-02-08 (Fri, 08 Feb 2019) Changed paths: M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/search/query/impl/ElasticsearchSearchQueryBuilderFactory.java M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/search/query/impl/LuceneSearchQueryBuilderFactory.java M util/internal/integrationtest/common/src/main/java/org/hibernate/search/util/impl/integrationtest/common/stub/backend/index/impl/StubSearchQueryBuilderFactory.java Log Message: ----------- HSEARCH-3425 Warnings: 'for' loop replaceable with 'foreach' Commit: 806776bfb9bb1efdb2100b7f2e9014d2a345c8db https://github.com/hibernate/hibernate-search/commit/806776bfb9bb1efdb210... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2019-02-08 (Fri, 08 Feb 2019) Changed paths: M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/orchestration/impl/ElasticsearchParallelChangesetsWorkOrchestrator.java M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/work/impl/AbstractSimpleBulkableElasticsearchWork.java M backend/elasticsearch/src/test/java/org/hibernate/search/backend/elasticsearch/orchestration/impl/ElasticsearchDefaultWorkSequenceBuilderTest.java M engine/src/main/java/org/hibernate/search/engine/common/impl/SearchIntegrationBuilderImpl.java M engine/src/main/java/org/hibernate/search/engine/environment/classpath/spi/ClassLoaderHelper.java M engine/src/main/java/org/hibernate/search/engine/logging/impl/Log.java M engine/src/main/java/org/hibernate/search/engine/logging/spi/MappingKeyFormatter.java M engine/src/test/java/org/hibernate/search/engine/cfg/spi/ConfigurationPropertyBeanReferenceTest.java M engine/src/test/java/org/hibernate/search/engine/cfg/spi/ConfigurationPropertyInvalidSimpleValuesTest.java M engine/src/test/java/org/hibernate/search/engine/cfg/spi/ConfigurationPropertyValidMissingValuesTest.java M engine/src/test/java/org/hibernate/search/engine/cfg/spi/ConfigurationPropertyValidSimpleValuesTest.java M integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/search/projection/FieldSearchProjectionIT.java M integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/work/IndexDocumentWorkExecutorIT.java M integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/work/IndexWorkExecutorIT.java M integrationtest/mapper/pojo/src/test/java/org/hibernate/search/integrationtest/mapper/pojo/mapping/definition/DocumentIdBaseIT.java M integrationtest/mapper/pojo/src/test/java/org/hibernate/search/integrationtest/mapper/pojo/mapping/definition/FieldBaseIT.java M integrationtest/mapper/pojo/src/test/java/org/hibernate/search/integrationtest/mapper/pojo/mapping/definition/FieldContainerExtractorBaseIT.java M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/logging/impl/Log.java M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/mapping/impl/HibernateOrmMetatadaContributor.java M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/model/impl/HibernateOrmPathFilterFactory.java M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/extractor/ContainerExtractorPath.java M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/extractor/builtin/BuiltinContainerExtractor.java M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/extractor/impl/ContainerExtractorBinder.java M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/logging/impl/Log.java M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/logging/spi/PojoTypeModelFormatter.java M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/mapping/definition/annotation/ContainerExtractorRef.java M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/mapping/definition/annotation/impl/AnnotationProcessorHelper.java M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/mapping/definition/programmatic/AssociationInverseSideMappingContext.java M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/mapping/definition/programmatic/IndexingDependencyMappingContext.java M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/mapping/definition/programmatic/PropertyFieldMappingContext.java M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/mapping/definition/programmatic/PropertyIndexedEmbeddedMappingContext.java M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/mapping/impl/PojoWorkPlanImpl.java M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/model/additionalmetadata/building/impl/PojoEntityTypeAdditionalMetadataBuilder.java M mapper/pojo/src/test/java/org/hibernate/search/mapper/pojo/dirtiness/building/impl/PojoAssociationPathInverterTest.java M mapper/pojo/src/test/java/org/hibernate/search/mapper/pojo/model/typepattern/impl/TypePatternMatcherFactoryTest.java M mapper/pojo/src/test/java/org/hibernate/search/mapper/pojo/util/impl/GenericTypeContextTest.java M util/internal/common/src/main/java/org/hibernate/search/util/impl/common/logging/EnumFormatter.java M util/internal/common/src/main/java/org/hibernate/search/util/impl/common/logging/TypeFormatter.java M util/internal/integrationtest/common/src/main/java/org/hibernate/search/util/impl/integrationtest/common/assertion/SearchResultAssert.java M util/internal/integrationtest/common/src/main/java/org/hibernate/search/util/impl/integrationtest/common/stub/backend/document/model/StubIndexSchemaNode.java M util/internal/test/src/main/java/org/hibernate/search/util/impl/test/ExceptionMatcherBuilder.java Log Message: ----------- HSEARCH-3425 Warnings: raw types Commit: 2ff3fa706abd90e3946582222313592bbc235c6a https://github.com/hibernate/hibernate-search/commit/2ff3fa706abd90e39465... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2019-02-08 (Fri, 08 Feb 2019) Changed paths: M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/search/query/impl/LuceneSearcher.java Log Message: ----------- HSEARCH-3425 Warnings: unnecessary explicit unboxing Commit: 803748825f7ab1f9cce18ece691bb2be167e3269 https://github.com/hibernate/hibernate-search/commit/803748825f7ab1f9cce1... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2019-02-08 (Fri, 08 Feb 2019) Changed paths: M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/gson/impl/AbstractConfiguredExtraPropertiesJsonAdapterFactory.java M util/internal/common/src/main/java/org/hibernate/search/util/impl/common/Executors.java Log Message: ----------- HSEARCH-3425 Warnings: Explicit type argument can be replaced with <> Commit: ee4dff10406c9c5bd2f265054ba9f9d06b824399 https://github.com/hibernate/hibernate-search/commit/ee4dff10406c9c5bd2f2... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2019-02-08 (Fri, 08 Feb 2019) Changed paths: M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/util/impl/AnalyzerUtils.java M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/massindexing/impl/IdentifierProducer.java Log Message: ----------- HSEARCH-3425 Warnings: use try-with-resources where possible Commit: 395dbb91949d616465aeec0329cad2eb490c82cc https://github.com/hibernate/hibernate-search/commit/395dbb91949d616465ae... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2019-02-08 (Fri, 08 Feb 2019) Changed paths: M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/orchestration/impl/ElasticsearchDefaultWorkExecutionContext.java M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/search/reader/impl/ManagedMultiReader.java Log Message: ----------- HSEARCH-3425 Warnings: lambda can be replaced with method reference Commit: e46a3874ccdfa78c6d9ebeb9572bbefed139c937 https://github.com/hibernate/hibernate-search/commit/e46a3874ccdfa78c6d9e... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2019-02-08 (Fri, 08 Feb 2019) Changed paths: M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/client/impl/GsonHttpEntity.java M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/types/codec/impl/ElasticsearchFieldCodec.java M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/work/impl/BulkWork.java M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/search/projection/impl/LuceneSearchProjection.java M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/search/reader/impl/ManagedMultiReader.java M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/massindexing/impl/IdentifierConsumerDocumentProducer.java M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/massindexing/impl/IdentifierProducer.java M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/massindexing/impl/MassIndexerImpl.java M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/bridge/builtin/spatial/annotation/GeoPointBridge.java Log Message: ----------- HSEARCH-3425 Warnings: Invalid javadoc Commit: 5354f91d913ce3bc2902e975ba67470d6210b3c4 https://github.com/hibernate/hibernate-search/commit/5354f91d913ce3bc2902... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2019-02-08 (Fri, 08 Feb 2019) Changed paths: M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/bridge/builtin/spatial/annotation/GeoPointBridge.java Log Message: ----------- HSEARCH-3425 Warnings: unused constants Commit: 6215f30444f8daa9b80c951cbf1ab0d8c37d353b https://github.com/hibernate/hibernate-search/commit/6215f30444f8daa9b80c... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2019-02-08 (Fri, 08 Feb 2019) Changed paths: M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/orchestration/impl/ElasticsearchParallelChangesetsWorkOrchestrator.java M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/search/impl/LuceneSearchQueryElementCollector.java M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/search/reader/impl/ManagedMultiReader.java M engine/src/main/java/org/hibernate/search/engine/environment/classpath/spi/DefaultClassAndResourceResolver.java M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/mapping/impl/PojoWorkPlanImpl.java M util/internal/integrationtest/common/src/main/java/org/hibernate/search/util/impl/integrationtest/common/assertion/SearchResultAssert.java Log Message: ----------- HSEARCH-3425 Warnings: Call to 'toArray()' with pre-sized array argument 'new CompletableFuture[futures.size()]' Commit: 2c092504023ee70bad2c954547576c425a5e925e https://github.com/hibernate/hibernate-search/commit/2c092504023ee70bad2c... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2019-02-08 (Fri, 08 Feb 2019) Changed paths: M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/gson/impl/AbstractConfiguredExtraPropertiesJsonAdapterFactory.java M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/work/impl/DefaultElasticsearchRequestSuccessAssessor.java M build-config/src/main/java/org/hibernate/checkstyle/checks/regexp/IllegalImport.java Log Message: ----------- HSEARCH-3425 Warnings: Manual array to collection copy Commit: 481790d1c82e8439eb4febf9c11c795cc6eff06c https://github.com/hibernate/hibernate-search/commit/481790d1c82e8439eb4f... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2019-02-08 (Fri, 08 Feb 2019) Changed paths: M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/client/impl/ElasticsearchClientFactoryImpl.java M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/index/admin/gson/impl/AnalysisJsonElementEquivalence.java Log Message: ----------- HSEARCH-3425 Warnings: Suspicious variable assignments Commit: 94c88755e12f9461df3532d2fcc34dea8dc19f3c https://github.com/hibernate/hibernate-search/commit/94c88755e12f9461df35... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2019-02-08 (Fri, 08 Feb 2019) Changed paths: M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/index/admin/impl/ElasticsearchSchemaValidatorImpl.java Log Message: ----------- HSEARCH-3425 Warnings: NPE Commit: 90a49c0fc4f3ae13984a4802698aa6abac28c217 https://github.com/hibernate/hibernate-search/commit/90a49c0fc4f3ae13984a... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2019-02-08 (Fri, 08 Feb 2019) Changed paths: M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/mapping/building/impl/PojoMapper.java Log Message: ----------- HSEARCH-3425 Warnings: unused assignment Commit: babd444c4f03e3a1cccc098d4c6779148aecf1c9 https://github.com/hibernate/hibernate-search/commit/babd444c4f03e3a1cccc... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2019-02-08 (Fri, 08 Feb 2019) Changed paths: M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/index/admin/impl/ElasticsearchSchemaValidatorImpl.java M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/search/query/impl/LuceneSearchQueryBuilderFactory.java M util/internal/integrationtest/common/src/main/java/org/hibernate/search/util/impl/integrationtest/common/rule/SearchWorkCall.java M util/internal/test/src/main/java/org/hibernate/search/util/impl/test/ExceptionMatcherBuilder.java M util/internal/test/src/main/java/org/hibernate/search/util/impl/test/rule/ExpectedLog4jLog.java Log Message: ----------- HSEARCH-3425 Warnings: Explicit type arguments can be inferred Commit: a2a297c9aee96d8958c9683c053dd7e884125937 https://github.com/hibernate/hibernate-search/commit/a2a297c9aee96d8958c9... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2019-02-08 (Fri, 08 Feb 2019) Changed paths: M build-config/src/main/java/org/hibernate/checkstyle/checks/regexp/DoubleSpacesCheck.java Log Message: ----------- HSEARCH-3425 Warnings: double space in regexp is hard to read Commit: 37026ce66e01d2d93f8b3ddd517687d6ddd6fcd7 https://github.com/hibernate/hibernate-search/commit/37026ce66e01d2d93f8b... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2019-02-08 (Fri, 08 Feb 2019) Changed paths: M integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/search/predicate/BoolSearchPredicateIT.java Log Message: ----------- HSEARCH-3425 Add tests for filter() methods for the boolean predicate Some warnings allowed me to find out they were not covered by tests. Commit: 3d917383a8d2a8660781097026e8b838b5fd5e97 https://github.com/hibernate/hibernate-search/commit/3d917383a8d2a8660781... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2019-02-08 (Fri, 08 Feb 2019) Changed paths: M integrationtest/mapper/pojo/src/test/java/org/hibernate/search/integrationtest/mapper/pojo/mapping/definition/AbstractFieldContainerExtractorIT.java M integrationtest/mapper/pojo/src/test/java/org/hibernate/search/integrationtest/mapper/pojo/mapping/definition/FieldContainerExtractorExplicitIT.java M integrationtest/mapper/pojo/src/test/java/org/hibernate/search/integrationtest/mapper/pojo/mapping/definition/FieldContainerExtractorImplicitIT.java Log Message: ----------- HSEARCH-3425 Add missing tests for the OptionalLong/OptionalDouble container extractors Spotted thanks to warnings about BuiltinContainers.OPTIONAL_LONG not being used. Commit: 17f1581929c536b549d85e11f09ff8fa53d41990 https://github.com/hibernate/hibernate-search/commit/17f1581929c536b549d8... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2019-02-08 (Fri, 08 Feb 2019) Changed paths: M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/client/impl/Paths.java M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/document/model/impl/esnative/DataType.java M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/gson/impl/DefaultGsonProvider.java M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/gson/impl/UnexpectedJsonElementTypeException.java M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/gson/spi/JsonLogHelper.java M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/index/admin/impl/ElasticsearchIndexAdministrationClient.java M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/index/admin/impl/ElasticsearchSchemaAccessor.java M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/index/admin/impl/ElasticsearchSchemaCreatorImpl.java M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/index/admin/impl/ElasticsearchSchemaDropper.java M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/index/admin/impl/ElasticsearchSchemaDropperImpl.java M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/index/admin/impl/ElasticsearchSchemaMigrator.java M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/index/admin/impl/ElasticsearchSchemaMigratorImpl.java M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/index/admin/impl/ElasticsearchSchemaValidator.java M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/index/admin/impl/ElasticsearchSchemaValidatorImpl.java M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/logging/impl/Log.java M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/search/impl/ElasticsearchSearchQueryElementCollector.java M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/search/impl/ElasticsearchSearchTargetModel.java M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/search/sort/impl/ElasticsearchSearchSortCollector.java M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/work/builder/impl/CountWorkBuilder.java M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/work/builder/impl/DeleteByQueryWorkBuilder.java M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/work/impl/CountWork.java M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/work/impl/DeleteByQueryWork.java M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/document/model/impl/LuceneIndexSchemaFieldNode.java M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/search/extraction/impl/LuceneCollectorsBuilder.java M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/search/impl/LuceneSearchQueryElementCollector.java M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/search/impl/LuceneSearchTargetModel.java M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/search/query/impl/LuceneSearcher.java M engine/src/main/java/org/hibernate/search/engine/backend/document/spi/IndexSchemaObjectFieldDefinitionHelper.java M engine/src/main/java/org/hibernate/search/engine/common/impl/ErrorContextImpl.java M engine/src/main/java/org/hibernate/search/engine/common/spi/ErrorContext.java M engine/src/main/java/org/hibernate/search/engine/common/spi/ErrorContextBuilder.java M engine/src/main/java/org/hibernate/search/engine/common/spi/SearchIntegration.java M engine/src/main/java/org/hibernate/search/engine/mapper/mapping/building/impl/AbstractIndexModelBindingContext.java M engine/src/main/java/org/hibernate/search/engine/mapper/mapping/building/spi/IndexModelBindingContext.java R engine/src/main/java/org/hibernate/search/engine/mapper/model/spi/SearchModel.java M engine/src/main/java/org/hibernate/search/engine/search/dsl/predicate/impl/DefaultSearchPredicateFactoryContext.java M engine/src/main/java/org/hibernate/search/engine/search/dsl/predicate/impl/MatchIdPredicateContextImpl.java M engine/src/main/java/org/hibernate/search/engine/spatial/ImmutableGeoPolygon.java M engine/src/test/java/org/hibernate/search/engine/cfg/spi/ConfigurationPropertyInvalidSimpleValuesTest.java M integrationtest/backend/elasticsearch/src/test/java/org/hibernate/search/integrationtest/backend/elasticsearch/search/query/ElasticsearchSearchQueryIT.java M integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/search/predicate/MatchIdSearchPredicateIT.java M integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/search/predicate/MatchIdWithConverterSearchPredicateIT.java M integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/search/predicate/MatchSearchPredicateIT.java M integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/search/predicate/NestedSearchPredicateIT.java M integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/search/projection/CompositeSearchProjectionIT.java M integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/search/projection/FieldSearchProjectionIT.java M integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/search/projection/SearchProjectionIT.java M integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/testsupport/types/FieldTypeDescriptor.java M integrationtest/mapper/orm/src/test/java/org/hibernate/search/integrationtest/mapper/orm/model/BridgeUsingPropertyMarkerAccessIT.java M integrationtest/mapper/pojo/src/test/java/org/hibernate/search/integrationtest/mapper/pojo/mapping/definition/BridgeIT.java M integrationtest/mapper/pojo/src/test/java/org/hibernate/search/integrationtest/mapper/pojo/mapping/definition/DependencyIT.java M integrationtest/mapper/pojo/src/test/java/org/hibernate/search/integrationtest/mapper/pojo/mapping/definition/DocumentIdBaseIT.java M integrationtest/mapper/pojo/src/test/java/org/hibernate/search/integrationtest/mapper/pojo/mapping/definition/IndexedEmbeddedBaseIT.java M integrationtest/mapper/pojo/src/test/java/org/hibernate/search/integrationtest/mapper/pojo/mapping/definition/IndexedIT.java M integrationtest/mapper/pojo/src/test/java/org/hibernate/search/integrationtest/mapper/pojo/mapping/definition/KeywordFieldIT.java M integrationtest/showcase/library/src/test/java/org/hibernate/search/integrationtest/showcase/OrmElasticsearchLibraryShowcaseIT.java M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/bootstrap/impl/HibernateSearchIntegrator.java M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/bootstrap/impl/HibernateSearchSessionFactoryObserver.java M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/event/impl/FullTextIndexEventListener.java M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/logging/impl/Log.java M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/extractor/impl/ChainingContainerExtractor.java M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/mapping/building/spi/ErrorCollectingPojoPropertyMetadataContributor.java M mapper/pojo/src/test/java/org/hibernate/search/mapper/pojo/util/impl/GenericTypeContextTest.java M util/internal/common/src/main/java/org/hibernate/search/util/impl/common/StringHelper.java M util/internal/common/src/test/java/org/hibernate/search/util/impl/common/SuppressingCloserTest.java M util/internal/integrationtest/common/src/main/java/org/hibernate/search/util/impl/integrationtest/common/stub/backend/StubBackendBehavior.java M util/internal/integrationtest/common/src/main/java/org/hibernate/search/util/impl/integrationtest/common/stub/backend/index/impl/StubIndexSearchTargetContext.java R util/internal/integrationtest/common/src/main/java/org/hibernate/search/util/impl/integrationtest/common/stub/backend/search/StubHit.java Log Message: ----------- HSEARCH-3425 Warnings: unused methods/constants/parameters/etc. Commit: 553ad8a95058d38131bf7f81b0b12599842cbb31 https://github.com/hibernate/hibernate-search/commit/553ad8a95058d38131bf... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2019-02-08 (Fri, 08 Feb 2019) Changed paths: M integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/search/spatial/DistanceSearchProjectionIT.java Log Message: ----------- HSEARCH-3425 Fix a typo in tests Commit: 1eaee61b01598394604ff3a0536b67f957ac06be https://github.com/hibernate/hibernate-search/commit/1eaee61b01598394604f... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2019-02-08 (Fri, 08 Feb 2019) Changed paths: M util/internal/test/src/main/java/org/hibernate/search/util/impl/test/FutureAssert.java Log Message: ----------- HSEARCH-3425 Warnings: Caught exception is immediately rethrown Commit: 6c6b857e22f3a92a065950f98e8e67fec508a797 https://github.com/hibernate/hibernate-search/commit/6c6b857e22f3a92a0659... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2019-02-08 (Fri, 08 Feb 2019) Changed paths: M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/search/projection/impl/ElasticsearchExplanationProjection.java M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/search/projection/impl/ElasticsearchFieldProjection.java M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/search/projection/impl/ElasticsearchSourceProjection.java M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/search/query/impl/ElasticsearchSearchResultExtractorImpl.java M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/search/projection/impl/LuceneFieldProjection.java M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/search/query/impl/LuceneSearchResultExtractorImpl.java M engine/src/test/java/org/hibernate/search/engine/common/dsl/impl/DslExtensionStateTest.java M integrationtest/mapper/orm/src/test/java/org/hibernate/search/integrationtest/mapper/orm/automaticindexing/AutomaticIndexingMappedSuperclassIT.java M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/impl/FullTextQueryImpl.java M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/bridge/builtin/impl/DefaultJavaUtilDateValueBridge.java M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/bridge/impl/BridgeResolver.java M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/dirtiness/impl/PojoImplicitReindexingResolverDirtinessFilterNode.java M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/extractor/impl/ContainerExtractorBinder.java M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/mapping/definition/programmatic/impl/PropertyFullTextFieldMappingContextImpl.java M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/mapping/impl/PropertyIdentifierMapping.java M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/model/impl/AbstractPojoModelCompositeElement.java M mapper/pojo/src/test/java/org/hibernate/search/mapper/pojo/dirtiness/building/impl/PojoAssociationPathInverterTest.java M util/internal/integrationtest/common/src/main/java/org/hibernate/search/util/impl/integrationtest/common/assertion/SearchResultAssert.java M util/internal/test/src/main/java/org/hibernate/search/util/impl/test/ExceptionMatcherBuilder.java Log Message: ----------- HSEARCH-3425 Warnings: Unnecessary @SuppressWarning Commit: 516cad60fc8feb95404b8412952f6e76c908fb24 https://github.com/hibernate/hibernate-search/commit/516cad60fc8feb95404b... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2019-02-08 (Fri, 08 Feb 2019) Changed paths: M backend/elasticsearch/src/test/java/org/hibernate/search/backend/elasticsearch/orchestration/impl/ElasticsearchParallelChangesetsWorkOrchestratorTest.java M backend/elasticsearch/src/test/java/org/hibernate/search/backend/elasticsearch/orchestration/impl/ElasticsearchSerialChangesetsWorkOrchestratorTest.java M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/impl/HibernateSearchContextService.java Log Message: ----------- HSEARCH-3425 Warnings: resource leak Commit: 858ba954a72e4847a4485ce1d8d7a9d248e49341 https://github.com/hibernate/hibernate-search/commit/858ba954a72e4847a448... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2019-02-08 (Fri, 08 Feb 2019) Changed paths: M integrationtest/showcase/library/src/test/java/org/hibernate/search/integrationtest/showcase/ManualIndexingIT.java M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/impl/HibernateSearchContextService.java Log Message: ----------- HSEARCH-3425 Warnings: dead code Commit: ddf3af023b3982262286cc65d40c8fa4a5c11bf4 https://github.com/hibernate/hibernate-search/commit/ddf3af023b3982262286... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2019-02-08 (Fri, 08 Feb 2019) Changed paths: M integrationtest/backend/elasticsearch/src/test/java/org/hibernate/search/integrationtest/backend/elasticsearch/ElasticsearchExtensionIT.java M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/bootstrap/impl/ExtendedBeanManagerSynchronizer.java M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/model/impl/HibernateOrmBootstrapIntrospector.java Log Message: ----------- HSEARCH-3425 Warnings: use of deprecated code Commit: 45edec6478b978e644f71d4272ef1a66c3782409 https://github.com/hibernate/hibernate-search/commit/45edec6478b978e644f7... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2019-02-08 (Fri, 08 Feb 2019) Changed paths: M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/dirtiness/building/impl/PojoIndexingDependencyCollectorValueNode.java Log Message: ----------- HSEARCH-3425 Warning: type parameter name hides another type parameter Commit: 5ec767bf55182a5840382e1fa6dbf11907dfc9c7 https://github.com/hibernate/hibernate-search/commit/5ec767bf55182a584038... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2019-02-08 (Fri, 08 Feb 2019) Changed paths: M documentation/src/test/resources/META-INF/persistence.xml Log Message: ----------- HSEARCH-3425 Warning: missing XML schema Commit: a5b9475a140336e7c909b2d916216f7fed29195b https://github.com/hibernate/hibernate-search/commit/a5b9475a140336e7c909... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2019-02-08 (Fri, 08 Feb 2019) Changed paths: M engine/src/test/java/org/hibernate/search/engine/common/dsl/impl/DslExtensionStateTest.java Log Message: ----------- HSEARCH-3425 Missing @Override annotations Compare: https://github.com/hibernate/hibernate-search/compare/1554f4d0bad8...a5b9...