[hibernate-commits] [hibernate/hibernate-orm] 6a630e: make PostInsertIdentifierGenerator extend InDataba...

Branch: refs/heads/main Home: https://github.com/hibernate/hibernate-orm Commit: 6a630e3515fa7343524899bf8fb1fa70110ce4cd https://github.com/hibernate/hibernate-orm/commit/6a630e3515fa7343524899b... Author: Gavin <gavin(a)hibernate.org&gt; Date: 2022-12-02 (Fri, 02 Dec 2022) Changed paths: M hibernate-core/src/main/java/org/hibernate/boot/internal/InFlightMetadataCollectorImpl.java M hibernate-core/src/main/java/org/hibernate/dialect/identity/IdentityColumnSupport.java M hibernate-core/src/main/java/org/hibernate/dialect/temptable/TemporaryTable.java M hibernate-core/src/main/java/org/hibernate/engine/spi/SessionFactoryDelegatingImpl.java M hibernate-core/src/main/java/org/hibernate/engine/spi/SessionFactoryImplementor.java M hibernate-core/src/main/java/org/hibernate/event/internal/AbstractSaveEventListener.java M hibernate-core/src/main/java/org/hibernate/id/AbstractPostInsertGenerator.java M hibernate-core/src/main/java/org/hibernate/id/BulkInsertionCapableIdentifierGenerator.java M hibernate-core/src/main/java/org/hibernate/id/Configurable.java M hibernate-core/src/main/java/org/hibernate/id/IdentityGenerator.java M hibernate-core/src/main/java/org/hibernate/id/IncrementGenerator.java M hibernate-core/src/main/java/org/hibernate/id/PostInsertIdentifierGenerator.java M hibernate-core/src/main/java/org/hibernate/id/PostInsertIdentityPersister.java M hibernate-core/src/main/java/org/hibernate/id/SelectGenerator.java M hibernate-core/src/main/java/org/hibernate/id/enhanced/TableGenerator.java M hibernate-core/src/main/java/org/hibernate/id/factory/IdentifierGeneratorFactory.java M hibernate-core/src/main/java/org/hibernate/id/factory/internal/IdentifierGeneratorUtil.java M hibernate-core/src/main/java/org/hibernate/id/factory/internal/StandardIdentifierGeneratorFactory.java M hibernate-core/src/main/java/org/hibernate/id/insert/AbstractReturningDelegate.java M hibernate-core/src/main/java/org/hibernate/id/insert/AbstractSelectingDelegate.java M hibernate-core/src/main/java/org/hibernate/id/insert/BasicSelectingDelegate.java M hibernate-core/src/main/java/org/hibernate/id/insert/InsertReturningDelegate.java M hibernate-core/src/main/java/org/hibernate/id/insert/InsertSelectIdentityInsert.java M hibernate-core/src/main/java/org/hibernate/internal/SessionFactoryImpl.java M hibernate-core/src/main/java/org/hibernate/internal/StatelessSessionImpl.java M hibernate-core/src/main/java/org/hibernate/mapping/Component.java M hibernate-core/src/main/java/org/hibernate/mapping/KeyValue.java M hibernate-core/src/main/java/org/hibernate/mapping/SimpleValue.java M hibernate-core/src/main/java/org/hibernate/persister/collection/AbstractCollectionPersister.java M hibernate-core/src/main/java/org/hibernate/persister/entity/AbstractEntityPersister.java M hibernate-core/src/main/java/org/hibernate/persister/entity/EntityPersister.java M hibernate-core/src/main/java/org/hibernate/persister/entity/mutation/AbstractMutationCoordinator.java M hibernate-core/src/main/java/org/hibernate/persister/entity/mutation/InsertCoordinator.java M hibernate-core/src/main/java/org/hibernate/persister/entity/mutation/UpdateCoordinatorStandard.java M hibernate-core/src/main/java/org/hibernate/query/sqm/internal/QuerySqmImpl.java M hibernate-core/src/main/java/org/hibernate/query/sqm/mutation/internal/cte/CteInsertHandler.java M hibernate-core/src/main/java/org/hibernate/query/sqm/mutation/internal/temptable/InsertExecutionDelegate.java M hibernate-core/src/main/java/org/hibernate/query/sqm/mutation/internal/temptable/TableBasedInsertHandler.java M hibernate-core/src/main/java/org/hibernate/query/sqm/sql/BaseSqmToSqlAstConverter.java M hibernate-core/src/main/java/org/hibernate/tuple/GeneratedAlwaysValueGeneration.java M hibernate-core/src/main/java/org/hibernate/tuple/GeneratedValueGeneration.java M hibernate-core/src/main/java/org/hibernate/tuple/IdentifierAttribute.java M hibernate-core/src/main/java/org/hibernate/tuple/IdentifierProperty.java M hibernate-core/src/main/java/org/hibernate/tuple/InDatabaseGenerator.java M hibernate-core/src/main/java/org/hibernate/tuple/PropertyFactory.java M hibernate-core/src/main/java/org/hibernate/tuple/ValueGeneration.java M hibernate-core/src/main/java/org/hibernate/tuple/entity/EntityMetamodel.java M hibernate-core/src/test/java/org/hibernate/orm/test/hql/BulkManipulationTest.java Log Message: ----------- make PostInsertIdentifierGenerator extend InDatabaseGenerator Commit: 7b0ca427dd813f8365dbd06b0be8834ed348d180 https://github.com/hibernate/hibernate-orm/commit/7b0ca427dd813f8365dbd06... Author: Gavin <gavin(a)hibernate.org&gt; Date: 2022-12-02 (Fri, 02 Dec 2022) Changed paths: R hibernate-core/src/main/java/org/hibernate/id/AbstractPostInsertGenerator.java M hibernate-core/src/main/java/org/hibernate/id/BulkInsertionCapableIdentifierGenerator.java M hibernate-core/src/main/java/org/hibernate/id/IdentityGenerator.java M hibernate-core/src/main/java/org/hibernate/id/PostInsertIdentifierGenerator.java M hibernate-core/src/main/java/org/hibernate/id/SelectGenerator.java M hibernate-core/src/main/java/org/hibernate/id/enhanced/SequenceStyleGenerator.java M hibernate-core/src/main/java/org/hibernate/id/insert/AbstractSelectingDelegate.java M hibernate-core/src/main/java/org/hibernate/id/insert/BasicSelectingDelegate.java M hibernate-core/src/main/java/org/hibernate/id/insert/InsertGeneratedIdentifierDelegate.java A hibernate-core/src/main/java/org/hibernate/id/insert/SelectGeneratorDelegate.java M hibernate-core/src/main/java/org/hibernate/persister/entity/AbstractEntityPersister.java M hibernate-core/src/main/java/org/hibernate/persister/entity/EntityPersister.java M hibernate-core/src/main/java/org/hibernate/query/sqm/mutation/internal/temptable/InsertExecutionDelegate.java M hibernate-core/src/main/java/org/hibernate/tuple/InDatabaseGenerator.java Log Message: ----------- remove nexus between Generators and InsertGeneratedIdentifierDelegates this is certain a very debatable move, but I think it's necessary to keep the layering intact - we don't want this very technical construct hanging off the side of the Generator APIs, which are user-visible Commit: 4195772c1581cba15e89683ba2c2175c71a359cc https://github.com/hibernate/hibernate-orm/commit/4195772c1581cba15e89683... Author: Gavin <gavin(a)hibernate.org&gt; Date: 2022-12-02 (Fri, 02 Dec 2022) Changed paths: M hibernate-core/src/main/java/org/hibernate/NotYetImplementedFor6Exception.java M hibernate-core/src/main/java/org/hibernate/id/IdentifierGeneratorHelper.java M hibernate-core/src/main/java/org/hibernate/id/insert/AbstractReturningDelegate.java M hibernate-core/src/main/java/org/hibernate/id/insert/AbstractSelectingDelegate.java M hibernate-core/src/main/java/org/hibernate/id/insert/BasicSelectingDelegate.java A hibernate-core/src/main/java/org/hibernate/id/insert/DelegateHelper.java M hibernate-core/src/main/java/org/hibernate/id/insert/GetGeneratedKeysDelegate.java M hibernate-core/src/main/java/org/hibernate/id/insert/IdentifierGeneratingInsert.java M hibernate-core/src/main/java/org/hibernate/id/insert/InsertReturningDelegate.java M hibernate-core/src/main/java/org/hibernate/id/insert/InsertSelectIdentityInsert.java R hibernate-core/src/main/java/org/hibernate/id/insert/SelectGeneratorDelegate.java M hibernate-core/src/main/java/org/hibernate/id/insert/TableInsertReturningBuilder.java A hibernate-core/src/main/java/org/hibernate/id/insert/UniqueKeySelectingDelegate.java M hibernate-core/src/main/java/org/hibernate/persister/entity/AbstractEntityPersister.java M hibernate-core/src/main/java/org/hibernate/sql/Insert.java M hibernate-core/src/main/java/org/hibernate/sql/model/ast/builder/AbstractTableInsertBuilder.java Log Message: ----------- generalize the InsertReturningDelegates to handle arbitrary InDatabaseGenerators the bit limitation is that an InDatabaseGenerator can be multi-column, but all the InsertReturningDelegates assume that they map exactly one IDENTITY column Commit: 337919b7662523efbde2571741d4ecafac7745c8 https://github.com/hibernate/hibernate-orm/commit/337919b7662523efbde2571... Author: Gavin <gavin(a)hibernate.org&gt; Date: 2022-12-02 (Fri, 02 Dec 2022) Changed paths: M hibernate-core/src/main/java/org/hibernate/id/AbstractUUIDGenerator.java M hibernate-core/src/main/java/org/hibernate/id/Assigned.java M hibernate-core/src/main/java/org/hibernate/id/CompositeNestedGeneratedValueGenerator.java M hibernate-core/src/main/java/org/hibernate/id/ForeignGenerator.java M hibernate-core/src/main/java/org/hibernate/id/GUIDGenerator.java M hibernate-core/src/main/java/org/hibernate/id/IdentifierGeneratorHelper.java M hibernate-core/src/main/java/org/hibernate/id/IdentityGenerator.java M hibernate-core/src/main/java/org/hibernate/id/IncrementGenerator.java M hibernate-core/src/main/java/org/hibernate/id/OptimizableGenerator.java M hibernate-core/src/main/java/org/hibernate/id/ResultSetIdentifierConsumer.java M hibernate-core/src/main/java/org/hibernate/id/SelectGenerator.java M hibernate-core/src/main/java/org/hibernate/id/UUIDGenerator.java M hibernate-core/src/main/java/org/hibernate/id/factory/spi/StandardGenerator.java M hibernate-core/src/main/java/org/hibernate/id/insert/AbstractSelectingDelegate.java M hibernate-core/src/main/java/org/hibernate/id/insert/BasicSelectingDelegate.java M hibernate-core/src/main/java/org/hibernate/id/insert/GetGeneratedKeysDelegate.java M hibernate-core/src/main/java/org/hibernate/id/insert/InsertGeneratedIdentifierDelegate.java M hibernate-core/src/main/java/org/hibernate/id/insert/InsertReturningDelegate.java M hibernate-core/src/main/java/org/hibernate/id/insert/UniqueKeySelectingDelegate.java M hibernate-core/src/test/java/org/hibernate/orm/test/fetchmode/toone/EagerToOneWithJoinFetchModeTests.java Log Message: ----------- kill off some awful code in IdentifierGeneratorHelper - should make multi-column (post insert) id generators work by side effect - also make StandardGenerator a mixin type interface Commit: 392b2f2364309aae34be0062828419c9792e5a56 https://github.com/hibernate/hibernate-orm/commit/392b2f2364309aae34be006... Author: Gavin <gavin(a)hibernate.org&gt; Date: 2022-12-02 (Fri, 02 Dec 2022) Changed paths: M hibernate-core/src/main/java/org/hibernate/id/insert/InsertGeneratedIdentifierDelegate.java Log Message: ----------- update javadoc for InsertGeneratedIdentifierDelegate Compare: https://github.com/hibernate/hibernate-orm/compare/4b2f8ff8ae09...392b2f2...