[hibernate-commits] [hibernate/hibernate-orm] 1dfb62: HHH-20598 Add test for issue

Branch: refs/heads/main Home: https://github.com/hibernate/hibernate-orm Commit: 1dfb62e9c603fabbb928ed551164d1ff76a9ac8a https://github.com/hibernate/hibernate-orm/commit/1dfb62e9c603fabbb928ed5... Author: Andrea Boriero <andrea(a)hibernate.org&gt; Date: 2026-06-19 (Fri, 19 Jun 2026) Changed paths: M hibernate-core/src/test/java/org/hibernate/orm/test/boot/jaxb/mapping/HbmTransformationJaxbTests.java A hibernate-core/src/test/java/org/hibernate/orm/test/boot/jaxb/mapping/sortnatural/Person.java A hibernate-core/src/test/resources/xml/jaxb/mapping/sort-natural/hbm.xml Log Message: ----------- HHH-20598 Add test for issue Test demonstrates that HbmXmlTransformer incorrectly passes sort="natural" through as a comparator class name instead of converting it to <sort-natural/>. The orm.xml reader then fails trying to load class "natural". Co-Authored-By: Claude Opus 4.6 (1M context) <noreply(a)anthropic.com&gt; Commit: 93a653d6891eb194922dc371676c6234dfa9c38d https://github.com/hibernate/hibernate-orm/commit/93a653d6891eb194922dc37... Author: Andrea Boriero <andrea(a)hibernate.org&gt; Date: 2026-06-19 (Fri, 19 Jun 2026) Changed paths: M hibernate-core/src/main/java/org/hibernate/boot/jaxb/hbm/transform/HbmXmlTransformer.java Log Message: ----------- HHH-20598 HbmXmlTransformer converts sort="natural" as a comparator class name instead of <sort-natural/> When hbm.xml has sort="natural" on a set or map, the transformer now emits <sort-natural/> (via setSortNatural()) instead of passing "natural" as a comparator class name to setSort(). Custom comparator class names (sort="com.example.MyComparator") continue to use setSort() as before. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply(a)anthropic.com&gt; Commit: 5f86b406f90448ba8e83caab2d469eadb9c0f427 https://github.com/hibernate/hibernate-orm/commit/5f86b406f90448ba8e83caa... Author: Andrea Boriero <andrea(a)hibernate.org&gt; Date: 2026-06-19 (Fri, 19 Jun 2026) Changed paths: M hibernate-core/src/test/java/org/hibernate/orm/test/boot/jaxb/mapping/HbmTransformationJaxbTests.java A hibernate-core/src/test/java/org/hibernate/orm/test/boot/jaxb/mapping/compositeelement/EmbeddedAddress.java A hibernate-core/src/test/java/org/hibernate/orm/test/boot/jaxb/mapping/compositeelement/MyEntity.java A hibernate-core/src/test/resources/xml/jaxb/mapping/composite-element/hbm.xml Log Message: ----------- HHH-20599 Add test for issue Test demonstrates that HbmXmlTransformer sets a table attribute on columns inside composite-element embeddables, causing the orm.xml reader to interpret it as a secondary table reference instead of recognizing that the columns belong to the collection table. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply(a)anthropic.com&gt; Commit: c909d2c29aba61acf1facb2d570b1d4426770c5f https://github.com/hibernate/hibernate-orm/commit/c909d2c29aba61acf1facb2... Author: Andrea Boriero <andrea(a)hibernate.org&gt; Date: 2026-06-19 (Fri, 19 Jun 2026) Changed paths: M hibernate-core/src/main/java/org/hibernate/boot/jaxb/hbm/transform/HbmXmlTransformer.java Log Message: ----------- HHH-20599 HbmXmlTransformer sets wrong table attribute on composite-element columns causing secondary table error Two fixes for composite-element columns in collections: 1. Set currentBaseTable to the collection table when processing composite-element attributes, so the table name check in transferColumnsAndFormulas strips the table attribute from basic property columns (they belong to the collection table, not a secondary table). 2. Apply the same currentBaseTable check in the Value-based overload of transferColumnsAndFormulas, which is used for many-to-one join columns inside composite-elements. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply(a)anthropic.com&gt; Compare: https://github.com/hibernate/hibernate-orm/compare/94df08ef53c8...c909d2c... To unsubscribe from these emails, change your notification settings at https://github.com/hibernate/hibernate-orm/settings/notifications