[hibernate-commits] [hibernate/hibernate-search] e36ca4: HSEARCH-840 Rename IndexManager to MappedIndexMana...

Branch: refs/heads/master Home: https://github.com/hibernate/hibernate-search Commit: e36ca42dda959ade60ae672d4165c0b6508e1905 https://github.com/hibernate/hibernate-search/commit/e36ca42dda959ade60ae... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2018-09-11 (Tue, 11 Sep 2018) Changed paths: R engine/src/main/java/org/hibernate/search/engine/backend/index/spi/IndexManager.java M engine/src/main/java/org/hibernate/search/engine/backend/index/spi/IndexManagerImplementor.java M engine/src/main/java/org/hibernate/search/engine/common/impl/IndexManagerBuildingStateHolder.java A engine/src/main/java/org/hibernate/search/engine/common/impl/MappedIndexManagerImpl.java M engine/src/main/java/org/hibernate/search/engine/mapper/mapping/building/spi/IndexManagerBuildingState.java A engine/src/main/java/org/hibernate/search/engine/mapper/mapping/spi/MappedIndexManager.java M engine/src/main/java/org/hibernate/search/engine/search/ProjectionConstants.java M integrationtest/backend/elasticsearch/src/test/java/org/hibernate/search/integrationtest/backend/elasticsearch/ExtensionIT.java M integrationtest/backend/lucene/src/test/java/org/hibernate/search/integrationtest/backend/lucene/ExtensionIT.java M integrationtest/backend/lucene/src/test/java/org/hibernate/search/integrationtest/backend/lucene/search/LuceneSearchMultiIndexIT.java M integrationtest/backend/lucene/src/test/java/org/hibernate/search/integrationtest/backend/lucene/search/LuceneSearchSortIT.java M integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/IndexFieldAccessorIT.java M integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/MultiTenancyIT.java M integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/ObjectFieldStorageIT.java M integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/SmokeIT.java M integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/search/SearchMultiIndexIT.java M integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/search/SearchQueryIT.java M integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/search/SearchResultLoadingOrTransformingIT.java M integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/search/predicate/BoolSearchPredicateIT.java M integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/search/predicate/MatchAllSearchPredicateIT.java M integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/search/predicate/MatchSearchPredicateIT.java M integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/search/predicate/NestedSearchPredicateIT.java M integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/search/predicate/RangeSearchPredicateIT.java M integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/search/predicate/SearchPredicateIT.java M integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/search/predicate/spatial/AbstractSpatialWithinSearchPredicateIT.java M integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/search/projection/SearchProjectionIT.java M integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/search/sort/SearchSortByFieldIT.java M integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/search/sort/SearchSortIT.java M integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/util/rule/SearchSetupHelper.java M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/mapping/impl/PojoIndexedTypeManager.java M util/internal/integrationtest/common/src/main/java/org/hibernate/search/util/impl/integrationtest/common/stub/mapper/StubMapper.java M util/internal/integrationtest/common/src/main/java/org/hibernate/search/util/impl/integrationtest/common/stub/mapper/StubMapping.java Log Message: ----------- HSEARCH-840 Rename IndexManager to MappedIndexManager ... to make it obvious that it's an SPI for the mapper rather than an actual API. And since it's now clearly tainted by mapper-layer concept, add a class to act as an adapter between MappedIndexManager (the interface exposed to the mapper layer) and IndexManagerImplementor (the interface implemented by the backend layer). Commit: aefed24cd0720db90502cc4fd6d3ef666e48e4d2 https://github.com/hibernate/hibernate-search/commit/aefed24cd0720db90502... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2018-09-11 (Tue, 11 Sep 2018) Changed paths: M engine/src/main/java/org/hibernate/search/engine/backend/Backend.java Log Message: ----------- HSEARCH-840 Add missing javadoc to the Backend interface (which is API) We will add a similar interface for index managers, so let's document everything correctly. Commit: 749dd93d688db3a9f38b1ad15304637851917d52 https://github.com/hibernate/hibernate-search/commit/749dd93d688db3a9f38b... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2018-09-11 (Tue, 11 Sep 2018) Changed paths: M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/impl/LuceneLocalDirectoryBackend.java Log Message: ----------- HSEARCH-840 Fix Lucene backend not implementing LuceneBackend Commit: 220a4b097f67e418bef1d5a31100155316407e4a https://github.com/hibernate/hibernate-search/commit/220a4b097f67e418bef1... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2018-09-11 (Tue, 11 Sep 2018) Changed paths: M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/logging/impl/Log.java M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/logging/impl/Log.java Log Message: ----------- HSEARCH-840 Fix error formatting when trying to unwrap backends Commit: 3866eca481f923317f184a9ed829c17119f93997 https://github.com/hibernate/hibernate-search/commit/3866eca481f923317f18... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2018-09-11 (Tue, 11 Sep 2018) Changed paths: M integrationtest/backend/elasticsearch/src/test/java/org/hibernate/search/integrationtest/backend/elasticsearch/ExtensionIT.java M integrationtest/backend/lucene/src/test/java/org/hibernate/search/integrationtest/backend/lucene/ExtensionIT.java Log Message: ----------- HSEARCH-840 Test backend unwrapping to their API interface Commit: 69b020f7ff8652e3a173732c2962bd48f80ae410 https://github.com/hibernate/hibernate-search/commit/69b020f7ff8652e3a173... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2018-09-11 (Tue, 11 Sep 2018) Changed paths: M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/impl/ElasticsearchBackendImpl.java M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/impl/LuceneLocalDirectoryBackend.java Log Message: ----------- HSEARCH-840 Fix invalid conditions in Backend.unwrap implementations If one calls backend.unwrap( SomeUserDefinedInterfaceExtendingLuceneBackend.class ), we want the Lucene backend to fail. Before this patch, it just returned 'this', and the user code would encounter a ClassCastException. Commit: 098d49bc042d5b709cb073efd64f55a8cae8f78e https://github.com/hibernate/hibernate-search/commit/098d49bc042d5b709cb0... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2018-09-11 (Tue, 11 Sep 2018) Changed paths: A backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/index/ElasticsearchIndexManager.java R backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/index/impl/ElasticsearchIndexManager.java M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/index/impl/ElasticsearchIndexManagerBuilder.java A backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/index/impl/ElasticsearchIndexManagerImpl.java M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/index/impl/ElasticsearchIndexSearchTargetBuilder.java M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/logging/impl/Log.java A backend/lucene/src/main/java/org/hibernate/search/backend/lucene/index/LuceneIndexManager.java M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/index/impl/LuceneDirectoryIndexManager.java R backend/lucene/src/main/java/org/hibernate/search/backend/lucene/index/impl/LuceneIndexManager.java A backend/lucene/src/main/java/org/hibernate/search/backend/lucene/index/impl/LuceneIndexManagerImplementor.java M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/index/impl/LuceneIndexSearchTargetBuilder.java M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/logging/impl/Log.java A engine/src/main/java/org/hibernate/search/engine/backend/index/IndexManager.java M engine/src/main/java/org/hibernate/search/engine/backend/index/spi/IndexManagerImplementor.java M engine/src/main/java/org/hibernate/search/engine/common/impl/MappedIndexManagerImpl.java M engine/src/main/java/org/hibernate/search/engine/common/impl/SearchMappingRepositoryImpl.java M engine/src/main/java/org/hibernate/search/engine/common/spi/SearchMappingRepository.java M engine/src/main/java/org/hibernate/search/engine/mapper/mapping/spi/MappedIndexManager.java M util/internal/integrationtest/common/src/main/java/org/hibernate/search/util/impl/integrationtest/common/stub/backend/index/impl/StubIndexManager.java Log Message: ----------- HSEARCH-840 Add API types for index managers Commit: 81cb8fea2825aebf6f7bc34b55e67080f0dfd738 https://github.com/hibernate/hibernate-search/commit/81cb8fea2825aebf6f7b... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2018-09-11 (Tue, 11 Sep 2018) Changed paths: M integrationtest/backend/elasticsearch/src/test/java/org/hibernate/search/integrationtest/backend/elasticsearch/ExtensionIT.java M integrationtest/backend/lucene/src/test/java/org/hibernate/search/integrationtest/backend/lucene/ExtensionIT.java Log Message: ----------- HSEARCH-840 Test index manager unwrapping to their API interface Commit: f2891390da2e1c5aa622696eddddb0656ba4c76a https://github.com/hibernate/hibernate-search/commit/f2891390da2e1c5aa622... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2018-09-11 (Tue, 11 Sep 2018) Changed paths: M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/impl/LuceneBackendFactory.java A backend/lucene/src/main/java/org/hibernate/search/backend/lucene/impl/LuceneBackendImpl.java R backend/lucene/src/main/java/org/hibernate/search/backend/lucene/impl/LuceneLocalDirectoryBackend.java R backend/lucene/src/main/java/org/hibernate/search/backend/lucene/index/impl/LuceneDirectoryIndexManager.java R backend/lucene/src/main/java/org/hibernate/search/backend/lucene/index/impl/LuceneDirectoryIndexManagerBuilder.java A backend/lucene/src/main/java/org/hibernate/search/backend/lucene/index/impl/LuceneIndexManagerBuilder.java A backend/lucene/src/main/java/org/hibernate/search/backend/lucene/index/impl/LuceneIndexManagerImpl.java R backend/lucene/src/main/java/org/hibernate/search/backend/lucene/index/impl/LuceneIndexManagerImplementor.java M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/index/impl/LuceneIndexSearchTargetBuilder.java M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/logging/impl/Log.java Log Message: ----------- HSEARCH-840 Remove the LuceneIndexManagerImplementor interface and all the "directory-agnostic" layer We always need directories in the current implementation; let's consider the problem of having a Lucene index manager that does not rely on directories later (if ever). Commit: 9f758142e41997498517abe58c332393437ca9a2 https://github.com/hibernate/hibernate-search/commit/9f758142e41997498517... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2018-09-11 (Tue, 11 Sep 2018) Changed paths: M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/impl/LuceneBackendFactory.java M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/impl/LuceneBackendImpl.java M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/impl/MMapDirectoryProvider.java Log Message: ----------- HSEARCH-840 Create directory provider in LuceneBackendFactory instead of LuceneBackendImpl It makes more sense now that LuceneBackendImpl has a name that is independent of the directory technology. Compare: https://github.com/hibernate/hibernate-search/compare/82f9131404af...9f75... **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.