[hibernate-commits] [hibernate/hibernate-search] 380395: HSEARCH-3776 Fix the visibility of IndexWriterDele...

Branch: refs/heads/master Home: https://github.com/hibernate/hibernate-search Commit: 380395beb3f0ddccd75b6d67b2355fbc7186c70c https://github.com/hibernate/hibernate-search/commit/380395beb3f0ddccd75b... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2020-04-20 (Mon, 20 Apr 2020) Changed paths: M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/lowlevel/writer/impl/IndexWriterDelegatorImpl.java Log Message: ----------- HSEARCH-3776 Fix the visibility of IndexWriterDelegatorImpl#closeAfterFailure No one should use this except IndexWriterProvider. Not related to this PR, but while we're at it... Commit: b9795f4bb9dbc30c5a94a339be5d83c6e0777e20 https://github.com/hibernate/hibernate-search/commit/b9795f4bb9dbc30c5a94... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2020-04-20 (Mon, 20 Apr 2020) Changed paths: M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/logging/impl/Log.java A backend/lucene/src/main/java/org/hibernate/search/backend/lucene/logging/impl/LuceneLogCategories.java A backend/lucene/src/main/java/org/hibernate/search/backend/lucene/lowlevel/writer/impl/IndexWriterSetting.java A backend/lucene/src/main/java/org/hibernate/search/backend/lucene/lowlevel/writer/impl/LoggerInfoStream.java A backend/lucene/src/main/java/org/hibernate/search/backend/lucene/lowlevel/writer/impl/LuceneIndexingParameters.java A backend/lucene/src/test/java/org/hibernate/search/backend/lucene/lowlevel/writer/impl/LoggerInfoStreamTest.java A backend/lucene/src/test/java/org/hibernate/search/backend/lucene/lowlevel/writer/impl/TestAppender.java Log Message: ----------- HSEARCH-3776 Copy LuceneIndexingParameters and related classes from Search 5 Commit: 43b1b1f4afce218f851cb20d25df141ed24a014b https://github.com/hibernate/hibernate-search/commit/43b1b1f4afce218f851c... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2020-04-20 (Mon, 20 Apr 2020) Changed paths: M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/logging/impl/Log.java M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/lowlevel/writer/impl/IndexWriterSetting.java Log Message: ----------- HSEARCH-3776 Remove obsolete and deprecated index writer settings Commit: 7fcbdabeb28f3a74654de222d29786e8ca0585f4 https://github.com/hibernate/hibernate-search/commit/7fcbdabeb28f3a74654d... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2020-04-20 (Mon, 20 Apr 2020) Changed paths: M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/lowlevel/writer/impl/IndexWriterSetting.java M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/lowlevel/writer/impl/LuceneIndexingParameters.java Log Message: ----------- HSEARCH-3776 Don't make LuceneIndexParameters serializable Most of Hibernate Search is not serializable anyway. Commit: a609ccd24b50c684ccc7e922eb04c4a32b5f9e85 https://github.com/hibernate/hibernate-search/commit/a609ccd24b50c684ccc7... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2020-04-20 (Mon, 20 Apr 2020) Changed paths: M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/logging/impl/Log.java M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/logging/impl/LuceneLogCategories.java R backend/lucene/src/main/java/org/hibernate/search/backend/lucene/lowlevel/writer/impl/IndexWriterSetting.java A backend/lucene/src/main/java/org/hibernate/search/backend/lucene/lowlevel/writer/impl/IndexWriterSettingValue.java A backend/lucene/src/main/java/org/hibernate/search/backend/lucene/lowlevel/writer/impl/IndexWriterSettings.java M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/lowlevel/writer/impl/LuceneIndexingParameters.java Log Message: ----------- HSEARCH-3776 Remove unnecessary hacks to support multiple data types (integer and boolean) in IndexWriterSetting Commit: 0e4c9263b10251b03510b1773dd2b645c36f8a5b https://github.com/hibernate/hibernate-search/commit/0e4c9263b10251b03510... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2020-04-20 (Mon, 20 Apr 2020) Changed paths: M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/lowlevel/writer/impl/LuceneIndexingParameters.java Log Message: ----------- HSEARCH-3776 Simplify LuceneIndexingParameters Commit: 5e2f39ea3a543a2ace9f8b9c7a5f49292081dc73 https://github.com/hibernate/hibernate-search/commit/5e2f39ea3a543a2ace9f... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2020-04-20 (Mon, 20 Apr 2020) Changed paths: A backend/lucene/src/main/java/org/hibernate/search/backend/lucene/lowlevel/writer/impl/IndexWriterConfigSource.java R backend/lucene/src/main/java/org/hibernate/search/backend/lucene/lowlevel/writer/impl/LuceneIndexingParameters.java Log Message: ----------- HSEARCH-3776 Rename LuceneIndexingParameters to clarify it's about index writer config Commit: f846cace62954a3415e1b361e46fb8a191415837 https://github.com/hibernate/hibernate-search/commit/f846cace62954a3415e1... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2020-04-20 (Mon, 20 Apr 2020) Changed paths: M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/index/impl/IndexManagerBackendContext.java M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/index/impl/ShardHolder.java M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/index/impl/ShardingStrategyInitializationContextImpl.java M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/lowlevel/index/impl/DebugIOStrategy.java M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/lowlevel/index/impl/IOStrategy.java M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/lowlevel/index/impl/NearRealTimeIOStrategy.java M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/lowlevel/writer/impl/IndexWriterConfigSource.java M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/lowlevel/writer/impl/IndexWriterProvider.java Log Message: ----------- HSEARCH-3776 Apply index writer settings defined in configuration properties Commit: b1085be8b754c27d642616f59d2547507353ec31 https://github.com/hibernate/hibernate-search/commit/b1085be8b754c27d6426... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2020-04-20 (Mon, 20 Apr 2020) Changed paths: M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/cfg/LuceneIndexSettings.java M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/logging/impl/LuceneLogCategories.java M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/lowlevel/writer/impl/IndexWriterSettings.java Log Message: ----------- HSEARCH-3776 Expose configuration property keys for index writer config as constants in LuceneIndexSettings Commit: c621abc655769348bfd89b14ae7b99d4a10f83a4 https://github.com/hibernate/hibernate-search/commit/c621abc655769348bfd8... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2020-04-20 (Mon, 20 Apr 2020) Changed paths: M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/cfg/LuceneIndexSettings.java M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/lowlevel/writer/impl/IndexWriterSettings.java Log Message: ----------- HSEARCH-3776 Rename merge_max_optimize_size to merge_max_forced_size Because the "optimize" operation is now called "force-merge", and the related setting in LogByteSizeMergePolicy is now setMaxMergeMBForForcedMerge. Commit: 31ac96c18a6ffbd8b1aea1d7dac4c9b149158d6a https://github.com/hibernate/hibernate-search/commit/31ac96c18a6ffbd8b1ae... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2020-04-20 (Mon, 20 Apr 2020) Changed paths: M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/cfg/LuceneIndexSettings.java M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/index/impl/IndexManagerBackendContext.java M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/lowlevel/writer/impl/IndexWriterSettings.java Log Message: ----------- HSEARCH-3776 Rename merge-related settings so that they have their own prefix E.g. io.writer.merge_max_forced_size becomes io.merge.max_forced_size Commit: 8eeedfd4dc83ec5b7026e49174105e7c9bcb2624 https://github.com/hibernate/hibernate-search/commit/8eeedfd4dc83ec5b7026... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2020-04-20 (Mon, 20 Apr 2020) Changed paths: M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/lowlevel/index/impl/IndexAccessorImpl.java M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/lowlevel/writer/impl/IndexWriterDelegatorImpl.java A integrationtest/backend/lucene/src/test/java/org/hibernate/search/integrationtest/backend/lucene/lowlevel/writer/LuceneIndexWriterSettingsIT.java M legacy/orm/src/test/java/org/hibernate/search/test/configuration/LuceneIndexingParametersTest.java M util/internal/integrationtest/mapper/stub/src/main/java/org/hibernate/search/util/impl/integrationtest/mapper/stub/StubMappedIndex.java Log Message: ----------- HSEARCH-3776 Test custom index writer settings for Lucene Commit: 80e2877624d488ea7039bcc0d2fff9f444c0aade https://github.com/hibernate/hibernate-search/commit/80e2877624d488ea7039... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2020-04-20 (Mon, 20 Apr 2020) Changed paths: M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/cfg/LuceneIndexSettings.java M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/logging/impl/LuceneLogCategories.java M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/lowlevel/writer/impl/IndexWriterSettings.java M integrationtest/backend/lucene/src/test/java/org/hibernate/search/integrationtest/backend/lucene/lowlevel/writer/LuceneIndexWriterSettingsIT.java Log Message: ----------- HSEARCH-3776 Move writer and merge settings to the "io" settings for the Lucene backend They are, after all, about IO, and will be documented in the section about IO in the reference documentation. Commit: c5e6dabc9da9de5512a23389f77a3cc3f62fc0af https://github.com/hibernate/hibernate-search/commit/c5e6dabc9da9de5512a2... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2020-04-20 (Mon, 20 Apr 2020) Changed paths: M documentation/src/main/asciidoc/backend-lucene.asciidoc M documentation/src/main/asciidoc/mapper-orm-indexing-manual.asciidoc M documentation/src/main/asciidoc/mapper-orm-indexing-massindexer.asciidoc R documentation/src/main/asciidoc/mapper-orm-indexing-optimizing.asciidoc M documentation/src/main/asciidoc/mapper-orm-indexing.asciidoc Log Message: ----------- HSEARCH-3776 Document writer and merge settings for the Lucene backend Commit: 9da1410e07a4a100748b417dd64fdb70caa43de3 https://github.com/hibernate/hibernate-search/commit/9da1410e07a4a100748b... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2020-04-20 (Mon, 20 Apr 2020) Changed paths: M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/cfg/LuceneBackendSettings.java M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/impl/LuceneBackendFactory.java M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/impl/LuceneBackendImpl.java M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/index/impl/IndexManagerBackendContext.java M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/lowlevel/writer/impl/IndexWriterConfigSource.java M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/lowlevel/writer/impl/IndexWriterProvider.java M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/orchestration/impl/LuceneSyncWorkOrchestratorImpl.java M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/work/impl/CountWork.java M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/work/impl/ExplainWork.java M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/work/impl/ReadWorkExecutionContext.java M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/work/impl/SearchWork.java Log Message: ----------- HSEARCH-3777 Configurable Similarity for Lucene, at the backend level Commit: 1f8afa4d65bb2184318f5a712afcbfb0b523cfbe https://github.com/hibernate/hibernate-search/commit/1f8afa4d65bb2184318f... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2020-04-20 (Mon, 20 Apr 2020) Changed paths: M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/impl/LuceneBackendFactory.java Log Message: ----------- HSEARCH-3777 Make sure to release resources if Lucene backend creation fails Commit: 150f4ca6215fb0934f83fbdf2f7bcf9409f04b3c https://github.com/hibernate/hibernate-search/commit/150f4ca6215fb0934f83... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2020-04-20 (Mon, 20 Apr 2020) Changed paths: A integrationtest/backend/lucene/src/test/java/org/hibernate/search/integrationtest/backend/lucene/lowlevel/similarity/LuceneSimilarityIT.java M legacy/orm/src/test/java/org/hibernate/search/test/similarity/SimilarityTest.java Log Message: ----------- HSEARCH-3777 Test setting the similarity explicitly for Lucene Commit: 577c2c36fc99e997f601ce98b97312f488c05578 https://github.com/hibernate/hibernate-search/commit/577c2c36fc99e997f601... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2020-04-20 (Mon, 20 Apr 2020) Changed paths: M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/analysis/LuceneAnalysisConfigurationContext.java M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/analysis/model/dsl/impl/LuceneAnalysisConfigurationContextImpl.java M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/analysis/model/impl/LuceneAnalysisDefinitionContributor.java M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/analysis/model/impl/LuceneAnalysisDefinitionRegistry.java M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/cfg/LuceneBackendSettings.java M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/impl/LuceneBackendFactory.java M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/impl/LuceneBackendImpl.java A integrationtest/backend/lucene/src/test/java/org/hibernate/search/integrationtest/backend/lucene/analysis/LuceneSimilarityIT.java R integrationtest/backend/lucene/src/test/java/org/hibernate/search/integrationtest/backend/lucene/lowlevel/similarity/LuceneSimilarityIT.java Log Message: ----------- HSEARCH-3777 Move configuration of the Similarity to LuceneAnalysisConfigurer Because that makes sense, but also because that's probably where we will have to allow definition of named similarities when we add support for per-field Similarity, like Elasticsearch offers: https://www.elastic.co/guide/en/elasticsearch/reference/5.6/similarity.html Commit: 022af0b1aa7d9c58543d0974655135a27e9e2b03 https://github.com/hibernate/hibernate-search/commit/022af0b1aa7d9c58543d... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2020-04-20 (Mon, 20 Apr 2020) Changed paths: M documentation/src/main/asciidoc/backend-lucene.asciidoc M documentation/src/test/java/org/hibernate/search/documentation/analysis/AnalysisIT.java A documentation/src/test/java/org/hibernate/search/documentation/analysis/CustomSimilarityLuceneAnalysisConfigurer.java Log Message: ----------- HSEARCH-3777 Document how to set a custom Similarity for Lucene Commit: ed328ac6fc60628382f28109f9d19759efad93ed https://github.com/hibernate/hibernate-search/commit/ed328ac6fc60628382f2... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2020-04-20 (Mon, 20 Apr 2020) Changed paths: M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/lowlevel/writer/impl/LoggerInfoStream.java Log Message: ----------- HSEARCH-3776 Sonar: Methods should not be empty Commit: 5b418cf7d8ba340296e18a1c66572c22a0152c1a https://github.com/hibernate/hibernate-search/commit/5b418cf7d8ba340296e1... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2020-04-20 (Mon, 20 Apr 2020) Changed paths: M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/index/impl/IndexManagerBackendContext.java M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/lowlevel/writer/impl/IndexWriterConfigSource.java M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/lowlevel/writer/impl/IndexWriterSettings.java Log Message: ----------- HSEARCH-3776 Mention the index/shard when logging index writer configuration Commit: 9ea9ae8b5da41afafcec77025afeb483749e5d05 https://github.com/hibernate/hibernate-search/commit/9ea9ae8b5da41afafcec... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2020-04-20 (Mon, 20 Apr 2020) Changed paths: M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/lowlevel/writer/impl/IndexWriterSettings.java Log Message: ----------- HSEARCH-3776 Sonar: Boxed "Boolean" should be avoided in boolean expressions Compare: https://github.com/hibernate/hibernate-search/compare/f58fa91801c2...9ea9...