[hibernate-commits] [hibernate/hibernate-search] 603099: HSEARCH-3386 Move the responsibility of passing th...

Branch: refs/heads/master Home: https://github.com/hibernate/hibernate-search Commit: 60309907d2f9761b0c895cf2c76d300762e73380 https://github.com/hibernate/hibernate-search/commit/60309907d2f9761b0c89... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2018-12-04 (Tue, 04 Dec 2018) Changed paths: M engine/src/main/java/org/hibernate/search/engine/environment/bean/BeanProvider.java M engine/src/main/java/org/hibernate/search/engine/environment/bean/BeanReference.java R engine/src/main/java/org/hibernate/search/engine/environment/bean/ImmutableBeanReference.java A engine/src/main/java/org/hibernate/search/engine/environment/bean/NameBeanReference.java A engine/src/main/java/org/hibernate/search/engine/environment/bean/TypeAndNameBeanReference.java A engine/src/main/java/org/hibernate/search/engine/environment/bean/TypeBeanReference.java M engine/src/main/java/org/hibernate/search/engine/environment/bean/impl/BeanProviderImpl.java M engine/src/main/java/org/hibernate/search/engine/logging/impl/Log.java M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/bridge/impl/BeanResolverBridgeBuilder.java M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/mapping/definition/annotation/impl/AnnotationProcessorHelper.java Log Message: ----------- HSEARCH-3386 Move the responsibility of passing the BeanReference data (name, class, ...) to the BeanReference itself Commit: e5e2897761388388e33989df8cfe46480640b4ed https://github.com/hibernate/hibernate-search/commit/e5e2897761388388e339... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2018-12-04 (Tue, 04 Dec 2018) Changed paths: M engine/src/main/java/org/hibernate/search/engine/cfg/impl/ConvertUtils.java M engine/src/main/java/org/hibernate/search/engine/logging/impl/Log.java A engine/src/test/java/org/hibernate/search/engine/cfg/spi/ConfigurationPropertyInvalidSimpleValuesTest.java A engine/src/test/java/org/hibernate/search/engine/cfg/spi/ConfigurationPropertyValidSimpleValuesTest.java Log Message: ----------- HSEARCH-3386 Test and fix ConfigurationProperty conversions Commit: 65b24109f6e203654ffa650419d2e4283d135046 https://github.com/hibernate/hibernate-search/commit/65b24109f6e203654ffa... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2018-12-04 (Tue, 04 Dec 2018) Changed paths: M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/impl/ElasticsearchBackendFactory.java M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/impl/LuceneBackendFactory.java M engine/src/main/java/org/hibernate/search/engine/cfg/impl/ConvertUtils.java M engine/src/main/java/org/hibernate/search/engine/cfg/impl/KeyContextImpl.java M engine/src/main/java/org/hibernate/search/engine/cfg/spi/KeyContext.java M engine/src/main/java/org/hibernate/search/engine/common/impl/IndexManagerBuildingStateHolder.java M engine/src/main/java/org/hibernate/search/engine/environment/bean/BeanReference.java A engine/src/main/java/org/hibernate/search/engine/environment/bean/InstanceBeanReference.java M engine/src/main/java/org/hibernate/search/engine/logging/impl/Log.java A engine/src/test/java/org/hibernate/search/engine/cfg/spi/ConfigurationPropertyBeanReferenceTest.java M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/mapping/impl/HibernateOrmMappingInitiator.java Log Message: ----------- HSEARCH-3386 Allow to create BeanReference configuration properties Commit: f08626140ccfda4303c6f15358a457bd3e3e4e45 https://github.com/hibernate/hibernate-search/commit/f08626140ccfda4303c6... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2018-12-04 (Tue, 04 Dec 2018) Changed paths: M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/impl/ElasticsearchBackendFactory.java M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/impl/LuceneBackendFactory.java M engine/src/main/java/org/hibernate/search/engine/cfg/impl/ConvertUtils.java M engine/src/main/java/org/hibernate/search/engine/cfg/impl/KeyContextImpl.java M engine/src/main/java/org/hibernate/search/engine/cfg/spi/KeyContext.java M engine/src/main/java/org/hibernate/search/engine/common/impl/IndexManagerBuildingStateHolder.java M engine/src/main/java/org/hibernate/search/engine/environment/bean/BeanProvider.java M engine/src/main/java/org/hibernate/search/engine/environment/bean/BeanReference.java A engine/src/main/java/org/hibernate/search/engine/environment/bean/CastingBeanReference.java M engine/src/main/java/org/hibernate/search/engine/environment/bean/InstanceBeanReference.java R engine/src/main/java/org/hibernate/search/engine/environment/bean/NameBeanReference.java M engine/src/main/java/org/hibernate/search/engine/environment/bean/TypeAndNameBeanReference.java M engine/src/main/java/org/hibernate/search/engine/environment/bean/TypeBeanReference.java M engine/src/main/java/org/hibernate/search/engine/environment/bean/impl/BeanProviderImpl.java M engine/src/main/java/org/hibernate/search/engine/environment/bean/spi/BeanResolver.java M engine/src/main/java/org/hibernate/search/engine/environment/bean/spi/ReflectionBeanResolver.java M engine/src/main/java/org/hibernate/search/engine/logging/impl/Log.java M engine/src/test/java/org/hibernate/search/engine/cfg/spi/ConfigurationPropertyBeanReferenceTest.java M integrationtest/mapper/pojo/src/test/java/org/hibernate/search/integrationtest/mapper/pojo/mapping/definition/BridgeIT.java M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/bootstrap/impl/HibernateOrmBeanContainerBeanResolver.java M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/mapping/impl/HibernateOrmMappingInitiator.java M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/bridge/impl/BeanResolverBridgeBuilder.java M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/extractor/impl/ContainerValueExtractorBinder.java M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/mapping/definition/annotation/impl/AnnotationProcessorHelper.java M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/mapping/definition/programmatic/PropertyDocumentIdMappingContext.java M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/mapping/definition/programmatic/PropertyFieldMappingContext.java M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/mapping/definition/programmatic/PropertyMappingContext.java M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/mapping/definition/programmatic/TypeMappingContext.java M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/mapping/definition/programmatic/impl/AbstractPropertyFieldMappingContext.java M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/mapping/definition/programmatic/impl/DelegatingPropertyMappingContext.java M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/mapping/definition/programmatic/impl/InitialPropertyMappingContext.java M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/mapping/definition/programmatic/impl/PropertyDocumentIdMappingContextImpl.java M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/mapping/definition/programmatic/impl/TypeMappingContextImpl.java Log Message: ----------- HSEARCH-3386 Move the responsibility of checking bean instance types to the BeanReference Doing that, we simplify the BeanReference configuration properties and the bean resolving in general. Note that this required to give up on @Factory annotations. The type passed to Hibernate Search when referencing a bridge, a filter, etc. must now always implement the requested interface, we can't just pass a factory class that doesn't implement anything. It's not a great loss, though: see HSEARCH-3055 for more information. Commit: d4254f7c0ae4df1d9f96565e02c662b98cdd57ca https://github.com/hibernate/hibernate-search/commit/d4254f7c0ae4df1d9f96... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2018-12-04 (Tue, 04 Dec 2018) Changed paths: M engine/src/main/java/org/hibernate/search/engine/cfg/spi/ConfigurationProperty.java Log Message: ----------- HSEARCH-3386 Add some javadoc to ConfigurationProperty Commit: 13eac3a84b171654819756dcbd688ad8232367fd https://github.com/hibernate/hibernate-search/commit/13eac3a84b1716548197... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2018-12-04 (Tue, 04 Dec 2018) Changed paths: M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/client/impl/ElasticsearchClientFactoryImpl.java M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/impl/ElasticsearchBackendFactory.java M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/impl/LuceneBackendFactory.java M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/logging/impl/Log.java A engine/src/main/java/org/hibernate/search/engine/cfg/impl/AbstractConfigurationProperty.java A engine/src/main/java/org/hibernate/search/engine/cfg/impl/DefaultedConfigurationProperty.java R engine/src/main/java/org/hibernate/search/engine/cfg/impl/DefaultedPropertyContext.java A engine/src/main/java/org/hibernate/search/engine/cfg/impl/DefaultedPropertyContextImpl.java R engine/src/main/java/org/hibernate/search/engine/cfg/impl/FunctionConfigurationProperty.java A engine/src/main/java/org/hibernate/search/engine/cfg/impl/OptionalConfigurationPropertyImpl.java M engine/src/main/java/org/hibernate/search/engine/cfg/impl/OptionalPropertyContextImpl.java M engine/src/main/java/org/hibernate/search/engine/cfg/spi/ConfigurationProperty.java A engine/src/main/java/org/hibernate/search/engine/cfg/spi/DefaultedPropertyContext.java A engine/src/main/java/org/hibernate/search/engine/cfg/spi/OptionalConfigurationProperty.java M engine/src/main/java/org/hibernate/search/engine/cfg/spi/OptionalPropertyContext.java R engine/src/main/java/org/hibernate/search/engine/cfg/spi/PropertyContext.java M engine/src/main/java/org/hibernate/search/engine/common/impl/IndexManagerBuildingStateHolder.java M engine/src/test/java/org/hibernate/search/engine/cfg/spi/ConfigurationPropertyBeanReferenceTest.java M engine/src/test/java/org/hibernate/search/engine/cfg/spi/ConfigurationPropertyValidSimpleValuesTest.java M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/mapping/impl/HibernateOrmMappingInitiator.java Log Message: ----------- HSEARCH-3386 Make sure that errors occurring when querying properties include some context In particular: * if an error occurs while retrieving a bean, we should display the property key and the bean reference; * if an error occurs because a mandatory property was missing, we should display the property key. Commit: 5982c357bc3adfd0217d239271a258ec63d274f6 https://github.com/hibernate/hibernate-search/commit/5982c357bc3adfd0217d... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2018-12-04 (Tue, 04 Dec 2018) Changed paths: M engine/src/main/java/org/hibernate/search/engine/cfg/ConfigurationPropertySource.java A engine/src/main/java/org/hibernate/search/engine/cfg/impl/MapConfigurationPropertySource.java M engine/src/main/java/org/hibernate/search/engine/common/impl/SearchIntegrationBuilderImpl.java M engine/src/main/java/org/hibernate/search/engine/common/spi/SearchIntegrationBuilder.java M integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/util/TckConfiguration.java M integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/util/rule/SearchSetupHelper.java M integrationtest/mapper/pojo/src/test/java/org/hibernate/search/integrationtest/mapper/pojo/test/util/rule/JavaBeanMappingSetupHelper.java M mapper/javabean/src/main/java/org/hibernate/search/mapper/javabean/JavaBeanMappingBuilder.java M util/internal/integrationtest/common/src/main/java/org/hibernate/search/util/impl/integrationtest/common/rule/MappingSetupHelper.java M util/internal/integrationtest/orm/src/main/java/org/hibernate/search/util/impl/integrationtest/orm/OrmSetupHelper.java Log Message: ----------- HSEARCH-3174 Adapt SPIs to the fact that non-String values are also accepted for configuration properties Non-string values were already supported, as shown by the test in commit "Add a test for ConfigurationProperty". Some SPIs just weren't allowing to pass non-string values until now. Compare: https://github.com/hibernate/hibernate-search/compare/9a02c6c18602...5982... **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.