7:37 a.m.
Branch: refs/heads/master
Home: https://github.com/hibernate/hibernate-search
Commit: c3b7ea40bab77238381ad11063d2945eb1fcb47a
https://github.com/hibernate/hibernate-search/commit/c3b7ea40bab77238381a...
Author: Yoann Rodière <yoann(a)hibernate.org>
Date: 2019-09-30 (Mon, 30 Sep 2019)
Changed paths:
M
engine/src/test/java/org/hibernate/search/engine/mapper/mapping/building/impl/ConfiguredIndexSchemaNestingContextTest.java
Log Message:
-----------
HSEARCH-3684 Simplify a test case in ConfiguredIndexSchemaNestingContextTest
Commit: fd1e913ea59fd8b481cbf87ff8aad123f0c411d3
https://github.com/hibernate/hibernate-search/commit/fd1e913ea59fd8b481cb...
Author: Yoann Rodière <yoann(a)hibernate.org>
Date: 2019-09-30 (Mon, 30 Sep 2019)
Changed paths:
M
engine/src/main/java/org/hibernate/search/engine/mapper/mapping/building/impl/IndexSchemaFilter.java
Log Message:
-----------
HSEARCH-3684 Clarify a comment in IndexSchemaFilter
Commit: d4a8aa5c12373e2ebf10871f3b113cdb930b3106
https://github.com/hibernate/hibernate-search/commit/d4a8aa5c12373e2ebf10...
Author: Yoann Rodière <yoann(a)hibernate.org>
Date: 2019-09-30 (Mon, 30 Sep 2019)
Changed paths:
M
engine/src/main/java/org/hibernate/search/engine/mapper/mapping/building/impl/ConfiguredIndexSchemaNestingContext.java
M
engine/src/main/java/org/hibernate/search/engine/mapper/mapping/building/impl/IndexSchemaFilter.java
Log Message:
-----------
HSEARCH-3684 Clarify the name of a property in IndexSchemaFilter
Turns out "proper" doesn't mean what I thought it did in English.
Commit: 3c0301766786988dc6d92a489717b490412ff191
https://github.com/hibernate/hibernate-search/commit/3c0301766786988dc6d9...
Author: Yoann Rodière <yoann(a)hibernate.org>
Date: 2019-09-30 (Mon, 30 Sep 2019)
Changed paths:
M
engine/src/main/java/org/hibernate/search/engine/mapper/mapping/building/impl/ConfiguredIndexSchemaNestingContext.java
A
engine/src/main/java/org/hibernate/search/engine/mapper/mapping/building/impl/DepthFilter.java
M
engine/src/main/java/org/hibernate/search/engine/mapper/mapping/building/impl/IndexSchemaFilter.java
A
engine/src/main/java/org/hibernate/search/engine/mapper/mapping/building/impl/PathFilter.java
Log Message:
-----------
HSEARCH-3684 Split the IndexSchemaFilter into multiple classes
So that hopefully I'll see more clearly what is going on.
Commit: 6aba396d6687cca83ec5bdaae0ea1fdeaaa72319
https://github.com/hibernate/hibernate-search/commit/6aba396d6687cca83ec5...
Author: Yoann Rodière <yoann(a)hibernate.org>
Date: 2019-09-30 (Mon, 30 Sep 2019)
Changed paths:
M
documentation/src/test/java/org/hibernate/search/documentation/mapper/orm/indexedembedded/includepathsanddepth/IndexedEmbeddedIncludePathsAndDepthIT.java
M
engine/src/test/java/org/hibernate/search/engine/mapper/mapping/building/impl/ConfiguredIndexSchemaNestingContextTest.java
Log Message:
-----------
HSEARCH-3684 Test that deeply nested indexed-embedded fields are not incorrectly
included
Commit: cc193d86de5093e0523afaf39da68cedee40f83d
https://github.com/hibernate/hibernate-search/commit/cc193d86de5093e0523a...
Author: Yoann Rodière <yoann(a)hibernate.org>
Date: 2019-09-30 (Mon, 30 Sep 2019)
Changed paths:
M documentation/src/main/asciidoc/mapper-orm-mapping.asciidoc
Log Message:
-----------
HSEARCH-3684 Clarify explanations in examples of use of includePaths/maxDepth
Or at least try to. It's much more complex than it appears.
Commit: 0e5e50adf8d8ea5476414be384b01ebd1a44b6b6
https://github.com/hibernate/hibernate-search/commit/0e5e50adf8d8ea547641...
Author: Yoann Rodière <yoann(a)hibernate.org>
Date: 2019-09-30 (Mon, 30 Sep 2019)
Changed paths:
M
engine/src/test/java/org/hibernate/search/engine/mapper/mapping/building/impl/ConfiguredIndexSchemaNestingContextTest.java
Log Message:
-----------
HSEARCH-3684 Clarify some comments in indexed-embedded tests
Commit: df6a99d9e2c5526faeb42a4304e7bfee720a526f
https://github.com/hibernate/hibernate-search/commit/df6a99d9e2c5526faeb4...
Author: Yoann Rodière <yoann(a)hibernate.org>
Date: 2019-09-30 (Mon, 30 Sep 2019)
Changed paths:
M
engine/src/test/java/org/hibernate/search/engine/mapper/mapping/building/impl/ConfiguredIndexSchemaNestingContextTest.java
Log Message:
-----------
HSEARCH-3684 Test includePaths composition without explicit depth
Commit: b839f45f088c29b36a7c36e9f33682f06cae06d4
https://github.com/hibernate/hibernate-search/commit/b839f45f088c29b36a7c...
Author: Yoann Rodière <yoann(a)hibernate.org>
Date: 2019-09-30 (Mon, 30 Sep 2019)
Changed paths:
M
engine/src/main/java/org/hibernate/search/engine/mapper/mapping/building/impl/ConfiguredIndexSchemaNestingContext.java
M
engine/src/main/java/org/hibernate/search/engine/mapper/mapping/building/impl/DepthFilter.java
M
engine/src/main/java/org/hibernate/search/engine/mapper/mapping/building/impl/IndexSchemaFilter.java
M
engine/src/main/java/org/hibernate/search/engine/mapper/mapping/building/impl/PathFilter.java
M
engine/src/test/java/org/hibernate/search/engine/mapper/mapping/building/impl/ConfiguredIndexSchemaNestingContextTest.java
Log Message:
-----------
HSEARCH-3684 Fix deeply nested indexed-embedded fields being incorrectly included
I ended up changing the approach completely: instead of pre-computing
the set of included paths when we compose filters, the filters simply
keep a reference to their parent and compose their decision "dynamically"
each time "isPathIncluded()" is called.
This is probably less efficient, but it's far easier to implement, debug
and understand. And as it turns out, it also seems to fix the bug.
Commit: 8233e6e5e455472b841a7a2b0aee22089f1e2b43
https://github.com/hibernate/hibernate-search/commit/8233e6e5e455472b841a...
Author: Yoann Rodière <yoann(a)hibernate.org>
Date: 2019-09-30 (Mon, 30 Sep 2019)
Changed paths:
M
engine/src/main/java/org/hibernate/search/engine/mapper/mapping/building/impl/AbstractIndexBindingContext.java
M
engine/src/main/java/org/hibernate/search/engine/mapper/mapping/building/impl/ConfiguredIndexSchemaNestingContext.java
M
engine/src/main/java/org/hibernate/search/engine/mapper/mapping/building/impl/IndexSchemaFilter.java
M
engine/src/main/java/org/hibernate/search/engine/mapper/mapping/building/impl/IndexedEmbeddedBindingContextImpl.java
A
engine/src/main/java/org/hibernate/search/engine/mapper/mapping/building/impl/IndexedEmbeddedPathTracker.java
M
engine/src/main/java/org/hibernate/search/engine/mapper/mapping/building/impl/PathFilter.java
M
engine/src/main/java/org/hibernate/search/engine/mapper/mapping/building/spi/IndexBindingContext.java
A
engine/src/main/java/org/hibernate/search/engine/mapper/mapping/building/spi/IndexedEmbeddedDefinition.java
M
engine/src/test/java/org/hibernate/search/engine/mapper/mapping/building/impl/ConfiguredIndexSchemaNestingContextTest.java
M
integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/document/DocumentElementBaseIT.java
M
mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/mapping/building/spi/PojoMappingCollectorValueNode.java
M
mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/mapping/definition/programmatic/impl/InitialPropertyMappingStep.java
M
mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/mapping/definition/programmatic/impl/PropertyMappingIndexedEmbeddedStepImpl.java
M
mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/mapping/definition/programmatic/impl/TypeMappingStepImpl.java
M
mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/processing/building/impl/PojoIndexingProcessorValueNodeBuilderDelegate.java
Log Message:
-----------
HSEARCH-3684 Move path tracking for indexed-embedded to a dedicated class
... so that we'll be able (in the next commits) to share path tracking
state across all "uses" of the same indexed-embedded.
This is especially important when an indexed-embedded is used
recursively: in that case, the deepest level may not make use of all
includePaths, and if we don't share tracking state, it will incorrectly
deem some includePaths useless.
Run IndexedEmbeddedIncludePathsAndDepthIT before this commit for an
example of such false positive.
Commit: 206eb85e03bac7c46ee49392095800acf865751d
https://github.com/hibernate/hibernate-search/commit/206eb85e03bac7c46ee4...
Author: Yoann Rodière <yoann(a)hibernate.org>
Date: 2019-09-30 (Mon, 30 Sep 2019)
Changed paths:
M
engine/src/main/java/org/hibernate/search/engine/common/impl/IndexManagerBuildingStateHolder.java
A
engine/src/main/java/org/hibernate/search/engine/common/impl/IndexedEntityBindingContextProviderImpl.java
M
engine/src/main/java/org/hibernate/search/engine/common/impl/SearchIntegrationBuilderImpl.java
M
engine/src/main/java/org/hibernate/search/engine/mapper/mapping/building/impl/IndexedEntityBindingContextImpl.java
M
engine/src/main/java/org/hibernate/search/engine/mapper/mapping/building/spi/IndexManagerBuildingState.java
R
engine/src/main/java/org/hibernate/search/engine/mapper/mapping/building/spi/IndexManagerBuildingStateProvider.java
A
engine/src/main/java/org/hibernate/search/engine/mapper/mapping/building/spi/IndexedEntityBindingContextProvider.java
M
engine/src/main/java/org/hibernate/search/engine/mapper/mapping/building/spi/Mapper.java
M
mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/mapping/building/impl/PojoIdentityMappingCollectorImpl.java
M
mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/mapping/building/impl/PojoIndexedTypeManagerBuilder.java
M
mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/mapping/building/impl/PojoMapper.java
M
mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/mapping/building/impl/PojoMappingHelper.java
M
util/internal/integrationtest/common/src/main/java/org/hibernate/search/util/impl/integrationtest/common/stub/mapper/StubMapper.java
M
util/internal/integrationtest/common/src/main/java/org/hibernate/search/util/impl/integrationtest/common/stub/mapper/StubTypeMetadataContributor.java
Log Message:
-----------
HSEARCH-3684 Move IndexedEntityBindingContext building to the mapper
... so that the mapper can maintain a repository of indexed-embedded
definition and make it available to the binding context (see next
commits).
Commit: 0cedc539f1a8b8fd2a6bc5c5272405950e398f9c
https://github.com/hibernate/hibernate-search/commit/0cedc539f1a8b8fd2a6b...
Author: Yoann Rodière <yoann(a)hibernate.org>
Date: 2019-09-30 (Mon, 30 Sep 2019)
Changed paths:
M
engine/src/main/java/org/hibernate/search/engine/common/impl/IndexedEntityBindingContextProviderImpl.java
M
engine/src/main/java/org/hibernate/search/engine/mapper/mapping/building/impl/AbstractIndexBindingContext.java
M
engine/src/main/java/org/hibernate/search/engine/mapper/mapping/building/impl/ConfiguredIndexSchemaNestingContext.java
M
engine/src/main/java/org/hibernate/search/engine/mapper/mapping/building/impl/IndexSchemaFilter.java
M
engine/src/main/java/org/hibernate/search/engine/mapper/mapping/building/impl/IndexedEmbeddedBindingContextImpl.java
R
engine/src/main/java/org/hibernate/search/engine/mapper/mapping/building/impl/IndexedEmbeddedPathTracker.java
M
engine/src/main/java/org/hibernate/search/engine/mapper/mapping/building/impl/IndexedEntityBindingContextImpl.java
M
engine/src/main/java/org/hibernate/search/engine/mapper/mapping/building/spi/IndexedEmbeddedBindingContext.java
A
engine/src/main/java/org/hibernate/search/engine/mapper/mapping/building/spi/IndexedEmbeddedPathTracker.java
M
engine/src/main/java/org/hibernate/search/engine/mapper/mapping/building/spi/IndexedEntityBindingContextProvider.java
A
engine/src/main/java/org/hibernate/search/engine/mapper/mapping/building/spi/IndexedEntityBindingMapperContext.java
M
engine/src/test/java/org/hibernate/search/engine/mapper/mapping/building/impl/ConfiguredIndexSchemaNestingContextTest.java
M
integrationtest/mapper/pojo/src/test/java/org/hibernate/search/integrationtest/mapper/pojo/mapping/definition/IndexedEmbeddedBaseIT.java
M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/logging/impl/Log.java
M
mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/mapping/building/impl/PojoMapper.java
M
mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/processing/building/impl/PojoIndexingProcessorValueNodeBuilderDelegate.java
M
util/internal/integrationtest/common/src/main/java/org/hibernate/search/util/impl/integrationtest/common/stub/mapper/StubMapper.java
Log Message:
-----------
HSEARCH-3684 Share the indexed-embedded path trackers across multiple
"instances" of the indexed-embedded
This fixes IndexedEmbeddedIncludePathsAndDepthIT (finally).
Commit: 61e2f9538e138d8bf694218855893989fea83025
https://github.com/hibernate/hibernate-search/commit/61e2f9538e138d8bf694...
Author: Yoann Rodière <yoann(a)hibernate.org>
Date: 2019-09-30 (Mon, 30 Sep 2019)
Changed paths:
M
engine/src/main/java/org/hibernate/search/engine/common/impl/IndexManagerBuildingStateHolder.java
R
engine/src/main/java/org/hibernate/search/engine/common/impl/MappedIndexManagerImpl.java
R
engine/src/main/java/org/hibernate/search/engine/common/impl/MappedIndexScopeBuilderImpl.java
R
engine/src/main/java/org/hibernate/search/engine/common/impl/MappedIndexScopeImpl.java
A
engine/src/main/java/org/hibernate/search/engine/mapper/mapping/impl/MappedIndexManagerImpl.java
A
engine/src/main/java/org/hibernate/search/engine/mapper/scope/impl/MappedIndexScopeBuilderImpl.java
A
engine/src/main/java/org/hibernate/search/engine/mapper/scope/impl/MappedIndexScopeImpl.java
Log Message:
-----------
HSEARCH-3684 Move implementations of MappedIndexManager et. al. to the correct
packages
They were probably forgotten at some point.
Commit: 75803a8ad6c536f3e9d30a7e6fbe41d06a9f3eb2
https://github.com/hibernate/hibernate-search/commit/75803a8ad6c536f3e9d3...
Author: Yoann Rodière <yoann(a)hibernate.org>
Date: 2019-09-30 (Mon, 30 Sep 2019)
Changed paths:
M
engine/src/main/java/org/hibernate/search/engine/common/impl/SearchIntegrationImpl.java
M
engine/src/main/java/org/hibernate/search/engine/common/impl/SearchIntegrationPartialBuildStateImpl.java
M engine/src/main/java/org/hibernate/search/engine/common/spi/SearchIntegration.java
M engine/src/main/java/org/hibernate/search/engine/logging/impl/Log.java
M
engine/src/main/java/org/hibernate/search/engine/mapper/mapping/spi/MappingKey.java
Log Message:
-----------
HSEARCH-3684 Remove the unnecessary getMapping method from SearchIntegration
Mappings are returned by the integration builder's finalizeMapping
method at bootstrap, and that's where mappers get their hands on the
finalized mapping.
There is no need to retrieve the mapping at runtime.
Commit: bc1b6c88700a502d5921f7e84792c08236ba03cb
https://github.com/hibernate/hibernate-search/commit/bc1b6c88700a502d5921...
Author: Yoann Rodière <yoann(a)hibernate.org>
Date: 2019-09-30 (Mon, 30 Sep 2019)
Changed paths:
M
engine/src/main/java/org/hibernate/search/engine/common/impl/MappingBuildContextImpl.java
M
engine/src/main/java/org/hibernate/search/engine/common/impl/MappingFinalizationContextImpl.java
M
engine/src/main/java/org/hibernate/search/engine/common/impl/SearchIntegrationBuilderImpl.java
M
engine/src/main/java/org/hibernate/search/engine/common/impl/SearchIntegrationPartialBuildStateImpl.java
M
engine/src/main/java/org/hibernate/search/engine/common/spi/SearchIntegrationBuilder.java
M
engine/src/main/java/org/hibernate/search/engine/common/spi/SearchIntegrationFinalizer.java
M
engine/src/main/java/org/hibernate/search/engine/logging/spi/MappingKeyFormatter.java
M
engine/src/main/java/org/hibernate/search/engine/mapper/mapping/building/spi/Mapper.java
A
engine/src/main/java/org/hibernate/search/engine/mapper/mapping/building/spi/MappingBuildContext.java
A
engine/src/main/java/org/hibernate/search/engine/mapper/mapping/building/spi/MappingFinalizationContext.java
A
engine/src/main/java/org/hibernate/search/engine/mapper/mapping/building/spi/MappingFinalizer.java
M
engine/src/main/java/org/hibernate/search/engine/mapper/mapping/building/spi/MappingInitiator.java
A
engine/src/main/java/org/hibernate/search/engine/mapper/mapping/building/spi/MappingKey.java
A
engine/src/main/java/org/hibernate/search/engine/mapper/mapping/building/spi/MappingPartialBuildState.java
R
engine/src/main/java/org/hibernate/search/engine/mapper/mapping/spi/MappingBuildContext.java
R
engine/src/main/java/org/hibernate/search/engine/mapper/mapping/spi/MappingFinalizationContext.java
R
engine/src/main/java/org/hibernate/search/engine/mapper/mapping/spi/MappingFinalizer.java
R
engine/src/main/java/org/hibernate/search/engine/mapper/mapping/spi/MappingKey.java
R
engine/src/main/java/org/hibernate/search/engine/mapper/mapping/spi/MappingPartialBuildState.java
M
mapper/javabean/src/main/java/org/hibernate/search/mapper/javabean/impl/JavaBeanTypeConfigurationContributor.java
M
mapper/javabean/src/main/java/org/hibernate/search/mapper/javabean/mapping/impl/JavaBeanMappingKey.java
M
mapper/javabean/src/main/java/org/hibernate/search/mapper/javabean/mapping/impl/JavaBeanMappingPartialBuildState.java
M
mapper/orm/src/main/java/org/hibernate/search/mapper/orm/mapping/impl/HibernateOrmMappingInitiator.java
M
mapper/orm/src/main/java/org/hibernate/search/mapper/orm/mapping/impl/HibernateOrmMappingKey.java
M
mapper/orm/src/main/java/org/hibernate/search/mapper/orm/mapping/impl/HibernateOrmMappingPartialBuildState.java
M
mapper/orm/src/main/java/org/hibernate/search/mapper/orm/mapping/impl/HibernateOrmMetatadaContributor.java
M
mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/extractor/impl/ContainerExtractorBinder.java
M
mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/mapping/building/impl/PojoIndexModelBinderImpl.java
M
mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/mapping/building/impl/PojoMapper.java
M
mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/mapping/definition/annotation/impl/AnnotationMappingConfigurationContextImpl.java
M
mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/mapping/definition/programmatic/impl/ProgrammaticMappingConfigurationContextImpl.java
M
mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/mapping/definition/programmatic/impl/TypeMappingStepImpl.java
M
mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/mapping/spi/AbstractPojoMappingInitiator.java
M
mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/mapping/spi/PojoMappingConfigurationContributor.java
M
util/internal/integrationtest/common/src/main/java/org/hibernate/search/util/impl/integrationtest/common/stub/mapper/StubMapper.java
M
util/internal/integrationtest/common/src/main/java/org/hibernate/search/util/impl/integrationtest/common/stub/mapper/StubMappingInitiator.java
M
util/internal/integrationtest/common/src/main/java/org/hibernate/search/util/impl/integrationtest/common/stub/mapper/StubMappingKey.java
M
util/internal/integrationtest/common/src/main/java/org/hibernate/search/util/impl/integrationtest/common/stub/mapper/StubMappingPartialBuildState.java
Log Message:
-----------
HSEARCH-3684 Move bootstrap mapping interfaces to the correct package
... with all the other bootstrap-only interfaces.
Commit: 129e37111f2ed7acc3779acb81e26a1e69d830d5
https://github.com/hibernate/hibernate-search/commit/129e37111f2ed7acc377...
Author: Yoann Rodière <yoann(a)hibernate.org>
Date: 2019-09-30 (Mon, 30 Sep 2019)
Changed paths:
M
engine/src/main/java/org/hibernate/search/engine/common/impl/IndexManagerBuildingStateHolder.java
R
engine/src/main/java/org/hibernate/search/engine/common/impl/IndexedEntityBindingContextProviderImpl.java
A
engine/src/main/java/org/hibernate/search/engine/common/impl/MappedIndexManagerFactoryImpl.java
M
engine/src/main/java/org/hibernate/search/engine/common/impl/SearchIntegrationBuilderImpl.java
A
engine/src/main/java/org/hibernate/search/engine/mapper/mapping/building/impl/IndexManagerBuildingState.java
A
engine/src/main/java/org/hibernate/search/engine/mapper/mapping/building/impl/MappedIndexManagerBuilderImpl.java
R
engine/src/main/java/org/hibernate/search/engine/mapper/mapping/building/spi/IndexManagerBuildingState.java
R
engine/src/main/java/org/hibernate/search/engine/mapper/mapping/building/spi/IndexedEntityBindingContextProvider.java
A
engine/src/main/java/org/hibernate/search/engine/mapper/mapping/building/spi/MappedIndexManagerBuilder.java
A
engine/src/main/java/org/hibernate/search/engine/mapper/mapping/building/spi/MappedIndexManagerFactory.java
M
engine/src/main/java/org/hibernate/search/engine/mapper/mapping/building/spi/Mapper.java
M
mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/mapping/building/impl/PojoIndexedTypeManagerBuilder.java
M
mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/mapping/building/impl/PojoMapper.java
M
util/internal/integrationtest/common/src/main/java/org/hibernate/search/util/impl/integrationtest/common/stub/mapper/StubMapper.java
Log Message:
-----------
HSEARCH-3684 Simplify collaboration between the mapper and index manager builders
Compare:
https://github.com/hibernate/hibernate-search/compare/32b32f460552...129e...