[hibernate-commits] [hibernate/hibernate-search] 58470c: HSEARCH-3407 Remove an unnecessary null check

Branch: refs/heads/5.10 Home: https://github.com/hibernate/hibernate-search Commit: 58470c2825abec4624f71b3c054e667eff704ec7 https://github.com/hibernate/hibernate-search/commit/58470c2825abec4624f7... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2018-11-07 (Wed, 07 Nov 2018) Changed paths: M elasticsearch/src/main/java/org/hibernate/search/elasticsearch/impl/ElasticsearchIndexWorkVisitor.java Log Message: ----------- HSEARCH-3407 Remove an unnecessary null check Commit: f423d481e3b0123ac79e3a8e4cca3bb5d42c1e9b https://github.com/hibernate/hibernate-search/commit/f423d481e3b0123ac79e... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2018-11-07 (Wed, 07 Nov 2018) Changed paths: M elasticsearch/src/main/java/org/hibernate/search/elasticsearch/impl/ElasticsearchIndexWorkVisitor.java M elasticsearch/src/main/java/org/hibernate/search/elasticsearch/logging/impl/Log.java Log Message: ----------- HSEARCH-3407 Correctly fetch the value of multi-valued boolean fields in the Elasticsearch integration We used to rely on TwoWayFieldBridge, but this only works when there is a single value for the field, because we just tell the bridge "fetch the value for the field with this name", and the bridge doesn't know which value to fetch, so it'll just return the first one. We solve this by fetching the raw (string) value ourselves, and passing the value to the bridge directly. This means custom bridges not implementing TwoWayStringBridge will not work. But I don't see the point of custom bridges in this case anyway, since we only detect the boolean type when the property itself is of type boolean or Boolean, so users may as well rely on the default bridge. Commit: 21e78af01845e8bc6072e039edaa009ab2e75dba https://github.com/hibernate/hibernate-search/commit/21e78af01845e8bc6072... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2018-11-07 (Wed, 07 Nov 2018) Changed paths: A engine/src/test/java/org/hibernate/search/test/bridge/MultiValuedBooleanBridgeTest.java Log Message: ----------- HSEARCH-3407 Test indexing of multi-valued boolean fields Compare: https://github.com/hibernate/hibernate-search/compare/16cf87e3c678...21e7... **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.