[hibernate-commits] [hibernate/hibernate-orm] 679ed3: add select generator test for Postgres, MySQL, EDB

Branch: refs/heads/main Home: https://github.com/hibernate/hibernate-orm Commit: 679ed3bbee1d581148a2956bf1f6c5533b492e6b https://github.com/hibernate/hibernate-orm/commit/679ed3bbee1d581148a2956... Author: Gavin <gavin(a)hibernate.org&gt; Date: 2022-12-20 (Tue, 20 Dec 2022) Changed paths: M hibernate-community-dialects/src/main/java/org/hibernate/community/dialect/H2LegacySqlAstTranslator.java M hibernate-core/src/test/java/org/hibernate/orm/test/generatedkeys/select/MyEntity.hbm.xml M hibernate-core/src/test/java/org/hibernate/orm/test/generatedkeys/select/SelectGeneratorTest.java M hibernate-core/src/test/java/org/hibernate/orm/test/generatedkeys/selectannotated/MyEntity.hbm.xml M hibernate-core/src/test/java/org/hibernate/orm/test/generatedkeys/selectannotated/SelectGeneratorTest.java Log Message: ----------- add select generator test for Postgres, MySQL, EDB Commit: d49b568d7bad50dfc2011a7b42e7d535c71fef31 https://github.com/hibernate/hibernate-orm/commit/d49b568d7bad50dfc2011a7... Author: Gavin <gavin(a)hibernate.org&gt; Date: 2022-12-20 (Tue, 20 Dec 2022) Changed paths: M hibernate-core/src/main/java/org/hibernate/dialect/Dialect.java M hibernate-core/src/main/java/org/hibernate/dialect/MariaDBDialect.java M hibernate-core/src/main/java/org/hibernate/dialect/PostgreSQLDialect.java M hibernate-core/src/main/java/org/hibernate/id/SelectGenerator.java Log Message: ----------- make SelectGenerator capable of using 'insert ... returning ...' Commit: ff9a60601cecce5063c408fe221862f7d602487a https://github.com/hibernate/hibernate-orm/commit/ff9a60601cecce5063c408f... Author: Gavin <gavin(a)hibernate.org&gt; Date: 2022-12-20 (Tue, 20 Dec 2022) Changed paths: M hibernate-core/src/main/java/org/hibernate/tool/schema/internal/exec/GenerationTargetToDatabase.java M hibernate-core/src/main/java/org/hibernate/tool/schema/internal/exec/GenerationTargetToScript.java M hibernate-core/src/main/java/org/hibernate/tool/schema/internal/exec/GenerationTargetToStdout.java M hibernate-core/src/test/java/org/hibernate/orm/test/schemaupdate/SchemaMigratorHaltOnErrorTest.java M hibernate-core/src/test/java/org/hibernate/orm/test/schemaupdate/SchemaUpdateHaltOnErrorTest.java Log Message: ----------- improve error reporting for DDL execution Commit: 493818141e46eb7c54a2892abb05a4fe50b48273 https://github.com/hibernate/hibernate-orm/commit/493818141e46eb7c54a2892... Author: Gavin <gavin(a)hibernate.org&gt; Date: 2022-12-20 (Tue, 20 Dec 2022) Changed paths: M hibernate-core/src/main/java/org/hibernate/engine/jdbc/internal/DDLFormatterImpl.java M hibernate-core/src/main/java/org/hibernate/tool/schema/internal/exec/GenerationTargetToDatabase.java Log Message: ----------- fix logging of DDL the DDL formatter was being applied twice Commit: 32790456b766189be85aeae87b46124d8072816e https://github.com/hibernate/hibernate-orm/commit/32790456b766189be85aeae... Author: Gavin <gavin(a)hibernate.org&gt; Date: 2022-12-20 (Tue, 20 Dec 2022) Changed paths: M hibernate-core/hibernate-core.gradle M hibernate-core/src/test/java/org/hibernate/orm/test/generatedkeys/select/MyEntity.hbm.xml A hibernate-core/src/test/java/org/hibernate/orm/test/generatedkeys/selectannotated/H2Trigger.java M hibernate-core/src/test/java/org/hibernate/orm/test/generatedkeys/selectannotated/MyEntity.hbm.xml M hibernate-core/src/test/java/org/hibernate/orm/test/generatedkeys/selectannotated/MyEntity.java M hibernate-core/src/test/java/org/hibernate/orm/test/generatedkeys/selectannotated/SelectGeneratorTest.java Log Message: ----------- test select generator on h2 Commit: 782d2c9707276b5415f4c8fc5286856494b29a43 https://github.com/hibernate/hibernate-orm/commit/782d2c9707276b5415f4c8f... Author: Gavin <gavin(a)hibernate.org&gt; Date: 2022-12-20 (Tue, 20 Dec 2022) Changed paths: M hibernate-core/src/main/java/org/hibernate/tool/schema/extract/internal/DatabaseInformationImpl.java M hibernate-core/src/main/java/org/hibernate/tool/schema/extract/internal/ExtractionContextImpl.java M hibernate-core/src/main/java/org/hibernate/tool/schema/internal/AbstractSchemaMigrator.java M hibernate-core/src/main/java/org/hibernate/tool/schema/internal/AbstractSchemaValidator.java M hibernate-core/src/main/java/org/hibernate/tool/schema/internal/GroupedSchemaMigratorImpl.java M hibernate-core/src/main/java/org/hibernate/tool/schema/internal/Helper.java M hibernate-core/src/main/java/org/hibernate/tool/schema/internal/HibernateSchemaManagementTool.java M hibernate-core/src/main/java/org/hibernate/tool/schema/internal/IndividuallySchemaMigratorImpl.java M hibernate-core/src/main/java/org/hibernate/tool/schema/internal/SchemaCreatorImpl.java M hibernate-core/src/main/java/org/hibernate/tool/schema/internal/SchemaDropperImpl.java M hibernate-core/src/main/java/org/hibernate/tool/schema/internal/SchemaTruncatorImpl.java M hibernate-core/src/main/java/org/hibernate/tool/schema/internal/StandardTableMigrator.java M hibernate-core/src/main/java/org/hibernate/tool/schema/internal/TableMigrator.java M hibernate-core/src/main/java/org/hibernate/tool/schema/internal/exec/ImprovedExtractionContextImpl.java M hibernate-core/src/main/java/org/hibernate/tool/schema/spi/ExtractionTool.java Log Message: ----------- refactor SchemaCreatorImpl, SchemaDropperImpl into bite-sized methods Commit: d93e72dc7e32baf110f93d69013e9ba6d44e72e8 https://github.com/hibernate/hibernate-orm/commit/d93e72dc7e32baf110f93d6... Author: Gavin <gavin(a)hibernate.org&gt; Date: 2022-12-20 (Tue, 20 Dec 2022) Changed paths: M hibernate-core/src/main/java/org/hibernate/cfg/AvailableSettings.java M hibernate-core/src/main/java/org/hibernate/metamodel/mapping/internal/MappingModelCreationHelper.java M hibernate-core/src/main/java/org/hibernate/persister/entity/UnionSubclassEntityPersister.java M hibernate-core/src/main/java/org/hibernate/query/sql/internal/SQLQueryParser.java Log Message: ----------- some misc minor cleanups Commit: ed0f93ecdd95dc0fa4ce2f3a8406ec50f439904f https://github.com/hibernate/hibernate-orm/commit/ed0f93ecdd95dc0fa4ce2f3... Author: Gavin <gavin(a)hibernate.org&gt; Date: 2022-12-20 (Tue, 20 Dec 2022) Changed paths: M hibernate-core/src/main/java/org/hibernate/dialect/H2Dialect.java Log Message: ----------- use 'from final table' in SelectGenerator on h2 Commit: 587857e6bf15a3cb110dd71d39cd1cd5839bb59c https://github.com/hibernate/hibernate-orm/commit/587857e6bf15a3cb110dd71... Author: Gavin <gavin(a)hibernate.org&gt; Date: 2022-12-20 (Tue, 20 Dec 2022) Changed paths: M hibernate-core/src/test/java/org/hibernate/orm/test/generatedkeys/select/MyEntity.hbm.xml M hibernate-core/src/test/java/org/hibernate/orm/test/generatedkeys/select/SelectGeneratorTest.java M hibernate-core/src/test/java/org/hibernate/orm/test/generatedkeys/selectannotated/MyEntity.hbm.xml M hibernate-core/src/test/java/org/hibernate/orm/test/generatedkeys/selectannotated/SelectGeneratorTest.java Log Message: ----------- run SelectGeneratorTest on Db2 Commit: c4e27c0a2e5638b8b3bf9cdbd380cc045fa1205c https://github.com/hibernate/hibernate-orm/commit/c4e27c0a2e5638b8b3bf9cd... Author: Gavin <gavin(a)hibernate.org&gt; Date: 2022-12-20 (Tue, 20 Dec 2022) Changed paths: M hibernate-core/src/test/java/org/hibernate/orm/test/generatedkeys/select/MyEntity.hbm.xml M hibernate-core/src/test/java/org/hibernate/orm/test/generatedkeys/select/SelectGeneratorTest.java M hibernate-core/src/test/java/org/hibernate/orm/test/generatedkeys/selectannotated/MyEntity.hbm.xml M hibernate-core/src/test/java/org/hibernate/orm/test/generatedkeys/selectannotated/SelectGeneratorTest.java Log Message: ----------- make select generator tests run on SQL Server Commit: 01fa0c0fe958270d420ecff244e9b7e7c236e8d7 https://github.com/hibernate/hibernate-orm/commit/01fa0c0fe958270d420ecff... Author: Gavin <gavin(a)hibernate.org&gt; Date: 2022-12-20 (Tue, 20 Dec 2022) Changed paths: M hibernate-core/src/main/java/org/hibernate/dialect/DB2Dialect.java M hibernate-core/src/main/java/org/hibernate/dialect/DB2SqlAstTranslator.java M hibernate-core/src/main/java/org/hibernate/dialect/H2SqlAstTranslator.java M hibernate-core/src/main/java/org/hibernate/dialect/identity/DB2IdentityColumnSupport.java Log Message: ----------- suppport 'from new table' on DB2 for retrieving generated primary keys Commit: 7b387f3ecfc65c282248975440b5655356a34fff https://github.com/hibernate/hibernate-orm/commit/7b387f3ecfc65c282248975... Author: Gavin <gavin(a)hibernate.org&gt; Date: 2022-12-20 (Tue, 20 Dec 2022) Changed paths: M hibernate-core/src/main/java/org/hibernate/engine/jdbc/internal/BasicFormatterImpl.java Log Message: ----------- correctly handle 'returning' clause in DML formatter Commit: 00edf484834abd3a63212668d49214e74fea2046 https://github.com/hibernate/hibernate-orm/commit/00edf484834abd3a6321266... Author: Gavin <gavin(a)hibernate.org&gt; Date: 2022-12-20 (Tue, 20 Dec 2022) Changed paths: M hibernate-core/src/main/java/org/hibernate/dialect/MariaDBDialect.java Log Message: ----------- fix version # of support for 'insert returning' on Maria Commit: ad2d4604fb40a2422b91fcb1af0d3876aed9c1ae https://github.com/hibernate/hibernate-orm/commit/ad2d4604fb40a2422b91fcb... Author: Gavin <gavin(a)hibernate.org&gt; Date: 2022-12-20 (Tue, 20 Dec 2022) Changed paths: M hibernate-core/src/main/java/org/hibernate/dialect/CockroachDialect.java M hibernate-core/src/main/java/org/hibernate/dialect/DB2Dialect.java M hibernate-core/src/main/java/org/hibernate/dialect/DB2iDialect.java M hibernate-core/src/main/java/org/hibernate/dialect/DB2zDialect.java M hibernate-core/src/main/java/org/hibernate/dialect/DerbyDialect.java M hibernate-core/src/main/java/org/hibernate/dialect/H2Dialect.java M hibernate-core/src/main/java/org/hibernate/dialect/MariaDBDialect.java M hibernate-core/src/main/java/org/hibernate/dialect/OracleDialect.java M hibernate-core/src/main/java/org/hibernate/dialect/PostgreSQLDialect.java Log Message: ----------- document supported database versions in Dialects there was incorrect information here for a couple of them Commit: 0f4cdc3bdb3b2cff5e16467f256af534febe165b https://github.com/hibernate/hibernate-orm/commit/0f4cdc3bdb3b2cff5e16467... Author: Gavin <gavin(a)hibernate.org&gt; Date: 2022-12-20 (Tue, 20 Dec 2022) Changed paths: M hibernate-core/src/main/java/org/hibernate/dialect/Dialect.java M hibernate-core/src/main/java/org/hibernate/dialect/OracleDialect.java M hibernate-core/src/main/java/org/hibernate/dialect/identity/IdentityColumnSupportImpl.java M hibernate-core/src/main/java/org/hibernate/dialect/identity/Oracle12cGetGeneratedKeysDelegate.java M hibernate-core/src/main/java/org/hibernate/dialect/identity/Oracle12cIdentityColumnSupport.java M hibernate-core/src/main/java/org/hibernate/id/SelectGenerator.java M hibernate-core/src/main/java/org/hibernate/id/insert/GetGeneratedKeysDelegate.java Log Message: ----------- use getGeneratedKeys() in SelectGenerator on Oracle Commit: 250995336b97f2db64ea37a265ecc88b2fde1493 https://github.com/hibernate/hibernate-orm/commit/250995336b97f2db64ea37a... Author: Gavin <gavin(a)hibernate.org&gt; Date: 2022-12-20 (Tue, 20 Dec 2022) Changed paths: M hibernate-core/src/main/java/org/hibernate/dialect/H2SqlAstTranslator.java M hibernate-core/src/main/java/org/hibernate/dialect/identity/H2FinalTableIdentityColumnSupport.java M hibernate-core/src/main/java/org/hibernate/dialect/identity/H2IdentityColumnSupport.java Log Message: ----------- note down an important TODO for later Commit: be3621d8f8de243645920de86aaf624ebc85e212 https://github.com/hibernate/hibernate-orm/commit/be3621d8f8de243645920de... Author: Gavin <gavin(a)hibernate.org&gt; Date: 2022-12-20 (Tue, 20 Dec 2022) Changed paths: M hibernate-core/src/main/java/org/hibernate/annotations/Generated.java M hibernate-core/src/main/java/org/hibernate/annotations/GeneratedColumn.java M hibernate-core/src/main/java/org/hibernate/dialect/Dialect.java M hibernate-core/src/main/java/org/hibernate/dialect/OracleDialect.java M hibernate-core/src/main/java/org/hibernate/generator/InDatabaseGenerator.java A hibernate-core/src/main/java/org/hibernate/generator/internal/NaturalIdHelper.java M hibernate-core/src/main/java/org/hibernate/id/SelectGenerator.java A hibernate-core/src/test/java/org/hibernate/orm/test/generatedkeys/generated/GeneratedTest.java A hibernate-core/src/test/java/org/hibernate/orm/test/generatedkeys/generated/H2Trigger.java A hibernate-core/src/test/java/org/hibernate/orm/test/generatedkeys/generated/MyEntity.hbm.xml A hibernate-core/src/test/java/org/hibernate/orm/test/generatedkeys/generated/MyEntity.java M hibernate-core/src/test/java/org/hibernate/orm/test/generatedkeys/select/SelectGeneratorTest.java M hibernate-core/src/test/java/org/hibernate/orm/test/generatedkeys/selectannotated/SelectGeneratorTest.java Log Message: ----------- hand over responsibilities of SelectGenerator to @Generated at the end of all this work on SelectGenerator, a cruel twist of fate! Commit: 3ad3c5a5095ec18f9d311ef95ecddea63e60162e https://github.com/hibernate/hibernate-orm/commit/3ad3c5a5095ec18f9d311ef... Author: Gavin <gavin(a)hibernate.org&gt; Date: 2022-12-20 (Tue, 20 Dec 2022) Changed paths: M documentation/src/main/asciidoc/topical/generated/GeneratedValues.adoc M documentation/src/test/java/org/hibernate/userguide/mapping/generated/GeneratedTest.java M hibernate-core/src/main/java/org/hibernate/annotations/ColumnDefault.java M hibernate-core/src/main/java/org/hibernate/annotations/ColumnTransformer.java M hibernate-core/src/main/java/org/hibernate/annotations/Generated.java M hibernate-core/src/main/java/org/hibernate/annotations/SQLInsert.java M hibernate-core/src/main/java/org/hibernate/annotations/SQLUpdate.java M hibernate-core/src/main/java/org/hibernate/generator/internal/GeneratedGeneration.java M hibernate-core/src/main/java/org/hibernate/id/SelectGenerator.java M hibernate-core/src/test/java/org/hibernate/orm/test/generatedkeys/generated/MyEntity.java Log Message: ----------- change default event timing for @Generated to event = INSERT - this makes sense if @Generated con now be used on @Id properties - but it's also convenient with @ColumnDefault Compare: https://github.com/hibernate/hibernate-orm/compare/d8bf64999844...3ad3c5a...