[hibernate-commits] [hibernate/hibernate-search] bd973e: HSEARCH-3110 Move ErrorHandler back to API

Branch: refs/heads/master Home: https://github.com/hibernate/hibernate-search Commit: bd973e91a393fe94a0b3fb17438d894307ee46e7 https://github.com/hibernate/hibernate-search/commit/bd973e91a393fe94a0b3... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2019-10-17 (Thu, 17 Oct 2019) Changed paths: M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/impl/ElasticsearchBackendImpl.java M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/orchestration/impl/ElasticsearchBatchingWorkOrchestrator.java M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/orchestration/impl/ElasticsearchDefaultWorkExecutionContext.java M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/orchestration/impl/ElasticsearchDefaultWorkSequenceBuilder.java M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/orchestration/impl/ElasticsearchWorkOrchestratorProvider.java M backend/elasticsearch/src/test/java/org/hibernate/search/backend/elasticsearch/orchestration/impl/ElasticsearchDefaultWorkSequenceBuilderTest.java M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/impl/LuceneBackendImpl.java M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/index/impl/IndexManagerBackendContext.java M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/lowlevel/index/impl/IndexAccessor.java M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/lowlevel/writer/impl/HibernateSearchConcurrentMergeScheduler.java M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/lowlevel/writer/impl/IndexWriterDelegatorImpl.java M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/orchestration/impl/LuceneBatchingWriteWorkOrchestrator.java M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/orchestration/impl/LuceneWriteWorkProcessor.java M backend/lucene/src/test/java/org/hibernate/search/backend/lucene/orchestration/impl/LuceneWriteWorkProcessorTest.java M engine/src/main/java/org/hibernate/search/engine/backend/orchestration/spi/BatchingExecutor.java M engine/src/main/java/org/hibernate/search/engine/backend/spi/BackendBuildContext.java M engine/src/main/java/org/hibernate/search/engine/cfg/EngineSettings.java M engine/src/main/java/org/hibernate/search/engine/cfg/spi/EngineSpiSettings.java M engine/src/main/java/org/hibernate/search/engine/common/impl/DelegatingBuildContext.java R engine/src/main/java/org/hibernate/search/engine/common/impl/ErrorContextImpl.java M engine/src/main/java/org/hibernate/search/engine/common/impl/RootBuildContext.java M engine/src/main/java/org/hibernate/search/engine/common/impl/SearchIntegrationBuilderImpl.java M engine/src/main/java/org/hibernate/search/engine/common/impl/SearchIntegrationImpl.java M engine/src/main/java/org/hibernate/search/engine/common/impl/SearchIntegrationPartialBuildStateImpl.java R engine/src/main/java/org/hibernate/search/engine/common/spi/ContextualErrorHandler.java R engine/src/main/java/org/hibernate/search/engine/common/spi/DefaultContextualErrorHandler.java R engine/src/main/java/org/hibernate/search/engine/common/spi/ErrorContext.java R engine/src/main/java/org/hibernate/search/engine/common/spi/ErrorContextBuilder.java R engine/src/main/java/org/hibernate/search/engine/common/spi/ErrorHandler.java R engine/src/main/java/org/hibernate/search/engine/common/spi/LogErrorHandler.java M engine/src/main/java/org/hibernate/search/engine/mapper/mapping/building/spi/MappingBuildContext.java A engine/src/main/java/org/hibernate/search/engine/reporting/ContextualErrorHandler.java A engine/src/main/java/org/hibernate/search/engine/reporting/DefaultContextualErrorHandler.java A engine/src/main/java/org/hibernate/search/engine/reporting/ErrorContext.java A engine/src/main/java/org/hibernate/search/engine/reporting/ErrorHandler.java A engine/src/main/java/org/hibernate/search/engine/reporting/impl/ErrorContextImpl.java A engine/src/main/java/org/hibernate/search/engine/reporting/impl/LogErrorHandler.java A engine/src/main/java/org/hibernate/search/engine/reporting/spi/ErrorContextBuilder.java M engine/src/test/java/org/hibernate/search/engine/backend/orchestration/spi/BatchingExecutorTest.java R engine/src/test/java/org/hibernate/search/engine/common/spi/DefaultContextualErrorHandlerTest.java A engine/src/test/java/org/hibernate/search/engine/reporting/DefaultContextualErrorHandlerTest.java M integrationtest/mapper/orm/src/test/java/org/hibernate/search/integrationtest/mapper/orm/massindexing/MassIndexingErrorHandlerIT.java M integrationtest/mapper/orm/src/test/java/org/hibernate/search/integrationtest/mapper/orm/massindexing/MassIndexingMonitorIT.java M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/mapping/impl/HibernateOrmMapping.java M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/massindexing/impl/BatchIndexingWorkspace.java M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/massindexing/impl/ErrorHandledRunnable.java M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/massindexing/impl/HibernateOrmMassIndexingMappingContext.java M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/massindexing/impl/IdentifierConsumerDocumentProducer.java M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/massindexing/impl/IdentifierProducer.java M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/massindexing/impl/OptionallyWrapInJTATransaction.java M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/mapping/building/impl/PojoMapper.java M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/mapping/impl/PojoMappingDelegateImpl.java M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/mapping/spi/PojoMappingDelegate.java Log Message: ----------- HSEARCH-3110 Move ErrorHandler back to API Commit: 2cba9166bf5165a4120676de0e3b593a05fef408 https://github.com/hibernate/hibernate-search/commit/2cba9166bf5165a41206... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2019-10-17 (Thu, 17 Oct 2019) Changed paths: M engine/src/main/java/org/hibernate/search/engine/reporting/ErrorContext.java M engine/src/main/java/org/hibernate/search/engine/reporting/impl/ErrorContextImpl.java Log Message: ----------- HSEARCH-1375 Remove an unused method from ErrorContext Commit: 1a1cd4fb771f7f67a01734469031fcc7bf1588b8 https://github.com/hibernate/hibernate-search/commit/1a1cd4fb771f7f67a017... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2019-10-17 (Thu, 17 Oct 2019) Changed paths: M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/impl/ElasticsearchBackendFactory.java M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/impl/ElasticsearchBackendImpl.java M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/orchestration/impl/ElasticsearchBatchingWorkOrchestrator.java M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/orchestration/impl/ElasticsearchDefaultWorkExecutionContext.java M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/orchestration/impl/ElasticsearchDefaultWorkSequenceBuilder.java M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/orchestration/impl/ElasticsearchWorkOrchestratorProvider.java M backend/elasticsearch/src/test/java/org/hibernate/search/backend/elasticsearch/orchestration/impl/ElasticsearchDefaultWorkSequenceBuilderTest.java M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/impl/LuceneBackendFactory.java M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/impl/LuceneBackendImpl.java M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/index/impl/IndexManagerBackendContext.java M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/lowlevel/index/impl/IndexAccessor.java M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/lowlevel/writer/impl/HibernateSearchConcurrentMergeScheduler.java M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/lowlevel/writer/impl/IndexWriterDelegatorImpl.java M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/orchestration/impl/LuceneBatchingWriteWorkOrchestrator.java M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/orchestration/impl/LuceneWriteWorkProcessor.java M backend/lucene/src/test/java/org/hibernate/search/backend/lucene/orchestration/impl/LuceneWriteWorkProcessorTest.java M engine/src/main/java/org/hibernate/search/engine/backend/orchestration/spi/BatchingExecutor.java M engine/src/main/java/org/hibernate/search/engine/backend/spi/BackendBuildContext.java M engine/src/main/java/org/hibernate/search/engine/cfg/EngineSettings.java M engine/src/main/java/org/hibernate/search/engine/common/impl/DelegatingBuildContext.java M engine/src/main/java/org/hibernate/search/engine/common/impl/RootBuildContext.java M engine/src/main/java/org/hibernate/search/engine/common/impl/SearchIntegrationBuilderImpl.java M engine/src/main/java/org/hibernate/search/engine/common/impl/SearchIntegrationImpl.java M engine/src/main/java/org/hibernate/search/engine/common/impl/SearchIntegrationPartialBuildStateImpl.java M engine/src/main/java/org/hibernate/search/engine/mapper/mapping/building/spi/MappingBuildContext.java R engine/src/main/java/org/hibernate/search/engine/reporting/ContextualErrorHandler.java A engine/src/main/java/org/hibernate/search/engine/reporting/ContextualFailureHandler.java R engine/src/main/java/org/hibernate/search/engine/reporting/DefaultContextualErrorHandler.java A engine/src/main/java/org/hibernate/search/engine/reporting/DefaultContextualFailureHandler.java R engine/src/main/java/org/hibernate/search/engine/reporting/ErrorContext.java R engine/src/main/java/org/hibernate/search/engine/reporting/ErrorHandler.java A engine/src/main/java/org/hibernate/search/engine/reporting/FailureContext.java A engine/src/main/java/org/hibernate/search/engine/reporting/FailureHandler.java R engine/src/main/java/org/hibernate/search/engine/reporting/impl/ErrorContextImpl.java A engine/src/main/java/org/hibernate/search/engine/reporting/impl/FailureContextImpl.java R engine/src/main/java/org/hibernate/search/engine/reporting/impl/LogErrorHandler.java A engine/src/main/java/org/hibernate/search/engine/reporting/impl/LogFailureHandler.java R engine/src/main/java/org/hibernate/search/engine/reporting/spi/ErrorContextBuilder.java A engine/src/main/java/org/hibernate/search/engine/reporting/spi/FailureContextBuilder.java M engine/src/test/java/org/hibernate/search/engine/backend/orchestration/spi/BatchingExecutorTest.java R engine/src/test/java/org/hibernate/search/engine/reporting/DefaultContextualErrorHandlerTest.java A engine/src/test/java/org/hibernate/search/engine/reporting/DefaultContextualFailureHandlerTest.java R integrationtest/mapper/orm/src/test/java/org/hibernate/search/integrationtest/mapper/orm/massindexing/MassIndexingErrorHandlerIT.java A integrationtest/mapper/orm/src/test/java/org/hibernate/search/integrationtest/mapper/orm/massindexing/MassIndexingFailureHandlerIT.java M integrationtest/mapper/orm/src/test/java/org/hibernate/search/integrationtest/mapper/orm/massindexing/MassIndexingMonitorIT.java M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/logging/impl/Log.java M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/mapping/impl/HibernateOrmMapping.java M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/massindexing/impl/BatchCoordinator.java M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/massindexing/impl/BatchIndexingWorkspace.java R mapper/orm/src/main/java/org/hibernate/search/mapper/orm/massindexing/impl/ErrorHandledRunnable.java A mapper/orm/src/main/java/org/hibernate/search/mapper/orm/massindexing/impl/FailureHandledRunnable.java M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/massindexing/impl/HibernateOrmMassIndexingMappingContext.java M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/massindexing/impl/IdentifierConsumerDocumentProducer.java M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/massindexing/impl/IdentifierProducer.java M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/massindexing/impl/OptionallyWrapInJTATransaction.java M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/mapping/building/impl/PojoMapper.java M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/mapping/impl/PojoMappingDelegateImpl.java M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/mapping/spi/PojoMappingDelegate.java M mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/work/impl/PojoScopeWorkspaceImpl.java Log Message: ----------- HSEARCH-1375 Rename ErrorHandler to FailureHandler ... and rename related concepts (ErrorContext, error_handler configuration property, ...). I used the term "Failure" because: 1. Exception isn't quite right, since we handle Throwables. 2. Error may incorrectly hint at java.lang.Error, and, again, we handle Throwables. 3. Failure has the advantage of being relatively exempt of a precise technical meaning. Commit: d2807cd672612728382a5cf66c455a3afa93db35 https://github.com/hibernate/hibernate-search/commit/d2807cd672612728382a... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2019-10-17 (Thu, 17 Oct 2019) Changed paths: M engine/src/main/java/org/hibernate/search/engine/reporting/FailureHandler.java Log Message: ----------- HSEARCH-1375 Remove now obsolete @since tags in FailureHandler et al. We changed the APIs, these tags no longer make sense. Commit: 1fb1f5f4a8664ccebd9b287ab44efc3d85033782 https://github.com/hibernate/hibernate-search/commit/1fb1f5f4a8664ccebd9b... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2019-10-17 (Thu, 17 Oct 2019) Changed paths: M engine/src/main/java/org/hibernate/search/engine/cfg/EngineSettings.java M engine/src/main/java/org/hibernate/search/engine/common/impl/SearchIntegrationBuilderImpl.java M engine/src/main/java/org/hibernate/search/engine/reporting/FailureHandler.java M integrationtest/mapper/orm/src/test/java/org/hibernate/search/integrationtest/mapper/orm/massindexing/MassIndexingFailureHandlerIT.java M integrationtest/mapper/orm/src/test/java/org/hibernate/search/integrationtest/mapper/orm/massindexing/MassIndexingMonitorIT.java Log Message: ----------- HSEARCH-1375 Clarify that the failure handler is about *background* failures Commit: fa1acb00fcb32f5dae518ef75f0d4620abcc6546 https://github.com/hibernate/hibernate-search/commit/fa1acb00fcb32f5dae51... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2019-10-17 (Thu, 17 Oct 2019) Changed paths: M engine/src/main/java/org/hibernate/search/engine/cfg/EngineSettings.java A engine/src/main/java/org/hibernate/search/engine/impl/EngineBeanConfigurer.java A engine/src/main/resources/META-INF/services/org.hibernate.search.engine.environment.bean.spi.BeanConfigurer Log Message: ----------- HSEARCH-1375 Re-allow setting the failure handler explicitly to "log" to get the default implementation Commit: e5af81577a49739631b6b38039f999ba7fd92ae7 https://github.com/hibernate/hibernate-search/commit/e5af81577a49739631b6... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2019-10-17 (Thu, 17 Oct 2019) Changed paths: M engine/src/main/java/org/hibernate/search/engine/reporting/DefaultContextualFailureHandler.java R engine/src/main/java/org/hibernate/search/engine/reporting/FailureContext.java M engine/src/main/java/org/hibernate/search/engine/reporting/FailureHandler.java A engine/src/main/java/org/hibernate/search/engine/reporting/IndexFailureContext.java R engine/src/main/java/org/hibernate/search/engine/reporting/impl/FailureContextImpl.java A engine/src/main/java/org/hibernate/search/engine/reporting/impl/IndexFailureContextImpl.java M engine/src/main/java/org/hibernate/search/engine/reporting/impl/LogFailureHandler.java R engine/src/main/java/org/hibernate/search/engine/reporting/spi/FailureContextBuilder.java A engine/src/main/java/org/hibernate/search/engine/reporting/spi/IndexFailureContextBuilder.java M engine/src/test/java/org/hibernate/search/engine/reporting/DefaultContextualFailureHandlerTest.java M integrationtest/mapper/orm/src/test/java/org/hibernate/search/integrationtest/mapper/orm/massindexing/MassIndexingFailureHandlerIT.java Log Message: ----------- HSEARCH-1375 Clarify that FailureContext is about failures in index operations So it's really only used when there are index operations to mention. If a background thread of the mapper were to fail, for example during mass indexing, you would not get a call to handle(IndexFailureContext). Commit: 66576d41e489b849231fe696d43fc38a4f7ea268 https://github.com/hibernate/hibernate-search/commit/66576d41e489b849231f... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2019-10-17 (Thu, 17 Oct 2019) Changed paths: M engine/src/main/java/org/hibernate/search/engine/reporting/spi/IndexFailureContextBuilder.java Log Message: ----------- HSEARCH-1375 Remove dead code from IndexFailureContextBuilder Commit: 5e9ebbcc251eededeb0019cb398f8aa10d9e5071 https://github.com/hibernate/hibernate-search/commit/5e9ebbcc251eededeb00... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2019-10-17 (Thu, 17 Oct 2019) Changed paths: M engine/src/main/java/org/hibernate/search/engine/reporting/DefaultContextualFailureHandler.java M engine/src/main/java/org/hibernate/search/engine/reporting/IndexFailureContext.java M engine/src/main/java/org/hibernate/search/engine/reporting/impl/IndexFailureContextImpl.java M engine/src/main/java/org/hibernate/search/engine/reporting/impl/LogFailureHandler.java M engine/src/main/java/org/hibernate/search/engine/reporting/spi/IndexFailureContextBuilder.java M engine/src/test/java/org/hibernate/search/engine/reporting/DefaultContextualFailureHandlerTest.java Log Message: ----------- HSEARCH-1375 Clarify the getters of IndexFailureContext Commit: dba2c66187f8e72b61c30189eb06572f9acd2690 https://github.com/hibernate/hibernate-search/commit/dba2c66187f8e72b61c3... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2019-10-17 (Thu, 17 Oct 2019) Changed paths: M engine/src/main/java/org/hibernate/search/engine/reporting/DefaultContextualFailureHandler.java R engine/src/main/java/org/hibernate/search/engine/reporting/impl/IndexFailureContextImpl.java R engine/src/main/java/org/hibernate/search/engine/reporting/spi/IndexFailureContextBuilder.java A engine/src/main/java/org/hibernate/search/engine/reporting/spi/IndexFailureContextImpl.java Log Message: ----------- HSEARCH-1375 Simplify IndexFailureContextImpl and its builder We're about to introduce more complexity with a type hierarchy, so we better start from something simple. Commit: d01dac7363451f3fcd5e5873bc9db863fc5e72df https://github.com/hibernate/hibernate-search/commit/d01dac7363451f3fcd5e... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2019-10-17 (Thu, 17 Oct 2019) Changed paths: A engine/src/main/java/org/hibernate/search/engine/reporting/FailureContext.java M engine/src/main/java/org/hibernate/search/engine/reporting/IndexFailureContext.java A engine/src/main/java/org/hibernate/search/engine/reporting/spi/FailureContextImpl.java M engine/src/main/java/org/hibernate/search/engine/reporting/spi/IndexFailureContextImpl.java Log Message: ----------- HSEARCH-1375 Introduce FailureContext, a more generic version of IndexFailureContext Commit: 646a613fa9b3b3d6b1c12070c81bb1477e69a10c https://github.com/hibernate/hibernate-search/commit/646a613fa9b3b3d6b1c1... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2019-10-17 (Thu, 17 Oct 2019) Changed paths: M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/orchestration/impl/ElasticsearchDefaultWorkExecutionContext.java M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/logging/impl/Log.java M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/lowlevel/writer/impl/HibernateSearchConcurrentMergeScheduler.java M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/orchestration/impl/LuceneWriteWorkProcessor.java M backend/lucene/src/test/java/org/hibernate/search/backend/lucene/orchestration/impl/LuceneWriteWorkProcessorTest.java M engine/src/main/java/org/hibernate/search/engine/backend/orchestration/spi/BatchingExecutor.java M engine/src/main/java/org/hibernate/search/engine/reporting/FailureHandler.java M engine/src/main/java/org/hibernate/search/engine/reporting/impl/LogFailureHandler.java M engine/src/test/java/org/hibernate/search/engine/backend/orchestration/spi/BatchingExecutorTest.java M integrationtest/mapper/orm/src/test/java/org/hibernate/search/integrationtest/mapper/orm/massindexing/MassIndexingFailureHandlerIT.java M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/logging/impl/Log.java M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/massindexing/impl/FailureHandledRunnable.java M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/massindexing/impl/IdentifierConsumerDocumentProducer.java M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/massindexing/impl/IdentifierProducer.java Log Message: ----------- HSEARCH-1375 Improve the consistency of the FailureHandler methods Pass a context no matter what, just a different type of context depending on the operation. Commit: 7faf474d6bc308731b4339a072d736a546c3b160 https://github.com/hibernate/hibernate-search/commit/7faf474d6bc308731b43... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2019-10-17 (Thu, 17 Oct 2019) Changed paths: M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/orchestration/impl/ElasticsearchDefaultWorkSequenceBuilder.java M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/orchestration/impl/ElasticsearchWorkOrchestratorProvider.java M backend/elasticsearch/src/test/java/org/hibernate/search/backend/elasticsearch/orchestration/impl/ElasticsearchDefaultWorkSequenceBuilderTest.java M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/index/impl/IndexManagerBackendContext.java M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/orchestration/impl/LuceneWriteWorkProcessor.java M backend/lucene/src/test/java/org/hibernate/search/backend/lucene/orchestration/impl/LuceneWriteWorkProcessorTest.java R engine/src/main/java/org/hibernate/search/engine/reporting/ContextualFailureHandler.java R engine/src/main/java/org/hibernate/search/engine/reporting/DefaultContextualFailureHandler.java M engine/src/main/java/org/hibernate/search/engine/reporting/FailureHandler.java A engine/src/main/java/org/hibernate/search/engine/reporting/spi/ContextualFailureHandler.java R engine/src/test/java/org/hibernate/search/engine/reporting/DefaultContextualFailureHandlerTest.java A engine/src/test/java/org/hibernate/search/engine/reporting/spi/ContextualFailureHandlerTest.java M integrationtest/mapper/orm/src/test/java/org/hibernate/search/integrationtest/mapper/orm/massindexing/MassIndexingFailureHandlerIT.java Log Message: ----------- HSEARCH-1375 Move ContextualFailureHandler to SPI No need to make the FailureHandler API more complex just for this. Commit: 0b818ab9ebe0c4d4737474a5fc96870988b8f5df https://github.com/hibernate/hibernate-search/commit/0b818ab9ebe0c4d47374... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2019-10-17 (Thu, 17 Oct 2019) Changed paths: M backend/elasticsearch/src/test/java/org/hibernate/search/backend/elasticsearch/orchestration/impl/ElasticsearchDefaultWorkSequenceBuilderTest.java M engine/src/main/java/org/hibernate/search/engine/reporting/FailureHandler.java Log Message: ----------- HSEARCH-1353 Clarify the expected behavior of failure handlers Commit: 25906577c1ab79be74ce38cff860eddc3aff9505 https://github.com/hibernate/hibernate-search/commit/25906577c1ab79be74ce... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2019-10-17 (Thu, 17 Oct 2019) Changed paths: M engine/src/main/java/org/hibernate/search/engine/reporting/FailureContext.java M engine/src/main/java/org/hibernate/search/engine/reporting/IndexFailureContext.java M engine/src/main/java/org/hibernate/search/engine/reporting/impl/LogFailureHandler.java M engine/src/main/java/org/hibernate/search/engine/reporting/spi/FailureContextImpl.java M engine/src/test/java/org/hibernate/search/engine/reporting/spi/ContextualFailureHandlerTest.java Log Message: ----------- HSEARCH-1375 Improve null-safety of access to FailureContext Commit: b40d498013eb2fe01527815482076f64d6a722b6 https://github.com/hibernate/hibernate-search/commit/b40d498013eb2fe01527... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2019-10-17 (Thu, 17 Oct 2019) Changed paths: M engine/src/main/java/org/hibernate/search/engine/reporting/IndexFailureContext.java M engine/src/main/java/org/hibernate/search/engine/reporting/impl/LogFailureHandler.java M engine/src/test/java/org/hibernate/search/engine/reporting/spi/ContextualFailureHandlerTest.java Log Message: ----------- HSEARCH-1375 Return List<?> instead of List<Object> from IndexFailureContext.getUncommittedOperations() ... so that we can change "?" to a specific type later, without breaking backward compatibility. Commit: a8e5d5a5a0725755c551cc050c07a5590c1b0a67 https://github.com/hibernate/hibernate-search/commit/a8e5d5a5a0725755c551... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2019-10-17 (Thu, 17 Oct 2019) Changed paths: M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/index/impl/IndexManagerBackendContext.java M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/orchestration/impl/LuceneWriteWorkProcessor.java M backend/lucene/src/test/java/org/hibernate/search/backend/lucene/orchestration/impl/LuceneWriteWorkProcessorTest.java Log Message: ----------- HSEARCH-1375 Correctly report uncommitted works to the failure handler upon Lucene indexing failures We used to only report works from the current workset after the one that failed, but really the uncommitted works before the failing work may also end up not being applied to the index, especially in case of commit failure. For example if we execute: 1. Workset 1: work 1, work 2 (commit strategy: no commit) 2. Workset 2: work 3, work 4, work 5 (commit strategy: no commit) ... and work 4 fails, then works 4 and 5 will obviously not be applied, but work 1, 2, and 3 may end up not being applied either, depending on the error, because we didn't commit them before the failure. Commit: 432106bccb9df69c0b65b44b491687ad868dc498 https://github.com/hibernate/hibernate-search/commit/432106bccb9df69c0b65... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2019-10-17 (Thu, 17 Oct 2019) Changed paths: M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/orchestration/impl/ElasticsearchDefaultWorkSequenceBuilder.java M backend/elasticsearch/src/test/java/org/hibernate/search/backend/elasticsearch/orchestration/impl/ElasticsearchDefaultWorkSequenceBuilderTest.java Log Message: ----------- HSEARCH-1375 Do not report bulk work failure twice Currently it's not very important, since we would only have added the exception as a suppressed exception to itself (weird, but not critical). In the next commits, this will become an actual problem, because of how we handle errors differently. Commit: b3e534fa3a299a4b10fece6344642604375ef39a https://github.com/hibernate/hibernate-search/commit/b3e534fa3a299a4b10fe... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2019-10-17 (Thu, 17 Oct 2019) Changed paths: M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/orchestration/impl/ElasticsearchDefaultWorkSequenceBuilder.java M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/orchestration/impl/ElasticsearchWorkOrchestratorProvider.java M backend/elasticsearch/src/test/java/org/hibernate/search/backend/elasticsearch/orchestration/impl/ElasticsearchDefaultWorkSequenceBuilderTest.java Log Message: ----------- HSEARCH-1375 Correctly report failures and uncommitted works to the failure handler upon Elasticsearch indexing failures 1. Report one failure per failed work. We used to report one failure with the first failed work as the "failing operation" and all other works as simply "uncommitted operations", but that's wrong: in some cases (bulk work failure) there are multiple failing works and the first one is not more responsible of the failure than the others. 2. Blame uncommitted works on the first failed work in each sequence. This is necessary now that we may report multiple failures per sequence. Commit: 95673cae19ce5f2d3d408c7485a2665811119d80 https://github.com/hibernate/hibernate-search/commit/95673cae19ce5f2d3d40... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2019-10-17 (Thu, 17 Oct 2019) Changed paths: M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/logging/impl/Log.java M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/orchestration/impl/ElasticsearchDefaultWorkSequenceBuilder.java M backend/elasticsearch/src/test/java/org/hibernate/search/backend/elasticsearch/orchestration/impl/ElasticsearchDefaultWorkSequenceBuilderTest.java Log Message: ----------- HSEARCH-1375 Use specific error messages when a bulked work fails because of its containing bulk work Commit: a393b2f7eba241157aeb30dcb5a42a7b090672e1 https://github.com/hibernate/hibernate-search/commit/a393b2f7eba241157aeb... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2019-10-17 (Thu, 17 Oct 2019) Changed paths: R engine/src/main/java/org/hibernate/search/engine/reporting/spi/ContextualFailureHandler.java R engine/src/test/java/org/hibernate/search/engine/reporting/spi/ContextualFailureHandlerTest.java Log Message: ----------- HSEARCH-1375 Remove ContextualFailureHandler It's no longer necessary, thanks to the changes in the last few commits. Commit: bcc45fbbb15fd5569c35a3e5568f076c80a2f97e https://github.com/hibernate/hibernate-search/commit/bcc45fbbb15fd5569c35... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2019-10-17 (Thu, 17 Oct 2019) Changed paths: M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/client/impl/ElasticsearchClientUtils.java M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/search/query/impl/ElasticsearchSearchQueryImpl.java M engine/src/main/java/org/hibernate/search/engine/backend/orchestration/spi/BatchingExecutor.java M integrationtest/backend/elasticsearch/src/test/java/org/hibernate/search/integrationtest/backend/elasticsearch/bootstrap/ElasticsearchBootstrapFailureIT.java M mapper/javabean/src/main/java/org/hibernate/search/mapper/javabean/session/impl/JavaBeanSearchSession.java M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/event/impl/InitializingHibernateSearchState.java M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/massindexing/impl/BatchCoordinator.java M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/massindexing/impl/IdentifierConsumerDocumentProducer.java M util/common/src/main/java/org/hibernate/search/util/common/impl/Futures.java M util/common/src/main/java/org/hibernate/search/util/common/impl/Throwables.java Log Message: ----------- HSEARCH-1375 Avoid direct uses of CompletableFuture.join() in non-test code This method wraps exceptions with CompletionException, which is generally not what we want (we want the original exception). Commit: e130c8c750d303ff7ca2da6b8373886dbc252636 https://github.com/hibernate/hibernate-search/commit/e130c8c750d303ff7ca2... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2019-10-17 (Thu, 17 Oct 2019) Changed paths: M build-config/src/main/resources/forbidden-runtime.txt M pom.xml Log Message: ----------- HSEARCH-1375 Forbid direct uses of CompletableFuture.join() in non-test code Commit: d4b6832a0db361e02907ac5140ccd8f7500f5eb4 https://github.com/hibernate/hibernate-search/commit/d4b6832a0db361e02907... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2019-10-17 (Thu, 17 Oct 2019) Changed paths: M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/index/admin/impl/ElasticsearchSchemaAccessor.java M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/index/admin/impl/ElasticsearchSchemaMigratorImpl.java M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/logging/impl/Log.java M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/index/impl/ShardHolder.java M engine/src/main/java/org/hibernate/search/engine/common/impl/IndexManagerPartialBuildState.java M util/common/src/main/java/org/hibernate/search/util/common/impl/Throwables.java Log Message: ----------- HSEARCH-1375 Correctly unwrap exceptions when propagating them to completable futures or failure handlers 1. If we don't wrap the lambda passsed to exceptionally with Futures.handler, we end up keeping the CompletionException wrapper in the stack trace. That's really not necessary and makes us lose the original exception message when we extract it through e.getMessage(). 2. If we use expectRuntimeException instead of expectException, we end up losing the original exception message if we extract it through e.getMessage(). Commit: c32bcc40703f2c2d4a2a64b73b96c54e14e7d145 https://github.com/hibernate/hibernate-search/commit/c32bcc40703f2c2d4a2a... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2019-10-17 (Thu, 17 Oct 2019) Changed paths: M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/logging/impl/Log.java Log Message: ----------- HSEARCH-1375 Avoid JBoss Logging message IDs in strings used to describe operations Commit: 067785d660bb5dbab141cca2ff48f19d25840bd0 https://github.com/hibernate/hibernate-search/commit/067785d660bb5dbab141... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2019-10-17 (Thu, 17 Oct 2019) Changed paths: R integrationtest/mapper/orm/src/test/java/org/hibernate/search/integrationtest/mapper/orm/massindexing/MassIndexingFailureHandlerIT.java A integrationtest/mapper/orm/src/test/java/org/hibernate/search/integrationtest/mapper/orm/massindexing/MassIndexingFailureIT.java M util/internal/integrationtest/common/src/main/java/org/hibernate/search/util/impl/integrationtest/common/rule/BackendMock.java Log Message: ----------- HSEARCH-1375 Test MassIndexer failures more throroughly Commit: 5afc90abdac5c14a18fb617c32127c36bd01d57a https://github.com/hibernate/hibernate-search/commit/5afc90abdac5c14a18fb... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2019-10-17 (Thu, 17 Oct 2019) Changed paths: M integrationtest/mapper/orm/src/test/java/org/hibernate/search/integrationtest/mapper/orm/massindexing/MassIndexingFailureIT.java A util/internal/integrationtest/common/src/main/java/org/hibernate/search/util/impl/integrationtest/common/stub/StubFailureHandler.java Log Message: ----------- HSEARCH-1375 Move CountingFailureHandler (now StubFailureHandler) to test utils Commit: d93a81dc7de155828af05d5229a9b51e99195e3f https://github.com/hibernate/hibernate-search/commit/d93a81dc7de155828af0... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2019-10-17 (Thu, 17 Oct 2019) Changed paths: M integrationtest/backend/elasticsearch/src/test/java/org/hibernate/search/integrationtest/backend/elasticsearch/client/ElasticsearchContentLengthIT.java M integrationtest/backend/elasticsearch/src/test/java/org/hibernate/search/integrationtest/backend/elasticsearch/testsupport/util/ElasticsearchTckBackendHelper.java A integrationtest/backend/elasticsearch/src/test/java/org/hibernate/search/integrationtest/backend/elasticsearch/testsupport/util/ElasticsearchTckBackendSetupStrategy.java M integrationtest/backend/lucene/src/test/java/org/hibernate/search/integrationtest/backend/lucene/testsupport/util/LuceneTckBackendHelper.java A integrationtest/backend/lucene/src/test/java/org/hibernate/search/integrationtest/backend/lucene/testsupport/util/LuceneTckBackendSetupStrategy.java A integrationtest/backend/lucene/src/test/java/org/hibernate/search/integrationtest/backend/lucene/testsupport/util/LuceneTestIndexesPathConfiguration.java R integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/testsupport/util/DefaultTckBackendSetupStrategy.java M integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/testsupport/util/TckBackendSetupStrategy.java M pom.xml M util/internal/integrationtest/common/src/main/java/org/hibernate/search/util/impl/integrationtest/common/TestConfigurationProvider.java Log Message: ----------- HSEARCH-1375 Remove abstractions from the TCK backend setup strategies I want to add more features in there and the abstractions get in the way. Commit: 7bea16028ee42e6e0e9cedb8eabb763da70ec526 https://github.com/hibernate/hibernate-search/commit/7bea16028ee42e6e0e9c... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2019-10-17 (Thu, 17 Oct 2019) Changed paths: M integrationtest/backend/elasticsearch/src/test/java/org/hibernate/search/integrationtest/backend/elasticsearch/gson/ElasticsearchGsonConcurrencyIT.java A integrationtest/backend/elasticsearch/src/test/java/org/hibernate/search/integrationtest/backend/elasticsearch/testsupport/util/ElasticsearchTckBackendAccessor.java M integrationtest/backend/elasticsearch/src/test/java/org/hibernate/search/integrationtest/backend/elasticsearch/testsupport/util/ElasticsearchTckBackendSetupStrategy.java A integrationtest/backend/lucene/src/test/java/org/hibernate/search/integrationtest/backend/lucene/testsupport/util/LuceneTckBackendAccessor.java M integrationtest/backend/lucene/src/test/java/org/hibernate/search/integrationtest/backend/lucene/testsupport/util/LuceneTckBackendSetupStrategy.java A integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/testsupport/util/TckBackendAccessor.java M integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/testsupport/util/TckBackendSetupStrategy.java M integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/testsupport/util/rule/SearchSetupHelper.java M util/internal/integrationtest/backend/elasticsearch/src/main/java/org/hibernate/search/util/impl/integrationtest/backend/elasticsearch/rule/TestElasticsearchClient.java Log Message: ----------- HSEARCH-1375 Add ways for TCK tests to trigger failures in index operations Commit: 241242f6458c990c46ec5ac9735485b95366ea38 https://github.com/hibernate/hibernate-search/commit/241242f6458c990c46ec... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2019-10-17 (Thu, 17 Oct 2019) Changed paths: M integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/testsupport/util/rule/SearchSetupHelper.java M util/internal/integrationtest/backend/elasticsearch/src/main/java/org/hibernate/search/util/impl/integrationtest/backend/elasticsearch/rule/TestElasticsearchClient.java Log Message: ----------- HSEARCH-1375 Ensure rules do not silently replace test exceptions with exceptions thrown in finally blocks Commit: eb0c571451937f3360499f21a2136baebb823775 https://github.com/hibernate/hibernate-search/commit/eb0c571451937f336049... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2019-10-17 (Thu, 17 Oct 2019) Changed paths: M integrationtest/backend/lucene/src/test/java/org/hibernate/search/integrationtest/backend/lucene/testsupport/util/LuceneTckBackendAccessor.java M integrationtest/backend/lucene/src/test/java/org/hibernate/search/integrationtest/backend/lucene/testsupport/util/LuceneTckBackendFeatures.java M integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/testsupport/util/TckBackendFeatures.java A integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/work/AbstractIndexWorkspaceSimpleOperationIT.java A integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/work/IndexWorkspaceFlushIT.java A integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/work/IndexWorkspaceOptimizeIT.java A integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/work/IndexWorkspacePurgeIT.java Log Message: ----------- HSEARCH-1375 Test failure reporting for IndexWorkspace operations ... on a best-effort basis, because several things are quite hard to assert. Commit: 311167f22613b51aa4d861fb49d969c6cb80351f https://github.com/hibernate/hibernate-search/commit/311167f22613b51aa4d8... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2019-10-17 (Thu, 17 Oct 2019) Changed paths: M engine/src/main/java/org/hibernate/search/engine/reporting/impl/LogFailureHandler.java Log Message: ----------- HSEARCH-1375 Add a few missing line breaks in LogFailureHandler Commit: 10e8cfbad018cd369ff597bcd7f626ce9a8c2934 https://github.com/hibernate/hibernate-search/commit/10e8cfbad018cd369ff5... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2019-10-17 (Thu, 17 Oct 2019) Changed paths: M integrationtest/backend/lucene/src/test/java/org/hibernate/search/integrationtest/backend/lucene/testsupport/util/LuceneTckBackendAccessor.java M integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/work/IndexIndexerIT.java Log Message: ----------- HSEARCH-1375 Test failure reporting for IndexIndexer operations Commit: 182e9f503693b9b9b07770b4cc0a5be6791297fc https://github.com/hibernate/hibernate-search/commit/182e9f503693b9b9b077... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2019-10-17 (Thu, 17 Oct 2019) Changed paths: M integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/work/IndexIndexingPlanIT.java Log Message: ----------- HSEARCH-1375 Test failure reporting for IndexIndexingPlan operations Commit: 2b8ec46b36daddb4687999d86f23b9fb2ef49152 https://github.com/hibernate/hibernate-search/commit/2b8ec46b36daddb46879... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2019-10-17 (Thu, 17 Oct 2019) Changed paths: M documentation/src/main/asciidoc/configuration.asciidoc A documentation/src/test/java/org/hibernate/search/documentation/reporting/failurehandler/FailureHandlerIT.java A documentation/src/test/java/org/hibernate/search/documentation/reporting/failurehandler/MyFailureHandler.java A documentation/src/test/resources/reporting/failurehandler.properties Log Message: ----------- HSEARCH-1353 Document background failure handling Commit: 70c6b9cd4dcebf36ed0eb3286c9ae9f829b35dd9 https://github.com/hibernate/hibernate-search/commit/70c6b9cd4dcebf36ed0e... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2019-10-17 (Thu, 17 Oct 2019) Changed paths: M documentation/src/main/asciidoc/configuration.asciidoc M documentation/src/test/java/org/hibernate/search/documentation/reporting/failurehandler/MyFailureHandler.java M engine/src/main/java/org/hibernate/search/engine/common/impl/SearchIntegrationBuilderImpl.java M engine/src/main/java/org/hibernate/search/engine/logging/impl/Log.java A engine/src/main/java/org/hibernate/search/engine/reporting/impl/FailSafeFailureHandlerWrapper.java A engine/src/test/java/org/hibernate/search/engine/reporting/impl/FailSafeFailureHandlerWrapperTest.java Log Message: ----------- HSEARCH-1375 Automatically wrap failure handlers to catch and log unexpected exceptions It's rather critical in this case, since the failure handler is called in... failure handling code, where we usually don't expect another failure. Compare: https://github.com/hibernate/hibernate-search/compare/30508cd8f184...70c6...