[hibernate-commits] [hibernate/hibernate-validator] c5fdd1: HV-1526 Move creation of ConstraintValidatorContex...

Branch: refs/heads/master Home: https://github.com/hibernate/hibernate-validator Commit: c5fdd1919703d0eea4996778c19ac577dae4ebab https://github.com/hibernate/hibernate-validator/commit/c5fdd1919703d0eea... Author: marko-bekhta <marko.prykladna(a)gmail.com&gt; Date: 2018-05-04 (Fri, 04 May 2018) Changed paths: M engine/src/main/java/org/hibernate/validator/internal/engine/ValidationContext.java M engine/src/main/java/org/hibernate/validator/internal/engine/constraintvalidation/ComposingConstraintTree.java M engine/src/main/java/org/hibernate/validator/internal/engine/constraintvalidation/SimpleConstraintTree.java Log Message: ----------- HV-1526 Move creation of ConstraintValidatorContextImpl into ValidationContext - As we want to encapsulate the ValidationContext specifics and for example not expose the getParameterNames() method, ConstraintValidatorContextImpl can be created inside the context and returned from it. - This also allows to remove unnecessarily exposed getters of clock provider and constraint validator payload Commit: 6d56faaaeb2d8da427655f039b5ea567390e9129 https://github.com/hibernate/hibernate-validator/commit/6d56faaaeb2d8da42... Author: marko-bekhta <marko.prykladna(a)gmail.com&gt; Date: 2018-05-04 (Fri, 04 May 2018) Changed paths: A engine/src/main/java/org/hibernate/validator/constraintvalidation/HibernateCrossParameterConstraintValidatorContext.java M engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/hv/ParameterScriptAssertValidator.java M engine/src/main/java/org/hibernate/validator/internal/engine/ValidationContext.java M engine/src/main/java/org/hibernate/validator/internal/engine/constraintvalidation/ConstraintTree.java M engine/src/main/java/org/hibernate/validator/internal/engine/constraintvalidation/ConstraintValidatorContextImpl.java A engine/src/main/java/org/hibernate/validator/internal/engine/constraintvalidation/CrossParameterConstraintValidatorContextImpl.java M engine/src/test/java/org/hibernate/validator/test/constraints/ConstraintValidatorContextImplTest.java M engine/src/test/java/org/hibernate/validator/testutils/ValidatorUtil.java Log Message: ----------- HV-1526 Make a distinction between cross-parameter and other ConstraintValidatorContext implementations Thus we don't have the method parameter names in the ConstraintValidatorContext if it does not make sense, e.g. for class-level or field validation. Commit: c00419569367f5363704ec62d0b61ec6585cca64 https://github.com/hibernate/hibernate-validator/commit/c00419569367f5363... Author: marko-bekhta <marko.prykladna(a)gmail.com&gt; Date: 2018-05-04 (Fri, 04 May 2018) Changed paths: M engine/src/main/java/org/hibernate/validator/internal/engine/ValidationContext.java M engine/src/main/java/org/hibernate/validator/internal/engine/constraintvalidation/ConstraintTree.java Log Message: ----------- HV-1526 Combine creation and addition of constraint violations in ValidationContext As now we don't create violations unless we need them, these operations can be combined. Another benefit is that ValidationContext exposes less public methods. Commit: 7af799ee3ca3750bcf2b6ff5885e585571c353bf https://github.com/hibernate/hibernate-validator/commit/7af799ee3ca3750bc... Author: marko-bekhta <marko.prykladna(a)gmail.com&gt; Date: 2018-05-04 (Fri, 04 May 2018) Changed paths: R engine/src/main/java/org/hibernate/validator/internal/engine/ValidationContext.java M engine/src/main/java/org/hibernate/validator/internal/engine/ValidatorFactoryImpl.java M engine/src/main/java/org/hibernate/validator/internal/engine/ValidatorImpl.java M engine/src/main/java/org/hibernate/validator/internal/engine/constraintvalidation/ComposingConstraintTree.java M engine/src/main/java/org/hibernate/validator/internal/engine/constraintvalidation/ConstraintTree.java M engine/src/main/java/org/hibernate/validator/internal/engine/constraintvalidation/SimpleConstraintTree.java A engine/src/main/java/org/hibernate/validator/internal/engine/validationcontext/AbstractValidationContext.java A engine/src/main/java/org/hibernate/validator/internal/engine/validationcontext/BeanValidationContext.java A engine/src/main/java/org/hibernate/validator/internal/engine/validationcontext/ExecutableValidationContext.java A engine/src/main/java/org/hibernate/validator/internal/engine/validationcontext/ParameterExecutableValidationContext.java A engine/src/main/java/org/hibernate/validator/internal/engine/validationcontext/PropertyValidationContext.java A engine/src/main/java/org/hibernate/validator/internal/engine/validationcontext/ReturnValueExecutableValidationContext.java A engine/src/main/java/org/hibernate/validator/internal/engine/validationcontext/ValidationContext.java A engine/src/main/java/org/hibernate/validator/internal/engine/validationcontext/ValidationContextBuilder.java A engine/src/main/java/org/hibernate/validator/internal/engine/validationcontext/ValidatorScopedContext.java A engine/src/main/java/org/hibernate/validator/internal/engine/validationcontext/package-info.java M engine/src/main/java/org/hibernate/validator/internal/metadata/core/MetaConstraint.java Log Message: ----------- HV-1526 Add different implementations of ValidationContext - add implementations for bean, property/value, executable parameter and executable return value contexts - extract builder for validation contexts to its own class Commit: 2e062647875d510ce9340753316201323991c65b https://github.com/hibernate/hibernate-validator/commit/2e062647875d510ce... Author: marko-bekhta <marko.prykladna(a)gmail.com&gt; Date: 2018-05-04 (Fri, 04 May 2018) Changed paths: M engine/src/main/java/org/hibernate/validator/internal/engine/ValidatorImpl.java M engine/src/main/java/org/hibernate/validator/internal/engine/constraintvalidation/ComposingConstraintTree.java M engine/src/main/java/org/hibernate/validator/internal/engine/constraintvalidation/ConstraintTree.java M engine/src/main/java/org/hibernate/validator/internal/engine/constraintvalidation/SimpleConstraintTree.java M engine/src/main/java/org/hibernate/validator/internal/engine/validationcontext/AbstractValidationContext.java A engine/src/main/java/org/hibernate/validator/internal/engine/validationcontext/BaseBeanValidationContext.java M engine/src/main/java/org/hibernate/validator/internal/engine/validationcontext/ExecutableValidationContext.java M engine/src/main/java/org/hibernate/validator/internal/engine/validationcontext/ValidationContext.java M engine/src/main/java/org/hibernate/validator/internal/engine/validationcontext/ValidationContextBuilder.java Log Message: ----------- HV-1526 Split ValidationContext into two parts As the methods used in ConstraintTree could be potentially reused for other kinds of validation contexts e.g. property holder contexts that won't have bean metadata related methods, we can separate these concerns and split the interface into two. Compare: https://github.com/hibernate/hibernate-validator/compare/1dd038f48830...2... **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.