Re: [infinispan-dev] Amanuensis: the infinispan clustered indexwriter

Hi Tristan, thank you very much, this is looking great; indeed I see some familiar patterns, but also some interesting new approaches. Some doubts: 1) I see you don't depend on the mux implementation org.jboss.ha.core.channelfactory.MuxChannel but in the one provided in jgroups. I was recommended to use org.jboss.ha.core.channelfactory.MuxChannel, but don't remember the reason, if any it might be outdated. Did you find out there's no need for this additional dependency? 2) Could you clarify the licensing, I'd like to reuse some of this code if possible. I hope it will be Hibernate Search compatible, also because I see you copied some code.. could you then restore the original @authors where due? (I might be wrong and didn't check in depth, just the methods in ExecutorContext look very similar to Search's Workspace. Actually it seems you was inspired by an older copy, while some bugs where now fixed *1, so you might as well want to depend on that code instead, to get more fixes in future). 3) I can't compile it: Non-resolvable parent POM: Could not find artifact net.dataforte:dataforte-parent:pom:6 4) I'd recommend you to make the IndexOperation implementations immutable, it seems you're suffering a bit from index visibility. 5) No tests ? :P *1 exceptions in backend threads wheren't guaranteed to be handled and could kill your helpers - seems you're affected too. Cheers, Sanne 2011/1/12 Tristan Tarrant<tristan.tarrant(a)gmail.com>: > Dear all, > > just wanted to let you know that I have published Amanuensis on GitHub: > https://github.com/tristantarrant/amanuensis > > As the subject says, Amanuensis is a clustered IndexWriter for Infinispan's > Lucene Directory which overcomes the usual limitation of having only one > writer open at any one time on a Directory by using JGroups muxed channels > to stream changes from the slaves to the coordinator. > > I have to thank Sanne for help in learning about JGroups muxed channels and > also for pointing me at Hibernate Search's backend. My approach is nearly > identical, but I wanted something that was a bit closer to a Lucene > IndexWriter. > > Tell me what you think. > > Tristan > > _______________________________________________ > infinispan-dev mailing list > infinispan-dev(a)lists.jboss.org > https://lists.jboss.org/mailman/listinfo/infinispan-dev > _______________________________________________ infinispan-dev mailing list infinispan-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/infinispan-dev