Re: [infinispan-dev] Syncing to central
On Oct 24, 2011, at 12:05 PM, Sanne Grinovero wrote:
>>
>> The only weirdness I see is the org.rhq.helpers stuff. It's mostly
>> flagged optional or provided but it's a lie, it's required and depends
>> on lots of pointless stuff (like Hibernate 3 ??).
>
> There's two aspects to this:
>
> 1. We hijack javadoc processing to generate the RHQ xml file, which means that the
annotations need be available beyond the compile phase. This forces the annotation, and
rhq annotations, dependencies to be required. At the time of writing this, I wasn't
aware of annotation processors and that would have been the right way to solve this issue.
That should avoid dependencies going beyond compilation time, but would bring other
issues, i.e. annotation processor discovery (we'd need one for JBoss Logging and one
for this)…etc.
What has annotation processor discovery to do with RHQ?
All JMX methods are annotated with JMX annotations and RHQ annotations too. The latter are
used to generate the RHQ configuration file which is what tells RHQ what a jmx value is
used for, whether a numeric measuremen, a text field…etc.
> 2. RHQ dependencies themselves which are rather dubious.
yes, can we move this to a separate module? Why does Infinispan core need them?
See above explanation
CacheMgmtInterceptor:
@ManagedAttribute(description = "Number of entries currently in the cache")
@Metric(displayName = "Number of current cache entries", displayType =
DisplayType.SUMMARY)
public int getNumberOfEntries() {
return dataContainer.size();
}
@Metric is an RHQ annotation
_______________________________________________
infinispan-dev mailing list
infinispan-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/infinispan-dev
--
Galder Zamarreño
Sr. Software Engineer
Infinispan, JBoss Cache