On Jan 18, 2011, at 6:51 PM, Manik Surtani wrote:
Great feedback, Pete. +1 to all suggestions here, I've added a
few more notes inline with some of the points below. Feel like making the changes
you've suggested?
Galder, could you pls help with the Scala-related points?
Sure :) - see below for comments:
Cheers
Manik
On 18 Jan 2011, at 16:17, Pete Muir wrote:
> 10)
http://community.jboss.org/wiki/InfinispanInteractiveTutorialwithScala
>
> Could do with some comments explaining what each line is doing, some of the code
isn't self describing
>
> e.g.
>
> what does me entering val defaultCache = manager.getCache[String, String]() actually
achieve?
>
Galder, care to look into this one?
In fairness, to do that tutorial you should know a bit of Scala. In fact, to be perfectly
honest, I don't see much point of doing that tutorial if you cannot understand that
line! FYI, that's the same as the following java code:
Cache<String, String> defaultCache = manager.getCache();
I'll still add the comments though.
> 11)
http://community.jboss.org/wiki/InfinispanInteractiveTutorialwithScala
>
> It might be neat to split up input and output e.g. into different snippets - make it
easier to read
+1, with separate comments for each.
>
> 12)
http://community.jboss.org/wiki/InfinispanInteractiveTutorialwithScala
>
> For "Cache with Transaction Management" I was not seeing TX semantics being
obeyed, I saw the size increment as a added key-value pairs
Galder, this as well?
I'll check it out.
Cheers
Manik
--
Manik Surtani
manik(a)jboss.org
twitter.com/maniksurtani
Lead, Infinispan
http://www.infinispan.org
_______________________________________________
infinispan-dev mailing list
infinispan-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/infinispan-dev
--
Galder Zamarreño
Sr. Software Engineer
Infinispan, JBoss Cache