Re: [infinispan-dev] build broken
Not sure what machine you have but tbh, if I run the tests on my MBP, I can hardly do
other stuff, particularly development. I'd need a separate machine for that.
It's true that I should at least run the build to make sure the rest compiles but this
stuff should be caught by CI too? Granted that it would not have picked it cos of
https://issues.jboss.org/browse/ISPN-1381
Guys, we have CI for something. If something's wrong, it needs to be flagged, not wait
for 1 month (that includes me of course).
On Sep 12, 2011, at 4:09 PM, Manik Surtani wrote:
+1, good point. My bad, I think I was the one who accepted this
patch ….
On 9 Sep 2011, at 14:32, Sanne Grinovero wrote:
> Hi all,
> I know nobody cares about Query.. but some of the commits of
> today/yesterday broke it.
>
> I think both the pull-requestor and the reviewer should run a full
> build before allowing any change to be pushed upstream; with a script
> like this one:
> https://gist.github.com/789588
>
> it won't even prevent you to work on a different branch while tests
> test are run, so while it takes some CPU, you can still look at other
> stuff.
>
> Sanne
> _______________________________________________
> infinispan-dev mailing list
> infinispan-dev(a)lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/infinispan-dev
--
Manik Surtani
manik(a)jboss.org
twitter.com/maniksurtani
Lead, Infinispan
http://www.infinispan.org
_______________________________________________
infinispan-dev mailing list
infinispan-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/infinispan-dev
--
Galder Zamarreño
Sr. Software Engineer
Infinispan, JBoss Cache