Re: [infinispan-dev] RadargunTPCC benchmark review

Hi Mircea, thank you. Before issuing a pull request I want to make two modifications in the code: 1) implementing Externalizable interface for the TPC-C domain objects (as suggested by Galder Zamarreño); 2) changing load/store methods of TPC-C domain classes in order to treat domain objects as immutable objects. In fact, I have noticed that we can have objects sharing among threads belonging to the same node. Unfortunately I cannot make these modifications before the end of the next week because I'm trying to finalize works for a close deadline. Nevertheless I think that you can already use the code for benchmarking because the aforementioned "objects sharing" problem affects only the application semantics (and it doesn't affect cache performances) while Externalizable interfaces only make a test run faster. Let me know if this is ok for you. Cheers, Sebastiano Il 10/11/11 01:54, Mircea Markus ha scritto: > > > On 7 Nov 2011, at 16:22, Sebastiano Peluso wrote: > >> Il 07/11/11 15:05, Galder Zamarreño ha scritto: >>> >>> Thx Sebastiano. Would you mind issuing a pull request for your tpcc branch so that we can integrate it into Radargun? >> Yes of course. >>> > Hi Sebastiano, > if you need any help on this please let me know - my transactional improvements are almost finished/currently being reviewed, so I'm really keen to play with TPCC :-) >