Re: [infinispan-dev] Configuration visitor - Re: [JBoss JIRA] Commented: (ISPN-145) No transport and singleton store enabled should not be allowed

Hi Galder, Although I agree with you that reflection is little bit harder to understand the advantage of this visitor pattern is many fold. Say, down the road, we have multiple of these visitors written, some of them, possibly, even written by third party clients. Our entire configuration tree class hierarchy is statically or compile time tied tied to these visitors and we don't want to go down this path. I'll give it another look, we can go static but we need to be aware of the trade offs. If I understand you correctly the approach you are suggesting is not modular. It is generally considered not to be a good practice to tie logical processing to data structures themselves when the likelihood of extending logical processing is significant. The whole reason behind adopting visitor pattern on our configuration tree is the ability to add new operations to existing configuration object structures without modifying these structures. By using visitor pattern and adhering to the so called open/closed principle we allow room to do any kind of operations on our configuration object structures. It might seems that validation is the last thing we are going to do - but it is not, for sure. And tomorrow when there is yet another operation we need to complete on configuration tree the implementation will be a breeze. Cheers, Vladimir On 09-09-10 4:11 AM, Galder Zamarreno wrote: