Re: [infinispan-dev] Cache Loaders configuration dilemma

I agree with Galder. These will change in 6.0 anyway. On 14 Aug 2012, at 10:02, Galder Zamarreño <galder(a)redhat.com&gt; wrote: Hmmm, I'm not sure this is the right time to actually change the API, that'd be IMO when we redesign the cache loaders. Instead, I'd add a new interface with the new method and extend the current CacheLoader. It's a bit messy but should only be temporary until we have an agreement on the cache loader interface. IOW, I'd rather change once, in a major release, than change now and then change again in 6.0. Thoughts? On Aug 9, 2012, at 8:54 AM, Tristan Tarrant wrote: Yes, I'm introducing interfaces: the whole org.infinispan.configuration is quite lacking in that respect ;) Tristan On 08/08/2012 07:27 PM, Sanne Grinovero wrote: I'd suggest to keep an interface in the API signature, much better than an abstract class. +1 to change the API, more changes are expected soon anyway. Sanne On 8 August 2012 18:51, Tristan Tarrant <ttarrant(a)redhat.com&gt; wrote: Hi guys, as part of ISPN-1978, I'm migrating the Cache Loaders to the new configuration builder APIs. I want to change the init() method of the CacheLoaders which has the following signature public void init(CacheLoaderConfig config, Cache<?, ?> cache, StreamingMarshaller m) throws CacheLoaderException to the following: public void init(AbstractLoaderConfiguration config, Cache<?, ?> cache, StreamingMarshaller m) throws CacheLoaderException This will break all existing cache loaders/stores: I'll fix all the ones bundled in the distribution, but do we need to provide compatibility with third party loaders ? Tristan _______________________________________________ infinispan-dev mailing list infinispan-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/infinispan-dev _______________________________________________ infinispan-dev mailing list infinispan-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/infinispan-dev _______________________________________________ infinispan-dev mailing list infinispan-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/infinispan-dev -- Galder Zamarreño Sr. Software Engineer Infinispan, JBoss Cache _______________________________________________ infinispan-dev mailing list infinispan-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/infinispan-dev -- Manik Surtani manik(a)jboss.org twitter.com/maniksurtani Founder and Project Lead, Infinispan http://www.infinispan.org Platform Architect, JBoss Data Grid http://red.ht/data-grid _______________________________________________ infinispan-dev mailing list infinispan-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/infinispan-dev