Re: [infinispan-dev] Feedback and requests on clustered and remote listeners
On Sep 23, 2014, at 15:18, Emmanuel Bernard <emmanuel(a)hibernate.org> wrote:
> I am not sold on this as it seems pretty trivial to decipher
which
> operation is which and the information would be present on the
> javadocs as well.
I very strongly disagree. Cf the other thread with Radim 's comment on topology
error.
And think about *future* evolutions. The enum would make that much safer. In the bin enum
world you would have to introduce a new YetAnotherKeyValueFilter interface :)
Nicer than an enum would be an explicit method, e.g.
handlePut/handleDelete/handleCreate/handleUpdate, as these would also receive the
appropriate param list. Of course this means moving away from the KeyValueFilter to an
UpdateFilter (good name, Radim) used only for cluster listeners.
Will, what would be the overall impact on the API as right now the KeyValueFilter is
reused between several components, like the cluster iterator.
Cheers,
--
Mircea Markus
Infinispan lead (www.infinispan.org)