Re: [infinispan-dev] Raison de etre of TestObjectStreamMarshaller
Galder Zamarreno wrote:
Hi guys,
I've spotted that JdbcMixedCacheStoreTest and others currently use
TestObjectStreamMarshaller rather than VersionAwareMarshaller. Why is
this? Easies of debugging with XStream based marshaller?
I needed a marshaller when
testing the code and used same marshaller as
BaseCacheStoreTest; There was no particular reason for choosing one or
other.
To increase test coverage, I'd suggest using VAM rather
TestObjectStreamMarshaller in tests as well.
In the case of JdbcMixedCacheStoreTest, the extended test coverage
comes from the fact that fromStream and toStream use start/multiple
writes/finish marshalling pattern, which is different to RPC calls,
where it's basically, start/one write/finish.
I can see the point of dummy cache stores cos you avoid needing a
database, files...etc, but I'm not sure whether about a dummy/test
marshaller. The more the production marshaller is used, the bigger
test coverage we have.
Makes sense to me.
Regards,