Hi guys As you know, I'm working on ISPN-3051, allowing each node to take a higher or lower proportion of the entries in the cache. I've implemented this by adding a float "loadFactor" setting in each node's configuration, with 1 being the default and any positive value being accepted (including 0). There are two questions I wanted to ask you about the configuration: 1. What do you think about the "loadFactor" name? I started having doubts about it, since it has a very different meaning in HashMap. I have come up with a couple alternatives, but I don't love any of them: "proportionalLoad" and "proportionalCapacity". 2. Where should we put this setting? I have added it as CacheConfiguration.clustering().hash().loadFactor(), but I can't think of a reason for having different values for each cache, so we might as well put it in the global configuration. Cheers Dan _______________________________________________ infinispan-dev mailing list infinispan-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/infinispan-dev

On 09/09/2013 11:18 AM, Dan Berindei wrote: > Hi guys > > As you know, I'm working on ISPN-3051, allowing each node to take a > higher or lower proportion of the entries in the cache. I've > implemented this by adding a float "loadFactor" setting in each node's > configuration, with 1 being the default and any positive value being > accepted (including 0). > > There are two questions I wanted to ask you about the configuration: > > 1. What do you think about the "loadFactor" name? I started having > doubts about it, since it has a very different meaning in HashMap. I > have come up with a couple alternatives, but I don't love any of them: > "proportionalLoad" and "proportionalCapacity". Since this is "per-node", you want to use the "node" word in there, so "nodeCapacity" would be good. Can this value change at runtime ?

> 2. Where should we put this setting? I have added it as > CacheConfiguration.clustering().hash().loadFactor(), but I can't think > of a reason for having different values for each cache, so we might as > well put it in the global configuration. Yes, global sounds good. And don't forget server :)

On 09/09/2013 10:18 AM, Dan Berindei wrote: > Hi guys > > As you know, I'm working on ISPN-3051, allowing each node to take a > higher or lower proportion of the entries in the cache. I've implemented > this by adding a float "loadFactor" setting in each node's > configuration, with 1 being the default and any positive value being > accepted (including 0). > > There are two questions I wanted to ask you about the configuration: > > 1. What do you think about the "loadFactor" name? I started having > doubts about it, since it has a very different meaning in HashMap. I > have come up with a couple alternatives, but I don't love any of them: > "proportionalLoad" and "proportionalCapacity". I think capacity is a good name...

> > 2. Where should we put this setting? I have added it as > CacheConfiguration.clustering().hash().loadFactor(), but I can't think > of a reason for having different values for each cache, so we might as > well put it in the global configuration. My vote is to having it per cache, so we can support use cases like this: having 2 caches in the same node but one is more prioritized/requested than the other and you may want to keep more data for the prioritized cache.

> > Cheers > Dan > > > > _______________________________________________ > infinispan-dev mailing list > infinispan-dev(a)lists.jboss.org > https://lists.jboss.org/mailman/listinfo/infinispan-dev > _______________________________________________ infinispan-dev mailing list infinispan-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/infinispan-dev