Hi Pedro and thanks for reporting this. Do you have versioning enabled? Otherwise the writeSkewCheck won't be performed at commit time. If you do have versioning enabled, may I suggest to take this on the user forums[1] - this way it would be easier for other users that have the same problem to find it. [1] https://community.jboss.org/community/infinispan?view=discussions&sta... <https://community.jboss.org/community/infinispan?view=discussions&sta... On 24 Jan 2012, at 18:42, Pedro Ruivo wrote: > Hi, > > I think I have spotted a problem with the write skew check > implementation based on versioning. > > I've made this test to confirm: > > I have a global counter that is incremented concurrently by two > different nodes, running ISPN with Repeatable Read with write skew > enabled. I expected that each successfully transaction will commit a > different value. > > In detail, each node do the following: > > beginTx > Integer count = cache.get("counter"); > count = count + 1; > cache.put("counter", count) > commitTx > > To avoid errors, I've run this test on two ISPN versions: 5.1.0.CR4 and > 5.0.1.Final. In 5.0.1.Final, it works as expected. However, on 5.1.0.CR4 > I have a lot of repeated values. After a first check at the code, I've > the impression that the problem may be due to that the version numbers > of the keys for which the write skew check should be run is not sent > with the prepare command. > > Cheers, > Pedro Ruivo > _______________________________________________ > infinispan-dev mailing list > infinispan-dev(a)lists.jboss.org <mailto:infinispan-dev@lists.jboss.org> > https://lists.jboss.org/mailman/listinfo/infinispan-dev _______________________________________________ infinispan-dev mailing list infinispan-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/infinispan-dev

Looks like a bug, mind creating a JIRA for it? On 24 Jan 2012, at 21:45, Pedro Ruivo wrote: > Hi, > > yes I have the versioning enabled. Like you said, I've posted in the forum too [1]. > > btw, the ISPN config is here [2] > > [1] -- https://community.jboss.org/thread/177846 > [2] -- http://pastebin.com/UCxGXw3K > > Cheers, > Pedro > > On 24-01-2012 19:15, Mircea Markus wrote: >> >> Hi Pedro and thanks for reporting this. >> Do you have versioning enabled? Otherwise the writeSkewCheck won't be performed at commit time. >> If you do have versioning enabled, may I suggest to take this on the user forums[1] - this way it would be easier for other users that have the same problem to find it. >> >> [1] https://community.jboss.org/community/infinispan?view=discussions&sta... >> >> On 24 Jan 2012, at 18:42, Pedro Ruivo wrote: >>> Hi, >>> >>> I think I have spotted a problem with the write skew check >>> implementation based on versioning. >>> >>> I've made this test to confirm: >>> >>> I have a global counter that is incremented concurrently by two >>> different nodes, running ISPN with Repeatable Read with write skew >>> enabled. I expected that each successfully transaction will commit a >>> different value. >>> >>> In detail, each node do the following: >>> >>> beginTx >>> Integer count = cache.get("counter"); >>> count = count + 1; >>> cache.put("counter", count) >>> commitTx >>> >>> To avoid errors, I've run this test on two ISPN versions: 5.1.0.CR4 and >>> 5.0.1.Final. In 5.0.1.Final, it works as expected. However, on 5.1.0.CR4 >>> I have a lot of repeated values. After a first check at the code, I've >>> the impression that the problem may be due to that the version numbers >>> of the keys for which the write skew check should be run is not sent >>> with the prepare command. >>> >>> Cheers, >>> Pedro Ruivo >>> _______________________________________________ >>> infinispan-dev mailing list >>> infinispan-dev(a)lists.jboss.org >>> https://lists.jboss.org/mailman/listinfo/infinispan-dev >> >> >> >> _______________________________________________ >> infinispan-dev mailing list >> infinispan-dev(a)lists.jboss.org >> https://lists.jboss.org/mailman/listinfo/infinispan-dev > _______________________________________________ > infinispan-dev mailing list > infinispan-dev(a)lists.jboss.org > https://lists.jboss.org/mailman/listinfo/infinispan-dev _______________________________________________ infinispan-dev mailing list infinispan-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/infinispan-dev