Guys, Our current Log impl allows for string formatting, using params like log.info("This is a {0} with some {1}", "string", "words") originally inspired by the Seam logger. IMO we should switch to using a more standard form of parameterisation, as used by the JDKs String.format() - as well as in many other languages including C and Python: log.info("This is a %s with some %s", "string", "words") This will be more consistent with String.format() used elsewhere (e.g., generating exception messages). A quick search and replace in the codebase will take care of this. Opinions?

In some languages, param 2 needs to be put before param 1. How do you solve that wo positional params? On 25 janv. 2011, at 15:52, Pete Muir wrote: > > On 25 Jan 2011, at 20:29, Manik Surtani wrote: > >> Guys, >> >> Our current Log impl allows for string formatting, using params like >> >> log.info("This is a {0} with some {1}", "string", "words") >> >> originally inspired by the Seam logger. IMO we should switch to using a more standard form of parameterisation, as used by the JDKs String.format() - as well as in many other languages including C and Python: >> >> log.info("This is a %s with some %s", "string", "words") >> >> This will be more consistent with String.format() used elsewhere (e.g., generating exception messages). A quick search and replace in the codebase will take care of this. Opinions? > > I like this style more FWIW, I think it's easier to alter messages. > _______________________________________________ > infinispan-dev mailing list > infinispan-dev(a)lists.jboss.org > https://lists.jboss.org/mailman/listinfo/infinispan-dev _______________________________________________ infinispan-dev mailing list infinispan-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/infinispan-dev

So I assume we're all happy with this change? I've already done the work in a topic branch and ready to push... On 25 Jan 2011, at 22:11, David M. Lloyd wrote: > Use the %1$s form. > > On 01/25/2011 04:08 PM, Emmanuel Bernard wrote: >> In some languages, param 2 needs to be put before param 1. How do you solve that wo positional params? >> >> On 25 janv. 2011, at 15:52, Pete Muir wrote: >> >>> >>> On 25 Jan 2011, at 20:29, Manik Surtani wrote: >>> >>>> Guys, >>>> >>>> Our current Log impl allows for string formatting, using params like >>>> >>>> log.info("This is a {0} with some {1}", "string", "words") >>>> >>>> originally inspired by the Seam logger. IMO we should switch to using a more standard form of parameterisation, as used by the JDKs String.format() - as well as in many other languages including C and Python: >>>> >>>> log.info("This is a %s with some %s", "string", "words") >>>> >>>> This will be more consistent with String.format() used elsewhere (e.g., generating exception messages). A quick search and replace in the codebase will take care of this. Opinions? >>> >>> I like this style more FWIW, I think it's easier to alter messages. >>> _______________________________________________ >>> infinispan-dev mailing list >>> infinispan-dev(a)lists.jboss.org >>> https://lists.jboss.org/mailman/listinfo/infinispan-dev >> >> >> _______________________________________________ >> infinispan-dev mailing list >> infinispan-dev(a)lists.jboss.org >> https://lists.jboss.org/mailman/listinfo/infinispan-dev > > > -- > - DML > _______________________________________________ > infinispan-dev mailing list > infinispan-dev(a)lists.jboss.org > https://lists.jboss.org/mailman/listinfo/infinispan-dev -- Manik Surtani manik(a)jboss.org twitter.com/maniksurtani Lead, Infinispan http://www.infinispan.org _______________________________________________ infinispan-dev mailing list infinispan-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/infinispan-dev

On 26 Jan 2011, at 11:50, Mircea Markus wrote: > I like the existing one more, as it makes it easier for me too which params goes where. It's non-standard though. I see people using String.format() to create exception messages - which is fine - but it means we have inconsistencies in the ways strings are created for logs and for exceptions.

Plus the C style of using %1$s isn't particularly hard, is it? :) The fact that it starts with '1' as opposed to '0' is a bit odd though.