12:39 a.m.
It took me quite some time to figure out about a resource leak in the
Query testsuite.
The Search Engine properly warns about unclosed resources, but the
automated test "cleanup" phase of the Infinispan testing framework
swallows and ignores any exception happening during a
CacheManager#close.
I realize there is a need for a "safe" cleanup but ignoring exceptions
is very tricky, could we change that to have the test fail at least?
Cheers,
Sanne
2:19 p.m.
Some of these warnings - which where ignored so far - are pointing out
to badly written tests which are leaking resources.
In particular if the Query engine isn't closed appropriately, file
handles to index segments are not cleared up, and these are at the
core of some of the intermittent failures we've recently seen cropping
up in the Query module.
I can't blame the test contributors having forgot some #close()
methods; for sure the intention of
TestingUtil.killCacheManagers(cacheManagers) - to make sure we
properly cleanup - is not fulfilled this way: to the contrary it
caused leaks to stay unnoticed.
Tests should really fail eagerly rather than silently continue.
On 14 August 2013 23:39, Sanne Grinovero <sanne(a)infinispan.org> wrote:
It took me quite some time to figure out about a resource leak in
the
Query testsuite.
The Search Engine properly warns about unclosed resources, but the
automated test "cleanup" phase of the Infinispan testing framework
swallows and ignores any exception happening during a
CacheManager#close.
I realize there is a need for a "safe" cleanup but ignoring exceptions
is very tricky, could we change that to have the test fail at least?
Cheers,
Sanne
3:54 p.m.
On Aug 15, 2013, at 12:39 AM, Sanne Grinovero <sanne(a)infinispan.org> wrote:
It took me quite some time to figure out about a resource leak in
the
Query testsuite.
The Search Engine properly warns about unclosed resources, but the
automated test "cleanup" phase of the Infinispan testing framework
swallows and ignores any exception happening during a
CacheManager#close.
I realize there is a need for a "safe" cleanup but ignoring exceptions
is very tricky, could we change that to have the test fail at least?
That might be tricky because often cache manager close happens in the @AfterClass phase at
which stage you cannot really fail a particular test. Not even if that was done in
@AfterMethod you'd get a test failure AFAIK.
The only time that it can lead to a test failure is when the cache manager is closed
within the test itself.
Maybe what we need is some tests that verify that when cache managers are closed,
resources are released. These could be subclassed/extended by other modules that add extra
resources to their work, and which should be released when cache manager closes.
Cheers,
Cheers,
Sanne
_______________________________________________
infinispan-dev mailing list
infinispan-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/infinispan-dev
--
Galder Zamarreño
galder(a)redhat.com
twitter.com/galderz
Project Lead, Escalante
http://escalante.io
Engineer, Infinispan
http://infinispan.org
4158
days inactive
4159
days old
infinispan-dev@lists.jboss.org
2 comments
2 participants
participants (2)
-
Galder Zamarreño -
Sanne Grinovero