Hey guys. Aleš Justin and I will be using infinispan's grid file system for Capedwarf.

I have fixed a few issues in GFS. Before I issue a pull request, I need to know if you guys prefer a single commit for all of them or separate commits. What about jira issues - separate or one single jira issue?

Here's a list of my commits: - Implement appending to files (up to now, the append parameter was ignored) - Implement GridFile.getParent() and getParentFile() - Implement GridFile.lastModified() - Prevent writing to and reading from directories - Fix bugs related to non-default chunk size - Leak when overwriting existing file with shorter content length (excess file chunks are never removed from cache) - Leak when calling GridFile.delete() (removes only file metadata, but not the actual file contents) - GridFile.createNewFile() does not honor the contract of File.createNewFile() - GridFile.list() does not honor contract of File.list() and also has a few bugs (it doesn't handle file separators correctly) - GridFilesystem.getFile(File, String) creates File with illegal path (on windows, the created file begins with "C:\...") - mkdir() fails on "/dir", but works on "dir" - the root dir is not handled properly - add javadoc to GridFilesystem There are also a few other things. Before I fix them, I would like you to confirm my thinking is correct: - GFS.getFile("/hello.txt") should point to the same file as GFS.getFile("hello.txt"), but it currently does not. GFS treats these two as two distinct files.

- GridFilesystem.remove() shouldn't be public, because the proper way to remove files is through GridFile.delete(). By calling GridFilesystem.remove(), only the file's contents are removed, but the metadata is not).

- GridFile.setLength() should throw an exception instead of printing to System.err

ML _______________________________________________ infinispan-dev mailing list infinispan-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/infinispan-dev

On 3 Jan 2012, at 17:31, Galder Zamarreño wrote: > > On Jan 3, 2012, at 2:55 PM, Marko Lukša wrote: > >> Hey guys. >> >> Aleš Justin and I will be using infinispan's grid file system for Capedwarf. > > What's Capedwarf? :) > >> >> I have fixed a few issues in GFS. Before I issue a pull request, I need >> to know if you guys prefer a single commit for all of them or separate >> commits. I'd rather have commits grouped by functionality than by JIRA; i.e. even for the same JIRA you could have multiple individual commits if the pice of functionality you add is large. This seem to be your case :-)

Yes, since in GFS there's no concept of "working dir" as there is in regular filesystems, the working/base dir should always be "/". So, do you think a basePath constructor parameter would come in handy to anyone? If so, I can implement it (instead of just making sure paths with a leading / are equivalent to paths without it).

One more question: since GFS is still experimental, is there any reason against me renaming fields & variables to the project's code style (currently, some vars are named like "default_chunk_size"); also there's probably no reason against me making fields in GridOutputStream private?

Hey guys. Aleš Justin and I will be using infinispan's grid file system for Capedwarf. I have fixed a few issues in GFS. Before I issue a pull request, I need to know if you guys prefer a single commit for all of them or separate commits. What about jira issues - separate or one single jira issue? Here's a list of my commits: - Implement appending to files (up to now, the append parameter was ignored) - Implement GridFile.getParent() and getParentFile() - Implement GridFile.lastModified() - Prevent writing to and reading from directories - Fix bugs related to non-default chunk size - Leak when overwriting existing file with shorter content length (excess file chunks are never removed from cache) - Leak when calling GridFile.delete() (removes only file metadata, but not the actual file contents) - GridFile.createNewFile() does not honor the contract of File.createNewFile() - GridFile.list() does not honor contract of File.list() and also has a few bugs (it doesn't handle file separators correctly) - GridFilesystem.getFile(File, String) creates File with illegal path (on windows, the created file begins with "C:\...") - mkdir() fails on "/dir", but works on "dir" - the root dir is not handled properly - add javadoc to GridFilesystem There are also a few other things. Before I fix them, I would like you to confirm my thinking is correct: - GFS.getFile("/hello.txt") should point to the same file as GFS.getFile("hello.txt"), but it currently does not. GFS treats these two as two distinct files. - GridFilesystem.remove() shouldn't be public, because the proper way to remove files is through GridFile.delete(). By calling GridFilesystem.remove(), only the file's contents are removed, but the metadata is not). - GridFile.setLength() should throw an exception instead of printing to System.err