10:34 a.m.
Hi all,
during ER12 testing I've found out that there are some tests which were not included
into ISPN testsuite run.
And this issue appeared both on our JDG related jobs as well as I've checked the
Cloudbees for the community version runs and the same situation is there.
If the testsute run Maven command includes the -Dtest=org/infinispan/**... parameter (for
corresponding module), then these tests are included in the run.
The thing was that there were some failing tests, which we didn't see during our
previous test runs.
I've found out that the issue is that some of the test classes don't follow the
naming convention for Maven (Test*.java || *Test.java || *TestCase.java). Example tests
are: JdbcMixedCacheStoreTest2 & JdbcMixedCacheStoreVamTest2 classes.
So I've renamed and fixed the tests mentioned above, but I will need to find all tests
which are under the mentioned category and rename them so that all existing tests run
properly (they are not so much).
Best regards,
Anna.
3:42 a.m.
I did a search a long time ago for wrong test names:
https://issues.jboss.org/browse/ISPN-2534
It seems I missed JdbcMixedCacheStoreTest2 / JdbcMixedCacheStoreVamTest2 in
the patch for some reason, although I did mention them in the JIRA
description :(
Searching again, I see some more tests that need renaming:
./core/src/test/java/org/infinispan/profiling/ProfileTestSlave.java
./core/src/test/java/org/infinispan/xsite/TestBackupForNotSpecified.java
./query/src/test/java/org/infinispan/query/config/LegacyConfigurationAdaptorTests.java
./tools/src/test/java/org/infinispan/test/fwk/TestNameVerifier.java
Could you create a JIRA + PR for them as well?
BTW, it may be a good idea to remove the auto-correcting functionality of
TestNameVerifier, so we can enable it all the time, and instead add the
ability to check the file names against the Surefire pattern.
Cheers
Dan
On Tue, Mar 5, 2013 at 6:34 PM, Anna Manukyan <amanukya(a)redhat.com> wrote:
Hi all,
during ER12 testing I've found out that there are some tests which were
not included into ISPN testsuite run.
And this issue appeared both on our JDG related jobs as well as I've
checked the Cloudbees for the community version runs and the same situation
is there.
If the testsute run Maven command includes the -Dtest=org/infinispan/**...
parameter (for corresponding module), then these tests are included in the
run.
The thing was that there were some failing tests, which we didn't see
during our previous test runs.
I've found out that the issue is that some of the test classes don't
follow the naming convention for Maven (Test*.java || *Test.java ||
*TestCase.java). Example tests are: JdbcMixedCacheStoreTest2 &
JdbcMixedCacheStoreVamTest2 classes.
So I've renamed and fixed the tests mentioned above, but I will need to
find all tests which are under the mentioned category and rename them so
that all existing tests run properly (they are not so much).
Best regards,
Anna.
_______________________________________________
infinispan-dev mailing list
infinispan-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/infinispan-dev
4309
days inactive
4310
days old
infinispan-dev@lists.jboss.org
1 comments
2 participants
participants (2)
-
Anna Manukyan -
Dan Berindei