Re: [jboss-as7-dev] Pull Request Retesting Ability
Nice!
However, if things have been committed since you pushed and it's not a
big imposition, it's nice if you rebase to trigger a retest. It's a more
accurate test, and if there are any rebase issues you'll find out early.
On 5/5/12 1:23 AM, Jason T. Greene wrote:
Correct, both the person requesting the test and the PR submitter
have
to be on it for it to run.
Also, if the PR submitter isn't on the whitelist, it will ask one of the
admins to confirm.
Here is an example:
https://github.com/jbossas/jboss-as/pull/2020
On 5/5/12 1:20 AM, Jaikiran Pai wrote:
> And I guess, to avoid misuse, only users who are on the whitelist can
> trigger that retesting ability?
>
> -Jaikiran
> On Saturday 05 May 2012 11:47 AM, Jason T. Greene wrote:
>> FYI,
>>
>> If you submit a pull request and the test fails due to a possible
>> intermittent failure or some environmental problem (github was down or
>> something), instead of rebasing your patch to force a retest, you can
>> now just ask with a phrase that has "retest this please":
>>
>> Could you retest this please?
>> jboss-as-pull-request, you are awesome, now go retest this please!
>> etc
>>
>
> _______________________________________________
> jboss-as7-dev mailing list
> jboss-as7-dev(a)lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/jboss-as7-dev
--
Brian Stansberry
Principal Software Engineer
JBoss by Red Hat