[JBoss JIRA] Created: (JBID-227) SAML20TokenProvider cannot handle missing cancel_ids_file
by Jaap Reitsma (JIRA)
SAML20TokenProvider cannot handle missing cancel_ids_file
---------------------------------------------------------
Key: JBID-227
URL: https://jira.jboss.org/jira/browse/JBID-227
Project: JBoss Identity
Issue Type: Bug
Components: Identity-Federation
Affects Versions: IDFED-1.0.0.beta3
Environment: Windows XP SP3, JBoss 5.1.0.GA
Reporter: Jaap Reitsma
Assignee: Anil Saldhana
In org.jboss.identity.federation.core.wstrust.plugins.saml.SAML20TokenProvider:
The logic to handle a potential missing cancel_ids_file is not correct. Instead of:
if (file == null && logger.isDebugEnabled())
logger.debug("File to store canceled ids has not been specified: ids will not be persisted!");
else
....
the intention is probably:
if (file == null) {
if (logger.isDebugEnabled()) {
logger.debug("File to store canceled ids has not been specified: ids will not be persisted!");
}
}
else
....
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
15 years
[JBoss JIRA] Created: (JBID-228) FileBasedMetadataConfigurationStore.loadTrustedProviders keeps trustedFile locked for some indeterminate period
by Jaap Reitsma (JIRA)
FileBasedMetadataConfigurationStore.loadTrustedProviders keeps trustedFile locked for some indeterminate period
---------------------------------------------------------------------------------------------------------------
Key: JBID-228
URL: https://jira.jboss.org/jira/browse/JBID-228
Project: JBoss Identity
Issue Type: Bug
Components: Identity-Federation
Environment: Windows XP SP3, JBoss 5.1.0.GA
Reporter: Jaap Reitsma
Assignee: Anil Saldhana
In package org.jboss.identity.federation.core.saml.v2.metadata.store, class FileBasedMetadataConfigurationStore, the method.loadTrustedProviders() locks the trustedFile for a (short) indeterminate period, due to a missing ois.close() at the end of the method. In the unit test a failure will occur in
FileBasedMetadataConfigurationStoreUnitTestCase.testTrustedProviders() due to a sharing violation (Windows) error, because it cannot delete a file which is held open, at least not in Windows.
Solution: Close the stream explicitly instead of waiting for the garbage collector.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
15 years