[JBoss JIRA] Closed: (JBMESSAGING-158) Tidy up tests
by Tim Fox (JIRA)
[ http://jira.jboss.com/jira/browse/JBMESSAGING-158?page=all ]
Tim Fox closed JBMESSAGING-158.
-------------------------------
Resolution: Out of Date
> Tidy up tests
> -------------
>
> Key: JBMESSAGING-158
> URL: http://jira.jboss.com/jira/browse/JBMESSAGING-158
> Project: JBoss Messaging
> Issue Type: Task
> Components: Tests and Performance
> Affects Versions: 1.0.0 alpha PR3
> Reporter: Ovidiu Feodorov
> Priority: Minor
> Fix For: 2.0.0 Beta
>
> Original Estimate: 2 days, 4 hours
> Remaining Estimate: 2 days, 4 hours
>
> Tidy up tests:
> - Some test classes (and notably MessageConsumerTest) do a lot of Connection/Session/Consumer/Producer creation in setUp(). The original idea was to separate as much boilerplate code as possible, but this leads to hard to understand tests and may lead to unexpected behavior, since the test my get "hidden" intialization it doesn't want. Refactor them and re-write each test to be as independent as possible.
> - For tests that send messages in a loop, use a centrally-configured loop counter, which can be easily globally modified. Stress test are more likely to exhibit edge cases and race conditions as the number of message increases, and it should be easy to control that number globally.
> Example
> public class Global
> {
> public static final int GENERAL_COUNTER = 100;
> ....
> }
> public class MyTest extends MessagingTestCase
> {
> // override if it doesn't makes sense locally
> protected int NUM_MESSAGES = Global.GENERAL_COUNTER;
> ...
> }
>
> - Some tests are not in the right file.
> When refactor tests, take extra care not to break their semantics, though.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
18 years, 2 months
[JBoss JIRA] Closed: (JBMESSAGING-271) Modifying a server/**/*Advised.java or a client/**/**Delegate.java file breaks the incremental build, because of AOPC failure
by Tim Fox (JIRA)
[ http://jira.jboss.com/jira/browse/JBMESSAGING-271?page=all ]
Tim Fox closed JBMESSAGING-271.
-------------------------------
Resolution: Out of Date
> Modifying a server/**/*Advised.java or a client/**/**Delegate.java file breaks the incremental build, because of AOPC failure
> -----------------------------------------------------------------------------------------------------------------------------
>
> Key: JBMESSAGING-271
> URL: http://jira.jboss.com/jira/browse/JBMESSAGING-271
> Project: JBoss Messaging
> Issue Type: Bug
> Components: Build System
> Reporter: Ovidiu Feodorov
> Priority: Minor
> Fix For: Unscheduled
>
>
> Modifying a class that is going to be AOPCed (server/**/*Advised.java or a client/**/**Delegate.java) breaks the incremental build, as the AOPC fails to process it:
> compile-classes:
> [javac] Compiling 1 source file to C:\work\src\cvs\jboss-head\jms\output\classes
> [aopc] java.lang.RuntimeException: defrost(): org.jboss.jms.client.delegate.ClientBrowserDelegate$close_N4742752445160157748 was pruned.
> [aopc] at javassist.CtClassType.checkPruned(CtClassType.java:1093)
> [aopc] at javassist.CtClassType.defrost(CtClassType.java:272)
> [aopc] at org.jboss.aop.instrument.OptimizedInvocations.defrostClassIfExists(OptimizedInvocations.java:66)
> [aopc] at org.jboss.aop.instrument.OptimizedInvocations.makeInvocationClass(OptimizedInvocations.java:96)
> [aopc] at org.jboss.aop.instrument.OptimizedMethodInvocations.createOptimizedInvocationClass(OptimizedMethodInvocations.java:78)
> [aopc] at org.jboss.aop.instrument.OptimizedMethodExecutionTransformer.transformMethod(OptimizedMethodExecutionTransformer.java:59)
> [aopc] at org.jboss.aop.instrument.MethodExecutionTransformer.instrument(MethodExecutionTransformer.java:137)
> [aopc] at org.jboss.aop.instrument.Instrumentor.transform(Instrumentor.java:654)
> [aopc] at org.jboss.aop.AspectManager.translate(AspectManager.java:835)
> [aopc] at org.jboss.aop.AspectManager.transform(AspectManager.java:747)
> [aopc] at org.jboss.aop.standalone.Compiler.compileFile(Compiler.java:345)
> [aopc] at org.jboss.aop.standalone.Compiler.compile(Compiler.java:234)
> [aopc] at org.jboss.aop.standalone.Compiler.main(Compiler.java:90)
> [aopc] [error] failed to transform: org.jboss.jms.client.delegate.ClientBrowserDelegate.. Do verbose mode if you want full stack trace.
> [aopc] java.lang.RuntimeException: failed to transform: org.jboss.jms.client.delegate.ClientBrowserDelegate
> [aopc] at org.jboss.aop.instrument.Instrumentor.transform(Instrumentor.java:728)
> [aopc] at org.jboss.aop.AspectManager.translate(AspectManager.java:835)
> [aopc] at org.jboss.aop.AspectManager.transform(AspectManager.java:747)
> [aopc] at org.jboss.aop.standalone.Compiler.compileFile(Compiler.java:345)
> [aopc] at org.jboss.aop.standalone.Compiler.compile(Compiler.java:234)
> [aopc] at org.jboss.aop.standalone.Compiler.main(Compiler.java:90)
> [aopc] Caused by: java.lang.RuntimeException: defrost(): org.jboss.jms.client.delegate.ClientBrowserDelegate$close_N4742752445160157748 was pruned.
> [aopc] at javassist.CtClassType.checkPruned(CtClassType.java:1093)
> [aopc] at javassist.CtClassType.defrost(CtClassType.java:272)
> [aopc] at org.jboss.aop.instrument.OptimizedInvocations.defrostClassIfExists(OptimizedInvocations.java:66)
> [aopc] at org.jboss.aop.instrument.OptimizedInvocations.makeInvocationClass(OptimizedInvocations.java:96)
> [aopc] at org.jboss.aop.instrument.OptimizedMethodInvocations.createOptimizedInvocationClass(OptimizedMethodInvocations.java:78)
> [aopc] at org.jboss.aop.instrument.OptimizedMethodExecutionTransformer.transformMethod(OptimizedMethodExecutionTransformer.java:59)
> [aopc] at org.jboss.aop.instrument.MethodExecutionTransformer.instrument(MethodExecutionTransformer.java:137)
> [aopc] at org.jboss.aop.instrument.Instrumentor.transform(Instrumentor.java:654)
> [aopc] ... 5 more
> [aopc] Exception in thread "main"
> BUILD FAILED
> C:\work\src\cvs\jboss-head\jms\build.xml:339: Java returned: 1
> The workaround in this case is to do a ant clean and then rebuild everything from scratch, which is very inefficient.
> Must be fixed properly
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
18 years, 2 months
[JBoss JIRA] Created: (JBMESSAGING-835) Simple test suite configuration
by Tim Fox (JIRA)
Simple test suite configuration
-------------------------------
Key: JBMESSAGING-835
URL: http://jira.jboss.com/jira/browse/JBMESSAGING-835
Project: JBoss Messaging
Issue Type: Task
Affects Versions: 1.2.0.Beta2
Reporter: Tim Fox
Assigned To: Ovidiu Feodorov
Fix For: 1.2.0.GA
The test suite configuration needs to be simplified.
Currently, the same settings can be specified in enrvironment variables, properties file, build.xml, system properties, and in container.xml, with a complex precedence hierarchy determining which setting overrides another setting.
Also some settings are specified redundantly - e.g. test database is inferred from the jdbc connection url but is already specified in the container.xml.
We should have one place and one place only where configuration settings are specified.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
18 years, 2 months