[JBoss JIRA] (WFCORE-3180) ElytronSubsystemMessages uses double quotes to surround string literals
by Brian Stansberry (JIRA)
[ https://issues.jboss.org/browse/WFCORE-3180?page=com.atlassian.jira.plugi... ]
Brian Stansberry commented on WFCORE-3180:
------------------------------------------
Hi [~yersan] -- sure that would be fine.
> ElytronSubsystemMessages uses double quotes to surround string literals
> -----------------------------------------------------------------------
>
> Key: WFCORE-3180
> URL: https://issues.jboss.org/browse/WFCORE-3180
> Project: WildFly Core
> Issue Type: Bug
> Components: Security
> Reporter: Brian Stansberry
> Priority: Minor
>
> Lots of things like this:
> @Message(id = 910, value = "Password cannot be resolved for key-store \"%s\"")
> Use ' instead of \". If the string ends up in a DMR ModelNode, which it often does, the output looks bad when double quotes are present.
> For this ModelNode
> ModelNode node = new ModelNode("Password cannot be resolved for key-store \"%s\"");
>
> A call to node.toString() produces
> "Password cannot be resolved for key-store \"%s\""
> node.asString() is better, but that requires a special call vs the standard Object.toString
> Password cannot be resolved for key-store "%s"
> This is minor since we can try to ensure asString is used or perhaps even consider changing how toString works. But I think single quotes are a better practice.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years
[JBoss JIRA] (WFCORE-3180) ElytronSubsystemMessages uses double quotes to surround string literals
by Yeray Borges (JIRA)
[ https://issues.jboss.org/browse/WFCORE-3180?page=com.atlassian.jira.plugi... ]
Yeray Borges commented on WFCORE-3180:
--------------------------------------
[~brian.stansberry] just a random thought, would you be interested in a solution that works with LocalDescription.properties as well?
There are text descriptions using double quotes there. Those descriptions are "badly" scaped when they are displayed by read-resource-description for example, maybe it could be useful a general solution that takes those cases into account.
> ElytronSubsystemMessages uses double quotes to surround string literals
> -----------------------------------------------------------------------
>
> Key: WFCORE-3180
> URL: https://issues.jboss.org/browse/WFCORE-3180
> Project: WildFly Core
> Issue Type: Bug
> Components: Security
> Reporter: Brian Stansberry
> Priority: Minor
>
> Lots of things like this:
> @Message(id = 910, value = "Password cannot be resolved for key-store \"%s\"")
> Use ' instead of \". If the string ends up in a DMR ModelNode, which it often does, the output looks bad when double quotes are present.
> For this ModelNode
> ModelNode node = new ModelNode("Password cannot be resolved for key-store \"%s\"");
>
> A call to node.toString() produces
> "Password cannot be resolved for key-store \"%s\""
> node.asString() is better, but that requires a special call vs the standard Object.toString
> Password cannot be resolved for key-store "%s"
> This is minor since we can try to ensure asString is used or perhaps even consider changing how toString works. But I think single quotes are a better practice.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years
[JBoss JIRA] (WFLY-9370) Fix failing SingletonTunnelTestCase
by Radoslav Husar (JIRA)
[ https://issues.jboss.org/browse/WFLY-9370?page=com.atlassian.jira.plugin.... ]
Radoslav Husar updated WFLY-9370:
---------------------------------
Fix Version/s: (was: 11.0.0.Final)
> Fix failing SingletonTunnelTestCase
> -----------------------------------
>
> Key: WFLY-9370
> URL: https://issues.jboss.org/browse/WFLY-9370
> Project: WildFly
> Issue Type: Bug
> Components: Clustering, Test Suite
> Affects Versions: 11.0.0.CR1
> Reporter: Radoslav Husar
> Assignee: Radoslav Husar
>
> {{SingletonTunnelTestCase(ASYNC-tunnel)#testSingletonService}} is failing consistently now.
> The problem is that this test is not run as part of regular CI execution thus is destined to be broken. The test should be moved to the right location and renamed (i.e. drop tunnel since that has nothing to do with what it is testing).
> {noformat}
> [0m[31m04:44:19,235 ERROR [org.jboss.as.controller.management-operation] (management-handler-thread - 1) WFLYCTL0013: Operation ("add") failed - address: ([("deployment" => "singleton.war")]) - failure description: {
> "WFLYCTL0412: Required services that are not installed:" => ["jboss.clustering.group.default"],
> "WFLYCTL0180: Services with missing/unavailable dependencies" => [
> "jboss.test1.service.default is missing [jboss.clustering.group.default]",
> "jboss.test2.service.default is missing [jboss.clustering.group.default]"
> ],
> "WFLYCTL0288: One or more services were unable to start due to one or more indirect dependencies not being available." => {
> "Services that were unable to start:" => [
> "jboss.deployment.discovery.\"singleton.war\"",
> "jboss.deployment.unit.\"singleton.war\".CdiValidatorFactoryService",
> "jboss.deployment.unit.\"singleton.war\".WeldStartService",
> "jboss.deployment.unit.\"singleton.war\".component.TopologyChangeListenerBean.JndiBindingsService",
> "jboss.deployment.unit.\"singleton.war\".component.TopologyChangeListenerBean.START",
> "jboss.deployment.unit.\"singleton.war\".component.TopologyChangeListenerBean.VIEW.\"org.jboss.as.test.clustering.TopologyChangeListener\".REMOTE",
> "jboss.deployment.unit.\"singleton.war\".component.TopologyChangeListenerBean.WeldInstantiator",
> "jboss.deployment.unit.\"singleton.war\".component.TopologyChangeListenerBean.WeldInterceptorBindingsService",
> "jboss.deployment.unit.\"singleton.war\".component.\"com.sun.faces.config.ConfigureListener\".START",
> "jboss.deployment.unit.\"singleton.war\".component.\"com.sun.faces.config.ConfigureListener\".WeldInstantiator",
> "jboss.deployment.unit.\"singleton.war\".component.\"javax.faces.webapp.FacetTag\".START",
> "jboss.deployment.unit.\"singleton.war\".component.\"javax.faces.webapp.FacetTag\".WeldInstantiator",
> "jboss.deployment.unit.\"singleton.war\".component.\"javax.servlet.jsp.jstl.tlv.PermittedTaglibsTLV\".START",
> "jboss.deployment.unit.\"singleton.war\".component.\"javax.servlet.jsp.jstl.tlv.PermittedTaglibsTLV\".WeldInstantiator",
> "jboss.deployment.unit.\"singleton.war\".component.\"javax.servlet.jsp.jstl.tlv.ScriptFreeTLV\".START",
> "jboss.deployment.unit.\"singleton.war\".component.\"javax.servlet.jsp.jstl.tlv.ScriptFreeTLV\".WeldInstantiator",
> "jboss.deployment.unit.\"singleton.war\".component.\"org.jboss.as.test.clustering.TopologyChangeListenerServlet\".START",
> "jboss.deployment.unit.\"singleton.war\".component.\"org.jboss.as.test.clustering.TopologyChangeListenerServlet\".WeldInstantiator",
> "jboss.deployment.unit.\"singleton.war\".component.\"org.jboss.as.test.clustering.cluster.singleton.service.NodeServiceServlet\".START",
> "jboss.deployment.unit.\"singleton.war\".component.\"org.jboss.as.test.clustering.cluster.singleton.service.NodeServiceServlet\".WeldInstantiator",
> "jboss.deployment.unit.\"singleton.war\".component.\"org.jboss.as.test.clustering.cluster.singleton.service.ValueServiceServlet\".START",
> "jboss.deployment.unit.\"singleton.war\".component.\"org.jboss.as.test.clustering.cluster.singleton.service.ValueServiceServlet\".WeldInstantiator",
> "jboss.deployment.unit.\"singleton.war\".component.\"org.jboss.weld.servlet.WeldInitialListener\".START",
> "jboss.deployment.unit.\"singleton.war\".component.\"org.jboss.weld.servlet.WeldInitialListener\".WeldInstantiator",
> "jboss.deployment.unit.\"singleton.war\".component.\"org.jboss.weld.servlet.WeldTerminalListener\".START",
> "jboss.deployment.unit.\"singleton.war\".component.\"org.jboss.weld.servlet.WeldTerminalListener\".WeldInstantiator",
> "jboss.deployment.unit.\"singleton.war\".deploymentCompleteService",
> "jboss.deployment.unit.\"singleton.war\".ejb3.client-context.registration-service",
> "jboss.deployment.unit.\"singleton.war\".jndiDependencyService",
> "jboss.deployment.unit.\"singleton.war\".moduleDeploymentRuntimeInformation",
> "jboss.deployment.unit.\"singleton.war\".moduleDeploymentRuntimeInformationStart",
> "jboss.naming.context.java.app.singleton.singleton.TopologyChangeListenerBean",
> "jboss.naming.context.java.app.singleton.singleton.\"TopologyChangeListenerBean!org.jboss.as.test.clustering.TopologyChangeListener\"",
> "jboss.naming.context.java.global.singleton.TopologyChangeListenerBean",
> "jboss.naming.context.java.global.singleton.\"TopologyChangeListenerBean!org.jboss.as.test.clustering.TopologyChangeListener\"",
> "jboss.naming.context.java.module.singleton.singleton.TopologyChangeListenerBean",
> "jboss.naming.context.java.module.singleton.singleton.\"TopologyChangeListenerBean!org.jboss.as.test.clustering.TopologyChangeListener\"",
> "jboss.undertow.deployment.default-server.default-host./singleton",
> "jboss.undertow.deployment.default-server.default-host./singleton.UndertowDeploymentInfoService"
> ],
> "Services that may be the cause:" => [
> "jboss.clustering.group.default",
> "org.wildfly.network.socket-binding.undefined"
> ]
> }
> }
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years
[JBoss JIRA] (WFLY-9370) Fix failing SingletonTunnelTestCase
by Radoslav Husar (JIRA)
[ https://issues.jboss.org/browse/WFLY-9370?page=com.atlassian.jira.plugin.... ]
Radoslav Husar updated WFLY-9370:
---------------------------------
Component/s: Test Suite
> Fix failing SingletonTunnelTestCase
> -----------------------------------
>
> Key: WFLY-9370
> URL: https://issues.jboss.org/browse/WFLY-9370
> Project: WildFly
> Issue Type: Bug
> Components: Clustering, Test Suite
> Affects Versions: 11.0.0.CR1
> Reporter: Radoslav Husar
> Assignee: Radoslav Husar
> Fix For: 11.0.0.Final
>
>
> {{SingletonTunnelTestCase(ASYNC-tunnel)#testSingletonService}} is failing consistently now.
> The problem is that this test is not run as part of regular CI execution thus is destined to be broken. The test should be moved to the right location and renamed (i.e. drop tunnel since that has nothing to do with what it is testing).
> {noformat}
> [0m[31m04:44:19,235 ERROR [org.jboss.as.controller.management-operation] (management-handler-thread - 1) WFLYCTL0013: Operation ("add") failed - address: ([("deployment" => "singleton.war")]) - failure description: {
> "WFLYCTL0412: Required services that are not installed:" => ["jboss.clustering.group.default"],
> "WFLYCTL0180: Services with missing/unavailable dependencies" => [
> "jboss.test1.service.default is missing [jboss.clustering.group.default]",
> "jboss.test2.service.default is missing [jboss.clustering.group.default]"
> ],
> "WFLYCTL0288: One or more services were unable to start due to one or more indirect dependencies not being available." => {
> "Services that were unable to start:" => [
> "jboss.deployment.discovery.\"singleton.war\"",
> "jboss.deployment.unit.\"singleton.war\".CdiValidatorFactoryService",
> "jboss.deployment.unit.\"singleton.war\".WeldStartService",
> "jboss.deployment.unit.\"singleton.war\".component.TopologyChangeListenerBean.JndiBindingsService",
> "jboss.deployment.unit.\"singleton.war\".component.TopologyChangeListenerBean.START",
> "jboss.deployment.unit.\"singleton.war\".component.TopologyChangeListenerBean.VIEW.\"org.jboss.as.test.clustering.TopologyChangeListener\".REMOTE",
> "jboss.deployment.unit.\"singleton.war\".component.TopologyChangeListenerBean.WeldInstantiator",
> "jboss.deployment.unit.\"singleton.war\".component.TopologyChangeListenerBean.WeldInterceptorBindingsService",
> "jboss.deployment.unit.\"singleton.war\".component.\"com.sun.faces.config.ConfigureListener\".START",
> "jboss.deployment.unit.\"singleton.war\".component.\"com.sun.faces.config.ConfigureListener\".WeldInstantiator",
> "jboss.deployment.unit.\"singleton.war\".component.\"javax.faces.webapp.FacetTag\".START",
> "jboss.deployment.unit.\"singleton.war\".component.\"javax.faces.webapp.FacetTag\".WeldInstantiator",
> "jboss.deployment.unit.\"singleton.war\".component.\"javax.servlet.jsp.jstl.tlv.PermittedTaglibsTLV\".START",
> "jboss.deployment.unit.\"singleton.war\".component.\"javax.servlet.jsp.jstl.tlv.PermittedTaglibsTLV\".WeldInstantiator",
> "jboss.deployment.unit.\"singleton.war\".component.\"javax.servlet.jsp.jstl.tlv.ScriptFreeTLV\".START",
> "jboss.deployment.unit.\"singleton.war\".component.\"javax.servlet.jsp.jstl.tlv.ScriptFreeTLV\".WeldInstantiator",
> "jboss.deployment.unit.\"singleton.war\".component.\"org.jboss.as.test.clustering.TopologyChangeListenerServlet\".START",
> "jboss.deployment.unit.\"singleton.war\".component.\"org.jboss.as.test.clustering.TopologyChangeListenerServlet\".WeldInstantiator",
> "jboss.deployment.unit.\"singleton.war\".component.\"org.jboss.as.test.clustering.cluster.singleton.service.NodeServiceServlet\".START",
> "jboss.deployment.unit.\"singleton.war\".component.\"org.jboss.as.test.clustering.cluster.singleton.service.NodeServiceServlet\".WeldInstantiator",
> "jboss.deployment.unit.\"singleton.war\".component.\"org.jboss.as.test.clustering.cluster.singleton.service.ValueServiceServlet\".START",
> "jboss.deployment.unit.\"singleton.war\".component.\"org.jboss.as.test.clustering.cluster.singleton.service.ValueServiceServlet\".WeldInstantiator",
> "jboss.deployment.unit.\"singleton.war\".component.\"org.jboss.weld.servlet.WeldInitialListener\".START",
> "jboss.deployment.unit.\"singleton.war\".component.\"org.jboss.weld.servlet.WeldInitialListener\".WeldInstantiator",
> "jboss.deployment.unit.\"singleton.war\".component.\"org.jboss.weld.servlet.WeldTerminalListener\".START",
> "jboss.deployment.unit.\"singleton.war\".component.\"org.jboss.weld.servlet.WeldTerminalListener\".WeldInstantiator",
> "jboss.deployment.unit.\"singleton.war\".deploymentCompleteService",
> "jboss.deployment.unit.\"singleton.war\".ejb3.client-context.registration-service",
> "jboss.deployment.unit.\"singleton.war\".jndiDependencyService",
> "jboss.deployment.unit.\"singleton.war\".moduleDeploymentRuntimeInformation",
> "jboss.deployment.unit.\"singleton.war\".moduleDeploymentRuntimeInformationStart",
> "jboss.naming.context.java.app.singleton.singleton.TopologyChangeListenerBean",
> "jboss.naming.context.java.app.singleton.singleton.\"TopologyChangeListenerBean!org.jboss.as.test.clustering.TopologyChangeListener\"",
> "jboss.naming.context.java.global.singleton.TopologyChangeListenerBean",
> "jboss.naming.context.java.global.singleton.\"TopologyChangeListenerBean!org.jboss.as.test.clustering.TopologyChangeListener\"",
> "jboss.naming.context.java.module.singleton.singleton.TopologyChangeListenerBean",
> "jboss.naming.context.java.module.singleton.singleton.\"TopologyChangeListenerBean!org.jboss.as.test.clustering.TopologyChangeListener\"",
> "jboss.undertow.deployment.default-server.default-host./singleton",
> "jboss.undertow.deployment.default-server.default-host./singleton.UndertowDeploymentInfoService"
> ],
> "Services that may be the cause:" => [
> "jboss.clustering.group.default",
> "org.wildfly.network.socket-binding.undefined"
> ]
> }
> }
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years
[JBoss JIRA] (WFLY-9412) Fix failing SingletonTunnelTestCase
by Radoslav Husar (JIRA)
Radoslav Husar created WFLY-9412:
------------------------------------
Summary: Fix failing SingletonTunnelTestCase
Key: WFLY-9412
URL: https://issues.jboss.org/browse/WFLY-9412
Project: WildFly
Issue Type: Bug
Components: Clustering
Affects Versions: 11.0.0.CR1
Reporter: Radoslav Husar
Assignee: Radoslav Husar
Fix For: 11.0.0.Final
{{SingletonTunnelTestCase(ASYNC-tunnel)#testSingletonService}} is failing consistently now.
The problem is that this test is not run as part of regular CI execution thus is destined to be broken. The test should be moved to the right location and renamed (i.e. drop tunnel since that has nothing to do with what it is testing).
{noformat}
[0m[31m04:44:19,235 ERROR [org.jboss.as.controller.management-operation] (management-handler-thread - 1) WFLYCTL0013: Operation ("add") failed - address: ([("deployment" => "singleton.war")]) - failure description: {
"WFLYCTL0412: Required services that are not installed:" => ["jboss.clustering.group.default"],
"WFLYCTL0180: Services with missing/unavailable dependencies" => [
"jboss.test1.service.default is missing [jboss.clustering.group.default]",
"jboss.test2.service.default is missing [jboss.clustering.group.default]"
],
"WFLYCTL0288: One or more services were unable to start due to one or more indirect dependencies not being available." => {
"Services that were unable to start:" => [
"jboss.deployment.discovery.\"singleton.war\"",
"jboss.deployment.unit.\"singleton.war\".CdiValidatorFactoryService",
"jboss.deployment.unit.\"singleton.war\".WeldStartService",
"jboss.deployment.unit.\"singleton.war\".component.TopologyChangeListenerBean.JndiBindingsService",
"jboss.deployment.unit.\"singleton.war\".component.TopologyChangeListenerBean.START",
"jboss.deployment.unit.\"singleton.war\".component.TopologyChangeListenerBean.VIEW.\"org.jboss.as.test.clustering.TopologyChangeListener\".REMOTE",
"jboss.deployment.unit.\"singleton.war\".component.TopologyChangeListenerBean.WeldInstantiator",
"jboss.deployment.unit.\"singleton.war\".component.TopologyChangeListenerBean.WeldInterceptorBindingsService",
"jboss.deployment.unit.\"singleton.war\".component.\"com.sun.faces.config.ConfigureListener\".START",
"jboss.deployment.unit.\"singleton.war\".component.\"com.sun.faces.config.ConfigureListener\".WeldInstantiator",
"jboss.deployment.unit.\"singleton.war\".component.\"javax.faces.webapp.FacetTag\".START",
"jboss.deployment.unit.\"singleton.war\".component.\"javax.faces.webapp.FacetTag\".WeldInstantiator",
"jboss.deployment.unit.\"singleton.war\".component.\"javax.servlet.jsp.jstl.tlv.PermittedTaglibsTLV\".START",
"jboss.deployment.unit.\"singleton.war\".component.\"javax.servlet.jsp.jstl.tlv.PermittedTaglibsTLV\".WeldInstantiator",
"jboss.deployment.unit.\"singleton.war\".component.\"javax.servlet.jsp.jstl.tlv.ScriptFreeTLV\".START",
"jboss.deployment.unit.\"singleton.war\".component.\"javax.servlet.jsp.jstl.tlv.ScriptFreeTLV\".WeldInstantiator",
"jboss.deployment.unit.\"singleton.war\".component.\"org.jboss.as.test.clustering.TopologyChangeListenerServlet\".START",
"jboss.deployment.unit.\"singleton.war\".component.\"org.jboss.as.test.clustering.TopologyChangeListenerServlet\".WeldInstantiator",
"jboss.deployment.unit.\"singleton.war\".component.\"org.jboss.as.test.clustering.cluster.singleton.service.NodeServiceServlet\".START",
"jboss.deployment.unit.\"singleton.war\".component.\"org.jboss.as.test.clustering.cluster.singleton.service.NodeServiceServlet\".WeldInstantiator",
"jboss.deployment.unit.\"singleton.war\".component.\"org.jboss.as.test.clustering.cluster.singleton.service.ValueServiceServlet\".START",
"jboss.deployment.unit.\"singleton.war\".component.\"org.jboss.as.test.clustering.cluster.singleton.service.ValueServiceServlet\".WeldInstantiator",
"jboss.deployment.unit.\"singleton.war\".component.\"org.jboss.weld.servlet.WeldInitialListener\".START",
"jboss.deployment.unit.\"singleton.war\".component.\"org.jboss.weld.servlet.WeldInitialListener\".WeldInstantiator",
"jboss.deployment.unit.\"singleton.war\".component.\"org.jboss.weld.servlet.WeldTerminalListener\".START",
"jboss.deployment.unit.\"singleton.war\".component.\"org.jboss.weld.servlet.WeldTerminalListener\".WeldInstantiator",
"jboss.deployment.unit.\"singleton.war\".deploymentCompleteService",
"jboss.deployment.unit.\"singleton.war\".ejb3.client-context.registration-service",
"jboss.deployment.unit.\"singleton.war\".jndiDependencyService",
"jboss.deployment.unit.\"singleton.war\".moduleDeploymentRuntimeInformation",
"jboss.deployment.unit.\"singleton.war\".moduleDeploymentRuntimeInformationStart",
"jboss.naming.context.java.app.singleton.singleton.TopologyChangeListenerBean",
"jboss.naming.context.java.app.singleton.singleton.\"TopologyChangeListenerBean!org.jboss.as.test.clustering.TopologyChangeListener\"",
"jboss.naming.context.java.global.singleton.TopologyChangeListenerBean",
"jboss.naming.context.java.global.singleton.\"TopologyChangeListenerBean!org.jboss.as.test.clustering.TopologyChangeListener\"",
"jboss.naming.context.java.module.singleton.singleton.TopologyChangeListenerBean",
"jboss.naming.context.java.module.singleton.singleton.\"TopologyChangeListenerBean!org.jboss.as.test.clustering.TopologyChangeListener\"",
"jboss.undertow.deployment.default-server.default-host./singleton",
"jboss.undertow.deployment.default-server.default-host./singleton.UndertowDeploymentInfoService"
],
"Services that may be the cause:" => [
"jboss.clustering.group.default",
"org.wildfly.network.socket-binding.undefined"
]
}
}
{noformat}
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years