[JBoss JIRA] (WFCORE-3562) Deployment disable-all doesn't correct function at domain
by Marek Kopecký (JIRA)
[ https://issues.jboss.org/browse/WFCORE-3562?page=com.atlassian.jira.plugi... ]
Marek Kopecký edited comment on WFCORE-3562 at 1/31/18 8:46 AM:
----------------------------------------------------------------
I'm able to reproduce this issue with three deployments too. I attached deployments that I used.
This is not a regression against EAP 7.1, because legacy deploy commands doesn't work correctly on EAP 7.1 too.
*These are my experiments:*
*New way:*
{noformat}
deployment deploy-file --server-groups=main-server-group ~/erase15/app01.war
deployment deploy-file --server-groups=main-server-group ~/erase15/app02.war
deployment deploy-file --server-groups=other-server-group,main-server-group ~/erase15/app03.war
deployment disable --server-groups=main-server-group app01.war
deployment info --server-group=main-server-group
deployment disable-all --all-relevant-server-groups
deployment info --server-group=main-server-group
{noformat}
WF master results (error occurs):
{noformat}
[domain@localhost:9990 /] deployment deploy-file --server-groups=main-server-group ~/erase15/app01.war
[domain@localhost:9990 /] deployment deploy-file --server-groups=main-server-group ~/erase15/app02.war
[domain@localhost:9990 /] deployment deploy-file --server-groups=other-server-group,main-server-group ~/erase15/app03.war
[domain@localhost:9990 /] deployment disable --server-groups=main-server-group app01.war
[domain@localhost:9990 /] deployment info --server-group=main-server-group
NAME RUNTIME-NAME STATE
app01.war app01.war added
app02.war app02.war enabled
app03.war app03.war enabled
[domain@localhost:9990 /] deployment disable-all --all-relevant-server-groups
org.jboss.as.cli.operation.OperationFormatException: None of the server groups is specified or references specified deployment.
[domain@localhost:9990 /] deployment info --server-group=main-server-group
NAME RUNTIME-NAME STATE
app01.war app01.war added
app02.war app02.war enabled
app03.war app03.war enabled
[domain@localhost:9990 /]
{noformat}
*Legacy way:*
{noformat}
deploy ~/erase15/app01.war --server-groups=main-server-group
deploy ~/erase15/app02.war --server-groups=main-server-group
deploy ~/erase15/app03.war --server-groups=other-server-group,main-server-group
undeploy app01.war --keep-content --server-groups=main-server-group
deployment-info --server-group=main-server-group
undeploy * --keep-content --server-groups=main-server-group,other-server-group
deployment-info --server-group=main-server-group
{noformat}
EAP 7.1 results (error occurs):
{noformat}
[domain@localhost:9990 /] deploy ~/erase15/app01.war --server-groups=main-server-group
[domain@localhost:9990 /] deploy ~/erase15/app02.war --server-groups=main-server-group
[domain@localhost:9990 /] deploy ~/erase15/app03.war --server-groups=other-server-group,main-server-group
[domain@localhost:9990 /] undeploy app01.war --keep-content --server-groups=main-server-group
[domain@localhost:9990 /] deployment-info --server-group=main-server-group
NAME RUNTIME-NAME STATE
app01.war app01.war added
app02.war app02.war enabled
app03.war app03.war enabled
[domain@localhost:9990 /] undeploy * --keep-content --server-groups=main-server-group,other-server-group
{"WFLYCTL0062: Composite operation failed and was rolled back. Steps that failed:" => {"Operation step-2" => "WFLYCTL0216: Management resource '[
(\"server-group\" => \"other-server-group\"),
(\"deployment\" => \"app01.war\")
]' not found"}}
[domain@localhost:9990 /] deployment-info --server-group=main-server-group
NAME RUNTIME-NAME STATE
app01.war app01.war added
app02.war app02.war enabled
app03.war app03.war enabled
[domain@localhost:9990 /]
{noformat}
WF master results (error occurs):
{noformat}
[domain@localhost:9990 /] deploy ~/erase15/app01.war --server-groups=main-server-group
[domain@localhost:9990 /] deploy ~/erase15/app02.war --server-groups=main-server-group
[domain@localhost:9990 /] deploy ~/erase15/app03.war --server-groups=other-server-group,main-server-group
[domain@localhost:9990 /] undeploy app01.war --keep-content --server-groups=main-server-group
[domain@localhost:9990 /] deployment-info --server-group=main-server-group
NAME RUNTIME-NAME STATE
app01.war app01.war added
app02.war app02.war enabled
app03.war app03.war enabled
[domain@localhost:9990 /] undeploy * --keep-content --server-groups=main-server-group,other-server-group
Undeploy failed: {"WFLYCTL0062: Composite operation failed and was rolled back. Steps that failed:" => {"Operation step-2" => "WFLYCTL0216: Management resource '[
(\"server-group\" => \"other-server-group\"),
(\"deployment\" => \"app01.war\")
]' not found"}}
[domain@localhost:9990 /] deployment-info --server-group=main-server-group
NAME RUNTIME-NAME STATE
app01.war app01.war added
app02.war app02.war enabled
app03.war app03.war enabled
[domain@localhost:9990 /]
{noformat}
was (Author: mkopecky):
I'm able to reproduce this issue with three deployments too. I attached deployments that I used.
This is not a regression against EAP 7.1, because legacy deploy commands works correctly, but new deployment command doesn't work in this scenario.
*These are my experiments:*
*New way:*
{noformat}
deployment deploy-file --server-groups=main-server-group ~/erase15/app01.war
deployment deploy-file --server-groups=main-server-group ~/erase15/app02.war
deployment deploy-file --server-groups=other-server-group,main-server-group ~/erase15/app03.war
deployment disable --server-groups=main-server-group app01.war
deployment info --server-group=main-server-group
deployment disable-all --all-relevant-server-groups
deployment info --server-group=main-server-group
{noformat}
WF master results (error occurs):
{noformat}
[domain@localhost:9990 /] deployment deploy-file --server-groups=main-server-group ~/erase15/app01.war
[domain@localhost:9990 /] deployment deploy-file --server-groups=main-server-group ~/erase15/app02.war
[domain@localhost:9990 /] deployment deploy-file --server-groups=other-server-group,main-server-group ~/erase15/app03.war
[domain@localhost:9990 /] deployment disable --server-groups=main-server-group app01.war
[domain@localhost:9990 /] deployment info --server-group=main-server-group
NAME RUNTIME-NAME STATE
app01.war app01.war added
app02.war app02.war enabled
app03.war app03.war enabled
[domain@localhost:9990 /] deployment disable-all --all-relevant-server-groups
org.jboss.as.cli.operation.OperationFormatException: None of the server groups is specified or references specified deployment.
[domain@localhost:9990 /] deployment info --server-group=main-server-group
NAME RUNTIME-NAME STATE
app01.war app01.war added
app02.war app02.war enabled
app03.war app03.war enabled
[domain@localhost:9990 /]
{noformat}
*Legacy way:*
{noformat}
deploy ~/erase15/app01.war --server-groups=main-server-group
deploy ~/erase15/app02.war --server-groups=main-server-group
deploy ~/erase15/app03.war --server-groups=other-server-group,main-server-group
undeploy app01.war --keep-content --server-groups=main-server-group
deployment-info --server-group=main-server-group
undeploy * --keep-content --server-groups=main-server-group
deployment-info --server-group=main-server-group
{noformat}
EAP 7.1 results (error doesn't occurs):
{noformat}
[mkopecky@dhcp-10-40-5-4 bin]$ ./jboss-cli.sh -c
[domain@localhost:9990 /] deploy ~/erase15/app01.war --server-groups=main-server-group
[domain@localhost:9990 /] deploy ~/erase15/app02.war --server-groups=main-server-group
[domain@localhost:9990 /] deploy ~/erase15/app03.war --server-groups=other-server-group,main-server-group
[domain@localhost:9990 /] undeploy app01.war --keep-content --server-groups=main-server-group
[domain@localhost:9990 /] deployment-info --server-group=main-server-group
NAME RUNTIME-NAME STATE
app01.war app01.war added
app02.war app02.war enabled
app03.war app03.war enabled
[domain@localhost:9990 /] undeploy * --keep-content --server-groups=main-server-group
[domain@localhost:9990 /] deployment-info --server-group=main-server-group
NAME RUNTIME-NAME STATE
app01.war app01.war added
app02.war app02.war added
app03.war app03.war added
[domain@localhost:9990 /]
{noformat}
WF master results (error doesn't occurs):
{noformat}
[domain@localhost:9990 /] deploy ~/erase15/app01.war --server-groups=main-server-group
[domain@localhost:9990 /] deploy ~/erase15/app02.war --server-groups=main-server-group
[domain@localhost:9990 /] deploy ~/erase15/app03.war --server-groups=other-server-group,main-server-group
[domain@localhost:9990 /] undeploy app01.war --keep-content --server-groups=main-server-group
[domain@localhost:9990 /] deployment-info --server-group=main-server-group
NAME RUNTIME-NAME STATE
app01.war app01.war added
app02.war app02.war enabled
app03.war app03.war enabled
[domain@localhost:9990 /] undeploy * --keep-content --server-groups=main-server-group
[domain@localhost:9990 /] deployment-info --server-group=main-server-group
NAME RUNTIME-NAME STATE
app01.war app01.war added
app02.war app02.war added
app03.war app03.war added
[domain@localhost:9990 /]
{noformat}
> Deployment disable-all doesn't correct function at domain
> ---------------------------------------------------------
>
> Key: WFCORE-3562
> URL: https://issues.jboss.org/browse/WFCORE-3562
> Project: WildFly Core
> Issue Type: Bug
> Components: CLI
> Reporter: Vratislav Marek
> Assignee: Jean-Francois Denise
> Attachments: app01.war, app02.war, app03.war
>
>
> Domain
> {noformat}
> [domain@localhost:9990 /] deployment disable-all --all-relevant-server-groups
> org.jboss.as.cli.operation.OperationFormatException: None of the server groups is specified or references specified deployment.
> [domain@localhost:9990 /]
> {noformat}
> {noformat}
> [domain@localhost:9990 /] undeploy * --keep-content --all-relevant-server-groups
> org.jboss.as.cli.operation.OperationFormatException: None of the server groups is specified or references specified deployment.
> [domain@localhost:9990 /]
> {noformat}
> {noformat}
> [domain@localhost:9990 /] deployment disable-all --server-groups=main-server-group
> {"WFLYCTL0062: Composite operation failed and was rolled back. Steps that failed:" => {"Operation step-4" => "WFLYCTL0216: Management resource '[
> (\"server-group\" => \"main-server-group\"),
> (\"deployment\" => \"cli-test-app2-deploy-all.war\")
> ]' not found"}}
> [domain@localhost:9990 /]
> {noformat}
> {noformat}
> [domain@localhost:9990 /] undeploy * --keep-content --server-groups=main-server-group
> {"WFLYCTL0062: Composite operation failed and was rolled back. Steps that failed:" => {"Operation step-4" => "WFLYCTL0216: Management resource '[
> (\"server-group\" => \"main-server-group\"),
> (\"deployment\" => \"cli-test-app2-deploy-all.war\")
> ]' not found"}}
> [domain@localhost:9990 /]
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
7 years, 10 months
[JBoss JIRA] (DROOLS-2263) Unexpected results in GDST when using enumerations with commas
by Toni Rikkola (JIRA)
[ https://issues.jboss.org/browse/DROOLS-2263?page=com.atlassian.jira.plugi... ]
Toni Rikkola updated DROOLS-2263:
---------------------------------
Summary: Unexpected results in GDST when using enumerations with commas (was: [GSS] (6.4.z) Unexpected results in GDST when using enumerations with commas)
> Unexpected results in GDST when using enumerations with commas
> --------------------------------------------------------------
>
> Key: DROOLS-2263
> URL: https://issues.jboss.org/browse/DROOLS-2263
> Project: Drools
> Issue Type: Bug
> Components: Guided Decision Table Editor
> Reporter: Toni Rikkola
> Assignee: Toni Rikkola
>
> When using enumerations where the values itself contain a comma, the rules generated by a GDST are unexpected, as the "contains in" operator splits those values in the enumerations. Example enumeration:
> {noformat}
> fact: person
> field: city
> context: ['paris','london','new york,boston']
> {noformat}
> Note: see the 'new york, boston' sample.
> The code generated will be:
> {noformat}
> rule "Row 1 personGDT"
> dialect "mvel"
> when
> p : person( city in ( "new york", "boston" ) )
> then
> end
> {noformat}
> Basically "paris" and "new york,boston" will be treated by the DSL parser as 3 strings in the DRL generation and will produce someting simiular to
> p : person( city in ( "paris", "new york", "boston" ) )
> But what the customer expects is the following
> p : person( city in ( "paris", "new york,boston" ) )
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
7 years, 10 months
[JBoss JIRA] (WFLY-232) Deployment fails when Dependencies is empty in a jars manifest
by RH Bugzilla Integration (JIRA)
[ https://issues.jboss.org/browse/WFLY-232?page=com.atlassian.jira.plugin.s... ]
RH Bugzilla Integration commented on WFLY-232:
----------------------------------------------
Anup Kumar Dey <andey(a)redhat.com> changed the Status of [bug 1539985|https://bugzilla.redhat.com/show_bug.cgi?id=1539985] from NEW to ASSIGNED
> Deployment fails when Dependencies is empty in a jars manifest
> --------------------------------------------------------------
>
> Key: WFLY-232
> URL: https://issues.jboss.org/browse/WFLY-232
> Project: WildFly
> Issue Type: Enhancement
> Reporter: Gábor Farkas
> Assignee: Stuart Douglas
> Fix For: 8.0.0.Alpha1
>
> Attachments: empty-manifest.ear
>
>
> I have a WAR, which produces the following error on deployment:
> Caused by: java.lang.IllegalArgumentException: Empty module specification
> at org.jboss.modules.ModuleIdentifier.fromString(ModuleIdentifier.java:169) [jboss-modules.jar:1.1.1.GA]
> at org.jboss.as.server.deployment.module.ManifestDependencyProcessor.deploy(ManifestDependencyProcessor.java:83) [jboss-as-server-7.1.1.Final.jar:7.1.1.Final]
> at org.jboss.as.server.deployment.DeploymentUnitPhaseService.start(DeploymentUnitPhaseService.java:113) [jboss-as-server-7.1.1.Final.jar:7.1.1.Final]
> ... 5 more
> I found that my WAR contains a jar in WEB-INF/lib that has empty dependencies defined in its manifest. More exactly it's "Dependencies: ", so the colon is followed by a space character before the new line characters. The ManifestDependencyProcessor parses this as one dependency, the name of which is the empty string.
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
7 years, 10 months
[JBoss JIRA] (WFCORE-3563) Could not enable application deployment on two server groups in domain
by Marek Kopecký (JIRA)
[ https://issues.jboss.org/browse/WFCORE-3563?page=com.atlassian.jira.plugi... ]
Marek Kopecký commented on WFCORE-3563:
---------------------------------------
[~jdenise]: I confirm [~vmarek] previous comment, this issue is valid also for EAP 7.1
> Could not enable application deployment on two server groups in domain
> ----------------------------------------------------------------------
>
> Key: WFCORE-3563
> URL: https://issues.jboss.org/browse/WFCORE-3563
> Project: WildFly Core
> Issue Type: Bug
> Components: CLI
> Reporter: Vratislav Marek
> Assignee: Jean-Francois Denise
>
> {noformat}
> [domain@localhost:9990 /] deployment enable --server-groups=other-server-group,main-server-group cli-test-app-deploy-all.ear
> {"WFLYCTL0062: Composite operation failed and was rolled back. Steps that failed:" => {"Operation step-1" => "WFLYCTL0212: Duplicate resource [
> (\"server-group\" => \"other-server-group\"),
> (\"deployment\" => \"cli-test-app-deploy-all.ear\")
> ]"}}
> [domain@localhost:9990 /]
> {noformat}
> {noformat}
> [domain@localhost:9990 /] deploy --name=cli-test-app-deploy-all.ear --server-groups=other-server-group,main-server-group
> {"WFLYCTL0062: Composite operation failed and was rolled back. Steps that failed:" => {"Operation step-1" => "WFLYCTL0212: Duplicate resource [
> (\"server-group\" => \"other-server-group\"),
> (\"deployment\" => \"cli-test-app-deploy-all.ear\")
> ]"}}
> [domain@localhost:9990 /]
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
7 years, 10 months
[JBoss JIRA] (WFCORE-3569) NPE is shown in server shutdown
by Richard Opalka (JIRA)
[ https://issues.jboss.org/browse/WFCORE-3569?page=com.atlassian.jira.plugi... ]
Richard Opalka edited comment on WFCORE-3569 at 1/31/18 6:49 AM:
-----------------------------------------------------------------
The following commit introduced this issue:
https://github.com/xnio/xnio/commit/071800e0a85c9da9b88a976ac7ecb85760924dbf
Before there was DebugAbortPolicy rejection execution handler associated with task pool.
Since now on there's termination task created and associated with task pool.
I was able to reproduce this issue with the following stack traces describing the problem:
---
java.lang.Exception:
at org.jboss.as.server.mgmt.ManagementWorkerService.stopDone(ManagementWorkerService.java:69)
at org.xnio.nio.NioXnioWorker.closeResource(NioXnioWorker.java:264)
at org.xnio.nio.NioXnioWorker.taskPoolTerminated(NioXnioWorker.java:360)
at org.xnio.XnioWorker$1.run(XnioWorker.java:127)
at org.jboss.threads.EnhancedQueueExecutor.safeRun(EnhancedQueueExecutor.java:1983)
at org.jboss.threads.EnhancedQueueExecutor.completeTermination(EnhancedQueueExecutor.java:1759)
at org.jboss.threads.EnhancedQueueExecutor.tryDeallocateThread(EnhancedQueueExecutor.java:1580)
at org.jboss.threads.EnhancedQueueExecutor$ThreadBody.run(EnhancedQueueExecutor.java:1393)
at java.lang.Thread.run(Thread.java:748)
java.lang.Exception:
at org.jboss.as.server.mgmt.ManagementWorkerService.stopDone(ManagementWorkerService.java:69)
at org.xnio.XnioWorker$1.run(XnioWorker.java:138)
at org.jboss.threads.EnhancedQueueExecutor.safeRun(EnhancedQueueExecutor.java:1983)
at org.jboss.threads.EnhancedQueueExecutor.completeTermination(EnhancedQueueExecutor.java:1759)
at org.jboss.threads.EnhancedQueueExecutor.tryDeallocateThread(EnhancedQueueExecutor.java:1580)
at org.jboss.threads.EnhancedQueueExecutor$ThreadBody.run(EnhancedQueueExecutor.java:1393)
at java.lang.Thread.run(Thread.java:748)
---
>From the stack traces above you can see that ManagementWorkerService.stopDone() is called twice.
Further more it is called twice from the same thread while executing terminationTask.
These are the possibilities how to fix this issue:
* either return back to DebugAbortPolicy rejection execution handler
* or eliminate call on line 137 because it "somehow" duplicates what is happening on line 126 already
* or make ManagementWorkerService.stopDone() idempotent
Since I don't know XNIO implementation details I can't say which of above proposals is the appropriate one (if any)
was (Author: ropalka):
The following commit introduced this issue:
https://github.com/xnio/xnio/commit/071800e0a85c9da9b88a976ac7ecb85760924dbf
Before there was DebugAbortPolicy rejection execution handler associated with task pool.
Since now on there's termination task created and associated with task pool.
I was able to reproduce this issue with the following stack traces describing the problem:
---
java.lang.Exception:
at org.jboss.as.server.mgmt.ManagementWorkerService.stopDone(ManagementWorkerService.java:69)
at org.xnio.nio.NioXnioWorker.closeResource(NioXnioWorker.java:264)
at org.xnio.nio.NioXnioWorker.taskPoolTerminated(NioXnioWorker.java:360)
at org.xnio.XnioWorker$1.run(XnioWorker.java:127)
at org.jboss.threads.EnhancedQueueExecutor.safeRun(EnhancedQueueExecutor.java:1983)
at org.jboss.threads.EnhancedQueueExecutor.completeTermination(EnhancedQueueExecutor.java:1759)
at org.jboss.threads.EnhancedQueueExecutor.tryDeallocateThread(EnhancedQueueExecutor.java:1580)
at org.jboss.threads.EnhancedQueueExecutor$ThreadBody.run(EnhancedQueueExecutor.java:1393)
at java.lang.Thread.run(Thread.java:748)
java.lang.Exception:
at org.jboss.as.server.mgmt.ManagementWorkerService.stopDone(ManagementWorkerService.java:69)
at org.xnio.XnioWorker$1.run(XnioWorker.java:138)
at org.jboss.threads.EnhancedQueueExecutor.safeRun(EnhancedQueueExecutor.java:1983)
at org.jboss.threads.EnhancedQueueExecutor.completeTermination(EnhancedQueueExecutor.java:1759)
at org.jboss.threads.EnhancedQueueExecutor.tryDeallocateThread(EnhancedQueueExecutor.java:1580)
at org.jboss.threads.EnhancedQueueExecutor$ThreadBody.run(EnhancedQueueExecutor.java:1393)
at java.lang.Thread.run(Thread.java:748)
---
>From the stack traces above you can see that ManagementWorkerService.stopDone() is called twice.
Further more it is called twice from the same thread while executing terminationTask.
These are the possibilities how to fix this issue:
* either return back to DebugAbortPolicy rejection execution handler
* or eliminate call on line 137 because it "somehow" duplicates what is happening on line 126 already
* or make ManagementWorkerService.stopDone() idempotent
Since I don't know XNIO implementation details I can't say which of above proposals is the appropriate one (if any)
> NPE is shown in server shutdown
> -------------------------------
>
> Key: WFCORE-3569
> URL: https://issues.jboss.org/browse/WFCORE-3569
> Project: WildFly Core
> Issue Type: Bug
> Components: CLI, Domain Management, IO, Server
> Affects Versions: 4.0.0.Alpha8
> Reporter: Chao Wang
> Assignee: David Lloyd
> Priority: Critical
>
> NullPointerException is shown in server shutdown with an open CLI connection in current WFLY master since WFCORE 4.0.0.Alpha7.
> Start the server and open a CLI connection, then stop server with Ctrl + C. We will see
> {noformat}
> 13:15:09,136 ERROR [org.jboss.threads.errors] (management task-1) Thread Thread[management task-1,5,main] threw an uncaught exception: java.lang.NullPointerException
> at org.jboss.as.server.mgmt.ManagementWorkerService.stopDone(ManagementWorkerService.java:72)
> at org.xnio.XnioWorker$1.run(XnioWorker.java:138)
> at org.jboss.threads.EnhancedQueueExecutor.safeRun(EnhancedQueueExecutor.java:1979)
> at org.jboss.threads.EnhancedQueueExecutor.completeTermination(EnhancedQueueExecutor.java:1755)
> at org.jboss.threads.EnhancedQueueExecutor.tryDeallocateThread(EnhancedQueueExecutor.java:1578)
> at org.jboss.threads.EnhancedQueueExecutor$ThreadBody.run(EnhancedQueueExecutor.java:1393)
> at java.lang.Thread.run(Thread.java:748)
> {noformat}
> I assign this to David as it seems this is caused by WFCORE-3397 and https://github.com/wildfly/wildfly-core/pull/3072 Please feel free to reassign to correct person.
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
7 years, 10 months
[JBoss JIRA] (WFCORE-3569) NPE is shown in server shutdown
by Richard Opalka (JIRA)
[ https://issues.jboss.org/browse/WFCORE-3569?page=com.atlassian.jira.plugi... ]
Richard Opalka commented on WFCORE-3569:
----------------------------------------
The following commit introduced this issue:
https://github.com/xnio/xnio/commit/071800e0a85c9da9b88a976ac7ecb85760924dbf
Before there was DebugAbortPolicy rejection execution handler associated with task pool.
Since now on there's termination task created and associated with task pool.
I was able to reproduce this issue with the following stack traces describing the problem:
---
java.lang.Exception:
at org.jboss.as.server.mgmt.ManagementWorkerService.stopDone(ManagementWorkerService.java:69)
at org.xnio.nio.NioXnioWorker.closeResource(NioXnioWorker.java:264)
at org.xnio.nio.NioXnioWorker.taskPoolTerminated(NioXnioWorker.java:360)
at org.xnio.XnioWorker$1.run(XnioWorker.java:127)
at org.jboss.threads.EnhancedQueueExecutor.safeRun(EnhancedQueueExecutor.java:1983)
at org.jboss.threads.EnhancedQueueExecutor.completeTermination(EnhancedQueueExecutor.java:1759)
at org.jboss.threads.EnhancedQueueExecutor.tryDeallocateThread(EnhancedQueueExecutor.java:1580)
at org.jboss.threads.EnhancedQueueExecutor$ThreadBody.run(EnhancedQueueExecutor.java:1393)
at java.lang.Thread.run(Thread.java:748)
java.lang.Exception:
at org.jboss.as.server.mgmt.ManagementWorkerService.stopDone(ManagementWorkerService.java:69)
at org.xnio.XnioWorker$1.run(XnioWorker.java:138)
at org.jboss.threads.EnhancedQueueExecutor.safeRun(EnhancedQueueExecutor.java:1983)
at org.jboss.threads.EnhancedQueueExecutor.completeTermination(EnhancedQueueExecutor.java:1759)
at org.jboss.threads.EnhancedQueueExecutor.tryDeallocateThread(EnhancedQueueExecutor.java:1580)
at org.jboss.threads.EnhancedQueueExecutor$ThreadBody.run(EnhancedQueueExecutor.java:1393)
at java.lang.Thread.run(Thread.java:748)
---
>From the stack traces above you can see that ManagementWorkerService.stopDone() is called twice.
Further more it is called twice from the same thread while executing terminationTask.
These are the possibilities how to fix this issue:
* either return back to DebugAbortPolicy rejection execution handler
* or eliminate call on line 137 because it "somehow" duplicates what is happening on line 126 already
* or make ManagementWorkerService.stopDone() idempotent
Since I don't know XNIO implementation details I can't say which of above proposals is the appropriate one (if any)
> NPE is shown in server shutdown
> -------------------------------
>
> Key: WFCORE-3569
> URL: https://issues.jboss.org/browse/WFCORE-3569
> Project: WildFly Core
> Issue Type: Bug
> Components: CLI, Domain Management, IO, Server
> Affects Versions: 4.0.0.Alpha8
> Reporter: Chao Wang
> Assignee: David Lloyd
> Priority: Critical
>
> NullPointerException is shown in server shutdown with an open CLI connection in current WFLY master since WFCORE 4.0.0.Alpha7.
> Start the server and open a CLI connection, then stop server with Ctrl + C. We will see
> {noformat}
> 13:15:09,136 ERROR [org.jboss.threads.errors] (management task-1) Thread Thread[management task-1,5,main] threw an uncaught exception: java.lang.NullPointerException
> at org.jboss.as.server.mgmt.ManagementWorkerService.stopDone(ManagementWorkerService.java:72)
> at org.xnio.XnioWorker$1.run(XnioWorker.java:138)
> at org.jboss.threads.EnhancedQueueExecutor.safeRun(EnhancedQueueExecutor.java:1979)
> at org.jboss.threads.EnhancedQueueExecutor.completeTermination(EnhancedQueueExecutor.java:1755)
> at org.jboss.threads.EnhancedQueueExecutor.tryDeallocateThread(EnhancedQueueExecutor.java:1578)
> at org.jboss.threads.EnhancedQueueExecutor$ThreadBody.run(EnhancedQueueExecutor.java:1393)
> at java.lang.Thread.run(Thread.java:748)
> {noformat}
> I assign this to David as it seems this is caused by WFCORE-3397 and https://github.com/wildfly/wildfly-core/pull/3072 Please feel free to reassign to correct person.
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
7 years, 10 months
[JBoss JIRA] (WFLY-9746) Revert JGroups capability reference to ChannelFactory
by Paul Ferraro (JIRA)
[ https://issues.jboss.org/browse/WFLY-9746?page=com.atlassian.jira.plugin.... ]
Paul Ferraro commented on WFLY-9746:
------------------------------------
WFLY-9271 changed the jgroups-stack capability reference to refer to a CommandDispatcherFactory capability. This breaks configuration that specified a JGroups-stack based JChannelFactory. To restore compatibility, we should revert this capability reference and in the event that a corresponding CommandDispatcherFactory capability does not exist, auto-create the missing JGroups channel resource required to create it.
> Revert JGroups capability reference to ChannelFactory
> -----------------------------------------------------
>
> Key: WFLY-9746
> URL: https://issues.jboss.org/browse/WFLY-9746
> Project: WildFly
> Issue Type: Bug
> Components: Clustering, JMS
> Affects Versions: 12.0.0.Alpha1
> Reporter: Paul Ferraro
> Assignee: Paul Ferraro
> Priority: Blocker
>
> There is regression If Artemis is configured to JGroups tcp stack to form cluster then server does not start and fail with:
> {code}
> 13:24:02,424 INFO [org.jboss.ws.common.management] (MSC service thread 1-8) JBWS022052: Starting JBossWS 5.1.9.Final (Apache CXF 3.1.12)
> 13:24:02,428 ERROR [org.jboss.as.controller.management-operation] (Controller Boot Thread) WFLYCTL0013: Operation ("add") failed - address: ([
> ("subsystem" => "messaging-activemq"),
> ("server" => "default")
> ]) - failure description: {
> "WFLYCTL0412: Required services that are not installed:" => [
> "jboss.messaging-activemq.default",
> "org.wildfly.clustering.command-dispatcher-factory.tcp"
> ],
> "WFLYCTL0180: Services with missing/unavailable dependencies" => [
> "jboss.messaging-activemq.default.jms.manager is missing [jboss.messaging-activemq.default]",
> "jboss.messaging-activemq.default is missing [org.wildfly.clustering.command-dispatcher-factory.tcp]"
> ]
> }
> 13:24:02,438 INFO [org.jboss.as.controller] (Controller Boot Thread) WFLYCTL0183: Service status report
> WFLYCTL0184: New missing/unsatisfied dependencies:
> service jboss.messaging-activemq.default (unavailable) dependents: [service jboss.messaging-activemq.default.jms.manager]
> service org.wildfly.clustering.command-dispatcher-factory.tcp (missing) dependents: [service jboss.messaging-activemq.default]
> 13:24:02,485 INFO [org.jboss.as.server] (Controller Boot Thread) WFLYSRV0212: Resuming server
> 13:24:02,487 INFO [org.jboss.as] (Controller Boot Thread) WFLYSRV0060: Http management interface listening on http://127.0.0.1:11990/management
> 13:24:02,487 INFO [org.jboss.as] (Controller Boot Thread) WFLYSRV0051: Admin console listening on http://127.0.0.1:11990
> {code}
> Configuration of jgroups and messaging-activemq subsystem:
> {code}
> <subsystem xmlns="urn:jboss:domain:jgroups:5.0">
> <channels default="ee">
> <channel name="ee" stack="udp" cluster="ejb"/>
> </channels>
> ...
> <stack name="tcp">
> <transport type="TCP" socket-binding="jgroups-tcp"/>
> <protocol type="org.jgroups.protocols.TCPPING">
> <property name="port_range">
> 10
> </property>
> <property name="num_initial_members">
> 1
> </property>
> <property name="initial_hosts">
> 127.0.0.1[9600]
> </property>
> <property name="timeout">
> 3000
> </property>
> </protocol>
> <protocol type="MERGE3"/>
> <protocol type="FD_SOCK"/>
> <protocol type="FD"/>
> <protocol type="VERIFY_SUSPECT"/>
> <protocol type="pbcast.NAKACK"/>
> <protocol type="UNICAST3"/>
> <protocol type="pbcast.STABLE"/>
> <protocol type="pbcast.GMS"/>
> <protocol type="UFC"/>
> <protocol type="MFC"/>
> <protocol type="FRAG2"/>
> <protocol type="RSVP"/>
> </stack>
> </stacks>
> </subsystem>
> ....
> <subsystem xmlns="urn:jboss:domain:messaging-activemq:3.0">
> <server name="default" persistence-enabled="true" id-cache-size="200000">
> <broadcast-group name="bg-group1" jgroups-stack="tcp" jgroups-channel="udp" broadcast-period="2000" connectors="connector"/>
> <discovery-group name="dg-group1" jgroups-stack="tcp" jgroups-channel="udp" refresh-timeout="10000"/>
> <cluster-connection name="my-cluster" address="jms" connector-name="connector" check-period="30000" connection-ttl="60000" call-timeout="30000" discovery-group="dg-group1"/>
> ...
> </server>
> </subsystem>
> {code}
> Attaching the whole config: standalone-full-ha.xml
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
7 years, 10 months
[JBoss JIRA] (WFLY-9746) Revert JGroups capability reference to ChannelFactory
by Paul Ferraro (JIRA)
[ https://issues.jboss.org/browse/WFLY-9746?page=com.atlassian.jira.plugin.... ]
Paul Ferraro moved JBEAP-14176 to WFLY-9746:
--------------------------------------------
Project: WildFly (was: JBoss Enterprise Application Platform)
Key: WFLY-9746 (was: JBEAP-14176)
Workflow: GIT Pull Request workflow (was: CDW with loose statuses v1)
Component/s: Clustering
JMS
(was: Clustering)
(was: JMS)
Affects Version/s: 12.0.0.Alpha1
(was: 7.2.0.GA)
> Revert JGroups capability reference to ChannelFactory
> -----------------------------------------------------
>
> Key: WFLY-9746
> URL: https://issues.jboss.org/browse/WFLY-9746
> Project: WildFly
> Issue Type: Bug
> Components: Clustering, JMS
> Affects Versions: 12.0.0.Alpha1
> Reporter: Paul Ferraro
> Assignee: Paul Ferraro
> Priority: Blocker
>
> There is regression If Artemis is configured to JGroups tcp stack to form cluster then server does not start and fail with:
> {code}
> 13:24:02,424 INFO [org.jboss.ws.common.management] (MSC service thread 1-8) JBWS022052: Starting JBossWS 5.1.9.Final (Apache CXF 3.1.12)
> 13:24:02,428 ERROR [org.jboss.as.controller.management-operation] (Controller Boot Thread) WFLYCTL0013: Operation ("add") failed - address: ([
> ("subsystem" => "messaging-activemq"),
> ("server" => "default")
> ]) - failure description: {
> "WFLYCTL0412: Required services that are not installed:" => [
> "jboss.messaging-activemq.default",
> "org.wildfly.clustering.command-dispatcher-factory.tcp"
> ],
> "WFLYCTL0180: Services with missing/unavailable dependencies" => [
> "jboss.messaging-activemq.default.jms.manager is missing [jboss.messaging-activemq.default]",
> "jboss.messaging-activemq.default is missing [org.wildfly.clustering.command-dispatcher-factory.tcp]"
> ]
> }
> 13:24:02,438 INFO [org.jboss.as.controller] (Controller Boot Thread) WFLYCTL0183: Service status report
> WFLYCTL0184: New missing/unsatisfied dependencies:
> service jboss.messaging-activemq.default (unavailable) dependents: [service jboss.messaging-activemq.default.jms.manager]
> service org.wildfly.clustering.command-dispatcher-factory.tcp (missing) dependents: [service jboss.messaging-activemq.default]
> 13:24:02,485 INFO [org.jboss.as.server] (Controller Boot Thread) WFLYSRV0212: Resuming server
> 13:24:02,487 INFO [org.jboss.as] (Controller Boot Thread) WFLYSRV0060: Http management interface listening on http://127.0.0.1:11990/management
> 13:24:02,487 INFO [org.jboss.as] (Controller Boot Thread) WFLYSRV0051: Admin console listening on http://127.0.0.1:11990
> {code}
> Configuration of jgroups and messaging-activemq subsystem:
> {code}
> <subsystem xmlns="urn:jboss:domain:jgroups:5.0">
> <channels default="ee">
> <channel name="ee" stack="udp" cluster="ejb"/>
> </channels>
> ...
> <stack name="tcp">
> <transport type="TCP" socket-binding="jgroups-tcp"/>
> <protocol type="org.jgroups.protocols.TCPPING">
> <property name="port_range">
> 10
> </property>
> <property name="num_initial_members">
> 1
> </property>
> <property name="initial_hosts">
> 127.0.0.1[9600]
> </property>
> <property name="timeout">
> 3000
> </property>
> </protocol>
> <protocol type="MERGE3"/>
> <protocol type="FD_SOCK"/>
> <protocol type="FD"/>
> <protocol type="VERIFY_SUSPECT"/>
> <protocol type="pbcast.NAKACK"/>
> <protocol type="UNICAST3"/>
> <protocol type="pbcast.STABLE"/>
> <protocol type="pbcast.GMS"/>
> <protocol type="UFC"/>
> <protocol type="MFC"/>
> <protocol type="FRAG2"/>
> <protocol type="RSVP"/>
> </stack>
> </stacks>
> </subsystem>
> ....
> <subsystem xmlns="urn:jboss:domain:messaging-activemq:3.0">
> <server name="default" persistence-enabled="true" id-cache-size="200000">
> <broadcast-group name="bg-group1" jgroups-stack="tcp" jgroups-channel="udp" broadcast-period="2000" connectors="connector"/>
> <discovery-group name="dg-group1" jgroups-stack="tcp" jgroups-channel="udp" refresh-timeout="10000"/>
> <cluster-connection name="my-cluster" address="jms" connector-name="connector" check-period="30000" connection-ttl="60000" call-timeout="30000" discovery-group="dg-group1"/>
> ...
> </server>
> </subsystem>
> {code}
> Attaching the whole config: standalone-full-ha.xml
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
7 years, 10 months
[JBoss JIRA] (WFCORE-3566) Different results of disabling commands already disabled deployment
by Marek Kopecký (JIRA)
[ https://issues.jboss.org/browse/WFCORE-3566?page=com.atlassian.jira.plugi... ]
Marek Kopecký commented on WFCORE-3566:
---------------------------------------
Warning message should be similar in both cases and this warning message should be user-friendly.
Anyway, this is not regression against EAP 7.1.
*Experiments for EAP 7.1:*
Domain:
{noformat}
[domain@localhost:9990 /] deployment deploy-file --server-groups=main-server-group ~/erase15/app01.war
Unexpected command 'deployment deploy-file --server-groups=main-server-group ~/erase15/app01.war'. Type 'help --commands' for the list of supported commands.
[domain@localhost:9990 /] deploy ~/erase15/app01.war --server-groups=main-server-group
[domain@localhost:9990 /] undeploy app01.war --keep-content --server-groups=main-server-group
[domain@localhost:9990 /] undeploy app01.war --keep-content --server-groups=main-server-group
[domain@localhost:9990 /]
{noformat}
Standalone:
{noformat}
[standalone@localhost:9990 /] deploy ~/erase15/app01.war
[standalone@localhost:9990 /] undeploy app01.war --keep-content
[standalone@localhost:9990 /] undeploy app01.war --keep-content
Undeploy failed: WFLYCTL0155: 'steps' may not be null
[standalone@localhost:9990 /]
{noformat}
> Different results of disabling commands already disabled deployment
> -------------------------------------------------------------------
>
> Key: WFCORE-3566
> URL: https://issues.jboss.org/browse/WFCORE-3566
> Project: WildFly Core
> Issue Type: Bug
> Components: CLI
> Reporter: Vratislav Marek
> Assignee: Jean-Francois Denise
>
> *Different command result of disabling already disabled deployment in standalone and domain mode*
> * In standalone return
> {noformat}
> WFLYCTL0155: 'steps' may not be null
> {noformat}
> * In domain return nothing, no warning or error
> {noformat}
> [standalone@localhost:9990 /] deployment info
> NAME RUNTIME-NAME PERSISTENT ENABLED STATUS
> cli-test-another-deploy.war cli-test-another-deploy.war true true OK
> cli-test-app1-deploy.war cli-test-app1-deploy.war true false STOPPED
> cli-test-app2-deploy.war cli-test-app2-deploy.war true true OK
> [standalone@localhost:9990 /] deployment disable cli-test-app1-deploy-all.war
> WFLYCTL0155: 'steps' may not be null
> [standalone@localhost:9990 /]
> {noformat}
> {noformat}
> [domain@localhost:9990 /] deployment info --server-groups=main-server-group
> NAME RUNTIME-NAME STATE
> cli-test-another-deploy-all.war cli-test-another-deploy-all.war enabled
> cli-test-app1-deploy-all.war cli-test-app1-deploy-all.war added
> cli-test-app2-deploy-all.war cli-test-app2-deploy-all.war not added
> cli-test-app3-deploy-all.war cli-test-app3-deploy-all.war enabled
> [domain@localhost:9990 /] deployment disable --server-groups=main-server-group cli-test-app1-deploy-all.war
> [domain@localhost:9990 /]
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
7 years, 10 months
[JBoss JIRA] (WFCORE-3562) Deployment disable-all doesn't correct function at domain
by Marek Kopecký (JIRA)
[ https://issues.jboss.org/browse/WFCORE-3562?page=com.atlassian.jira.plugi... ]
Marek Kopecký commented on WFCORE-3562:
---------------------------------------
I'm able to reproduce this issue with three deployments too. I attached deployments that I used.
This is not a regression against EAP 7.1, because legacy deploy commands works correctly, but new deployment command doesn't work in this scenario.
*These are my experiments:*
*New way:*
{noformat}
deployment deploy-file --server-groups=main-server-group ~/erase15/app01.war
deployment deploy-file --server-groups=main-server-group ~/erase15/app02.war
deployment deploy-file --server-groups=other-server-group,main-server-group ~/erase15/app03.war
deployment disable --server-groups=main-server-group app01.war
deployment info --server-group=main-server-group
deployment disable-all --all-relevant-server-groups
deployment info --server-group=main-server-group
{noformat}
WF master results (error occurs):
{noformat}
[domain@localhost:9990 /] deployment deploy-file --server-groups=main-server-group ~/erase15/app01.war
[domain@localhost:9990 /] deployment deploy-file --server-groups=main-server-group ~/erase15/app02.war
[domain@localhost:9990 /] deployment deploy-file --server-groups=other-server-group,main-server-group ~/erase15/app03.war
[domain@localhost:9990 /] deployment disable --server-groups=main-server-group app01.war
[domain@localhost:9990 /] deployment info --server-group=main-server-group
NAME RUNTIME-NAME STATE
app01.war app01.war added
app02.war app02.war enabled
app03.war app03.war enabled
[domain@localhost:9990 /] deployment disable-all --all-relevant-server-groups
org.jboss.as.cli.operation.OperationFormatException: None of the server groups is specified or references specified deployment.
[domain@localhost:9990 /] deployment info --server-group=main-server-group
NAME RUNTIME-NAME STATE
app01.war app01.war added
app02.war app02.war enabled
app03.war app03.war enabled
[domain@localhost:9990 /]
{noformat}
*Legacy way:*
{noformat}
deploy ~/erase15/app01.war --server-groups=main-server-group
deploy ~/erase15/app02.war --server-groups=main-server-group
deploy ~/erase15/app03.war --server-groups=other-server-group,main-server-group
undeploy app01.war --keep-content --server-groups=main-server-group
deployment-info --server-group=main-server-group
undeploy * --keep-content --server-groups=main-server-group
deployment-info --server-group=main-server-group
{noformat}
EAP 7.1 results (error doesn't occurs):
{noformat}
[mkopecky@dhcp-10-40-5-4 bin]$ ./jboss-cli.sh -c
[domain@localhost:9990 /] deploy ~/erase15/app01.war --server-groups=main-server-group
[domain@localhost:9990 /] deploy ~/erase15/app02.war --server-groups=main-server-group
[domain@localhost:9990 /] deploy ~/erase15/app03.war --server-groups=other-server-group,main-server-group
[domain@localhost:9990 /] undeploy app01.war --keep-content --server-groups=main-server-group
[domain@localhost:9990 /] deployment-info --server-group=main-server-group
NAME RUNTIME-NAME STATE
app01.war app01.war added
app02.war app02.war enabled
app03.war app03.war enabled
[domain@localhost:9990 /] undeploy * --keep-content --server-groups=main-server-group
[domain@localhost:9990 /] deployment-info --server-group=main-server-group
NAME RUNTIME-NAME STATE
app01.war app01.war added
app02.war app02.war added
app03.war app03.war added
[domain@localhost:9990 /]
{noformat}
WF master results (error doesn't occurs):
{noformat}
[domain@localhost:9990 /] deploy ~/erase15/app01.war --server-groups=main-server-group
[domain@localhost:9990 /] deploy ~/erase15/app02.war --server-groups=main-server-group
[domain@localhost:9990 /] deploy ~/erase15/app03.war --server-groups=other-server-group,main-server-group
[domain@localhost:9990 /] undeploy app01.war --keep-content --server-groups=main-server-group
[domain@localhost:9990 /] deployment-info --server-group=main-server-group
NAME RUNTIME-NAME STATE
app01.war app01.war added
app02.war app02.war enabled
app03.war app03.war enabled
[domain@localhost:9990 /] undeploy * --keep-content --server-groups=main-server-group
[domain@localhost:9990 /] deployment-info --server-group=main-server-group
NAME RUNTIME-NAME STATE
app01.war app01.war added
app02.war app02.war added
app03.war app03.war added
[domain@localhost:9990 /]
{noformat}
> Deployment disable-all doesn't correct function at domain
> ---------------------------------------------------------
>
> Key: WFCORE-3562
> URL: https://issues.jboss.org/browse/WFCORE-3562
> Project: WildFly Core
> Issue Type: Bug
> Components: CLI
> Reporter: Vratislav Marek
> Assignee: Jean-Francois Denise
> Attachments: app01.war, app02.war, app03.war
>
>
> Domain
> {noformat}
> [domain@localhost:9990 /] deployment disable-all --all-relevant-server-groups
> org.jboss.as.cli.operation.OperationFormatException: None of the server groups is specified or references specified deployment.
> [domain@localhost:9990 /]
> {noformat}
> {noformat}
> [domain@localhost:9990 /] undeploy * --keep-content --all-relevant-server-groups
> org.jboss.as.cli.operation.OperationFormatException: None of the server groups is specified or references specified deployment.
> [domain@localhost:9990 /]
> {noformat}
> {noformat}
> [domain@localhost:9990 /] deployment disable-all --server-groups=main-server-group
> {"WFLYCTL0062: Composite operation failed and was rolled back. Steps that failed:" => {"Operation step-4" => "WFLYCTL0216: Management resource '[
> (\"server-group\" => \"main-server-group\"),
> (\"deployment\" => \"cli-test-app2-deploy-all.war\")
> ]' not found"}}
> [domain@localhost:9990 /]
> {noformat}
> {noformat}
> [domain@localhost:9990 /] undeploy * --keep-content --server-groups=main-server-group
> {"WFLYCTL0062: Composite operation failed and was rolled back. Steps that failed:" => {"Operation step-4" => "WFLYCTL0216: Management resource '[
> (\"server-group\" => \"main-server-group\"),
> (\"deployment\" => \"cli-test-app2-deploy-all.war\")
> ]' not found"}}
> [domain@localhost:9990 /]
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
7 years, 10 months