[JBoss JIRA] (WFLY-12601) Eliminate StabilityMonitor usages in clustering subsystem
by Richard Opalka (Jira)
[ https://issues.jboss.org/browse/WFLY-12601?page=com.atlassian.jira.plugin... ]
Richard Opalka commented on WFLY-12601:
---------------------------------------
I attached ServiceSupplier UML diagram in order to describe what MSC broken code means there.
ServiceSupplier.get() installs new temporary MSC service in order to obtain dependency value in a
new MSC API proper way.
There are two problems with that code in ServiceSupplier.get() method.
(1) I realized StabilityMonitor feature is broken by design and thus code calling
SM.awaitStability() may obtain false "stability achieved" notifications.
This is the case mainly for dependencies whose dependency chain is greater than 2.
(2) There is concurrent race condition between SM.awaitStability() call and controller.getState() call.
It may happen even if "stability achieved" was properly reported that
service may transition from UP to some other state between these two calls.
It is not possible to avoid (1) kind of issues other way than eliminate usages of StabilityMonitor.
To fix (2) kind of issues it is necessary to obtain dependency values while dependency is in UP state.
That means values particular service provide are valid iff service finished its start() lifecycle method
and didn't start its stop() lifecycle method.
I created MSC branch for you [~pferraro] to demonstrate how you should fix these "obtain statistics" scenarios:
https://github.com/ropalka/jboss-msc/commits/WFLY-12601
If you will have any questions WRT jboss-msc or this reported issue please
don't hesitate and ask me either via mail or via #jboss-msc stream in WildFly Zulip chat.
> Eliminate StabilityMonitor usages in clustering subsystem
> ---------------------------------------------------------
>
> Key: WFLY-12601
> URL: https://issues.jboss.org/browse/WFLY-12601
> Project: WildFly
> Issue Type: Bug
> Components: Clustering
> Reporter: Richard Opalka
> Assignee: Paul Ferraro
> Priority: Major
> Fix For: 19.0.0.Beta1
>
> Attachments: ServiceSupplier.png
>
>
> Clustering needs to eliminate usages of StabilityMonitor because SM is not reliable.
> It is possible that SM will prematurely inform about achieved stability even if it is not true.
> The reason is SM is not propagated up the dependencies chain and thus it may report
> about achieved stability even in case dependencies chain didn't finish its processing yet
> and 'real' stability wasn't achieved yet.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years
[JBoss JIRA] (WFLY-12602) Translated clustering attribute do not correctly translate undefine-attribute operation.
by Paul Ferraro (Jira)
Paul Ferraro created WFLY-12602:
-----------------------------------
Summary: Translated clustering attribute do not correctly translate undefine-attribute operation.
Key: WFLY-12602
URL: https://issues.jboss.org/browse/WFLY-12602
Project: WildFly
Issue Type: Bug
Components: Clustering
Affects Versions: 18.0.0.Beta1
Reporter: Paul Ferraro
Assignee: Paul Ferraro
Clustering subsystems make use of generic operations handlers for handling things like:
stats-enabled -> statistics-enabled
While the read-attribute and write-attribute operations are correctly handled, the undefine-attribute operation is not.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years
[JBoss JIRA] (DROOLS-4574) Scenario test: UX to add an expression-based value.
by Elizabeth Clayton (Jira)
[ https://issues.jboss.org/browse/DROOLS-4574?page=com.atlassian.jira.plugi... ]
Elizabeth Clayton updated DROOLS-4574:
--------------------------------------
Description:
As a technical/advanced user (Cameron), I want to be able to input expression-based values in scenario given/expect row cells, so that I can define inputs for complex objects and logic.
Note: Syntax highlighting and etc., are out of scope. Refer to: https://issues.jboss.org/browse/DROOLS-3514
was:As a technical/advanced user (Cameron), I want to be able to input expression-based values in scenario given/expect row cells, so that I can define inputs for complex objects and logic.
> Scenario test: UX to add an expression-based value.
> ----------------------------------------------------
>
> Key: DROOLS-4574
> URL: https://issues.jboss.org/browse/DROOLS-4574
> Project: Drools
> Issue Type: Story
> Components: Scenario Simulation and Testing
> Reporter: Elizabeth Clayton
> Assignee: Elizabeth Clayton
> Priority: Major
> Labels: UX, UXTeam
>
> As a technical/advanced user (Cameron), I want to be able to input expression-based values in scenario given/expect row cells, so that I can define inputs for complex objects and logic.
> Note: Syntax highlighting and etc., are out of scope. Refer to: https://issues.jboss.org/browse/DROOLS-3514
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years
[JBoss JIRA] (WFLY-12601) Eliminate StabilityMonitor usages in clustering subsystem
by Richard Opalka (Jira)
[ https://issues.jboss.org/browse/WFLY-12601?page=com.atlassian.jira.plugin... ]
Richard Opalka updated WFLY-12601:
----------------------------------
Attachment: ServiceSupplier.png
> Eliminate StabilityMonitor usages in clustering subsystem
> ---------------------------------------------------------
>
> Key: WFLY-12601
> URL: https://issues.jboss.org/browse/WFLY-12601
> Project: WildFly
> Issue Type: Bug
> Components: Clustering
> Reporter: Richard Opalka
> Assignee: Paul Ferraro
> Priority: Major
> Fix For: 19.0.0.Beta1
>
> Attachments: ServiceSupplier.png
>
>
> Clustering needs to eliminate usages of StabilityMonitor because SM is not reliable.
> It is possible that SM will prematurely inform about achieved stability even if it is not true.
> The reason is SM is not propagated up the dependencies chain and thus it may report
> about achieved stability even in case dependencies chain didn't finish its processing yet
> and 'real' stability wasn't achieved yet.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years
[JBoss JIRA] (WFLY-12601) Eliminate StabilityMonitor usages in clustering subsystem
by Richard Opalka (Jira)
Richard Opalka created WFLY-12601:
-------------------------------------
Summary: Eliminate StabilityMonitor usages in clustering subsystem
Key: WFLY-12601
URL: https://issues.jboss.org/browse/WFLY-12601
Project: WildFly
Issue Type: Bug
Components: Clustering
Reporter: Richard Opalka
Assignee: Paul Ferraro
Fix For: 19.0.0.Beta1
Clustering needs to eliminate usages of StabilityMonitor because SM is not reliable.
It is possible that SM will prematurely inform about achieved stability even if it is not true.
The reason is SM is not propagated up the dependencies chain and thus it may report
about achieved stability even in case dependencies chain didn't finish its processing yet
and 'real' stability wasn't achieved yet.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years
[JBoss JIRA] (WFWIP-214) Can't install more than one JDBC driver
by Jan Blizňák (Jira)
[ https://issues.jboss.org/browse/WFWIP-214?page=com.atlassian.jira.plugin.... ]
Jan Blizňák updated WFWIP-214:
------------------------------
Description:
With latest image {{docker-registry.upshift.redhat.com/kwills/eap-cd-openshift-rhel8:18.0-EAP7-1216 digest: sha256:a65337b39f0b84f803bd3f8561c2ac937bab316a7de2df50e3afe72f90906020 size: 951}} it is not possible to install more than one JDBC driver within S2I process. There is a bug in /opt/jboss/container/wildfly/s2i/install-common/install-common.sh, the /opt/eap/bin/launch/drivers.cli is always overwritten.
It should be enough to fix this line https://github.com/wildfly/wildfly-cekit-modules/blob/master/jboss/contai...
was:
With latest image {{docker-registry.upshift.redhat.com/kwills/eap-cd-openshift-rhel8:18.0-EAP7-1216
18.0-EAP7-1216: digest: sha256:a65337b39f0b84f803bd3f8561c2ac937bab316a7de2df50e3afe72f90906020 size: 951}} it is not possible to install more than one JDBC driver within S2I process. There is a bug in /opt/jboss/container/wildfly/s2i/install-common/install-common.sh, the /opt/eap/bin/launch/drivers.cli is always overwritten.
It should be enough to fix this line https://github.com/wildfly/wildfly-cekit-modules/blob/master/jboss/contai...
> Can't install more than one JDBC driver
> ---------------------------------------
>
> Key: WFWIP-214
> URL: https://issues.jboss.org/browse/WFWIP-214
> Project: WildFly WIP
> Issue Type: Bug
> Components: OpenShift
> Reporter: Jan Blizňák
> Assignee: Brian Stansberry
> Priority: Critical
>
> With latest image {{docker-registry.upshift.redhat.com/kwills/eap-cd-openshift-rhel8:18.0-EAP7-1216 digest: sha256:a65337b39f0b84f803bd3f8561c2ac937bab316a7de2df50e3afe72f90906020 size: 951}} it is not possible to install more than one JDBC driver within S2I process. There is a bug in /opt/jboss/container/wildfly/s2i/install-common/install-common.sh, the /opt/eap/bin/launch/drivers.cli is always overwritten.
> It should be enough to fix this line https://github.com/wildfly/wildfly-cekit-modules/blob/master/jboss/contai...
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years
[JBoss JIRA] (WFWIP-214) Can't install more than one JDBC driver
by Jan Blizňák (Jira)
Jan Blizňák created WFWIP-214:
---------------------------------
Summary: Can't install more than one JDBC driver
Key: WFWIP-214
URL: https://issues.jboss.org/browse/WFWIP-214
Project: WildFly WIP
Issue Type: Bug
Components: OpenShift
Reporter: Jan Blizňák
Assignee: Brian Stansberry
With latest image {{docker-registry.upshift.redhat.com/kwills/eap-cd-openshift-rhel8:18.0-EAP7-1216
18.0-EAP7-1216: digest: sha256:a65337b39f0b84f803bd3f8561c2ac937bab316a7de2df50e3afe72f90906020 size: 951}} it is not possible to install more than one JDBC driver within S2I process. There is a bug in /opt/jboss/container/wildfly/s2i/install-common/install-common.sh, the /opt/eap/bin/launch/drivers.cli is always overwritten.
It should be enough to fix this line https://github.com/wildfly/wildfly-cekit-modules/blob/master/jboss/contai...
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years