[Red Hat JIRA] (DROOLS-5920) Wrong BetaIndex offset with Or in executable-model
by Toshiya Kobayashi (Jira)
Toshiya Kobayashi created DROOLS-5920:
-----------------------------------------
Summary: Wrong BetaIndex offset with Or in executable-model
Key: DROOLS-5920
URL: https://issues.redhat.com/browse/DROOLS-5920
Project: Drools
Issue Type: Bug
Components: executable model
Affects Versions: 7.47.0.Final
Reporter: Toshiya Kobayashi
Assignee: Toshiya Kobayashi
Fix for DROOLS-5916 was not enough. LambdaConstraint.indexingDeclaration needs to be updated when an original Declaration is replaced. If not, betaIndex uses a wrong offset to retrieve a fact from a tuple.
This rule can reproduce the offset problem.
{noformat}
import org.drools.modelcompiler.domain.Person;rule R when
$e : Person(name == "Edson")
$p : Person(name == "Mark") or
( $mark : Person(name == "Mark")
and
$p : Person(age == $mark.age) )
$s: String(this == $p.name)
then
System.out.println("Found: " + $s);
end
{noformat}
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
4 years, 9 months
[Red Hat JIRA] (DROOLS-5919) KieServiceImpl is not exposing getter for kContainers map.
by Tomasz Maciejewski (Jira)
Tomasz Maciejewski created DROOLS-5919:
------------------------------------------
Summary: KieServiceImpl is not exposing getter for kContainers map.
Key: DROOLS-5919
URL: https://issues.redhat.com/browse/DROOLS-5919
Project: Drools
Issue Type: Enhancement
Components: core engine
Reporter: Tomasz Maciejewski
Assignee: Mario Fusco
KieServiceImpl is not exposing getter for kContainers map.
The scenario description:
1) Client application creates kieContainers (not classpathKContainer)
2) Client application wants to update kieContainer to the new version with updateToVersion
3) Currently it seems like there is *no* getter method exposed to retrieve an entry from kContainers map by containerId, same like getKieClasspathContainer for the classpathKContainer
Proposed solution (KieServiceImpl class):
_public KieContainer getKieContainer(String containerId) {_
_return kContainers.get(containerId);_
_}_
Is there any reason it is not exposed or it is possible to find it somewhere else?
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
4 years, 9 months
[Red Hat JIRA] (DROOLS-5778) Rule evaluation optimization : alpha node range index additional enhancements
by Kris Verlaenen (Jira)
[ https://issues.redhat.com/browse/DROOLS-5778?page=com.atlassian.jira.plug... ]
Kris Verlaenen updated DROOLS-5778:
-----------------------------------
Sprint: 2020 Week 46-48 (from Nov 9), 2020 Week 49-51 (from Nov 30), 2020 Week 52-03 (from Dec 21) (was: 2020 Week 46-48 (from Nov 9), 2020 Week 49-51 (from Nov 30))
> Rule evaluation optimization : alpha node range index additional enhancements
> -----------------------------------------------------------------------------
>
> Key: DROOLS-5778
> URL: https://issues.redhat.com/browse/DROOLS-5778
> Project: Drools
> Issue Type: Story
> Components: core engine
> Affects Versions: 7.45.0.Final
> Reporter: Toshiya Kobayashi
> Assignee: Toshiya Kobayashi
> Priority: Major
>
> Motivation: This Story follows up DROOLS-5631 to embrace additional enhancements related to alpha node range index.
> Goals: Better rule execution performance.
> Impact: Better rule execution performance. It might have slight overhead during rule build time.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
4 years, 9 months
[Red Hat JIRA] (DROOLS-5724) Fix DMN-PMML integration
by Kris Verlaenen (Jira)
[ https://issues.redhat.com/browse/DROOLS-5724?page=com.atlassian.jira.plug... ]
Kris Verlaenen updated DROOLS-5724:
-----------------------------------
Sprint: 2020 Week 46-48 (from Nov 9), 2020 Week 49-51 (from Nov 30), 2020 Week 52-03 (from Dec 21) (was: 2020 Week 46-48 (from Nov 9), 2020 Week 49-51 (from Nov 30))
> Fix DMN-PMML integration
> ------------------------
>
> Key: DROOLS-5724
> URL: https://issues.redhat.com/browse/DROOLS-5724
> Project: Drools
> Issue Type: Task
> Reporter: Gabriele Cardosi
> Assignee: Matteo Mortari
> Priority: Critical
> Labels: TrustyAI
>
> To have Trusty-PMML working withouth MVEL (i.e. drools-7.45) a fix has been made.
> Unfortunately, that modification broke DMN-PMML integration inside drools.
> -A very quick and dirty solution has been to-
> -1) expose the-
> -DMNRuntimeKB runtimeKB inside DMNRuntimeImpl-
> -2) based on the actual class at runtime, if it is "DMNRuntimeKBWrappingIKB" use a code patch the works in drools, otherwise the "kogito" one.-
> -This has been done only for extreme needs, but must be redisigned and properly implemented ASAP-
> The root cause of that is DMN ignoring the Kogito API.
> Kogito defines a _container_ class (org.kie.kogito.app.Application) that is meant to be used by all components (processes, ruleunits, decisions and predictions) to invoke the others.
> Trusty PMML fullfill this API, exposing predictive models throught the the
> {code:java}
> org.kie.kogito.app.PredictionModels.getPredictionModel(String modelName)
> {code}
> but since DMNKogito completely ignore this, a painful workaround has been needed to solve the issue.
> Instead of adding workarounds one on top of the other, a different approach on DMN side is required, respecting the constraints put by the containers.
> Having done that, the DMN-PMML integration would be automatically resolved.
> I'll be available for more explanation, if needed.
> [~evacchi] [~danielezonca] [~tirelli] FYI
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
4 years, 9 months
[Red Hat JIRA] (WFLY-14247) Error Page is not displayed when trying to access META-INF or WEB-INF
by Melvin Yam (Jira)
[ https://issues.redhat.com/browse/WFLY-14247?page=com.atlassian.jira.plugi... ]
Melvin Yam updated WFLY-14247:
------------------------------
Description:
I have a simple webapp war file with the following structure:
{quote}{{Listing archive: mywebapp.war}}{{--}}
{{Path = mywebapp.war}}
{{Type = zip}}
{{Physical Size = 1441}}{{Date Time Attr Size Compressed Name}}
{{------------------- ----- ------------ ------------ ------------------------}}
{{2020-12-23 20:09:20 ....A 18 18 error.html}}
{{2020-12-23 20:09:02 ....A 18 18 index.html}}
{{2020-12-23 20:10:13 D.... 0 0 META-INF}}
{{2020-12-23 03:16:37 ....A 39 39 META-INF\MANIFEST.MF}}
{{2020-12-23 20:12:38 D.... 0 0 WEB-INF}}
{{2020-12-23 20:12:28 D.... 0 0 WEB-INF\classes}}
{{2020-12-23 20:12:35 D.... 0 0 WEB-INF\lib}}
{{2020-12-23 20:11:54 ....A 480 248 WEB-INF\web.xml}}
{{------------------- ----- ------------ ------------ ------------------------}}
{{2020-12-23 20:12:38 555 323 4 files, 4 folders}}
{quote}
In web.xml, it defines the error page:
{quote}<web-app xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns="http://xmlns.jcp.org/xml/ns/javaee"
xsi:schemaLocation="http://xmlns.jcp.org/xml/ns/javaee http://xmlns.jcp.org/xml/ns/javaee/web-app_4_0.xsd" version="4.0">
<display-name>mywebapp</display-name>
<welcome-file-list>
<welcome-file>index.html</welcome-file>
</welcome-file-list>
<error-page>
<location>/error.html</location>
</error-page>
</web-app>
{quote}
After deploying the webapp successfully in local WildFly server.
Accessing the following URL will trigger the error page to be shown:
[http://127.0.0.1:8080/mywebapp/dummy]
[http://127.0.0.1:8080/mywebapp/META-INF/MANIFEST.MF]
[http://127.0.0.1:8080/mywebapp/META-INF/dummy/dummy]
However, the following URL will NOT trigger the error page:
[http://127.0.0.1:8080/mywebapp/META-INF]
[http://127.0.0.1:8080/mywebapp/WEB-INF]
[http://127.0.0.1:8080/mywebapp/WEB-INF/web.xml|http://127.0.0.1:8080/mywe...]
[http://127.0.0.1:8080/mywebapp/WEB-INF/dummy/dummy]
Instead, it just displays the text "404 - Not Found"
was:
I have a simple webapp war file with the following structure:
{quote}{{Listing archive: mywebapp.war}}{{--}}
{{Path = mywebapp.war}}
{{Type = zip}}
{{Physical Size = 1441}}{{Date Time Attr Size Compressed Name}}
{{------------------- ----- ------------ ------------ ------------------------}}
{{2020-12-23 20:09:20 ....A 18 18 error.html}}
{{2020-12-23 20:09:02 ....A 18 18 index.html}}
{{2020-12-23 20:10:13 D.... 0 0 META-INF}}
{{2020-12-23 03:16:37 ....A 39 39 META-INF\MANIFEST.MF}}
{{2020-12-23 20:12:38 D.... 0 0 WEB-INF}}
{{2020-12-23 20:12:28 D.... 0 0 WEB-INF\classes}}
{{2020-12-23 20:12:35 D.... 0 0 WEB-INF\lib}}
{{2020-12-23 20:11:54 ....A 480 248 WEB-INF\web.xml}}
{{------------------- ----- ------------ ------------ ------------------------}}
{{2020-12-23 20:12:38 555 323 4 files, 4 folders}}{quote}
In web.xml, it defines the error page:
{quote}{{<?xml version="1.0" encoding="UTF-8"?>}}
{{<web-app xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns="http://xmlns.jcp.org/xml/ns/javaee"}}
{{ xsi:schemaLocation="http://xmlns.jcp.org/xml/ns/javaee http://xmlns.jcp.org/xml/ns/javaee/web-app_4_0.xsd" version="4.0">}}
{{ <display-name>mywebapp</display-name>}}
{{ <welcome-file-list>}}
{{ <welcome-file>index.html</welcome-file>}}
{{ </welcome-file-list>}}
{{ <error-page>}}
{{ <location>/error.html</location>}}
{{ </error-page>}}
{{</web-app>}}{quote}
After deploying the webapp successfully in local WildFly server.
Accessing the following URL will trigger the error page to be shown:
[http://127.0.0.1:8080/mywebapp/dummy]
[http://127.0.0.1:8080/mywebapp/META-INF/MANIFEST.MF]
[http://127.0.0.1:8080/mywebapp/META-INF/dummy/dummy]
However, the following URL will NOT trigger the error page:
[http://127.0.0.1:8080/mywebapp/META-INF]
[http://127.0.0.1:8080/mywebapp/WEB-INF]
[http://127.0.0.1:8080/mywebapp/WEB-INF/web.xml|http://127.0.0.1:8080/mywe...]
[http://127.0.0.1:8080/mywebapp/WEB-INF/dummy/dummy]
Instead, it just displays the text "404 - Not Found"
> Error Page is not displayed when trying to access META-INF or WEB-INF
> ---------------------------------------------------------------------
>
> Key: WFLY-14247
> URL: https://issues.redhat.com/browse/WFLY-14247
> Project: WildFly
> Issue Type: Bug
> Affects Versions: 21.0.2.Final
> Reporter: Melvin Yam
> Assignee: Brian Stansberry
> Priority: Minor
> Attachments: mywebapp.war
>
>
> I have a simple webapp war file with the following structure:
> {quote}{{Listing archive: mywebapp.war}}{{--}}
> {{Path = mywebapp.war}}
> {{Type = zip}}
> {{Physical Size = 1441}}{{Date Time Attr Size Compressed Name}}
> {{------------------- ----- ------------ ------------ ------------------------}}
> {{2020-12-23 20:09:20 ....A 18 18 error.html}}
> {{2020-12-23 20:09:02 ....A 18 18 index.html}}
> {{2020-12-23 20:10:13 D.... 0 0 META-INF}}
> {{2020-12-23 03:16:37 ....A 39 39 META-INF\MANIFEST.MF}}
> {{2020-12-23 20:12:38 D.... 0 0 WEB-INF}}
> {{2020-12-23 20:12:28 D.... 0 0 WEB-INF\classes}}
> {{2020-12-23 20:12:35 D.... 0 0 WEB-INF\lib}}
> {{2020-12-23 20:11:54 ....A 480 248 WEB-INF\web.xml}}
> {{------------------- ----- ------------ ------------ ------------------------}}
> {{2020-12-23 20:12:38 555 323 4 files, 4 folders}}
> {quote}
>
> In web.xml, it defines the error page:
> {quote}<web-app xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns="http://xmlns.jcp.org/xml/ns/javaee"
> xsi:schemaLocation="http://xmlns.jcp.org/xml/ns/javaee http://xmlns.jcp.org/xml/ns/javaee/web-app_4_0.xsd" version="4.0">
> <display-name>mywebapp</display-name>
> <welcome-file-list>
> <welcome-file>index.html</welcome-file>
> </welcome-file-list>
> <error-page>
> <location>/error.html</location>
> </error-page>
> </web-app>
> {quote}
>
> After deploying the webapp successfully in local WildFly server.
> Accessing the following URL will trigger the error page to be shown:
> [http://127.0.0.1:8080/mywebapp/dummy]
> [http://127.0.0.1:8080/mywebapp/META-INF/MANIFEST.MF]
> [http://127.0.0.1:8080/mywebapp/META-INF/dummy/dummy]
>
> However, the following URL will NOT trigger the error page:
> [http://127.0.0.1:8080/mywebapp/META-INF]
> [http://127.0.0.1:8080/mywebapp/WEB-INF]
> [http://127.0.0.1:8080/mywebapp/WEB-INF/web.xml|http://127.0.0.1:8080/mywe...]
> [http://127.0.0.1:8080/mywebapp/WEB-INF/dummy/dummy]
> Instead, it just displays the text "404 - Not Found"
>
>
>
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
4 years, 9 months
[Red Hat JIRA] (DROOLS-5917) Use LambdaConstraint predicate information to generate better comments in ANC for DMN Alpha Network
by Luca Molteni (Jira)
Luca Molteni created DROOLS-5917:
------------------------------------
Summary: Use LambdaConstraint predicate information to generate better comments in ANC for DMN Alpha Network
Key: DROOLS-5917
URL: https://issues.redhat.com/browse/DROOLS-5917
Project: Drools
Issue Type: Bug
Components: dmn engine
Reporter: Luca Molteni
Assignee: Luca Molteni
It should be possible to put the actual constraints in comments in a generated ANC by leveraging the `PredicateInformation` class used in the executable model to give better error messages.
In the compiled alpha network, instead of
private org.drools.modelcompiler.constraints.LambdaConstraint lambdaConstraint490; // [AlphaNode(490) constraint=Constraint for '0066e054-7241-4ccd-886d-ab6d7e08a99e' (index: null)]
we should have
private org.drools.modelcompiler.constraints.LambdaConstraint lambdaConstraint490; // [AlphaNode(490) constraint=x == true" (index: null)]
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
4 years, 9 months