[JBoss JIRA] (WFLY-13808) Make HTTP server available during deployment when starting up
by Alojzij Blatnik (Jira)
[ https://issues.redhat.com/browse/WFLY-13808?page=com.atlassian.jira.plugi... ]
Alojzij Blatnik commented on WFLY-13808:
----------------------------------------
Hi.
Thanks for the information. I attached the patch here. It can be applied on top of wildfly-core, tag 12.0.3.Final.
Br.
[^diff.patch]
> Make HTTP server available during deployment when starting up
> -------------------------------------------------------------
>
> Key: WFLY-13808
> URL: https://issues.redhat.com/browse/WFLY-13808
> Project: WildFly
> Issue Type: Bug
> Affects Versions: 20.0.1.Final
> Reporter: Alojzij Blatnik
> Assignee: Brian Stansberry
> Priority: Major
> Attachments: diff.patch
>
>
> HTTP server isn't available during deployment when Wildfly is starting up. That behavior is a feature, so that HTTP server is not serving until application isn't fully deployed. That behavior causes us trouble, because we have EAR with multiple services in WARs which communicate with each other during deployment phase.
> That was introduced in Wildfly 11 and is still present in 20.0.1. I think, that this wasn't intended to behave by default (see start suspended or start normal) [https://github.com/wildfly/wildfly/blob/master/docs/src/main/asciidoc/_ad... settings actually make no difference - it starts suspended in both cases (only admin-only is honored correctly).
> I was poking around the source code (see diff.patch) and made small changes in wildfly-core to make it work, but AbstractControllerService would need to be if-elsed by desired start mode.
>
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
5 years, 1 month
[JBoss JIRA] (WFLY-13808) Make HTTP server available during deployment when starting up
by Alojzij Blatnik (Jira)
[ https://issues.redhat.com/browse/WFLY-13808?page=com.atlassian.jira.plugi... ]
Alojzij Blatnik updated WFLY-13808:
-----------------------------------
Attachment: diff.patch
> Make HTTP server available during deployment when starting up
> -------------------------------------------------------------
>
> Key: WFLY-13808
> URL: https://issues.redhat.com/browse/WFLY-13808
> Project: WildFly
> Issue Type: Bug
> Affects Versions: 20.0.1.Final
> Reporter: Alojzij Blatnik
> Assignee: Brian Stansberry
> Priority: Major
> Attachments: diff.patch
>
>
> HTTP server isn't available during deployment when Wildfly is starting up. That behavior is a feature, so that HTTP server is not serving until application isn't fully deployed. That behavior causes us trouble, because we have EAR with multiple services in WARs which communicate with each other during deployment phase.
> That was introduced in Wildfly 11 and is still present in 20.0.1. I think, that this wasn't intended to behave by default (see start suspended or start normal) [https://github.com/wildfly/wildfly/blob/master/docs/src/main/asciidoc/_ad... settings actually make no difference - it starts suspended in both cases (only admin-only is honored correctly).
> I was poking around the source code (see diff.patch) and made small changes in wildfly-core to make it work, but AbstractControllerService would need to be if-elsed by desired start mode.
>
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
5 years, 1 month
[JBoss JIRA] (WFLY-13774) Difference in OpenTracing subsystem standard configuration leads to the tests failures
by Brian Stansberry (Jira)
[ https://issues.redhat.com/browse/WFLY-13774?page=com.atlassian.jira.plugi... ]
Brian Stansberry updated WFLY-13774:
------------------------------------
Component/s: Build System
> Difference in OpenTracing subsystem standard configuration leads to the tests failures
> ---------------------------------------------------------------------------------------
>
> Key: WFLY-13774
> URL: https://issues.redhat.com/browse/WFLY-13774
> Project: WildFly
> Issue Type: Bug
> Components: Build System, MP OpenTracing
> Reporter: Sultan Zhantemirov
> Assignee: Emmanuel Hugonnet
> Priority: Major
>
> Since OpenTracing has been introduced, `standalone.xml` had the following OT SmallRye subsystem configuration:
> {noformat}
> <subsystem xmlns="urn:wildfly:microprofile-opentracing-smallrye:2.0" default-tracer="jaeger">
> <jaeger-tracer name="jaeger">
> <sampler-configuration sampler-type="const" sampler-param="1.0"/>
> </jaeger-tracer>
> </subsystem>
> {noformat}
> With WildFly 19 and later we also have `standalone-microprofile.xml` configuration file which is used by default in MicroProfile test suite [1]. It has the following configuration:
> {noformat}
> <subsystem xmlns="urn:wildfly:microprofile-opentracing-smallrye:2.0"/>
> {noformat}
> As it is recommended in documentation [2] it's better to define missing Jaeger properties (_sampler type _and _sampler param_) in order to sample every request. Sampling every request is needed by MicroProfile test suite OpenTracing basic tests.
> A question is: will `standalone-microprofile.xml` configuration file have the wider OT subsystem configuration? Or do the tests have to define additional attributes in subsystem by themselves?
> Thank you.
> [1] - https://github.com/jboss-eap-qe/eap-microprofile-test-suite#target-distri...
> [2] - https://access.redhat.com/documentation/en-us/red_hat_jboss_enterprise_ap...
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
5 years, 1 month
[JBoss JIRA] (WFLY-13808) Make HTTP server available during deployment when starting up
by Brian Stansberry (Jira)
[ https://issues.redhat.com/browse/WFLY-13808?page=com.atlassian.jira.plugi... ]
Brian Stansberry commented on WFLY-13808:
-----------------------------------------
This isn't a bug; it was deliberately done. Accepting requests over the network while the server is starting results in requests hitting incompletely started resources and getting random errors.
WFCORE-4291 is a Feature Request to add an ability to turn off this behavior; it sounds like you are looking for a similar thing.
There is no diff.patch attached. https://github.com/bstansberry/wildfly-core/tree/WFCORE-4291 is the work I did on it before I had to move away from it. If you have any suggestions they're welcome. I expect the issue will be resolved for WildFly 22.
> Make HTTP server available during deployment when starting up
> -------------------------------------------------------------
>
> Key: WFLY-13808
> URL: https://issues.redhat.com/browse/WFLY-13808
> Project: WildFly
> Issue Type: Bug
> Affects Versions: 20.0.1.Final
> Reporter: Alojzij Blatnik
> Assignee: Brian Stansberry
> Priority: Major
>
> HTTP server isn't available during deployment when Wildfly is starting up. That behavior is a feature, so that HTTP server is not serving until application isn't fully deployed. That behavior causes us trouble, because we have EAR with multiple services in WARs which communicate with each other during deployment phase.
> That was introduced in Wildfly 11 and is still present in 20.0.1. I think, that this wasn't intended to behave by default (see start suspended or start normal) [https://github.com/wildfly/wildfly/blob/master/docs/src/main/asciidoc/_ad... settings actually make no difference - it starts suspended in both cases (only admin-only is honored correctly).
> I was poking around the source code (see diff.patch) and made small changes in wildfly-core to make it work, but AbstractControllerService would need to be if-elsed by desired start mode.
>
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
5 years, 1 month
[JBoss JIRA] (WFLY-13808) Make HTTP server available during deployment when starting up
by Brian Stansberry (Jira)
[ https://issues.redhat.com/browse/WFLY-13808?page=com.atlassian.jira.plugi... ]
Brian Stansberry resolved WFLY-13808.
-------------------------------------
Resolution: Duplicate Issue
> Make HTTP server available during deployment when starting up
> -------------------------------------------------------------
>
> Key: WFLY-13808
> URL: https://issues.redhat.com/browse/WFLY-13808
> Project: WildFly
> Issue Type: Bug
> Affects Versions: 20.0.1.Final
> Reporter: Alojzij Blatnik
> Assignee: Brian Stansberry
> Priority: Major
>
> HTTP server isn't available during deployment when Wildfly is starting up. That behavior is a feature, so that HTTP server is not serving until application isn't fully deployed. That behavior causes us trouble, because we have EAR with multiple services in WARs which communicate with each other during deployment phase.
> That was introduced in Wildfly 11 and is still present in 20.0.1. I think, that this wasn't intended to behave by default (see start suspended or start normal) [https://github.com/wildfly/wildfly/blob/master/docs/src/main/asciidoc/_ad... settings actually make no difference - it starts suspended in both cases (only admin-only is honored correctly).
> I was poking around the source code (see diff.patch) and made small changes in wildfly-core to make it work, but AbstractControllerService would need to be if-elsed by desired start mode.
>
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
5 years, 1 month
[JBoss JIRA] (WFLY-13774) Difference in OpenTracing subsystem standard configuration leads to the tests failures
by Brian Stansberry (Jira)
[ https://issues.redhat.com/browse/WFLY-13774?page=com.atlassian.jira.plugi... ]
Brian Stansberry reassigned WFLY-13774:
---------------------------------------
Component/s: MP OpenTracing
(was: Build System)
Assignee: Emmanuel Hugonnet (was: Brian Stansberry)
> Difference in OpenTracing subsystem standard configuration leads to the tests failures
> ---------------------------------------------------------------------------------------
>
> Key: WFLY-13774
> URL: https://issues.redhat.com/browse/WFLY-13774
> Project: WildFly
> Issue Type: Bug
> Components: MP OpenTracing
> Reporter: Sultan Zhantemirov
> Assignee: Emmanuel Hugonnet
> Priority: Major
>
> Since OpenTracing has been introduced, `standalone.xml` had the following OT SmallRye subsystem configuration:
> {noformat}
> <subsystem xmlns="urn:wildfly:microprofile-opentracing-smallrye:2.0" default-tracer="jaeger">
> <jaeger-tracer name="jaeger">
> <sampler-configuration sampler-type="const" sampler-param="1.0"/>
> </jaeger-tracer>
> </subsystem>
> {noformat}
> With WildFly 19 and later we also have `standalone-microprofile.xml` configuration file which is used by default in MicroProfile test suite [1]. It has the following configuration:
> {noformat}
> <subsystem xmlns="urn:wildfly:microprofile-opentracing-smallrye:2.0"/>
> {noformat}
> As it is recommended in documentation [2] it's better to define missing Jaeger properties (_sampler type _and _sampler param_) in order to sample every request. Sampling every request is needed by MicroProfile test suite OpenTracing basic tests.
> A question is: will `standalone-microprofile.xml` configuration file have the wider OT subsystem configuration? Or do the tests have to define additional attributes in subsystem by themselves?
> Thank you.
> [1] - https://github.com/jboss-eap-qe/eap-microprofile-test-suite#target-distri...
> [2] - https://access.redhat.com/documentation/en-us/red_hat_jboss_enterprise_ap...
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
5 years, 1 month