[JBoss JIRA] (DROOLS-5434) Incorrect warning about file declaring wrong package
by Magnus Larsson (Jira)
[ https://issues.redhat.com/browse/DROOLS-5434?page=com.atlassian.jira.plug... ]
Magnus Larsson commented on DROOLS-5434:
----------------------------------------
[~mfusco] Absolutely, I pushed it to a public repo here: https://github.com/Miicroo/test-drools
> Incorrect warning about file declaring wrong package
> ----------------------------------------------------
>
> Key: DROOLS-5434
> URL: https://issues.redhat.com/browse/DROOLS-5434
> Project: Drools
> Issue Type: Bug
> Components: core engine
> Reporter: Magnus Larsson
> Assignee: Mario Fusco
> Priority: Major
> Attachments: image-2020-09-03-09-20-10-089.png
>
>
> I am running Drools in a Spring-Boot jar and get the following warning statement _File 'BOOT-INF/classes/com/example/test/TEST.drl' is in folder 'BOOT-INF/classes/com/example/test' but declares package 'com.example.test'. It is advised to have a correspondance between package and folder names_. The package name in the drl file is correct, the problem is just that _BOOT-INF.classes._ isn't considered when evaluating if printing the warning or not.
> I have tracked it down to *KieBuilderImpl.java*, method *isFileInKieBase*. The last 2 lines in that method calls:
> {code:java}
> // packageNameForFile prints warning if package in .drl file is not same as flatted directory structure
> // Does not care about SUPPORTED_RESOURCES_ROOTS, thus prints the warning
> String pkgNameForFile = packageNameForFile( fileName, folderNameForFile, !useFolders, file );
> // Does care about SUPPORTED_RESOURCES_ROOTS, so the drl file is loaded
> return isPackageInKieBase( kieBase, pkgNameForFile );
> {code}
> As it is implemented right now, the warning might either be a false-positive (and still get loaded), or the package is wrong (and the file is not loaded).
> Voting to include the SUPPORTED_RESOURCES_ROOTS as valid prefixes when checking if the warning should be printed.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
5 years, 1 month
[JBoss JIRA] (JGRP-2230) Multiple discovery protocols without MULTI_PING
by Bela Ban (Jira)
[ https://issues.redhat.com/browse/JGRP-2230?page=com.atlassian.jira.plugin... ]
Bela Ban resolved JGRP-2230.
----------------------------
Release Notes Text: We can now simply add multiple discovery protocols without having to add MULTI_PING to the config.
Resolution: Done
> Multiple discovery protocols without MULTI_PING
> -----------------------------------------------
>
> Key: JGRP-2230
> URL: https://issues.redhat.com/browse/JGRP-2230
> Project: JGroups
> Issue Type: Feature Request
> Reporter: Bela Ban
> Assignee: Bela Ban
> Priority: Major
> Fix For: 5.1
>
>
> Currently, {{MULTI_PING}} is needed to forward discovery requests to multiple discovery protocols. If we change the API in 5.0, and pass a {{Responses}} object down to the discovery protocols, and each discovery protocol forwards discovery requests down (and responses up), and they all add responses to the same {{Responses}} object, then we would not need {{MULTI_PING}} any longer.
> However, this is an API change, so can be done only in 5.0.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
5 years, 1 month
[JBoss JIRA] (WFWIP-346) Bootable JAR - Second bootable JAR fails to package if first uses certain layers
by Jan Kasik (Jira)
[ https://issues.redhat.com/browse/WFWIP-346?page=com.atlassian.jira.plugin... ]
Jan Kasik commented on WFWIP-346:
---------------------------------
[~jdenise] Thank you too for a quick fix! I tried it even with our new QE testsuite (where the problem first occurred) and your feature branch seems to be fixing the issue.
> Bootable JAR - Second bootable JAR fails to package if first uses certain layers
> --------------------------------------------------------------------------------
>
> Key: WFWIP-346
> URL: https://issues.redhat.com/browse/WFWIP-346
> Project: WildFly WIP
> Issue Type: Bug
> Reporter: Jan Kasik
> Assignee: Jean Francois Denise
> Priority: Critical
>
> See the reproducer: https://github.com/honza-kasik/layer-conflict - there are two Maven modules, each configured to run WildFly Maven JAR plugin.
> If I run {{mvn clean package -Dversion.org.wildfly.jar.plugin=2.0.0.Beta3}}, bootable JAR for app-one builds but for app-two the build ends up with an error and app-two fails to package:
> {noformat}
> [ERROR] Failed to execute goal org.wildfly.plugins:wildfly-jar-maven-plugin:2.0.0.Beta3:package (default) on project app-two: Provisioning failed: Failed to generate standalone.xml on {
> [ERROR] "operation" => "composite",
> [ERROR] "address" => [],
> [ERROR] "rollback-on-runtime-failure" => true,
> [ERROR] "steps" => [
> [ERROR] {
> [ERROR] "operation" => "add",
> [ERROR] "address" => [("interface" => "public")],
> [ERROR] "inet-address" => "${jboss.bind.address:127.0.0.1}"
> [ERROR] },
> [ERROR] {
> [ERROR] "operation" => "add",
> [ERROR] "address" => [("extension" => "org.wildfly.extension.bean-validation")]
> [ERROR] },
> [ERROR] {
> [ERROR] "operation" => "add",
> [ERROR] "address" => [("extension" => "org.jboss.as.weld")]
> [ERROR] },
> [ERROR] {
> [ERROR] "operation" => "add",
> [ERROR] "address" => [("extension" => "org.jboss.as.naming")]
> [ERROR] },
> [ERROR] {
> [ERROR] "operation" => "add",
> [ERROR] "address" => [("extension" => "org.jboss.as.ee")]
> [ERROR] },
> [ERROR] {
> [ERROR] "operation" => "add",
> [ERROR] "address" => [("extension" => "org.wildfly.extension.io")]
> [ERROR] },
> [ERROR] {
> [ERROR] "operation" => "add",
> [ERROR] "address" => [("extension" => "org.wildfly.extension.undertow")]
> [ERROR] },
> [ERROR] {
> [ERROR] "operation" => "add",
> [ERROR] "address" => [("extension" => "org.jboss.as.jaxrs")]
> [ERROR] }
> [ERROR] ]
> [ERROR] }: {"WFLYCTL0062: Composite operation failed and was rolled back. Steps that failed:" => {"Operation step-8" => "WFLYCTL0310: Extension module org.jboss.as.jaxrs not found"}}
> {noformat}
> Packaging when running {{mvn clean install -Dversion.org.wildfly.jar.plugin=2.0.0.Beta3 -pl app-two}} ends with success. Same for {{app-one}} only.
> If I replace layers in app-one with layer {{cloud-server}} both modules build successfully.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
5 years, 1 month
[JBoss JIRA] (DROOLS-5619) [DMN Designer] Copy/paste is not working for Decision & BusinessKnowledgeModel nodes
by Roger Martinez (Jira)
[ https://issues.redhat.com/browse/DROOLS-5619?page=com.atlassian.jira.plug... ]
Roger Martinez commented on DROOLS-5619:
----------------------------------------
Hey [~dadossan] [~karreiro] [~jomarko]
Thanks for reporting guys, and sorry for the inconveniences.
I'd increased the severity to critical (could be even blocker) and also updated the title, as the copy/paste was also failing for both _Decision_ and _BusinessKnowledgeModel_ nodes.
Let you know I'm just going to create a PR that fixes it.
Thanks!
> [DMN Designer] Copy/paste is not working for Decision & BusinessKnowledgeModel nodes
> ------------------------------------------------------------------------------------
>
> Key: DROOLS-5619
> URL: https://issues.redhat.com/browse/DROOLS-5619
> Project: Drools
> Issue Type: Bug
> Components: DMN Editor
> Reporter: Daniel José dos Santos
> Assignee: Roger Martinez
> Priority: Critical
> Labels: Stunner, drools-tools
>
> The copy/past of Decision nodes throws an exception.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
5 years, 1 month
[JBoss JIRA] (WFLY-13823) Windows Service Script stopping problems
by Martin Miller (Jira)
[ https://issues.redhat.com/browse/WFLY-13823?page=com.atlassian.jira.plugi... ]
Martin Miller commented on WFLY-13823:
--------------------------------------
Solution (Sorry to have opened an issue!)
It seems to work correctly when we specify the /controller when creating the service.
> Windows Service Script stopping problems
> ----------------------------------------
>
> Key: WFLY-13823
> URL: https://issues.redhat.com/browse/WFLY-13823
> Project: WildFly
> Issue Type: Bug
> Components: Scripts
> Affects Versions: 20.0.1.Final
> Reporter: Martin Miller
> Priority: Minor
>
> I'm trying to have two standalone instances running at the same time, and I think it works.
> The problem is that stopping service 2 stops service 1 and service 2 seems to be stuck as far as windows is concerned.
>
> I then have to kill java to be back to a normal state.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
5 years, 1 month