[Red Hat JIRA] (DROOLS-6018) Enable exec-model for moved tests in drools-test-coverage
by Toshiya Kobayashi (Jira)
[ https://issues.redhat.com/browse/DROOLS-6018?page=com.atlassian.jira.plug... ]
Toshiya Kobayashi commented on DROOLS-6018:
-------------------------------------------
Just a note: reviewing those tests...
package org.drools.mvel
Most of the tests use MVELConstraint/MVELConstraintTestUtil. We can change them to LambdaConstraint to remove drools-mvel dependency. Then we can move them to drools-core test?
package org.drools.mvel.asm
Move to drools-core test?
package org.drools.mvel.compiler
Apart from fact classes, there are a few tests.
InlineCastTest/NestedAccessorsTest (extends CommonTestMethodBase)
NodeHashingTest (KieHelper)
package org.drools.mvel.compiler.api
KnowledgeBuilderTest (directly use KnowledgeBuilder, newKieBuilder. Intentional api test... we can leave it?)
...
> Enable exec-model for moved tests in drools-test-coverage
> ---------------------------------------------------------
>
> Key: DROOLS-6018
> URL: https://issues.redhat.com/browse/DROOLS-6018
> Project: Drools
> Issue Type: Task
> Components: executable model
> Affects Versions: 7.49.0.Final
> Reporter: Toshiya Kobayashi
> Assignee: Toshiya Kobayashi
> Priority: Major
>
> DROOLS-5972 and DROOLS-6017 moved/moves unit tests from drools-mvel but these tests are still tested only for standard-drl.
> This JIRA is to ensure those moved tests to be run against exec-model so we can enhance the test coverage.
--
This message was sent by Atlassian Jira
(v8.13.1#813001)
4 years, 10 months
[Red Hat JIRA] (DROOLS-6041) "RHS doesn't have a type" error when a semicolon is missing with exec-model and mvel dialect
by Toshiya Kobayashi (Jira)
[ https://issues.redhat.com/browse/DROOLS-6041?page=com.atlassian.jira.plug... ]
Toshiya Kobayashi updated DROOLS-6041:
--------------------------------------
Sprint: 2021 Week 07-09 (from Feb 15)
Story Points: 3
> "RHS doesn't have a type" error when a semicolon is missing with exec-model and mvel dialect
> --------------------------------------------------------------------------------------------
>
> Key: DROOLS-6041
> URL: https://issues.redhat.com/browse/DROOLS-6041
> Project: Drools
> Issue Type: Bug
> Components: executable model
> Affects Versions: 7.50.0.Final
> Reporter: Toshiya Kobayashi
> Assignee: Toshiya Kobayashi
> Priority: Major
>
> With a rule like this: (See, a semicolon is missing in the "p2.age = 30" line)
> {noformat}
> rule R
> dialect "mvel"
> when
> Person(name == "Mario")
> then
> Person p2 = new Person("John");
> p2.age = 30
> insert(p2);
> end
> {noformat}
> exec-model fails with
> {noformat}
> CompilationProblemErrorResult: org.drools.mvelcompiler.MvelCompilerException: RHS doesn't have a type
> {noformat}
> while standard-drl runs successfully.
> I'm not sure if exec-model should work the same as standard-drl (treat a new line as a delimiter?), or give a better error message.
> This looks to be a rare issue but when using spreadsheet, it's possible to forget to add a semicolon. (Then users don't notice the mistake because standard-drl executes it succesfully)
--
This message was sent by Atlassian Jira
(v8.13.1#813001)
4 years, 10 months
[Red Hat JIRA] (WFLY-11638) MP Metrics - sort alphabetically /metrics output
by Rostislav Svoboda (Jira)
[ https://issues.redhat.com/browse/WFLY-11638?page=com.atlassian.jira.plugi... ]
Rostislav Svoboda commented on WFLY-11638:
------------------------------------------
Hi [~jaslee]. I'm no longer on EAP QE team, CCing [~msvehla] (EAP QE lead) to be notified about this JIRA.
WFLY is community tracker, so I think it's fine to move to Closed state + set the fix version if you will be able to identify it.
> MP Metrics - sort alphabetically /metrics output
> ------------------------------------------------
>
> Key: WFLY-11638
> URL: https://issues.redhat.com/browse/WFLY-11638
> Project: WildFly
> Issue Type: Enhancement
> Components: MP Metrics
> Reporter: Rostislav Svoboda
> Assignee: Jason Lee
> Priority: Major
>
> MP Metrics - sort alphabetically /metrics output
> When playing with https://github.com/wildfly/wildfly/pull/11949 I got upset about metrics not being sorted alphabetically or at least grouped together.
> My use case was to look at wildfly_undertow_** metrics via browser.
> base: and vendor: metrics are grouped together, WF subsystem metrics not - e.g. wildfly_undertow_** metrics were listed on 4 different places.
> If alphabetical order is not easy to be achieved, subsystem metrics should be at least grouped together.
> I know machines do not care about the order, but people have to look at /metrics too (from time to time ...).
--
This message was sent by Atlassian Jira
(v8.13.1#813001)
4 years, 10 months
[Red Hat JIRA] (DROOLS-6042) Actual text value instead of tip
by Gabriele Cardosi (Jira)
[ https://issues.redhat.com/browse/DROOLS-6042?page=com.atlassian.jira.plug... ]
Gabriele Cardosi updated DROOLS-6042:
-------------------------------------
Description:
When creating a new DataType, inside the "Name" text box a String "Insert a name" is shown.
That string is a tip, and as such should be shown, but in reality it is the actual value of that text box.
That leads to
1) when editing, the user have to cancel that string before (not expected, giving the shown message)
2) if not edited, the name of the field remains the proposed one.
If that proposed string should serve a s default/auto generated value, it would be better no not use a "do that" sentence.
Attached screens.
If a "do that" string is to be used, then it should be shown as in the "Search data type" search combo
was:
When creating a new DataType, inside the "Name" text box a String "Insert a name" is shown.
That string is a tip, and as such should be shown, but in reality it is the actual value of that text box.
That leads to
1) when editing, the user have to cancel that string before
2) if not edited, the name of the field remains the proposed one.
If that proposed string should serve a s default/auto generated value, it would be better no not use a "do that" sentence.
Attached screens.
If a "do that" string is to be used, then it should be shown as in the "Search data type" search combo
> Actual text value instead of tip
> --------------------------------
>
> Key: DROOLS-6042
> URL: https://issues.redhat.com/browse/DROOLS-6042
> Project: Drools
> Issue Type: Bug
> Affects Versions: 7.50.0.Final
> Reporter: Gabriele Cardosi
> Assignee: Mario Fusco
> Priority: Major
> Attachments: CreatedField.png, CreationField.png, ExpectedBehavior.png
>
>
> When creating a new DataType, inside the "Name" text box a String "Insert a name" is shown.
> That string is a tip, and as such should be shown, but in reality it is the actual value of that text box.
> That leads to
> 1) when editing, the user have to cancel that string before (not expected, giving the shown message)
> 2) if not edited, the name of the field remains the proposed one.
> If that proposed string should serve a s default/auto generated value, it would be better no not use a "do that" sentence.
> Attached screens.
> If a "do that" string is to be used, then it should be shown as in the "Search data type" search combo
--
This message was sent by Atlassian Jira
(v8.13.1#813001)
4 years, 10 months
[Red Hat JIRA] (DROOLS-6042) Actual text value instead of tip
by Gabriele Cardosi (Jira)
[ https://issues.redhat.com/browse/DROOLS-6042?page=com.atlassian.jira.plug... ]
Gabriele Cardosi updated DROOLS-6042:
-------------------------------------
Description:
When creating a new DataType, inside the "Name" text box a String "Insert a name" is shown.
That string is a tip, and as such should be shown, but in reality it is the actual value of that text box.
That leads to
1) when editing, the user have to cancel that string before
2) if not edited, the name of the field remains the proposed one.
If that proposed string should serve a s default/auto generated value, it would be better no not use a "do that" sentence.
Attached screens.
If a "do that" string is to be used, then it should be shown as in the "Search data type" search combo
was:
When creating a new DataType, inside the "Name" text box a String "Insert a name" is shown.
That string is a tip, and as such should be shown, but in reality it is the actual value of that text box.
That leads to
1) when editing, the user have to cancel that string before
2) if not edited, the name of the field remains the proposed one.
If that proposed string should serve a s default/autogenerated value, it would be better no not use a "do that" sentence.
Attached screens
> Actual text value instead of tip
> --------------------------------
>
> Key: DROOLS-6042
> URL: https://issues.redhat.com/browse/DROOLS-6042
> Project: Drools
> Issue Type: Bug
> Affects Versions: 7.50.0.Final
> Reporter: Gabriele Cardosi
> Assignee: Mario Fusco
> Priority: Major
> Attachments: CreatedField.png, CreationField.png, ExpectedBehavior.png
>
>
> When creating a new DataType, inside the "Name" text box a String "Insert a name" is shown.
> That string is a tip, and as such should be shown, but in reality it is the actual value of that text box.
> That leads to
> 1) when editing, the user have to cancel that string before
> 2) if not edited, the name of the field remains the proposed one.
> If that proposed string should serve a s default/auto generated value, it would be better no not use a "do that" sentence.
> Attached screens.
> If a "do that" string is to be used, then it should be shown as in the "Search data type" search combo
--
This message was sent by Atlassian Jira
(v8.13.1#813001)
4 years, 10 months
[Red Hat JIRA] (DROOLS-6042) Actual text value instead of tip
by Gabriele Cardosi (Jira)
[ https://issues.redhat.com/browse/DROOLS-6042?page=com.atlassian.jira.plug... ]
Gabriele Cardosi updated DROOLS-6042:
-------------------------------------
Attachment: ExpectedBehavior.png
> Actual text value instead of tip
> --------------------------------
>
> Key: DROOLS-6042
> URL: https://issues.redhat.com/browse/DROOLS-6042
> Project: Drools
> Issue Type: Bug
> Affects Versions: 7.50.0.Final
> Reporter: Gabriele Cardosi
> Assignee: Mario Fusco
> Priority: Major
> Attachments: CreatedField.png, CreationField.png, ExpectedBehavior.png
>
>
> When creating a new DataType, inside the "Name" text box a String "Insert a name" is shown.
> That string is a tip, and as such should be shown, but in reality it is the actual value of that text box.
> That leads to
> 1) when editing, the user have to cancel that string before
> 2) if not edited, the name of the field remains the proposed one.
> If that proposed string should serve a s default/autogenerated value, it would be better no not use a "do that" sentence.
> Attached screens
--
This message was sent by Atlassian Jira
(v8.13.1#813001)
4 years, 10 months
[Red Hat JIRA] (DROOLS-6042) Actual text value instead of tip
by Gabriele Cardosi (Jira)
[ https://issues.redhat.com/browse/DROOLS-6042?page=com.atlassian.jira.plug... ]
Gabriele Cardosi updated DROOLS-6042:
-------------------------------------
Attachment: CreatedField.png
> Actual text value instead of tip
> --------------------------------
>
> Key: DROOLS-6042
> URL: https://issues.redhat.com/browse/DROOLS-6042
> Project: Drools
> Issue Type: Bug
> Affects Versions: 7.50.0.Final
> Reporter: Gabriele Cardosi
> Assignee: Mario Fusco
> Priority: Major
> Attachments: CreatedField.png, CreationField.png, ExpectedBehavior.png
>
>
> When creating a new DataType, inside the "Name" text box a String "Insert a name" is shown.
> That string is a tip, and as such should be shown, but in reality it is the actual value of that text box.
> That leads to
> 1) when editing, the user have to cancel that string before
> 2) if not edited, the name of the field remains the proposed one.
> If that proposed string should serve a s default/autogenerated value, it would be better no not use a "do that" sentence.
> Attached screens
--
This message was sent by Atlassian Jira
(v8.13.1#813001)
4 years, 10 months
[Red Hat JIRA] (DROOLS-6042) Actual text value instead of tip
by Gabriele Cardosi (Jira)
[ https://issues.redhat.com/browse/DROOLS-6042?page=com.atlassian.jira.plug... ]
Gabriele Cardosi updated DROOLS-6042:
-------------------------------------
Attachment: CreationField.png
> Actual text value instead of tip
> --------------------------------
>
> Key: DROOLS-6042
> URL: https://issues.redhat.com/browse/DROOLS-6042
> Project: Drools
> Issue Type: Bug
> Affects Versions: 7.50.0.Final
> Reporter: Gabriele Cardosi
> Assignee: Mario Fusco
> Priority: Major
> Attachments: CreationField.png
>
>
> When creating a new DataType, inside the "Name" text box a String "Insert a name" is shown.
> That string is a tip, and as such should be shown, but in reality it is the actual value of that text box.
> That leads to
> 1) when editing, the user have to cancel that string before
> 2) if not edited, the name of the field remains the proposed one.
> If that proposed string should serve a s default/autogenerated value, it would be better no not use a "do that" sentence.
> Attached screens
--
This message was sent by Atlassian Jira
(v8.13.1#813001)
4 years, 10 months
[Red Hat JIRA] (DROOLS-6042) Actual text value instead of tip
by Gabriele Cardosi (Jira)
Gabriele Cardosi created DROOLS-6042:
----------------------------------------
Summary: Actual text value instead of tip
Key: DROOLS-6042
URL: https://issues.redhat.com/browse/DROOLS-6042
Project: Drools
Issue Type: Bug
Affects Versions: 7.50.0.Final
Reporter: Gabriele Cardosi
Assignee: Mario Fusco
When creating a new DataType, inside the "Name" text box a String "Insert a name" is shown.
That string is a tip, and as such should be shown, but in reality it is the actual value of that text box.
That leads to
1) when editing, the user have to cancel that string before
2) if not edited, the name of the field remains the proposed one.
If that proposed string should serve a s default/autogenerated value, it would be better no not use a "do that" sentence.
Attached screens
--
This message was sent by Atlassian Jira
(v8.13.1#813001)
4 years, 10 months