[ https://jira.jboss.org/jira/browse/JBPORTAL-2226?page=com.atlassian.jira.... ] Prabhat Jha updated JBPORTAL-2226: ---------------------------------- Summary: Clicking on potlet window decorator does not seem to work all the time on IE7 (was: Clicking on potlet window decorator does not seem to work all the time) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBPORTAL-2226?page=com.atlassian.jira.... ] Work on JBPORTAL-2226 started by Wesley Hales. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBPORTAL-2226?page=com.atlassian.jira.... ] Chris Laprun reopened JBPORTAL-2226: ------------------------------------ Several things. First, this hasn't been commited to 2.6 branch. Second, this breaks in AJAX context. Looking at it now. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBPORTAL-2226?page=com.atlassian.jira.... ] Chris Laprun commented on JBPORTAL-2226: ---------------------------------------- This solution won't work in existing themes (in particular, the ones bundled with Portal, apart from Renewal). -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBPORTAL-2226?page=com.atlassian.jira.... ] Chris Laprun commented on JBPORTAL-2226: ---------------------------------------- Initial rendering is broken in IE 6 at least, title and decorations render too high. Interestingly, as soon as you start a DnD operation, this gets right. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBPORTAL-2226?page=com.atlassian.jira.... ] Wesley Hales commented on JBPORTAL-2226: ---------------------------------------- Thanks for looking into this Chris, lets see If I can address all of your comments: Unfortunately the changes you made do not work in IE 7 (or any browser for that matter). An easy way to test this is with any browser is to click directly on a mode button and without letting go of the mouse button, try to drag the window. If the window drags, this problem has not been fixed. This MUST be handled in the markup because of portlet-mode-container being contained in the dnd-handle/dyna-decoration in the DynaDecorationRenderer. I have looked at this problem many times (and provided 2 different fixes, err proposals ;) and we can either choose to fix it by changing the markup (via default renderers) or let IE7 users deal with erratic mode button behavior. And as you can see in my first comment, my goal was to keep this transitional markup valid as well. - This solution will work with existing themes. The themes are responsible for making changes that adapt to any new stuff coming from the renderer. Luckily, the change I made doesn't mess up the DOM at a top level. We simply need to move the portlet-mode-container outside of the handle. This should be an easy fix for each theme to adapt to. - The only other way I can think to handle this is to surgically remove/insert the mode-container via the DOM using javascript. - You said the "AJAX context" broke due to my change. What exactly broke? This change should be markup moving only, I didn't touch any functional pieces. But I may have missed an unclosed div or something. Regardless, we need a solution based on the current renderer system going forward. What do you propose? - JBPORTAL-2327 was due to this change. We just need to use something better instead of DynaRenderOptions to see which title should be rendered. This is the tricky sot in the code trying not to break what customers may depend on this embedded markup that is rendered. - "Initial rendering is broken in IE 6 at least, title and decorations render too high" I fixed the title, but the mode buttons are still a little too high. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBPORTAL-2226?page=com.atlassian.jira.... ] Chris Laprun commented on JBPORTAL-2226: ---------------------------------------- Concerning the DnD that occurs if you initiate it by clicking on the mode button and not releasing the mouse button, I think this is a marginal use case. Granted, it'd be nice if we could have a cleaner solution but it's not worth requiring an update to all the themes and renderer implementations at this point. If that's the only problem, then consider this case closed. Please make sure that DnD works properly while dragging from the title bar in IE 7. It works well enough in Safari, Firefox and IE 6. If it works as well in IE 7 (which I have no way to test), I'll close this issue. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBPORTAL-2226?page=com.atlassian.jira.... ] Wesley Hales commented on JBPORTAL-2226: ---------------------------------------- Ok, it looks like this may work. This is good enough for me. If people complain, let's just write another renderer. However, the handle only takes up half of the title bar, usability wise this sucks, but is the best we can get for what we have to work with. - Don't forget to copy to 2.6 branch -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira