[JBoss JIRA] (WFCORE-1855) Possible NPE on controller service start
by David Lloyd (JIRA)
David Lloyd created WFCORE-1855:
-----------------------------------
Summary: Possible NPE on controller service start
Key: WFCORE-1855
URL: https://issues.jboss.org/browse/WFCORE-1855
Project: WildFly Core
Issue Type: Bug
Reporter: David Lloyd
In {{org.jboss.as.controller.AbstractControllerService}}, the {{start}} method starts up a background thread which performs a certain amount of the boot process. Before this thread is started, a volatile field {{controller}} is initialized with the controller reported by the {{start()}} method.
Inside this thread, some work is performed, and at the end of a certain amount of work, the {{finishBoot()}} method is invoked. This method calls {{controller.finishBoot()}}, referencing the field that was set in the {{start()}} method.
The problem arises when the service itself is stopped before the boot thread completes. This causes the {{controller}} field to be nulled out, resulting in an NPE.
I think we need to look at:
* Why are we using a background thread for this?
* Why are we _not_ using the asynchronous startup feature?
I think we must do one of these two things in order to make this code "safe".
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
9 years, 7 months
[JBoss JIRA] (WFCORE-1854) Wrong result on :browse-content(depth>0) on archived deployments deployed by deployment scanner
by Brian Stansberry (JIRA)
[ https://issues.jboss.org/browse/WFCORE-1854?page=com.atlassian.jira.plugi... ]
Brian Stansberry reassigned WFCORE-1854:
----------------------------------------
Assignee: ehsavoie Hugonnet (was: Brian Stansberry)
> Wrong result on :browse-content(depth>0) on archived deployments deployed by deployment scanner
> -----------------------------------------------------------------------------------------------
>
> Key: WFCORE-1854
> URL: https://issues.jboss.org/browse/WFCORE-1854
> Project: WildFly Core
> Issue Type: Bug
> Components: Domain Management
> Affects Versions: 3.0.0.Alpha9
> Reporter: Michal Jurc
> Assignee: ehsavoie Hugonnet
>
> With archived deployment deployed by deployment scanner, the {{/deployment=jboss-kitchensink-ear.ear:browse-content(depth=1)}} command returns the following result:
> {code}{
> "outcome" => "success",
> "result" => [
> {
> "path" => "META-INF/",
> "directory" => true
> },
> {
> "path" => "META-INF/MANIFEST.MF",
> "directory" => false,
> "file-size" => 130L
> },
> {
> "path" => "jboss-kitchensink-ear-web.war",
> "directory" => false,
> "file-size" => 63190L
> },
> {
> "path" => "jboss-kitchensink-ear-ejb.jar",
> "directory" => false,
> "file-size" => 12256L
> },
> {
> "path" => "META-INF/application.xml",
> "directory" => false,
> "file-size" => 802L
> },
> {
> "path" => "META-INF/kitchensink-ear-quickstart-ds.xml",
> "directory" => false,
> "file-size" => 1955L
> },
> {
> "path" => "META-INF/maven/org.jboss.quickstarts.eap/jboss-kitchensink-ear-ear/pom.xml",
> "directory" => false,
> "file-size" => 5582L
> },
> {
> "path" => "META-INF/maven/org.jboss.quickstarts.eap/jboss-kitchensink-ear-ear/pom.properties",
> "directory" => false,
> "file-size" => 143L
> }
> ]
> }
> {code}
> WFCORE-1851 does not fix this.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
9 years, 7 months
[JBoss JIRA] (WFCORE-1854) Wrong result on :browse-content(depth>0) on archived deployments deployed by deployment scanner
by Michal Jurc (JIRA)
[ https://issues.jboss.org/browse/WFCORE-1854?page=com.atlassian.jira.plugi... ]
Michal Jurc updated WFCORE-1854:
--------------------------------
Description:
With archived deployment deployed by deployment scanner, the {{/deployment=jboss-kitchensink-ear.ear:browse-content(depth=1)}} command returns the following result:
{code}{
"outcome" => "success",
"result" => [
{
"path" => "META-INF/",
"directory" => true
},
{
"path" => "META-INF/MANIFEST.MF",
"directory" => false,
"file-size" => 130L
},
{
"path" => "jboss-kitchensink-ear-web.war",
"directory" => false,
"file-size" => 63190L
},
{
"path" => "jboss-kitchensink-ear-ejb.jar",
"directory" => false,
"file-size" => 12256L
},
{
"path" => "META-INF/application.xml",
"directory" => false,
"file-size" => 802L
},
{
"path" => "META-INF/kitchensink-ear-quickstart-ds.xml",
"directory" => false,
"file-size" => 1955L
},
{
"path" => "META-INF/maven/org.jboss.quickstarts.eap/jboss-kitchensink-ear-ear/pom.xml",
"directory" => false,
"file-size" => 5582L
},
{
"path" => "META-INF/maven/org.jboss.quickstarts.eap/jboss-kitchensink-ear-ear/pom.properties",
"directory" => false,
"file-size" => 143L
}
]
}
{code}
WFCORE-1851 does not fix this.
was:
With archived deployment deployed by deployment scanner, the {{/deployment=jboss-kitchensink-ear.ear:browse-content(depth=1)}} command returns the following result:
{code}{
"outcome" => "success",
"result" => [
{
"path" => "META-INF/",
"directory" => true
},
{
"path" => "META-INF/MANIFEST.MF",
"directory" => false,
"file-size" => 130L
},
{
"path" => "jboss-kitchensink-ear-web.war",
"directory" => false,
"file-size" => 63190L
},
{
"path" => "jboss-kitchensink-ear-ejb.jar",
"directory" => false,
"file-size" => 12256L
},
{
"path" => "META-INF/application.xml",
"directory" => false,
"file-size" => 802L
},
{
"path" => "META-INF/kitchensink-ear-quickstart-ds.xml",
"directory" => false,
"file-size" => 1955L
},
{
"path" => "META-INF/maven/org.jboss.quickstarts.eap/jboss-kitchensink-ear-ear/pom.xml",
"directory" => false,
"file-size" => 5582L
},
{
"path" => "META-INF/maven/org.jboss.quickstarts.eap/jboss-kitchensink-ear-ear/pom.properties",
"directory" => false,
"file-size" => 143L
}
]
}
{code}
> Wrong result on :browse-content(depth>0) on archived deployments deployed by deployment scanner
> -----------------------------------------------------------------------------------------------
>
> Key: WFCORE-1854
> URL: https://issues.jboss.org/browse/WFCORE-1854
> Project: WildFly Core
> Issue Type: Bug
> Components: Domain Management
> Affects Versions: 3.0.0.Alpha9
> Reporter: Michal Jurc
> Assignee: Brian Stansberry
>
> With archived deployment deployed by deployment scanner, the {{/deployment=jboss-kitchensink-ear.ear:browse-content(depth=1)}} command returns the following result:
> {code}{
> "outcome" => "success",
> "result" => [
> {
> "path" => "META-INF/",
> "directory" => true
> },
> {
> "path" => "META-INF/MANIFEST.MF",
> "directory" => false,
> "file-size" => 130L
> },
> {
> "path" => "jboss-kitchensink-ear-web.war",
> "directory" => false,
> "file-size" => 63190L
> },
> {
> "path" => "jboss-kitchensink-ear-ejb.jar",
> "directory" => false,
> "file-size" => 12256L
> },
> {
> "path" => "META-INF/application.xml",
> "directory" => false,
> "file-size" => 802L
> },
> {
> "path" => "META-INF/kitchensink-ear-quickstart-ds.xml",
> "directory" => false,
> "file-size" => 1955L
> },
> {
> "path" => "META-INF/maven/org.jboss.quickstarts.eap/jboss-kitchensink-ear-ear/pom.xml",
> "directory" => false,
> "file-size" => 5582L
> },
> {
> "path" => "META-INF/maven/org.jboss.quickstarts.eap/jboss-kitchensink-ear-ear/pom.properties",
> "directory" => false,
> "file-size" => 143L
> }
> ]
> }
> {code}
> WFCORE-1851 does not fix this.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
9 years, 7 months
[JBoss JIRA] (WFCORE-1854) Wrong result on :browse-content(depth>0) on archived deployments deployed by deployment scanner
by Michal Jurc (JIRA)
[ https://issues.jboss.org/browse/WFCORE-1854?page=com.atlassian.jira.plugi... ]
Michal Jurc updated WFCORE-1854:
--------------------------------
Description:
With archived deployment deployed by deployment scanner, the {{/deployment=jboss-kitchensink-ear.ear:browse-content(depth=1)}} command returns the following result:
{code}{
"outcome" => "success",
"result" => [
{
"path" => "META-INF/",
"directory" => true
},
{
"path" => "META-INF/MANIFEST.MF",
"directory" => false,
"file-size" => 130L
},
{
"path" => "jboss-kitchensink-ear-web.war",
"directory" => false,
"file-size" => 63190L
},
{
"path" => "jboss-kitchensink-ear-ejb.jar",
"directory" => false,
"file-size" => 12256L
},
{
"path" => "META-INF/application.xml",
"directory" => false,
"file-size" => 802L
},
{
"path" => "META-INF/kitchensink-ear-quickstart-ds.xml",
"directory" => false,
"file-size" => 1955L
},
{
"path" => "META-INF/maven/org.jboss.quickstarts.eap/jboss-kitchensink-ear-ear/pom.xml",
"directory" => false,
"file-size" => 5582L
},
{
"path" => "META-INF/maven/org.jboss.quickstarts.eap/jboss-kitchensink-ear-ear/pom.properties",
"directory" => false,
"file-size" => 143L
}
]
}
{code}
WFCORE-1851 does not fix this.
was:
With archived deployment deployed by deployment scanner, the {{/deployment=jboss-kitchensink-ear.ear:browse-content(depth=1)}} command returns the following result:
{code}{
"outcome" => "success",
"result" => [
{
"path" => "META-INF/",
"directory" => true
},
{
"path" => "META-INF/MANIFEST.MF",
"directory" => false,
"file-size" => 130L
},
{
"path" => "jboss-kitchensink-ear-web.war",
"directory" => false,
"file-size" => 63190L
},
{
"path" => "jboss-kitchensink-ear-ejb.jar",
"directory" => false,
"file-size" => 12256L
},
{
"path" => "META-INF/application.xml",
"directory" => false,
"file-size" => 802L
},
{
"path" => "META-INF/kitchensink-ear-quickstart-ds.xml",
"directory" => false,
"file-size" => 1955L
},
{
"path" => "META-INF/maven/org.jboss.quickstarts.eap/jboss-kitchensink-ear-ear/pom.xml",
"directory" => false,
"file-size" => 5582L
},
{
"path" => "META-INF/maven/org.jboss.quickstarts.eap/jboss-kitchensink-ear-ear/pom.properties",
"directory" => false,
"file-size" => 143L
}
]
}
{code}
WFCORE-1851 does not fix this.
> Wrong result on :browse-content(depth>0) on archived deployments deployed by deployment scanner
> -----------------------------------------------------------------------------------------------
>
> Key: WFCORE-1854
> URL: https://issues.jboss.org/browse/WFCORE-1854
> Project: WildFly Core
> Issue Type: Bug
> Components: Domain Management
> Affects Versions: 3.0.0.Alpha9
> Reporter: Michal Jurc
> Assignee: Brian Stansberry
>
> With archived deployment deployed by deployment scanner, the {{/deployment=jboss-kitchensink-ear.ear:browse-content(depth=1)}} command returns the following result:
> {code}{
> "outcome" => "success",
> "result" => [
> {
> "path" => "META-INF/",
> "directory" => true
> },
> {
> "path" => "META-INF/MANIFEST.MF",
> "directory" => false,
> "file-size" => 130L
> },
> {
> "path" => "jboss-kitchensink-ear-web.war",
> "directory" => false,
> "file-size" => 63190L
> },
> {
> "path" => "jboss-kitchensink-ear-ejb.jar",
> "directory" => false,
> "file-size" => 12256L
> },
> {
> "path" => "META-INF/application.xml",
> "directory" => false,
> "file-size" => 802L
> },
> {
> "path" => "META-INF/kitchensink-ear-quickstart-ds.xml",
> "directory" => false,
> "file-size" => 1955L
> },
> {
> "path" => "META-INF/maven/org.jboss.quickstarts.eap/jboss-kitchensink-ear-ear/pom.xml",
> "directory" => false,
> "file-size" => 5582L
> },
> {
> "path" => "META-INF/maven/org.jboss.quickstarts.eap/jboss-kitchensink-ear-ear/pom.properties",
> "directory" => false,
> "file-size" => 143L
> }
> ]
> }
> {code}
> WFCORE-1851 does not fix this.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
9 years, 7 months
[JBoss JIRA] (WFCORE-1854) Wrong result on :browse-content(depth>0) on archived deployments deployed by deployment scanner
by Michal Jurc (JIRA)
[ https://issues.jboss.org/browse/WFCORE-1854?page=com.atlassian.jira.plugi... ]
Michal Jurc moved JBEAP-6306 to WFCORE-1854:
--------------------------------------------
Project: WildFly Core (was: JBoss Enterprise Application Platform)
Key: WFCORE-1854 (was: JBEAP-6306)
Workflow: GIT Pull Request workflow (was: CDW with loose statuses v1)
Component/s: Domain Management
(was: Domain Management)
Affects Version/s: 3.0.0.Alpha9
(was: 7.1.0.DR5)
(was: 7.1.0.DR6)
> Wrong result on :browse-content(depth>0) on archived deployments deployed by deployment scanner
> -----------------------------------------------------------------------------------------------
>
> Key: WFCORE-1854
> URL: https://issues.jboss.org/browse/WFCORE-1854
> Project: WildFly Core
> Issue Type: Bug
> Components: Domain Management
> Affects Versions: 3.0.0.Alpha9
> Reporter: Michal Jurc
> Assignee: Brian Stansberry
>
> With archived deployment deployed by deployment scanner, the {{/deployment=jboss-kitchensink-ear.ear:browse-content(depth=1)}} command returns the following result:
> {code}{
> "outcome" => "success",
> "result" => [
> {
> "path" => "META-INF/",
> "directory" => true
> },
> {
> "path" => "META-INF/MANIFEST.MF",
> "directory" => false,
> "file-size" => 130L
> },
> {
> "path" => "jboss-kitchensink-ear-web.war",
> "directory" => false,
> "file-size" => 63190L
> },
> {
> "path" => "jboss-kitchensink-ear-ejb.jar",
> "directory" => false,
> "file-size" => 12256L
> },
> {
> "path" => "META-INF/application.xml",
> "directory" => false,
> "file-size" => 802L
> },
> {
> "path" => "META-INF/kitchensink-ear-quickstart-ds.xml",
> "directory" => false,
> "file-size" => 1955L
> },
> {
> "path" => "META-INF/maven/org.jboss.quickstarts.eap/jboss-kitchensink-ear-ear/pom.xml",
> "directory" => false,
> "file-size" => 5582L
> },
> {
> "path" => "META-INF/maven/org.jboss.quickstarts.eap/jboss-kitchensink-ear-ear/pom.properties",
> "directory" => false,
> "file-size" => 143L
> }
> ]
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
9 years, 7 months
[JBoss JIRA] (WFCORE-1851) Inconsistent behaviour with browse-content(depth=1) operation between archived and exploded deployments
by Michal Jurc (JIRA)
[ https://issues.jboss.org/browse/WFCORE-1851?page=com.atlassian.jira.plugi... ]
Michal Jurc updated WFCORE-1851:
--------------------------------
Comment: was deleted
(was: The behaviour is still inconsistent for archived deployments deployed through deployment scanner.)
> Inconsistent behaviour with browse-content(depth=1) operation between archived and exploded deployments
> -------------------------------------------------------------------------------------------------------
>
> Key: WFCORE-1851
> URL: https://issues.jboss.org/browse/WFCORE-1851
> Project: WildFly Core
> Issue Type: Bug
> Components: Domain Management
> Affects Versions: 3.0.0.Alpha9
> Reporter: Michal Jurc
> Assignee: ehsavoie Hugonnet
> Fix For: 3.0.0.Alpha10
>
> Attachments: jboss-kitchensink-ear.ear
>
>
> {{/deployment=jboss-kitchensink-ear.ear:browse-content(depth=1)}} operation returns inconsistent result depending on whether the deployment is exploded or not. Deployment attached.
> Archived:
> {code}{
> "outcome" => "success",
> "result" => [
> {
> "path" => "jboss-kitchensink-ear-web.war",
> "directory" => false,
> "file-size" => 63190L
> },
> {
> "path" => "jboss-kitchensink-ear-ejb.jar",
> "directory" => false,
> "file-size" => 12256L
> },
> {
> "path" => "META-INF/",
> "directory" => true
> }
> ]
> }
> {code}
> Exploded:
> {code}{
> "outcome" => "success",
> "result" => [
> {
> "path" => "META-INF/",
> "directory" => true
> },
> {
> "path" => "META-INF/MANIFEST.MF",
> "directory" => false,
> "file-size" => 130L
> },
> {
> "path" => "jboss-kitchensink-ear-web.war",
> "directory" => false,
> "file-size" => 63190L
> },
> {
> "path" => "jboss-kitchensink-ear-ejb.jar",
> "directory" => false,
> "file-size" => 12256L
> },
> {
> "path" => "META-INF/application.xml",
> "directory" => false,
> "file-size" => 802L
> },
> {
> "path" => "META-INF/kitchensink-ear-quickstart-ds.xml",
> "directory" => false,
> "file-size" => 1955L
> },
> {
> "path" => "META-INF/maven/org.jboss.quickstarts.eap/jboss-kitchensink-ear-ear/pom.xml",
> "directory" => false,
> "file-size" => 5582L
> },
> {
> "path" => "META-INF/maven/org.jboss.quickstarts.eap/jboss-kitchensink-ear-ear/pom.properties",
> "directory" => false,
> "file-size" => 143L
> }
> ]
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
9 years, 7 months
[JBoss JIRA] (WFCORE-1851) Inconsistent behaviour with browse-content(depth=1) operation between archived and exploded deployments
by Michal Jurc (JIRA)
[ https://issues.jboss.org/browse/WFCORE-1851?page=com.atlassian.jira.plugi... ]
Michal Jurc commented on WFCORE-1851:
-------------------------------------
The behaviour is still inconsistent for archived deployments deployed through deployment scanner.
> Inconsistent behaviour with browse-content(depth=1) operation between archived and exploded deployments
> -------------------------------------------------------------------------------------------------------
>
> Key: WFCORE-1851
> URL: https://issues.jboss.org/browse/WFCORE-1851
> Project: WildFly Core
> Issue Type: Bug
> Components: Domain Management
> Affects Versions: 3.0.0.Alpha9
> Reporter: Michal Jurc
> Assignee: ehsavoie Hugonnet
> Fix For: 3.0.0.Alpha10
>
> Attachments: jboss-kitchensink-ear.ear
>
>
> {{/deployment=jboss-kitchensink-ear.ear:browse-content(depth=1)}} operation returns inconsistent result depending on whether the deployment is exploded or not. Deployment attached.
> Archived:
> {code}{
> "outcome" => "success",
> "result" => [
> {
> "path" => "jboss-kitchensink-ear-web.war",
> "directory" => false,
> "file-size" => 63190L
> },
> {
> "path" => "jboss-kitchensink-ear-ejb.jar",
> "directory" => false,
> "file-size" => 12256L
> },
> {
> "path" => "META-INF/",
> "directory" => true
> }
> ]
> }
> {code}
> Exploded:
> {code}{
> "outcome" => "success",
> "result" => [
> {
> "path" => "META-INF/",
> "directory" => true
> },
> {
> "path" => "META-INF/MANIFEST.MF",
> "directory" => false,
> "file-size" => 130L
> },
> {
> "path" => "jboss-kitchensink-ear-web.war",
> "directory" => false,
> "file-size" => 63190L
> },
> {
> "path" => "jboss-kitchensink-ear-ejb.jar",
> "directory" => false,
> "file-size" => 12256L
> },
> {
> "path" => "META-INF/application.xml",
> "directory" => false,
> "file-size" => 802L
> },
> {
> "path" => "META-INF/kitchensink-ear-quickstart-ds.xml",
> "directory" => false,
> "file-size" => 1955L
> },
> {
> "path" => "META-INF/maven/org.jboss.quickstarts.eap/jboss-kitchensink-ear-ear/pom.xml",
> "directory" => false,
> "file-size" => 5582L
> },
> {
> "path" => "META-INF/maven/org.jboss.quickstarts.eap/jboss-kitchensink-ear-ear/pom.properties",
> "directory" => false,
> "file-size" => 143L
> }
> ]
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
9 years, 7 months