[JBoss JIRA] (WFCORE-1854) Wrong result on :browse-content(depth>0) on archived deployments deployed by deployment scanner
by ehsavoie Hugonnet (JIRA)
[ https://issues.jboss.org/browse/WFCORE-1854?page=com.atlassian.jira.plugi... ]
ehsavoie Hugonnet commented on WFCORE-1854:
-------------------------------------------
I don't reproduce it on upstream master (with the fix for WFCORE-1851) :
{code:java}
[standalone@localhost:9990 /] /deployment=wildfly-kitchensink-ear.ear:read-resource(include-runtime)
{
"outcome" => "success",
"result" => {
"content" => [{"hash" => bytes {
0x3e, 0x04, 0x34, 0xd7, 0xd4, 0x5f, 0x5a, 0x92,
0xd4, 0x1a, 0x81, 0x96, 0x67, 0xdb, 0x53, 0x4f,
0x8f, 0xdb, 0xf6, 0x31
}}],
"disabled-time" => 1475676768425L,
"disabled-timestamp" => "2016-10-05 16:12:48,425 CEST",
"enabled" => false,
"enabled-time" => 1475676724207L,
"enabled-timestamp" => "2016-10-05 16:12:04,207 CEST",
"managed" => true,
"name" => "wildfly-kitchensink-ear.ear",
"owner" => [
("subsystem" => "deployment-scanner"),
("scanner" => "default")
],
"persistent" => false,
"runtime-name" => "wildfly-kitchensink-ear.ear",
"status" => "STOPPED",
"subdeployment" => undefined,
"subsystem" => undefined
}
}
deployment=wildfly-kitchensink-ear.ear:browse-content(depth=1)
{
"outcome" => "success",
"result" => [
{
"path" => "META-INF/",
"directory" => true
},
{
"path" => "wildfly-kitchensink-ear-web.war",
"directory" => false,
"file-size" => 63332L
},
{
"path" => "wildfly-kitchensink-ear-ejb.jar",
"directory" => false,
"file-size" => 12128L
}
]
{code}
> Wrong result on :browse-content(depth>0) on archived deployments deployed by deployment scanner
> -----------------------------------------------------------------------------------------------
>
> Key: WFCORE-1854
> URL: https://issues.jboss.org/browse/WFCORE-1854
> Project: WildFly Core
> Issue Type: Bug
> Components: Domain Management
> Affects Versions: 3.0.0.Alpha9
> Reporter: Michal Jurc
> Assignee: ehsavoie Hugonnet
>
> With archived deployment deployed by deployment scanner, the {{/deployment=jboss-kitchensink-ear.ear:browse-content(depth=1)}} command returns the following result:
> {code}{
> "outcome" => "success",
> "result" => [
> {
> "path" => "META-INF/",
> "directory" => true
> },
> {
> "path" => "META-INF/MANIFEST.MF",
> "directory" => false,
> "file-size" => 130L
> },
> {
> "path" => "jboss-kitchensink-ear-web.war",
> "directory" => false,
> "file-size" => 63190L
> },
> {
> "path" => "jboss-kitchensink-ear-ejb.jar",
> "directory" => false,
> "file-size" => 12256L
> },
> {
> "path" => "META-INF/application.xml",
> "directory" => false,
> "file-size" => 802L
> },
> {
> "path" => "META-INF/kitchensink-ear-quickstart-ds.xml",
> "directory" => false,
> "file-size" => 1955L
> },
> {
> "path" => "META-INF/maven/org.jboss.quickstarts.eap/jboss-kitchensink-ear-ear/pom.xml",
> "directory" => false,
> "file-size" => 5582L
> },
> {
> "path" => "META-INF/maven/org.jboss.quickstarts.eap/jboss-kitchensink-ear-ear/pom.properties",
> "directory" => false,
> "file-size" => 143L
> }
> ]
> }
> {code}
> WFCORE-1851 does not fix this.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
9 years, 3 months
[JBoss JIRA] (WFCORE-1855) Possible NPE on controller service start
by Brian Stansberry (JIRA)
[ https://issues.jboss.org/browse/WFCORE-1855?page=com.atlassian.jira.plugi... ]
Brian Stansberry commented on WFCORE-1855:
------------------------------------------
Neither of those two approaches will work. Everything depends on the AbstractControllerService being started.
Conceivably the boot thread stuff could be refactored out into a separate service that depends on the AbstractControllerService. It would need some analysis to look into any gotchas. I believe this has been this way since quite early in AS 7.0 so I'm not sure if it's this way for a real good reason or if it was just a result of inexperience.
> Possible NPE on controller service start
> ----------------------------------------
>
> Key: WFCORE-1855
> URL: https://issues.jboss.org/browse/WFCORE-1855
> Project: WildFly Core
> Issue Type: Bug
> Reporter: David Lloyd
>
> In {{org.jboss.as.controller.AbstractControllerService}}, the {{start}} method starts up a background thread which performs a certain amount of the boot process. Before this thread is started, a volatile field {{controller}} is initialized with the controller reported by the {{start()}} method.
> Inside this thread, some work is performed, and at the end of a certain amount of work, the {{finishBoot()}} method is invoked. This method calls {{controller.finishBoot()}}, referencing the field that was set in the {{start()}} method.
> The problem arises when the service itself is stopped before the boot thread completes. This causes the {{controller}} field to be nulled out, resulting in an NPE.
> I think we need to look at:
> * Why are we using a background thread for this?
> * Why are we _not_ using the asynchronous startup feature?
> I think we must do one of these two things in order to make this code "safe".
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
9 years, 3 months
[JBoss JIRA] (WFLY-7155) Update Hibernate to 5.0.11
by Scott Marlow (JIRA)
[ https://issues.jboss.org/browse/WFLY-7155?page=com.atlassian.jira.plugin.... ]
Scott Marlow closed WFLY-7155.
------------------------------
Resolution: Rejected
Rejecting as we are actively maintaining the WildFly master branch. We can consider upgrading Hibernate in earlier releases if there are strong reasons for doing so, otherwise, lets focus on the "master" branch changes (e.g. getting ORM 5.1.x upgraded for WildFly 11).
> Update Hibernate to 5.0.11
> --------------------------
>
> Key: WFLY-7155
> URL: https://issues.jboss.org/browse/WFLY-7155
> Project: WildFly
> Issue Type: Component Upgrade
> Components: JPA / Hibernate
> Affects Versions: 10.2.0.Final, 11.0.0.Alpha1
> Reporter: Frank Langelage
> Assignee: Scott Marlow
>
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
9 years, 3 months
[JBoss JIRA] (WFLY-6854) Upgrade Hibernate ORM to 5.1.1
by Scott Marlow (JIRA)
[ https://issues.jboss.org/browse/WFLY-6854?page=com.atlassian.jira.plugin.... ]
Scott Marlow updated WFLY-6854:
-------------------------------
Summary: Upgrade Hibernate ORM to 5.1.1 (was: Upgrade Hibernate ORM to 5.1.x)
> Upgrade Hibernate ORM to 5.1.1
> ------------------------------
>
> Key: WFLY-6854
> URL: https://issues.jboss.org/browse/WFLY-6854
> Project: WildFly
> Issue Type: Feature Request
> Components: JPA / Hibernate
> Reporter: Emmanuel Bernard
> Assignee: Scott Marlow
> Fix For: 11.0.0.Alpha1
>
>
> This is a follow up on WFLY-6682.
> After looking at the list of potential incompatibilities, we decided to not upgrade to 5.2 but instead to 5.1 to provide a smoother experience to users.
> We can consider adding a 5.2 optional switch via Jipijapa if bandwidth permit but let's treat it as a second issue and have [~smarlow] lead it.
> PS: I put v11Alpha1 but feel free to adjust it to any WF 11 version that fits best.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
9 years, 3 months
[JBoss JIRA] (WFCORE-1855) Possible NPE on controller service start
by David Lloyd (JIRA)
David Lloyd created WFCORE-1855:
-----------------------------------
Summary: Possible NPE on controller service start
Key: WFCORE-1855
URL: https://issues.jboss.org/browse/WFCORE-1855
Project: WildFly Core
Issue Type: Bug
Reporter: David Lloyd
In {{org.jboss.as.controller.AbstractControllerService}}, the {{start}} method starts up a background thread which performs a certain amount of the boot process. Before this thread is started, a volatile field {{controller}} is initialized with the controller reported by the {{start()}} method.
Inside this thread, some work is performed, and at the end of a certain amount of work, the {{finishBoot()}} method is invoked. This method calls {{controller.finishBoot()}}, referencing the field that was set in the {{start()}} method.
The problem arises when the service itself is stopped before the boot thread completes. This causes the {{controller}} field to be nulled out, resulting in an NPE.
I think we need to look at:
* Why are we using a background thread for this?
* Why are we _not_ using the asynchronous startup feature?
I think we must do one of these two things in order to make this code "safe".
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
9 years, 3 months
[JBoss JIRA] (WFCORE-1854) Wrong result on :browse-content(depth>0) on archived deployments deployed by deployment scanner
by Brian Stansberry (JIRA)
[ https://issues.jboss.org/browse/WFCORE-1854?page=com.atlassian.jira.plugi... ]
Brian Stansberry reassigned WFCORE-1854:
----------------------------------------
Assignee: ehsavoie Hugonnet (was: Brian Stansberry)
> Wrong result on :browse-content(depth>0) on archived deployments deployed by deployment scanner
> -----------------------------------------------------------------------------------------------
>
> Key: WFCORE-1854
> URL: https://issues.jboss.org/browse/WFCORE-1854
> Project: WildFly Core
> Issue Type: Bug
> Components: Domain Management
> Affects Versions: 3.0.0.Alpha9
> Reporter: Michal Jurc
> Assignee: ehsavoie Hugonnet
>
> With archived deployment deployed by deployment scanner, the {{/deployment=jboss-kitchensink-ear.ear:browse-content(depth=1)}} command returns the following result:
> {code}{
> "outcome" => "success",
> "result" => [
> {
> "path" => "META-INF/",
> "directory" => true
> },
> {
> "path" => "META-INF/MANIFEST.MF",
> "directory" => false,
> "file-size" => 130L
> },
> {
> "path" => "jboss-kitchensink-ear-web.war",
> "directory" => false,
> "file-size" => 63190L
> },
> {
> "path" => "jboss-kitchensink-ear-ejb.jar",
> "directory" => false,
> "file-size" => 12256L
> },
> {
> "path" => "META-INF/application.xml",
> "directory" => false,
> "file-size" => 802L
> },
> {
> "path" => "META-INF/kitchensink-ear-quickstart-ds.xml",
> "directory" => false,
> "file-size" => 1955L
> },
> {
> "path" => "META-INF/maven/org.jboss.quickstarts.eap/jboss-kitchensink-ear-ear/pom.xml",
> "directory" => false,
> "file-size" => 5582L
> },
> {
> "path" => "META-INF/maven/org.jboss.quickstarts.eap/jboss-kitchensink-ear-ear/pom.properties",
> "directory" => false,
> "file-size" => 143L
> }
> ]
> }
> {code}
> WFCORE-1851 does not fix this.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
9 years, 3 months