July 2016 - jboss-jira - Jboss List Archives

[JBoss JIRA] (ELY-615) Improvement for usage of file.mkdirs() in FileSystemSecurityRealm.Identity

by Tomaz Cerar (JIRA)

[ https://issues.jboss.org/browse/ELY-615?page=com.atlassian.jira.plugin.sy... ] Tomaz Cerar commented on ELY-615: --------------------------------- Better than using file.mkdirs() would be to use Files#createDirectories as it properly throws exceptions > Improvement for usage of file.mkdirs() in FileSystemSecurityRealm.Identity > -------------------------------------------------------------------------- > > Key: ELY-615 > URL: https://issues.jboss.org/browse/ELY-615 > Project: WildFly Elytron > Issue Type: Bug > Affects Versions: 1.1.0.Beta7 > Reporter: Ondrej Lukas > Assignee: Darran Lofthouse > Priority: Minor > Labels: static_analysis > Fix For: 1.1.0.Beta8 > > > There is method {{tempPath()}} in org.wildfly.security.auth.realm.FileSystemSecurityRealm.Identity which uses {{file.mkdirs()}} without checking its return value. It is bad practice to ignore return value of this method (since false means that file has not been created and it can result to any unexpected and confusing failure later). -- This message was sent by Atlassian JIRA (v6.4.11#64026)

8 years, 5 months

1
0
0 / 0

[JBoss JIRA] (WFLY-6728) JDBC persistence-store for Artemis

by Daniel Fröhlich (JIRA)

[ https://issues.jboss.org/browse/WFLY-6728?page=com.atlassian.jira.plugin.... ] Daniel Fröhlich commented on WFLY-6728: --------------------------------------- No, it is not the same thing as with EAP6. With EAP6, the use AMQ6 embedded, not via RA. So the AMQ broker is running inside the same jvm as EAP does. They do so because they want a very high likelihood that the PUT of a message does succeed. And if Sender and Broker a within the same JVM, that is the case. In the RAR approach with an external running Broker (maybe on the same host, but different jvm process), there is a chance that the broker might be offline (not yet started, killed by kernel oom killer, whatever). That approach follows good HA principles to reduce the number of components in your design. So again, a perfectly good architectural decision. And again that makes it important that we support JDBC persistence not only in AMQ via RAR, but also embedded in EAP. They have a standing rule in place to never ever go into production with "x.0.0" numbers ;-) They will start the migration from EAP5/7 to EAP7 next year with go live target in 2018. So there should be enough time for us to implement and stabilize the functionality. > JDBC persistence-store for Artemis > ---------------------------------- > > Key: WFLY-6728 > URL: https://issues.jboss.org/browse/WFLY-6728 > Project: WildFly > Issue Type: Enhancement > Components: JMS > Affects Versions: 10.0.0.Final > Reporter: Jochen Cordes > Assignee: Jeff Mesnil > > Apache ActiveMQ had the capability to store messages into a database via JDBC. In Apache ActiveMQ Artemis this has gone. > For a consistent backup data of various (co-located) systems participating in transactions should reside at the same datastore as otherwise this needs to be achieved through application software design (i.e. idempotent consumers etc.). > As in Apache ActiveMQ Artemis a JDBC Persistence-Store is about to be introduced we should also offer this capability on WildFly / EAP. -- This message was sent by Atlassian JIRA (v6.4.11#64026)

8 years, 5 months

1
0
0 / 0

[JBoss JIRA] (ELY-615) Improvement for usage of file.mkdirs() in FileSystemSecurityRealm.Identity

by Ondrej Lukas (JIRA)

[ https://issues.jboss.org/browse/ELY-615?page=com.atlassian.jira.plugin.sy... ] Ondrej Lukas updated ELY-615: ----------------------------- Fix Version/s: 1.1.0.Beta8 > Improvement for usage of file.mkdirs() in FileSystemSecurityRealm.Identity > -------------------------------------------------------------------------- > > Key: ELY-615 > URL: https://issues.jboss.org/browse/ELY-615 > Project: WildFly Elytron > Issue Type: Bug > Affects Versions: 1.1.0.Beta7 > Reporter: Ondrej Lukas > Assignee: Darran Lofthouse > Priority: Minor > Labels: static_analysis > Fix For: 1.1.0.Beta8 > > > There is method {{tempPath()}} in org.wildfly.security.auth.realm.FileSystemSecurityRealm.Identity which uses {{file.mkdirs()}} without checking its return value. It is bad practice to ignore return value of this method (since false means that file has not been created and it can result to any unexpected and confusing failure later). -- This message was sent by Atlassian JIRA (v6.4.11#64026)

8 years, 5 months

1
0
0 / 0

[JBoss JIRA] (ELY-612) Missing or unnecessary null check in AbstractDigestMechanism

by Ondrej Lukas (JIRA)

[ https://issues.jboss.org/browse/ELY-612?page=com.atlassian.jira.plugin.sy... ] Ondrej Lukas updated ELY-612: ----------------------------- Fix Version/s: 1.1.0.Beta8 > Missing or unnecessary null check in AbstractDigestMechanism > ------------------------------------------------------------ > > Key: ELY-612 > URL: https://issues.jboss.org/browse/ELY-612 > Project: WildFly Elytron > Issue Type: Bug > Affects Versions: 1.1.0.Beta7 > Reporter: Ondrej Lukas > Assignee: Darran Lofthouse > Labels: static_analysis > Fix For: 1.1.0.Beta8 > > > There is missing or unnecessary null check in {{getSaltedPasswordFromTwoWay}} method of org.wildfly.security.sasl.digest.AbstractDigestMechanism. {{char[] passwordChars}} is assigned on line 650 [1]. > * In case when null can be assigned to {{passwordChars}} then there is missing null check before calling {{userRealmPasswordDigest(messageDigest, username, realm, passwordChars);}} on line 658 which can result to NPE. > * In case when null cannot be assigned to {{passwordChars}} then there is unnecessary null check on line 659. > [1] https://github.com/wildfly-security/wildfly-elytron/blob/e01a09572b02f33d... -- This message was sent by Atlassian JIRA (v6.4.11#64026)

8 years, 5 months

1
0
0 / 0

[JBoss JIRA] (ELY-613) Some nested classes should be considered to be static nested in Elytron

by Ondrej Lukas (JIRA)

[ https://issues.jboss.org/browse/ELY-613?page=com.atlassian.jira.plugin.sy... ] Ondrej Lukas updated ELY-613: ----------------------------- Fix Version/s: 1.1.0.Beta8 > Some nested classes should be considered to be static nested in Elytron > ----------------------------------------------------------------------- > > Key: ELY-613 > URL: https://issues.jboss.org/browse/ELY-613 > Project: WildFly Elytron > Issue Type: Bug > Affects Versions: 1.1.0.Beta7 > Reporter: Ondrej Lukas > Assignee: Darran Lofthouse > Labels: static_analysis > Fix For: 1.1.0.Beta8 > > > There are some inner classes in Elytron which should be considered to be static nested to avoid dependency on their outer class. Following nested classes should be considered: > * LoadedIdentity and Identity from org.wildfly.security.auth.realm.FileSystemSecurityRealm > * DecoderState from org.wildfly.security.asn1.DERDecoder > * AccountEntry from org.wildfly.security.auth.realm.LegacyPropertiesSecurityRealm > * JaasAuthorizationIdentity and DefaultCallbackHandler from org.wildfly.security.auth.realm.JaasSecurityRealm > * LoadKey from org.wildfly.security.keystore.AtomicLoadKeyStore -- This message was sent by Atlassian JIRA (v6.4.11#64026)

8 years, 5 months

1
0
0 / 0

[JBoss JIRA] (ELY-614) Missing null check in equals() method of AbstractPermission

by Ondrej Lukas (JIRA)

[ https://issues.jboss.org/browse/ELY-614?page=com.atlassian.jira.plugin.sy... ] Ondrej Lukas updated ELY-614: ----------------------------- Fix Version/s: 1.1.0.Beta8 > Missing null check in equals() method of AbstractPermission > ----------------------------------------------------------- > > Key: ELY-614 > URL: https://issues.jboss.org/browse/ELY-614 > Project: WildFly Elytron > Issue Type: Bug > Affects Versions: 1.1.0.Beta7 > Reporter: Ondrej Lukas > Assignee: Darran Lofthouse > Labels: static_analysis > Fix For: 1.1.0.Beta8 > > > There is missing null check in {{org.wildfly.security.permission.AbstractPermission.equals(Object obj)}} method. NPE is thrown for null {{obj}} parameter. -- This message was sent by Atlassian JIRA (v6.4.11#64026)

8 years, 5 months

1
0
0 / 0

[JBoss JIRA] (ELY-610) Missing null check in build() method of X509CertificateBuilder

by Ondrej Lukas (JIRA)

[ https://issues.jboss.org/browse/ELY-610?page=com.atlassian.jira.plugin.sy... ] Ondrej Lukas updated ELY-610: ----------------------------- Fix Version/s: 1.1.0.Beta8 > Missing null check in build() method of X509CertificateBuilder > -------------------------------------------------------------- > > Key: ELY-610 > URL: https://issues.jboss.org/browse/ELY-610 > Project: WildFly Elytron > Issue Type: Bug > Affects Versions: 1.1.0.Beta7 > Reporter: Ondrej Lukas > Assignee: Darran Lofthouse > Labels: static_analysis > Fix For: 1.1.0.Beta8 > > > Calling {{ASN1.oidFromSignatureAlgorithm(String)}} in {{org.wildfly.security.x500.cert.X509CertificateBuilder.build()}} method on line 375 [1] for unknown algorithms returns null which is assigned to {{signatureAlgorithmOid}} and results to NPE thrown from {{derEncoder.encodeObjectIdentifier(signatureAlgorithmOid)}} on line 377. > [1] https://github.com/wildfly-security/wildfly-elytron/blob/e01a09572b02f33d... -- This message was sent by Atlassian JIRA (v6.4.11#64026)

8 years, 5 months

1
0
0 / 0

[JBoss JIRA] (ELY-611) Unintentional integer overflow in LongNameSetPermissionCollection

by Ondrej Lukas (JIRA)

[ https://issues.jboss.org/browse/ELY-611?page=com.atlassian.jira.plugin.sy... ] Ondrej Lukas updated ELY-611: ----------------------------- Fix Version/s: 1.1.0.Beta8 > Unintentional integer overflow in LongNameSetPermissionCollection > ----------------------------------------------------------------- > > Key: ELY-611 > URL: https://issues.jboss.org/browse/ELY-611 > Project: WildFly Elytron > Issue Type: Bug > Affects Versions: 1.1.0.Beta7 > Reporter: Ondrej Lukas > Assignee: Darran Lofthouse > Labels: static_analysis > Fix For: 1.1.0.Beta8 > > > There are potentially overflowing expressions in org.wildfly.security.permission.LongNameSetPermissionCollection in {{getBitsForName}} method. Expressions {{1 << nameEnumeration.size()}} and {{1 << nameEnumeration.indexOf(name)}} are evaluated as integer but assigned to {{bits}} variable which is long. It can be avoided by casting {{1}} to long. -- This message was sent by Atlassian JIRA (v6.4.11#64026)

8 years, 5 months

1
0
0 / 0

[JBoss JIRA] (ELY-609) Unguarded read in ElytronPolicyConfiguration

by Ondrej Lukas (JIRA)

[ https://issues.jboss.org/browse/ELY-609?page=com.atlassian.jira.plugin.sy... ] Ondrej Lukas updated ELY-609: ----------------------------- Fix Version/s: 1.1.0.Beta8 > Unguarded read in ElytronPolicyConfiguration > -------------------------------------------- > > Key: ELY-609 > URL: https://issues.jboss.org/browse/ELY-609 > Project: WildFly Elytron > Issue Type: Bug > Affects Versions: 1.1.0.Beta7 > Reporter: Ondrej Lukas > Assignee: Darran Lofthouse > Labels: static_analysis > Fix For: 1.1.0.Beta8 > > > Access to fields {{uncheckedPermissions}}, {{excludedPermissions}} and {{rolePermissions}} in {{org.wildfly.security.authz.jacc.ElytronPolicyConfiguration}} is holded by lock. However lock is not used in their getter methods. Getters should be also handled by locks to avoid unguarded read of those fields. -- This message was sent by Atlassian JIRA (v6.4.11#64026)

8 years, 5 months

1
0
0 / 0

[JBoss JIRA] (ELY-615) Improvement for usage of file.mkdirs() in FileSystemSecurityRealm.Identity

by Ondrej Lukas (JIRA)

Ondrej Lukas created ELY-615: -------------------------------- Summary: Improvement for usage of file.mkdirs() in FileSystemSecurityRealm.Identity Key: ELY-615 URL: https://issues.jboss.org/browse/ELY-615 Project: WildFly Elytron Issue Type: Bug Affects Versions: 1.1.0.Beta7 Reporter: Ondrej Lukas Assignee: Darran Lofthouse Priority: Minor There is method {{tempPath()}} in org.wildfly.security.auth.realm.FileSystemSecurityRealm.Identity which uses {{file.mkdirs()}} without checking its return value. It is bad practice to ignore return value of this method (since false means that file has not been created and it can result to any unexpected and confusing failure later). -- This message was sent by Atlassian JIRA (v6.4.11#64026)

8 years, 5 months

1
0
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

jboss-jira July 2016