[JBoss JIRA] (ELY-614) Missing null check in equals() method of AbstractPermission
by Ondrej Lukas (JIRA)
Ondrej Lukas created ELY-614:
--------------------------------
Summary: Missing null check in equals() method of AbstractPermission
Key: ELY-614
URL: https://issues.jboss.org/browse/ELY-614
Project: WildFly Elytron
Issue Type: Bug
Affects Versions: 1.1.0.Beta7
Reporter: Ondrej Lukas
Assignee: Darran Lofthouse
There is missing null check in {{org.wildfly.security.permission.AbstractPermission.equals(Object obj)}} method. NPE is thrown for null {{obj}} parameter.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
7 years, 10 months
[JBoss JIRA] (ELY-613) Some nested classes should be considered to be static nested in Elytron
by Ondrej Lukas (JIRA)
Ondrej Lukas created ELY-613:
--------------------------------
Summary: Some nested classes should be considered to be static nested in Elytron
Key: ELY-613
URL: https://issues.jboss.org/browse/ELY-613
Project: WildFly Elytron
Issue Type: Bug
Affects Versions: 1.1.0.Beta7
Reporter: Ondrej Lukas
Assignee: Darran Lofthouse
There are some inner classes in Elytron which should be considered to be static nested to avoid dependency on their outer class. Following nested classes should be considered:
* LoadedIdentity and Identity from org.wildfly.security.auth.realm.FileSystemSecurityRealm
* DecoderState from org.wildfly.security.asn1.DERDecoder
* AccountEntry from org.wildfly.security.auth.realm.LegacyPropertiesSecurityRealm
* JaasAuthorizationIdentity and DefaultCallbackHandler from org.wildfly.security.auth.realm.JaasSecurityRealm
* LoadKey from org.wildfly.security.keystore.AtomicLoadKeyStore
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
7 years, 10 months
[JBoss JIRA] (ELY-612) Missing or unnecessary null check in AbstractDigestMechanism
by Ondrej Lukas (JIRA)
Ondrej Lukas created ELY-612:
--------------------------------
Summary: Missing or unnecessary null check in AbstractDigestMechanism
Key: ELY-612
URL: https://issues.jboss.org/browse/ELY-612
Project: WildFly Elytron
Issue Type: Bug
Affects Versions: 1.1.0.Beta7
Reporter: Ondrej Lukas
Assignee: Darran Lofthouse
There is missing or unnecessary null check in {{getSaltedPasswordFromTwoWay}} method of org.wildfly.security.sasl.digest.AbstractDigestMechanism. {{char[] passwordChars}} is assigned on line 650 [1].
* In case when null can be assigned to {{passwordChars}} then there is missing null check before calling {{userRealmPasswordDigest(messageDigest, username, realm, passwordChars);}} on line 658 which can result to NPE.
* In case when null cannot be assigned to {{passwordChars}} then there is unnecessary null check on line 659.
[1] https://github.com/wildfly-security/wildfly-elytron/blob/e01a09572b02f33d...
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
7 years, 10 months
[JBoss JIRA] (ELY-611) Unintentional integer overflow in LongNameSetPermissionCollection
by Ondrej Lukas (JIRA)
Ondrej Lukas created ELY-611:
--------------------------------
Summary: Unintentional integer overflow in LongNameSetPermissionCollection
Key: ELY-611
URL: https://issues.jboss.org/browse/ELY-611
Project: WildFly Elytron
Issue Type: Bug
Affects Versions: 1.1.0.Beta7
Reporter: Ondrej Lukas
Assignee: Darran Lofthouse
There are potentially overflowing expressions in org.wildfly.security.permission.LongNameSetPermissionCollection in {{getBitsForName}} method. Expressions {{1 << nameEnumeration.size()}} and {{1 << nameEnumeration.indexOf(name)}} are evaluated as integer but assigned to {{bits}} variable which is long. It can be avoided by casting {{1}} to long.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
7 years, 10 months
[JBoss JIRA] (ELY-609) Unguarded read in ElytronPolicyConfiguration
by Ondrej Lukas (JIRA)
Ondrej Lukas created ELY-609:
--------------------------------
Summary: Unguarded read in ElytronPolicyConfiguration
Key: ELY-609
URL: https://issues.jboss.org/browse/ELY-609
Project: WildFly Elytron
Issue Type: Bug
Affects Versions: 1.1.0.Beta7
Reporter: Ondrej Lukas
Assignee: Darran Lofthouse
Access to fields {{uncheckedPermissions}}, {{excludedPermissions}} and {{rolePermissions}} in {{org.wildfly.security.authz.jacc.ElytronPolicyConfiguration}} is holded by lock. However lock is not used in their getter methods. Getters should be also handled by locks to avoid unguarded read of those fields.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
7 years, 10 months
[JBoss JIRA] (DROOLS-1103) FireAllRules can trigger java.util.concurrent.RejectedExecutionException from the JDKTimerService
by Mario Fusco (JIRA)
[ https://issues.jboss.org/browse/DROOLS-1103?page=com.atlassian.jira.plugi... ]
Mario Fusco commented on DROOLS-1103:
-------------------------------------
Also this commit is required for this fix https://github.com/droolsjbpm/drools/commit/fe4d08a0a
> FireAllRules can trigger java.util.concurrent.RejectedExecutionException from the JDKTimerService
> -------------------------------------------------------------------------------------------------
>
> Key: DROOLS-1103
> URL: https://issues.jboss.org/browse/DROOLS-1103
> Project: Drools
> Issue Type: Bug
> Affects Versions: 6.3.0.Final, 6.4.0.Final
> Reporter: Juan Carlos Garcia
> Assignee: Mario Fusco
> Fix For: 7.0.0.Beta2
>
> Attachments: RejectedExecutionExceptionBugReport.zip
>
>
> Under very rare circumstance we have found the following exception *java.util.concurrent.RejectedExecutionException* in our production log.
> Our guess is that the Drools Session is on its way to be dispose, while a new incoming request is in the middle of a fireAllRules operation (race condition).
> I will try to provide a reproducible testcase for this.
> {code}
> Caused by: java.util.concurrent.RejectedExecutionException: Task java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask@3e896443 rejected from java.util.concurrent.ScheduledThreadPoolExecutor@71cc2f4c[Terminated, pool size = 0, active threads = 0, queued tasks = 0, completed tasks = 0]
> at java.util.concurrent.ThreadPoolExecutor$AbortPolicy.rejectedExecution(ThreadPoolExecutor.java:2047)
> at java.util.concurrent.ThreadPoolExecutor.reject(ThreadPoolExecutor.java:823)
> at java.util.concurrent.ScheduledThreadPoolExecutor.delayedExecute(ScheduledThreadPoolExecutor.java:326)
> at java.util.concurrent.ScheduledThreadPoolExecutor.schedule(ScheduledThreadPoolExecutor.java:549)
> at org.drools.core.time.impl.JDKTimerService.internalSchedule(JDKTimerService.java:118)
> at org.drools.core.time.impl.JDKTimerService.scheduleJob(JDKTimerService.java:101)
> at org.drools.core.phreak.PhreakTimerNode.scheduleTimer(PhreakTimerNode.java:304)
> at org.drools.core.phreak.PhreakTimerNode.scheduleLeftTuple(PhreakTimerNode.java:233)
> at org.drools.core.phreak.PhreakTimerNode.doLeftUpdates(PhreakTimerNode.java:131)
> at org.drools.core.phreak.PhreakTimerNode.doNode(PhreakTimerNode.java:65)
> at org.drools.core.phreak.RuleNetworkEvaluator.innerEval(RuleNetworkEvaluator.java:357)
> at org.drools.core.phreak.RuleNetworkEvaluator.outerEval(RuleNetworkEvaluator.java:161)
> at org.drools.core.phreak.RuleNetworkEvaluator.evaluateNetwork(RuleNetworkEvaluator.java:116)
> at org.drools.core.phreak.RuleExecutor.reEvaluateNetwork(RuleExecutor.java:194)
> at org.drools.core.phreak.RuleExecutor.evaluateNetworkAndFire(RuleExecutor.java:67)
> at org.drools.core.common.DefaultAgenda.fireNextItem(DefaultAgenda.java:935)
> at org.drools.core.common.DefaultAgenda.fireAllRules(DefaultAgenda.java:1200)
> at org.drools.core.common.AbstractWorkingMemory.fireAllRules(AbstractWorkingMemory.java:957)
> at org.drools.core.common.AbstractWorkingMemory.fireAllRules(AbstractWorkingMemory.java:936)
> at org.drools.core.impl.StatefulKnowledgeSessionImpl.fireAllRules(StatefulKnowledgeSessionImpl.java:260)
> at XXXXXX.XXXXX.XXXXX.processEventDrools(EventProcessorImpl.java:128)
> at XXXXXX.XXXXX.XXXXX.processEvent(EventProcessorImpl.java:101)
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
7 years, 10 months
[JBoss JIRA] (WFCORE-1679) jconsole wildfly cli tab plugin not reacting to connect/disconnect button
by Enrique González Martínez (JIRA)
Enrique González Martínez created WFCORE-1679:
-------------------------------------------------
Summary: jconsole wildfly cli tab plugin not reacting to connect/disconnect button
Key: WFCORE-1679
URL: https://issues.jboss.org/browse/WFCORE-1679
Project: WildFly Core
Issue Type: Bug
Reporter: Enrique González Martínez
The current plugin does not reac to the connect/dissconnect button. causing an error in the next use case:
1) loing
2) show the jconsole tb
3) disconnect jconsole
4) connect jconsole again
try to execute anything jconsole tab plugin
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
7 years, 10 months