March 2017 - jboss-jira - Jboss List Archives

[JBoss JIRA] (WFLY-8257) Ignore failing test in AS TS with Elytron profile to be able to run -Delytron on pull requests

by Josef Cacek (JIRA)

[ https://issues.jboss.org/browse/WFLY-8257?page=com.atlassian.jira.plugin.... ] Josef Cacek commented on WFLY-8257: ----------------------------------- PR sent. It adds `assumes` to failing tests. To reenable them without code chage one may use the `-Dwildfly.tmp.enable.elytron.profile.tests=true` Maven argument. > Ignore failing test in AS TS with Elytron profile to be able to run -Delytron on pull requests > ---------------------------------------------------------------------------------------------- > > Key: WFLY-8257 > URL: https://issues.jboss.org/browse/WFLY-8257 > Project: WildFly > Issue Type: Task > Components: Test Suite > Reporter: Josef Cacek > Assignee: Josef Cacek > Priority: Critical > > Introduce similar assumption method as is already present for failing invocation tests in {{DisableInvocationTestUtil}}. Use it for tests failing with Elytron profile to be able to run the pull request checks with {{-Delytron}} too. -- This message was sent by Atlassian JIRA (v7.2.3#72005)

8 years, 10 months

1
0
0 / 0

[JBoss JIRA] (ELY-957) Coverity static analysis: DefaultSingleSignOn.getIdentity() not synchronized

by Martin Choma (JIRA)

[ https://issues.jboss.org/browse/ELY-957?page=com.atlassian.jira.plugin.sy... ] Martin Choma commented on ELY-957: ---------------------------------- On read there have to be ensured correct/fresh data is picked up by: - synchronized keyword - volatile keyword Current implementation DefaultSingleSignOnEntry choose volatile approach. It is correct. My concern is that all future implementation of SingleSignOnEntry must think on that and use volatile approach to be correct. On the other hand if DefaultSingleSignOn.getIdentity use synchronized keyword, all future implementation will be safe. Does it make sense to you? >From my PoV moving synchronized modifier to synchronized block, doesn't change situation. > Coverity static analysis: DefaultSingleSignOn.getIdentity() not synchronized > ---------------------------------------------------------------------------- > > Key: ELY-957 > URL: https://issues.jboss.org/browse/ELY-957 > Project: WildFly Elytron > Issue Type: Bug > Components: HTTP > Affects Versions: 1.1.0.Beta24 > Reporter: Martin Choma > Assignee: Paul Ferraro > Priority: Minor > > Coverity static-analysis scan found getter is not synchronized, while setter is. > {code} > public SecurityIdentity getIdentity() { > return this.entry.getCachedIdentity().getSecurityIdentity(); > } > {code} > Current implementation is correct because in DefaultSingleSignOnEntry (currently only avalaible implementation of SingleSignOnEntry) cachedIdentity is volatile. > However other implementations can be wrongly implemented. Once getIdentity() would be marked with synchronize modifier, such problem shouldn't occure. > https://scan7.coverity.com/reports.htm#v23632/p11778/fileInstanceId=84908... -- This message was sent by Atlassian JIRA (v7.2.3#72005)

8 years, 10 months

1
0
0 / 0

[JBoss JIRA] (WFLY-8265) Incorrect class loader is used for loading custom Initial context factory in Elytron dir-context

by Ondrej Lukas (JIRA)

Ondrej Lukas created WFLY-8265: ---------------------------------- Summary: Incorrect class loader is used for loading custom Initial context factory in Elytron dir-context Key: WFLY-8265 URL: https://issues.jboss.org/browse/WFLY-8265 Project: WildFly Issue Type: Bug Components: Security Reporter: Ondrej Lukas Assignee: Darran Lofthouse Priority: Critical Quoting from [1]: {quote} DEBUG [org.wildfly.security] (default task-1) Could not create [class javax.naming.ldap.InitialLdapContext]. Failed to connect to LDAP server.: javax.naming.NamingException: WFLYNAM0027: Failed instantiate InitialContextFactory "com.sun.jndi.ldap.LdapCtxFactory" from classloader ModuleClassLoader for Module "deployment.print-roles.war" from Service Module Loader [Root exception is java.lang.ClassNotFoundException: "com.sun.jndi.ldap.LdapCtxFactory" from [Module "deployment.print-roles.war" from Service Module Loader]] at org.jboss.as.naming.InitialContext.getDefaultInitCtx(InitialContext.java:120) at org.jboss.as.naming.InitialContext.init(InitialContext.java:101) We can see from the stack trace the deployments class loader is being used. I think by default the ClassLoader of the subsystem should be used i.e. that will have the common dependencies. However we may want to also add a module attribute so an alternative module can be specified for when creating the InitialDirContext. {quote} [1] https://issues.jboss.org/browse/JBEAP-8025?focusedCommentId=13370291&page... -- This message was sent by Atlassian JIRA (v7.2.3#72005)

8 years, 10 months

1
0
0 / 0

[JBoss JIRA] (DROOLS-1458) Compilation error when compiling DMN model with a BKM node that depends on another BKM node

by Edson Tirelli (JIRA)

[ https://issues.jboss.org/browse/DROOLS-1458?page=com.atlassian.jira.plugi... ] Edson Tirelli commented on DROOLS-1458: --------------------------------------- Pull request submitted. > Compilation error when compiling DMN model with a BKM node that depends on another BKM node > ------------------------------------------------------------------------------------------- > > Key: DROOLS-1458 > URL: https://issues.jboss.org/browse/DROOLS-1458 > Project: Drools > Issue Type: Bug > Components: dmn engine > Affects Versions: 7.0.0.Beta6 > Reporter: Edson Tirelli > Assignee: Edson Tirelli > Fix For: 7.0.0.Final > > > When a DMN model contains a BKM node that depends on another BKM node, the compiler raises an error like: > `Error compiling FEEL expression 'monthlyPayment(loanAmt,rate,360)' for name 'paymentAmt' on node 'FinancialMetrics': Unknown variable 'monthlyPayment'` -- This message was sent by Atlassian JIRA (v7.2.3#72005)

8 years, 10 months

1
0
0 / 0

[JBoss JIRA] (DROOLS-1456) Improve error messages and error handling on DMN compilation and execution

by Edson Tirelli (JIRA)

[ https://issues.jboss.org/browse/DROOLS-1456?page=com.atlassian.jira.plugi... ] Edson Tirelli updated DROOLS-1456: ---------------------------------- Description: This is a placeholder ticket for several small improvements on the error messages and error handling. 1. When a decision or a BKM has no expression, it raises the message “No expression defined for node ‘_guid’”. Would it be possible to put the node name when one is defined instead? 2. Add the DMN model object reference to the DMNMessage class. was: This is a placeholder ticket for several small improvements on the error messages and error handling. 1. When a decision or a BKM has no expression, it raises the message “No expression defined for node ‘_guid’”. Would it be possible to put the node name when one is defined instead? 2. Add the DMN model object reference to the DMNMessage class. 3. Fix compilation error for models with BKM nodes that depend on other BKM nodes. > Improve error messages and error handling on DMN compilation and execution > -------------------------------------------------------------------------- > > Key: DROOLS-1456 > URL: https://issues.jboss.org/browse/DROOLS-1456 > Project: Drools > Issue Type: Bug > Components: dmn engine > Affects Versions: 7.0.0.Beta6 > Reporter: Edson Tirelli > Assignee: Edson Tirelli > Fix For: 7.0.0.Final > > > This is a placeholder ticket for several small improvements on the error messages and error handling. > 1. When a decision or a BKM has no expression, it raises the message “No expression defined for node ‘_guid’”. Would it be possible to put the node name when one is defined instead? > 2. Add the DMN model object reference to the DMNMessage class. -- This message was sent by Atlassian JIRA (v7.2.3#72005)

8 years, 10 months

1
0
0 / 0

[JBoss JIRA] (DROOLS-1458) Compilation error when compiling DMN model with a BKM node that depends on another BKM node

by Edson Tirelli (JIRA)

Edson Tirelli created DROOLS-1458: ------------------------------------- Summary: Compilation error when compiling DMN model with a BKM node that depends on another BKM node Key: DROOLS-1458 URL: https://issues.jboss.org/browse/DROOLS-1458 Project: Drools Issue Type: Bug Components: dmn engine Affects Versions: 7.0.0.Beta6 Reporter: Edson Tirelli Assignee: Edson Tirelli Fix For: 7.0.0.Final When a DMN model contains a BKM node that depends on another BKM node, the compiler raises an error like: `Error compiling FEEL expression 'monthlyPayment(loanAmt,rate,360)' for name 'paymentAmt' on node 'FinancialMetrics': Unknown variable 'monthlyPayment'` -- This message was sent by Atlassian JIRA (v7.2.3#72005)

8 years, 10 months

1
0
0 / 0

[JBoss JIRA] (DROOLS-1456) Improve error messages and error handling on DMN compilation and execution

by Edson Tirelli (JIRA)

[ https://issues.jboss.org/browse/DROOLS-1456?page=com.atlassian.jira.plugi... ] Edson Tirelli updated DROOLS-1456: ---------------------------------- Description: This is a placeholder ticket for several small improvements on the error messages and error handling. 1. When a decision or a BKM has no expression, it raises the message “No expression defined for node ‘_guid’”. Would it be possible to put the node name when one is defined instead? 2. Add the DMN model object reference to the DMNMessage class. 3. Fix compilation error for models with BKM nodes that depend on other BKM nodes. was: This is a placeholder ticket for several small improvements on the error messages and error handling. 1. When a decision or a BKM has no expression, it raises the message “No expression defined for node ‘_guid’”. Would it be possible to put the node name when one is defined instead? 2. etc > Improve error messages and error handling on DMN compilation and execution > -------------------------------------------------------------------------- > > Key: DROOLS-1456 > URL: https://issues.jboss.org/browse/DROOLS-1456 > Project: Drools > Issue Type: Bug > Components: dmn engine > Affects Versions: 7.0.0.Beta6 > Reporter: Edson Tirelli > Assignee: Edson Tirelli > Fix For: 7.0.0.Final > > > This is a placeholder ticket for several small improvements on the error messages and error handling. > 1. When a decision or a BKM has no expression, it raises the message “No expression defined for node ‘_guid’”. Would it be possible to put the node name when one is defined instead? > 2. Add the DMN model object reference to the DMNMessage class. > 3. Fix compilation error for models with BKM nodes that depend on other BKM nodes. -- This message was sent by Atlassian JIRA (v7.2.3#72005)

8 years, 10 months

1
0
0 / 0

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

jboss-jira March 2017