[JBoss JIRA] (DROOLS-3825) Model compiler should not duplicate files across runs
by Edoardo Vacchi (Jira)
Edoardo Vacchi created DROOLS-3825:
--------------------------------------
Summary: Model compiler should not duplicate files across runs
Key: DROOLS-3825
URL: https://issues.jboss.org/browse/DROOLS-3825
Project: Drools
Issue Type: Bug
Reporter: Edoardo Vacchi
Assignee: Edoardo Vacchi
If you don't {{mvn clean}} each time you generate the executable model, new files will be generated at each run.
These seem to be the culprit:
{{PackageModel#getPackageUUID}}
{code}
private String generateRulesFileName() {
return RULES_FILE_NAME + generateUUID();
}
{code}
solution: use a counter; the compiler is single-threaded, two runs produce the same output, existing files will be just overwritten
deliverable: test case verifying files do not grow in number across runs
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years, 1 month
[JBoss JIRA] (DROOLS-3798) [DMN Designer] Included Models - When users open a DMN file with imported nodes, they must be able to see those nodes in the graph on read-only mode
by Guilherme Gomes (Jira)
[ https://issues.jboss.org/browse/DROOLS-3798?page=com.atlassian.jira.plugi... ]
Guilherme Gomes updated DROOLS-3798:
------------------------------------
Summary: [DMN Designer] Included Models - When users open a DMN file with imported nodes, they must be able to see those nodes in the graph on read-only mode (was: [DMN Designer] Included Models - Show imported nodes in the graph when a DMN with imported nodes is opened)
> [DMN Designer] Included Models - When users open a DMN file with imported nodes, they must be able to see those nodes in the graph on read-only mode
> ----------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: DROOLS-3798
> URL: https://issues.jboss.org/browse/DROOLS-3798
> Project: Drools
> Issue Type: Task
> Components: DMN Editor
> Reporter: Guilherme Gomes
> Assignee: Daniel José dos Santos
> Priority: Major
> Labels: drools-tools
> Attachments: daniel1.dmn, daniel2.dmn
>
>
> When users open the DMN editor with an imported file+ imported nodes, they must be able to see these nodes on read-only mode.
> ---
> Assets:
> - [^daniel1.dmn]
> - [^daniel2.dmn]
> ---
> This task comprehends:
> - Read imported nodes in the "daniel2.dmn", and put them into the canvas by consuming a *mocked service class* [1] to fill the node information;
> - Create the new imported nodes in the canvas;
> - Persist imported nodes info properly in the DMN file (when users save it);
> - Keep these imported nodes on read-only mode;
> - Keep the properties panel correctly updated.
> ---
> Acceptance criteria:
> - Open the "daniel2.dmn"
> - See the imported nodes from the "daniel1.dmn"
> - Try to change the name of the node (this should not be allowed, since the node must be on read only mode)
> - Check the properties panel properties
> ---
> [1] This service class will be responsible for returning all information from a given node from another DMN file. This API will be something like this: {{ExternalDMNFileService.getNode(final String dmnElementRef)}}
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years, 1 month
[JBoss JIRA] (DROOLS-3449) Creating a kjar with the maven pluging the executable model classes are generated twice
by Edoardo Vacchi (Jira)
[ https://issues.jboss.org/browse/DROOLS-3449?page=com.atlassian.jira.plugi... ]
Edoardo Vacchi edited comment on DROOLS-3449 at 4/1/19 10:07 AM:
-----------------------------------------------------------------
these seem to be the culprit:
{{PackageModel#getPackageUUID}}
{code}
private String generateRulesFileName() {
return RULES_FILE_NAME + generateUUID();
}
{code}
solution: use a counter; the compiler is single-threaded, two runs produce the same output, existing files will be just overwritten
was (Author: evacchi):
- {{PackageModel#getPackageUUID}}
and
{code}
private String generateRulesFileName() {
return RULES_FILE_NAME + generateUUID();
}
{code}
> Creating a kjar with the maven pluging the executable model classes are generated twice
> ---------------------------------------------------------------------------------------
>
> Key: DROOLS-3449
> URL: https://issues.jboss.org/browse/DROOLS-3449
> Project: Drools
> Issue Type: Bug
> Reporter: Mario Fusco
> Assignee: Edoardo Vacchi
> Priority: Major
> Attachments: simple-project.zip
>
>
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years, 1 month