[JBoss JIRA] (DROOLS-2733) Support MVEL Dialect using custom inline accumulate code with external declarations in the executable model
by Luca Molteni (Jira)
[ https://issues.jboss.org/browse/DROOLS-2733?page=com.atlassian.jira.plugi... ]
Luca Molteni commented on DROOLS-2733:
--------------------------------------
This could also be fixed by the mvel to java compiler
> Support MVEL Dialect using custom inline accumulate code with external declarations in the executable model
> -----------------------------------------------------------------------------------------------------------
>
> Key: DROOLS-2733
> URL: https://issues.jboss.org/browse/DROOLS-2733
> Project: Drools
> Issue Type: Feature Request
> Components: executable model
> Reporter: Luca Molteni
> Assignee: Luca Molteni
> Priority: Optional
>
> The executable model doesn't support custom inline accumulate code that uses external declarations such as
> {code:java}
> String str = "import " + Person.class.getCanonicalName() + ";\n" +
> "rule R dialect \"mvel\" when\n" +
> " String( $l : length )" +
> " $sum : Integer() from accumulate (\n" +
> " Person( age > 18, $age : age ), init( int sum = 0 * $l; ), action( sum += $age; ), reverse( sum -= $age; ), result( sum )\n" +
> " )" +
> "then\n" +
> " insert($sum);\n" +
> "end";
> {code}
> (Notice that in the init we multiply the sum value with the length of string)
> But it can support such style using the "classic" generation of accumulate classes which gets compiled among the executable model and instantiate during the execution of the DSL.
> This mechanism is broken with the MVEL dialect, as we don't have such generated classes.
> Probably what we should do instead is putting MVEL expressions in the DSL directly such as
> {code:java}
> accumulateScript("initCode", "accCode", "reverseCode");
> {code}
> and then during interpretation create a new MVEL context and execute the accumulate in memory
> See
> AccumulateUnsupportedTest.testMVELAccumulate
> AccumulateUnsupportedTest.testMVELAccumulate2WM
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
6 years, 8 months
[JBoss JIRA] (DROOLS-3198) kie maven plugin fails to build kjar if kmodule contains a ruleTemplate
by Luca Molteni (Jira)
[ https://issues.jboss.org/browse/DROOLS-3198?page=com.atlassian.jira.plugi... ]
Luca Molteni updated DROOLS-3198:
---------------------------------
Sprint: 2019 Week 14-16
> kie maven plugin fails to build kjar if kmodule contains a ruleTemplate
> -----------------------------------------------------------------------
>
> Key: DROOLS-3198
> URL: https://issues.jboss.org/browse/DROOLS-3198
> Project: Drools
> Issue Type: Bug
> Components: tools
> Affects Versions: 7.8.0.Final
> Reporter: Webster Homer
> Assignee: Luca Molteni
> Priority: Major
>
> If I have a maven pom that uses the kie maven plugin org.kie:kie-maven-plugin to build the kljar for deployment, and the project kjar has a ruleTemplate:
> <ruleTemplate dtable="rules/business/TermSearchQFRules.xls"
> template="rules/business/templates/TermSearchQF.drt"
> row="2" col="1"/>
> The build will fail with an error:
> ERROR] Failed to execute goal org.kie:kie-maven-plugin:7.8.0.Final:build (default-build) on project ba-search-kjar: Execution default-build of goal org.kie:kie-maven-plugin:7.8.0.Final:build failed: No RuleTable cells in spreadsheet. -> [Help 1]
> org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal org.kie:kie-maven-plugin:7.8.0.Final:build (default-build) on project ba-search-kjar: Execution default-build of goal org.kie:kie-maven-plugin:7.8.0.Final:build failed: No RuleTable cells in spreadsheet.
> Caused by: org.apache.maven.plugin.PluginExecutionException: Execution default-build of goal org.kie:kie-maven-plugin:7.8.0.Final:build failed: No RuleTable cells in spreadsheet.
> at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:110)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:209)
> ... 19 more
> Caused by: org.drools.template.parser.DecisionTableParseException: No RuleTable cells in spreadsheet.
> This is because the plugin doesn't understand the rule template, and treats the xls file as a decision table spreadsheet rather than a template spreadsheet.
> The kie-maven-plugin is a useful tool that compiles the kjar are build time rather than load time, and gives good diagnostics.
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
6 years, 8 months
[JBoss JIRA] (DROOLS-3802) Build error with executable-model, nested property with double-bytes property name
by Luca Molteni (Jira)
[ https://issues.jboss.org/browse/DROOLS-3802?page=com.atlassian.jira.plugi... ]
Luca Molteni updated DROOLS-3802:
---------------------------------
Sprint: 2019 Week 14-16
> Build error with executable-model, nested property with double-bytes property name
> ----------------------------------------------------------------------------------
>
> Key: DROOLS-3802
> URL: https://issues.jboss.org/browse/DROOLS-3802
> Project: Drools
> Issue Type: Bug
> Components: executable model
> Affects Versions: 7.18.0.Final
> Environment: 7.18.0.Final
> 7.18.0.Final-redhat-00002 (RHDM7.3.0)
> 7.14.0.Final-redhat-00004 (RHDM7.1.2)
> Reporter: Hiroko Miura
> Assignee: Luca Molteni
> Priority: Major
> Labels: support
> Attachments: NestedPropertyTest.zip
>
>
> Build of Executable Model fails with the following conditions in LHS:
> * multi-bytes property name (or started with capital letter)
> * accessing the property by the name without using getter.
> * accessing nested property by `.`
> e.g.
> {noformat}
> when
> $fact : Fact( 住所.zipCode == "1000001")
> ...
> {noformat}
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
6 years, 8 months
[JBoss JIRA] (DROOLS-3800) Parser error with executable-model on Map literal expression in constraint
by Luca Molteni (Jira)
[ https://issues.jboss.org/browse/DROOLS-3800?page=com.atlassian.jira.plugi... ]
Luca Molteni updated DROOLS-3800:
---------------------------------
Sprint: 2019 Week 14-16
> Parser error with executable-model on Map literal expression in constraint
> --------------------------------------------------------------------------
>
> Key: DROOLS-3800
> URL: https://issues.jboss.org/browse/DROOLS-3800
> Project: Drools
> Issue Type: Bug
> Components: executable model
> Affects Versions: 7.18.0.Final
> Environment: 7.18.0.Final
> 7.18.0.Final-redhat-00002 (RHDM7.3.0)
> 7.14.0.Final-redhat-00004 (RHDM7.1.2)
> Reporter: Hiroko Miura
> Assignee: Luca Molteni
> Priority: Major
> Labels: support
> Attachments: MapLiteralTest.zip
>
>
> When MAP literal expression is used in LHS like the following
> {noformat}
> when
> $fact: Fact(
> calc(["src":name, "target":"TEST"])
> )
> ...
> {noformat}
> KieBase build as Executable Model fails with parser error like:
> {noformat}
> org.drools.javaparser.ParseProblemException:
> Encountered unexpected token: "[" "["
> at line 1, column 6.
> Was expecting one of:
> ")"
> {noformat}
> This error does not happen when building this rule as normal kjar.
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
6 years, 8 months
[JBoss JIRA] (DROOLS-3815) Remove duplicated code in DMN validator
by Tibor Zimanyi (Jira)
[ https://issues.jboss.org/browse/DROOLS-3815?page=com.atlassian.jira.plugi... ]
Tibor Zimanyi updated DROOLS-3815:
----------------------------------
Description:
There is some code duplication in DMN validator code. E.g. in class DMNDTAnalyser. These duplications should be refactored, so the code is maintainable more easily.
Deliverables:
- No code in kie-dmn-validation is marked as duplicate when doing static analysis of the code.
was:There is some code duplication in DMN validator code. E.g. in class DMNDTAnalyser. These duplications should be refactored, so the code is maintainable more easily.
> Remove duplicated code in DMN validator
> ---------------------------------------
>
> Key: DROOLS-3815
> URL: https://issues.jboss.org/browse/DROOLS-3815
> Project: Drools
> Issue Type: Task
> Components: dmn engine
> Affects Versions: 7.19.0.Final
> Reporter: Tibor Zimanyi
> Assignee: Tibor Zimanyi
> Priority: Major
>
> There is some code duplication in DMN validator code. E.g. in class DMNDTAnalyser. These duplications should be refactored, so the code is maintainable more easily.
> Deliverables:
> - No code in kie-dmn-validation is marked as duplicate when doing static analysis of the code.
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
6 years, 8 months
[JBoss JIRA] (DROOLS-3815) Remove duplicated code in DMN validator
by Tibor Zimanyi (Jira)
Tibor Zimanyi created DROOLS-3815:
-------------------------------------
Summary: Remove duplicated code in DMN validator
Key: DROOLS-3815
URL: https://issues.jboss.org/browse/DROOLS-3815
Project: Drools
Issue Type: Task
Components: dmn engine
Affects Versions: 7.19.0.Final
Reporter: Tibor Zimanyi
Assignee: Tibor Zimanyi
There is some code duplication in DMN validator code. E.g. in class DMNDTAnalyser. These duplications should be refactored, so the code is maintainable more easily.
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
6 years, 8 months