[JBoss JIRA] (WFLY-10448) Obsolete java options -d32, -d64 in jdk-10 affect scripts domain.sh, standalone.sh, appclient.sh
by r searls (Jira)
[ https://issues.redhat.com/browse/WFLY-10448?page=com.atlassian.jira.plugi... ]
r searls closed WFLY-10448.
---------------------------
Resolution: Out of Date
Don't mess with these wfy scripts
> Obsolete java options -d32, -d64 in jdk-10 affect scripts domain.sh, standalone.sh, appclient.sh
> ------------------------------------------------------------------------------------------------
>
> Key: WFLY-10448
> URL: https://issues.redhat.com/browse/WFLY-10448
> Project: WildFly
> Issue Type: Bug
> Components: Scripts
> Affects Versions: 13.0.0.Final, 16.0.0.Final
> Reporter: r searls
> Assignee: r searls
> Priority: Minor
>
> bin\scripts domain.sh, standalone.sh and appclient.sh have a section of code that uses java option -d32 and -d64 when calling java to check the HotSpot type. These 2 options have been removed from JDK-10. They are marked as deprecated in JDK-9 but still function.
> These options are used in determining if '-server' is added to JAVA_OPTS. Enhancements need to be made to the scripts to check the JDK version and take appropriate action is assigning the value '-server'.
> The code affected
> {code:java}
> # Check for -d32/-d64 in JAVA_OPTS
> JVM_OPTVERSION="-version"
> JVM_D64_OPTION=`echo $JAVA_OPTS | $GREP "\-d64"`
> JVM_D32_OPTION=`echo $JAVA_OPTS | $GREP "\-d32"`
> test "x$JVM_D64_OPTION" != "x" && JVM_OPTVERSION="-d64 $JVM_OPTVERSION"
> test "x$JVM_D32_OPTION" != "x" && JVM_OPTVERSION="-d32 $JVM_OPTVERSION"
> # If -server not set in JAVA_OPTS, set it, if supported
> SERVER_SET=`echo $JAVA_OPTS | $GREP "\-server"`
> if [ "x$SERVER_SET" = "x" ]; then
> # Check for SUN(tm) JVM w/ HotSpot support
> if [ "x$HAS_HOTSPOT" = "x" ]; then
> HAS_HOTSPOT=`"$JAVA" $JVM_OPTVERSION -version 2>&1 | $GREP -i HotSpot`
> fi
> # Check for OpenJDK JVM w/server support
> if [ "x$HAS_OPENJDK" = "x" ]; then
> HAS_OPENJDK=`"$JAVA" $JVM_OPTVERSION 2>&1 | $GREP -i OpenJDK`
> fi
> # Check for IBM JVM w/server support
> if [ "x$HAS_IBM" = "x" ]; then
> HAS_IBM=`"$JAVA" $JVM_OPTVERSION 2>&1 | $GREP -i "IBM J9"`
> fi
> # Enable -server if we have Hotspot or OpenJDK, unless we can't
> if [ "x$HAS_HOTSPOT" != "x" -o "x$HAS_OPENJDK" != "x" -o "x$HAS_IBM" != "x" ]; then
> # MacOS does not support -server flag
> if [ "$darwin" != "true" ]; then
> PROCESS_CONTROLLER_JAVA_OPTS="-server $PROCESS_CONTROLLER_JAVA_OPTS"
> HOST_CONTROLLER_JAVA_OPTS="-server $HOST_CONTROLLER_JAVA_OPTS"
> JVM_OPTVERSION="-server $JVM_OPTVERSION"
> fi
> fi
> else
> JVM_OPTVERSION="-server $JVM_OPTVERSION"
> fi
> {code}
> Here is the output of the currently supported java versions
> Doc for jdk-8 states
> > java -help
> where options include:
> -d32 use a 32-bit data model if available
> -d64 use a 64-bit data model if available
> Using these options tell if the version supports 32-bit or 64-bit
> > java -d32 -version
> Error: This Java instance does not support a 32-bit JVM.
> Please install the desired version.
> > java -d64 -version
> java version "1.8.0_72"
> Java(TM) SE Runtime Environment (build 1.8.0_72-b15)
> Java HotSpot(TM) 64-Bit Server VM (build 25.72-b15, mixed mode)
> Doc for jdk-9 states
> > java -help
> where options include:
> -d32 Deprecated, will be removed in a future release
> -d64 Deprecated, will be removed in a future release
> > java -d32 -version
> Error: This Java instance does not support a 32-bit JVM.
> Please install the desired version.
> > java -d64 -version
> openjdk version "9.0.4"
> OpenJDK Runtime Environment (build 9.0.4+11)
> OpenJDK 64-Bit Server VM (build 9.0.4+11, mixed mode)
> Doc for jdk-10
> > java -help
> No documentation for these options listed
> > java -d32 -version
> Unrecognized option: -d32
> Error: Could not create the Java Virtual Machine.
> Error: A fatal exception has occurred. Program will exit.
> > java -d64 -version
> Unrecognized option: -d64
> Error: Could not create the Java Virtual Machine.
> Error: A fatal exception has occurred. Program will exit.
> Obsolete java options -d32, -d64 in jdk-10 affect scripts domain.sh, standalone.sh
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
5 years, 7 months
[JBoss JIRA] (WFCORE-5151) dir-contexts referral-mode attribute upper/lower case discrepancy
by Ricardo Martin Camarero (Jira)
[ https://issues.redhat.com/browse/WFCORE-5151?page=com.atlassian.jira.plug... ]
Ricardo Martin Camarero commented on WFCORE-5151:
-------------------------------------------------
This issue is triggered by ELY-1637, and I think the only issue is that we need to also change the default value to use toString() instead of name(). Values are valid in upper and lower case anyway, because of how EnumValidator works, but they are re-set to the toString() value. That's why the value is transformed into the lower case value.
> dir-contexts referral-mode attribute upper/lower case discrepancy
> -----------------------------------------------------------------
>
> Key: WFCORE-5151
> URL: https://issues.redhat.com/browse/WFCORE-5151
> Project: WildFly Core
> Issue Type: Bug
> Components: Security
> Affects Versions: 13.0.0.Beta6
> Reporter: Jan Stourac
> Assignee: Ricardo Martin Camarero
> Priority: Minor
> Attachments: reproducer.sh
>
>
> There seems to be a discrepancy of the '/elytron/dir-context[referral-mode]' attribute represented value.
> When there is no value set (default is applied), then particular value is printed in upper-case - {{IGNORE}}. Although, when we set custom value, then when we try to read it, it is printed in lower-case now, e.g. {{ignore}} (lower-case is also saved in raw xml configuration).
> This behavior started with {{WildFly 15.0.0.Final}} and is still present in {{WildFly 20.0.0.Final}}. Not sure whether this change was intentional. I was able to find only this issue which may be kind of related WFCORE-3971.
> In {{WildFly 14.0.0.Final}} there was always upper-case value printed.
> What is the issue here:
> # If this change was NOT intentional -> consider whether we would like to go to original behavior (upper-case returned always, including raw xml)
> # If this change was intentional -> we should probably update so that even default value is lower-case as otherwise this behavior can be confusing for the customer - sometimes there is printed value in upper-case only, otherwise lower-case only. Also, this may be complication for customer automation scripts too.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
5 years, 7 months
[JBoss JIRA] (WFCORE-5151) dir-contexts referral-mode attribute upper/lower case discrepancy
by Ricardo Martin Camarero (Jira)
[ https://issues.redhat.com/browse/WFCORE-5151?page=com.atlassian.jira.plug... ]
Ricardo Martin Camarero reassigned WFCORE-5151:
-----------------------------------------------
Assignee: Ricardo Martin Camarero
> dir-contexts referral-mode attribute upper/lower case discrepancy
> -----------------------------------------------------------------
>
> Key: WFCORE-5151
> URL: https://issues.redhat.com/browse/WFCORE-5151
> Project: WildFly Core
> Issue Type: Bug
> Components: Security
> Affects Versions: 13.0.0.Beta6
> Reporter: Jan Stourac
> Assignee: Ricardo Martin Camarero
> Priority: Minor
> Attachments: reproducer.sh
>
>
> There seems to be a discrepancy of the '/elytron/dir-context[referral-mode]' attribute represented value.
> When there is no value set (default is applied), then particular value is printed in upper-case - {{IGNORE}}. Although, when we set custom value, then when we try to read it, it is printed in lower-case now, e.g. {{ignore}} (lower-case is also saved in raw xml configuration).
> This behavior started with {{WildFly 15.0.0.Final}} and is still present in {{WildFly 20.0.0.Final}}. Not sure whether this change was intentional. I was able to find only this issue which may be kind of related WFCORE-3971.
> In {{WildFly 14.0.0.Final}} there was always upper-case value printed.
> What is the issue here:
> # If this change was NOT intentional -> consider whether we would like to go to original behavior (upper-case returned always, including raw xml)
> # If this change was intentional -> we should probably update so that even default value is lower-case as otherwise this behavior can be confusing for the customer - sometimes there is printed value in upper-case only, otherwise lower-case only. Also, this may be complication for customer automation scripts too.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
5 years, 7 months
[JBoss JIRA] (WFCORE-5147) Add TRACE / DEBUG logging for git integration
by Darran Lofthouse (Jira)
[ https://issues.redhat.com/browse/WFCORE-5147?page=com.atlassian.jira.plug... ]
Darran Lofthouse commented on WFCORE-5147:
------------------------------------------
Also messages that are logged at Level.INFO are missing message IDs
> Add TRACE / DEBUG logging for git integration
> ---------------------------------------------
>
> Key: WFCORE-5147
> URL: https://issues.redhat.com/browse/WFCORE-5147
> Project: WildFly Core
> Issue Type: Task
> Components: Management
> Reporter: Darran Lofthouse
> Assignee: Darran Lofthouse
> Priority: Major
> Fix For: 14.0.0.Beta1
>
>
> The initial load can likely be at DEBUG level but ongoing persist calls should likely be at TRACE as they would be per model update.
> Trying to debug some failures in the test case org.jboss.as.test.manualmode.management.persistence.RemoteSshGitRepositoryTestCase when executed using GitHub actions some messages from jgit seem missing but as there is no debug or trace logging around our use of jgit it is not clear if that logging is missing because jgit is not being called or if the messages are not getting flushed to the logs.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
5 years, 7 months