[
https://issues.redhat.com/browse/WFWIP-359?page=com.atlassian.jira.plugin...
]
Kabir Khan commented on WFWIP-359:
----------------------------------
I have added some better validation to the patch-apply command if they specify a patch
that looks like an XP stream patch.
If the user is not on the XP 2.0 patch stream (i.e. the server does not have the patch
stream set up OR they are on the 1.0 patch stream) you will get the following error:
{code:java}
java.lang.IllegalStateException: You are attempting to install a patch for the
'jboss-eap-xp-2.0' JBoss EAP XP Patch Stream. However this patch stream is not yet
set up in the JBoss EAP server. Run the 'setup' command to enable the patch
stream.
at
org.jboss.eap.util.xp.patch.stream.manager.ManagerPatchApplyAction.doExecute(ManagerPatchApplyAction.java:29)
at
org.jboss.eap.util.xp.patch.stream.manager.ManagerAction.execute(ManagerAction.java:40)
at org.jboss.eap.util.xp.patch.stream.manager.ManagerMain.main(ManagerMain.java:50)
{code}
If they try to install an old XP patch (i.e. 1.0) on a server with the XP 2.0 patch stream
set up, they will get this error:
{code:java}
java.lang.IllegalStateException: The JBoss EAP XP patch stream in the patch
'jboss-eap-xp-1.0' does not match the currently enabled JBoss EAP XP patch stream
[jboss-eap-xp-2.0]
at
org.jboss.eap.util.xp.patch.stream.manager.ManagerPatchApplyAction.doExecute(ManagerPatchApplyAction.java:33)
at
org.jboss.eap.util.xp.patch.stream.manager.ManagerAction.execute(ManagerAction.java:40)
at org.jboss.eap.util.xp.patch.stream.manager.ManagerMain.main(ManagerMain.java:50)
{code}
For base patch stream patches I am not doing any validation. Similarly, if it is neither a
base nor an XP patch (unlikely but you never know) I am not doing any validation.
Server can get to state, where XP2 manager thinks both XP1 and XP2
streams are active
-------------------------------------------------------------------------------------
Key: WFWIP-359
URL:
https://issues.redhat.com/browse/WFWIP-359
Project: WildFly WIP
Issue Type: Bug
Reporter: Martin Svehla
Assignee: Kabir Khan
Priority: Major
If I run setup first, manager activates XP2 stream. However, if I then use patch-apply to
apply XP1 patch, manager lets this action to happen and then thinks both streams are
active.
{code}
$ java -jar manager.jar status --jboss-home=jboss-eap-73
Starting JBoss EAP XP manager (2.0.0.Final-redhat-20200911).
The JBoss EAP XP patch stream is enabled. You may apply patches both from the JBoss EAP
and the JBoss EAP XP patch streams. While enabled the following support policy applies:
[snip]
You are currently on JBoss EAP XP 2.
Enabled patch streams and their cumulative patch ids:
- Patch stream: 'JBoss EAP'; Cumulative patch id: 'base'
- Patch stream: 'jboss-eap-xp-2.0'; Cumulative patch id: 'base'
Available commands in this state are: [remove]
{code}
{code}
$ java -jar manager.jar patch-apply --jboss-home=jboss-eap-7.3
--patch=jboss-eap-xp-1.0.2.GA-redhat-20200911-patch.zip
{code}
{code}
$ java -jar manager.jar status --jboss-home=jboss-eap-7.3
Starting JBoss EAP XP manager (2.0.0.Final-redhat-20200911).
The JBoss EAP XP patch stream setup in the JBoss EAP server seems broken.
Enabled patch streams and their cumulative patch ids:
- Patch stream: 'JBoss EAP'; Cumulative patch id: 'base'
- Patch stream: 'jboss-eap-xp-2.0'; Cumulative patch id: 'base'
- Patch stream: 'jboss-eap-xp-1.0'; Cumulative patch id:
'jboss-eap-xp-1.0.2.CP'
Available commands in this state are: [remove]
{code}
--
This message was sent by Atlassian Jira
(v7.13.8#713008)