[jboss-jira] [JBoss JIRA] (WFLY-11814) PrometheusCollector is not thread-safe causing NPEs during deployment
Paul Ferraro created WFLY-11814:
-----------------------------------
Summary: PrometheusCollector is not thread-safe causing NPEs during
deployment
Key: WFLY-11814
URL: https://issues.jboss.org/browse/WFLY-11814
Project: WildFly
Issue Type: Bug
Components: MP Metrics
Affects Versions: 16.0.0.Final
Reporter: Paul Ferraro
Assignee: Jeff Mesnil
The logic within PrometheusCollector.addMetricFamilySampleSupplier(...) is not thread safe
and can easily trigger an NPE during deployment.
e.g.
{noformat}
10:33:32,706 ERROR [org.jboss.msc.service.fail] (MSC service thread 1-3) MSC000001: Failed
to start service
jboss.deployment.subunit."web-sso.ear"."sso-with-no-auth.war".metrics:
org.jboss.msc.service.StartException in service
jboss.deployment.subunit."web-sso.ear"."sso-with-no-auth.war".metrics:
Failed to start service
at
org.jboss.msc.service.ServiceControllerImpl$StartTask.execute(ServiceControllerImpl.java:1730)
at
org.jboss.msc.service.ServiceControllerImpl$ControllerTask.run(ServiceControllerImpl.java:1558)
at
org.jboss.threads.ContextClassLoaderSavingRunnable.run(ContextClassLoaderSavingRunnable.java:35)
at org.jboss.threads.EnhancedQueueExecutor.safeRun(EnhancedQueueExecutor.java:1982)
at
org.jboss.threads.EnhancedQueueExecutor$ThreadBody.doRunTask(EnhancedQueueExecutor.java:1486)
at
org.jboss.threads.EnhancedQueueExecutor$ThreadBody.run(EnhancedQueueExecutor.java:1377)
at java.lang.Thread.run(Thread.java:748)
Caused by: java.lang.NullPointerException
at
org.wildfly.extension.microprofile.metrics.PrometheusCollector.addMetricFamilySampleSupplier(PrometheusCollector.java:32)
at
org.wildfly.extension.microprofile.metrics.MetricCollector.collectResourceMetrics0(MetricCollector.java:157)
at
org.wildfly.extension.microprofile.metrics.MetricCollector.collectResourceMetrics0(MetricCollector.java:166)
at
org.wildfly.extension.microprofile.metrics.MetricCollector.collectResourceMetrics(MetricCollector.java:92)
at
org.wildfly.extension.microprofile.metrics.deployment.DeploymentMetricService.start(DeploymentMetricService.java:54)
at
org.jboss.msc.service.ServiceControllerImpl$StartTask.startService(ServiceControllerImpl.java:1738)
at
org.jboss.msc.service.ServiceControllerImpl$StartTask.execute(ServiceControllerImpl.java:1700)
... 6 more
{noformat}
--
This message was sent by Atlassian Jira
(v7.12.1#712002)