[jboss-jira] [JBoss JIRA] (JGRP-1523) FD_ALL does not unsuspect on heartbeat

[ https://issues.jboss.org/browse/JGRP-1523?page=com.atlassian.jira.plugin.... ] Bela Ban edited comment on JGRP-1523 at 10/19/12 2:42 AM: ---------------------------------------------------------- [1:26pm] bela: ok, simple solution: [1:26pm] bela: if msg_counts_as_heartbeat is true and we do receive a message (or a heartbeat) from a member in suspected_mbrs, we remove it from suspected_mbrs [1:28pm] jboehm: why not recheck the timestamps in suspect()? [1:28pm] jboehm: should be faster [1:29pm] jboehm: suspect is only called if a new member is suspected, not every message, like update() in this case [1:30pm] bela: So how would you remove A from suspected_mbrs then ? [1:32pm] jboehm: in FD_ALL.suspect() instead of eligible_mbrs.removeAll(suspected_mbrs); iterate over suspected_mebrs, get the time stamp, check if it is OK and remove only if not [1:33pm] jboehm: or something like that [1:34pm] bela: aha. And remove members from suspected_mbrs whose timestamps are below the timeout. Hmm, would work I guess was (Author: belaban): are in the suspect list, but from which we do receive traffic ? [1:25pm] dberindei joined the chat room. [1:26pm] bela: ok, simple solution: [1:26pm] bela: if msg_counts_as_heartbeat is true and we do receive a message from a member in suspected_mbrs, we remove it from suspected_mbrs [1:28pm] jboehm: why not recheck the timestamps in suspect()? [1:28pm] jboehm: should be faster [1:29pm] jboehm: suspect is only called if a new member is suspected, not every message, like update() in this case [1:30pm] bela: So how would you remove A from suspected_mbrs then ? [1:32pm] jboehm: in FD_ALL.suspect() instead of eligible_mbrs.removeAll(suspected_mbrs); iterate over suspected_mebrs, get the time stamp, check if it is OK and remove only if not [1:33pm] jboehm: or something like that [1:34pm] bela: aha. And remove members from suspected_mbrs whose timestamps are below the timeout. Hmm, would work I guess -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira