[jboss-jira] [JBoss JIRA] (AS7-5062) PersistenceUnitRootURL for JPA providers may not be spec compliant

[ https://issues.jboss.org/browse/AS7-5062?page=com.atlassian.jira.plugin.s... ] Craig Ringer edited comment on AS7-5062 at 7/6/12 4:23 AM: ----------------------------------------------------------- It took me a bit of time to find out the answer to how EclipseLink is choking on the persistence unit root. It turns out that it does in fact check the protocol explicitly in org.eclipse.persistence.internal.jpa.deployment.ArchiveFactoryImpl using URL.getProtocol() and looking for "jar" or "file". If neither are found it tries to open the URL as an input stream using ArchiveFactoryImpl.isJarInputStream() , which calls url.openStream(), getting a valid org.jboss.vfs.VirtualJarInputStream, which it wraps in a java.util.jar.JarInputStream and calls JarInputStream.getNextEntry() on. This call returns null, so EclipseLink decides it can't iterate through the contents of the archive. Failing all else, it falls back to return a org.eclipse.persistence.internal.jpa.deployment.URLArchive if its various container-specific hacks and heuristics can't work out a more specific archive adapter to use. The comment on URLArchive says: {quote} * This is an implementation of {@link Archive} when container returns a url * that is not one of the familiar URL types like file or jar URLs. So, we can * not recursively walk thru' its hierarchy. As a result {@link #getEntries()} * returns an empty collection. {quote} Here's the ArchiveFactory code that makes the decision about the archive adapter to use: {code} package org.eclipse.persistence.internal.jpa.deployment; public class ArchiveFactoryImpl implements ArchiveFactory { // ... public Archive createArchive(URL rootUrl, String descriptorLocation, Map properties) throws URISyntaxException, IOException { // ... String protocol = rootUrl.getProtocol(); if ("file".equals(protocol)) { // ... } else if ("jar".equals(protocol)) { // ... } else if (isJarInputStream(rootUrl)){ result = new JarInputStreamURLArchive(rootUrl, descriptorLocation); } else { result = new URLArchive(rootUrl, descriptorLocation); } } } {code} Here's the complete code for ArchiveFactoryImpl.isJarInputStream: {code} /** * This method is called for a URL which has neither jar nor file protocol. * This attempts to find out if we can treat it as a URL from which a JAR * format InputStream can be obtained. * @param url */ protected boolean isJarInputStream(URL url) throws IOException { InputStream in = null; try { in = url.openStream(); if (in == null) { // for directories, we may get InputStream as null return false; } JarInputStream jis = null; try { jis = new JarInputStream(in); if (jis.getNextEntry() == null){// if there is no next entry, this jar stream can't be used return false; } return true; // we are successful in creating a Jar format IS } finally { if (jis != null){ jis.close(); } } } catch (IOException ioe) { if (in != null) { in.close(); } return false; } } {code} was (Author: ringerc): It took me a bit of time to find out the answer to how, exactly, EclipseLink is choking on the persistence unit root. It does, indeed, check the protocol explicitly in org.eclipse.persistence.internal.jpa.deployment.ArchiveFactoryImpl . It falls back to return a org.eclipse.persistence.internal.jpa.deployment.URLArchive if its various container-specific hacks and heuristics can't work out a more specific archive adapter to use. The comment on URLArchive says: {quote} * This is an implementation of {@link Archive} when container returns a url * that is not one of the familiar URL types like file or jar URLs. So, we can * not recursively walk thru' its hierarchy. As a result {@link #getEntries()} * returns an empty collection. {quote} Here's the ArchiveFactory code that makes the decision about the archive adapter to use: {code} package org.eclipse.persistence.internal.jpa.deployment; public class ArchiveFactoryImpl implements ArchiveFactory { // ... public Archive createArchive(URL rootUrl, String descriptorLocation, Map properties) throws URISyntaxException, IOException { // ... String protocol = rootUrl.getProtocol(); if ("file".equals(protocol)) { // ... } else if ("jar".equals(protocol)) { // ... } else if (isJarInputStream(rootUrl)){ result = new JarInputStreamURLArchive(rootUrl, descriptorLocation); } else { result = new URLArchive(rootUrl, descriptorLocation); } } } {code} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira