10:29 a.m.
Multi-pattern accumulate support
--------------------------------
Key: JBRULES-1040
URL: http://jira.jboss.com/jira/browse/JBRULES-1040
Project: JBoss Rules
Issue Type: Feature Request
Security Level: Public (Everyone can see)
Components: Drl Parser/Builder, Reteoo
Affects Versions: 4.0.0.GA
Reporter: Geoffrey De Smet
Assigned To: Mark Proctor
[Edson said there might be already such an issue, but I couldn't find it looking
through jira.]
Something like this should be possible:
$multipleQueensHorizontal : Long()
from accumulate(
$q1 : Queen($id : id, $y : y);
Queen(id > $id, y == $y);
, count($q1)
);
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:54 p.m.
New subject: [JBoss JIRA] Updated: (JBRULES-1040) Multi-pattern accumulate support
[ http://jira.jboss.com/jira/browse/JBRULES-1040?page=all ]
Mark Proctor updated JBRULES-1040:
----------------------------------
Fix Version/s: FUTURE
Multi-pattern accumulate support
--------------------------------
Key: JBRULES-1040
URL: http://jira.jboss.com/jira/browse/JBRULES-1040
Project: JBoss Rules
Issue Type: Feature Request
Security Level: Public(Everyone can see)
Components: Reteoo, Drl Parser/Builder
Affects Versions: 4.0.0.GA
Reporter: Geoffrey De Smet
Assigned To: Mark Proctor
Fix For: FUTURE
[Edson said there might be already such an issue, but I couldn't find it looking
through jira.]
Something like this should be possible:
$multipleQueensHorizontal : Long()
from accumulate(
$q1 : Queen($id : id, $y : y);
Queen(id > $id, y == $y);
, count($q1)
);
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:14 p.m.
New subject: [JBoss JIRA] Assigned: (JBRULES-1040) Multi-pattern accumulate support
[ http://jira.jboss.com/jira/browse/JBRULES-1040?page=all ]
Edson Tirelli reassigned JBRULES-1040:
--------------------------------------
Assignee: Edson Tirelli (was: Mark Proctor)
Multi-pattern accumulate support
--------------------------------
Key: JBRULES-1040
URL: http://jira.jboss.com/jira/browse/JBRULES-1040
Project: JBoss Rules
Issue Type: Feature Request
Security Level: Public(Everyone can see)
Components: Reteoo, Drl Parser/Builder
Affects Versions: 4.0.0.GA
Reporter: Geoffrey De Smet
Assigned To: Edson Tirelli
Fix For: FUTURE
[Edson said there might be already such an issue, but I couldn't find it looking
through jira.]
Something like this should be possible:
$multipleQueensHorizontal : Long()
from accumulate(
$q1 : Queen($id : id, $y : y);
Queen(id > $id, y == $y);
, count($q1)
);
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:20 p.m.
New subject: [JBoss JIRA] Resolved: (JBRULES-1040) Multi-pattern accumulate support
[ http://jira.jboss.com/jira/browse/JBRULES-1040?page=all ]
Edson Tirelli resolved JBRULES-1040.
------------------------------------
Fix Version/s: 4.0.2
(was: FUTURE)
Resolution: Done
Support for multi-pattern accumulate was added. Example:
Rule: Add to the Cheesery, all Cheese pieces whose type there are Persons who like it:
rule "MultiPatternAccumulate" salience 80
when
$cheesery : Cheesery( totalAmount > 30 )
from accumulate( $person : Person( $likes: likes) and $cheese
: Cheese( type == $likes ),
init( Cheesery cheesery = new Cheesery();
),
action( cheesery.addCheese( $cheese ); ),
reverse( cheesery.removeCheese( $cheese );
),
result( cheesery ) );
then
results.add( $cheesery );
end
All connectives used in the source must be explicitly defined, like the "and" in
the above example.
Support still needs to be added to the XML parser and documentation needs to be written.
Will open new tickets for these jobs.
Multi-pattern accumulate support
--------------------------------
Key: JBRULES-1040
URL: http://jira.jboss.com/jira/browse/JBRULES-1040
Project: JBoss Rules
Issue Type: Feature Request
Security Level: Public(Everyone can see)
Components: Reteoo, Drl Parser/Builder
Affects Versions: 4.0.0.GA
Reporter: Geoffrey De Smet
Assigned To: Edson Tirelli
Fix For: 4.0.2
[Edson said there might be already such an issue, but I couldn't find it looking
through jira.]
Something like this should be possible:
$multipleQueensHorizontal : Long()
from accumulate(
$q1 : Queen($id : id, $y : y);
Queen(id > $id, y == $y);
, count($q1)
);
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:30 a.m.
New subject: [JBoss JIRA] Commented: (JBRULES-1040) Multi-pattern accumulate support
[ http://jira.jboss.com/jira/browse/JBRULES-1040?page=comments#action_12378040 ]
Geoffrey De Smet commented on JBRULES-1040:
-------------------------------------------
As far as I can tell, it's not working:
rule "constraintsBroken"
when
$multipleQueensHorizontal : Long()
from accumulate(
$q1 : Queen($id : id, $y : y);
Queen(id > $id, y == $y);
, count($q1)
);
$multipleQueensAscendingDiagonal : Long()
from accumulate(
$q2 : Queen($id : id, $ascendingD : ascendingD);
Queen(id > $id, ascendingD == $ascendingD);
, count($q2)
);
$multipleQueensDescendingDiagonal : Long()
from accumulate(
$q3 : Queen($id : id, $descendingD : descendingD);
Queen(id > $id, descendingD == $descendingD);
, count($q3)
);
then
scoreCalculator.setScore( - $multipleQueensHorizontal -
$multipleQueensAscendingDiagonal - $multipleQueensDescendingDiagonal));
end
this gives problems on the ";" at each end.
so I tried this:
rule "constraintsBroken"
when
$multipleQueensHorizontal : Long()
from accumulate(
$q1 : Queen($id : id, $y : y)
Queen(id > $id, y == $y)
, count($q1)
);
$multipleQueensAscendingDiagonal : Long()
from accumulate(
$q2 : Queen($id : id, $ascendingD : ascendingD)
Queen(id > $id, ascendingD == $ascendingD)
, count($q2)
);
$multipleQueensDescendingDiagonal : Long()
from accumulate(
$q3 : Queen($id : id, $descendingD : descendingD)
Queen(id > $id, descendingD == $descendingD)
, count($q3)
);
then
scoreCalculator.setScore( - $multipleQueensHorizontal -
$multipleQueensAscendingDiagonal - $multipleQueensDescendingDiagonal));
end
which yields:
aused by: org.drools.rule.InvalidRulePackage: [69,6]: unknown:69:6 mismatched token:
[@178,2093:2093=',',<11>,69:6]; expecting type RIGHT_PAREN[69,14]:
unknown:69:14 Unexpected token '$q1'
at org.drools.rule.Package.checkValidity(Package.java:412)
Multi-pattern accumulate support
--------------------------------
Key: JBRULES-1040
URL: http://jira.jboss.com/jira/browse/JBRULES-1040
Project: JBoss Rules
Issue Type: Feature Request
Security Level: Public(Everyone can see)
Components: Drl Parser/Builder, Reteoo
Affects Versions: 4.0.0.GA
Reporter: Geoffrey De Smet
Assigned To: Edson Tirelli
Fix For: 4.0.2
[Edson said there might be already such an issue, but I couldn't find it looking
through jira.]
Something like this should be possible:
$multipleQueensHorizontal : Long()
from accumulate(
$q1 : Queen($id : id, $y : y);
Queen(id > $id, y == $y);
, count($q1)
);
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:32 a.m.
New subject: [JBoss JIRA] Commented: (JBRULES-1040) Multi-pattern accumulate support
[ http://jira.jboss.com/jira/browse/JBRULES-1040?page=comments#action_12378042 ]
Geoffrey De Smet commented on JBRULES-1040:
-------------------------------------------
Maybe it's because I am using functions, which don't work on them yet?
Multi-pattern accumulate support
--------------------------------
Key: JBRULES-1040
URL: http://jira.jboss.com/jira/browse/JBRULES-1040
Project: JBoss Rules
Issue Type: Feature Request
Security Level: Public(Everyone can see)
Components: Drl Parser/Builder, Reteoo
Affects Versions: 4.0.0.GA
Reporter: Geoffrey De Smet
Assigned To: Edson Tirelli
Fix For: 4.0.2
[Edson said there might be already such an issue, but I couldn't find it looking
through jira.]
Something like this should be possible:
$multipleQueensHorizontal : Long()
from accumulate(
$q1 : Queen($id : id, $y : y);
Queen(id > $id, y == $y);
, count($q1)
);
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:40 a.m.
New subject: [JBoss JIRA] Commented: (JBRULES-1040) Multi-pattern accumulate support
[ http://jira.jboss.com/jira/browse/JBRULES-1040?page=comments#action_12378044 ]
Edson Tirelli commented on JBRULES-1040:
----------------------------------------
Geoffrey, look at my example:
"All connectives used in the source must be explicitly defined, like the
"and" in the above example. "
So, you need to use "and", "not", "exists", etc in your
source patterns in the accumulate:
rule "constraintsBroken"
when
$multipleQueensHorizontal : Long()
from accumulate(
$q1 : Queen($id : id, $y : y) and
Queen(id > $id, y == $y)
, count($q1)
);
$multipleQueensAscendingDiagonal : Long()
from accumulate(
$q2 : Queen($id : id, $ascendingD : ascendingD) and
Queen(id > $id, ascendingD == $ascendingD)
, count($q2)
);
$multipleQueensDescendingDiagonal : Long()
from accumulate(
$q3 : Queen($id : id, $descendingD : descendingD) and
Queen(id > $id, descendingD == $descendingD)
, count($q3)
);
then
scoreCalculator.setScore( - $multipleQueensHorizontal -
$multipleQueensAscendingDiagonal - $multipleQueensDescendingDiagonal));
end
Let me know....
BTW, functions DOES work.
Multi-pattern accumulate support
--------------------------------
Key: JBRULES-1040
URL: http://jira.jboss.com/jira/browse/JBRULES-1040
Project: JBoss Rules
Issue Type: Feature Request
Security Level: Public(Everyone can see)
Components: Reteoo, Drl Parser/Builder
Affects Versions: 4.0.0.GA
Reporter: Geoffrey De Smet
Assigned To: Edson Tirelli
Fix For: 4.0.2
[Edson said there might be already such an issue, but I couldn't find it looking
through jira.]
Something like this should be possible:
$multipleQueensHorizontal : Long()
from accumulate(
$q1 : Queen($id : id, $y : y);
Queen(id > $id, y == $y);
, count($q1)
);
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:16 p.m.
New subject: [JBoss JIRA] Commented: (JBRULES-1040) Multi-pattern accumulate support
[ http://jira.jboss.com/jira/browse/JBRULES-1040?page=comments#action_12378137 ]
Geoffrey De Smet commented on JBRULES-1040:
-------------------------------------------
I am pretty sure I tried and's without ; too, I 'll try it again tomorrow :)
Multi-pattern accumulate support
--------------------------------
Key: JBRULES-1040
URL: http://jira.jboss.com/jira/browse/JBRULES-1040
Project: JBoss Rules
Issue Type: Feature Request
Security Level: Public(Everyone can see)
Components: Reteoo, Drl Parser/Builder
Affects Versions: 4.0.0.GA
Reporter: Geoffrey De Smet
Assigned To: Edson Tirelli
Fix For: 4.0.2
[Edson said there might be already such an issue, but I couldn't find it looking
through jira.]
Something like this should be possible:
$multipleQueensHorizontal : Long()
from accumulate(
$q1 : Queen($id : id, $y : y);
Queen(id > $id, y == $y);
, count($q1)
);
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:36 p.m.
New subject: [JBoss JIRA] Commented: (JBRULES-1040) Multi-pattern accumulate support
[ http://jira.jboss.com/jira/browse/JBRULES-1040?page=comments#action_12378139 ]
Edson Tirelli commented on JBRULES-1040:
----------------------------------------
Well, as soon as you do, let me know... it must work, but as you know, Murphy is always
around... :)
Multi-pattern accumulate support
--------------------------------
Key: JBRULES-1040
URL: http://jira.jboss.com/jira/browse/JBRULES-1040
Project: JBoss Rules
Issue Type: Feature Request
Security Level: Public(Everyone can see)
Components: Reteoo, Drl Parser/Builder
Affects Versions: 4.0.0.GA
Reporter: Geoffrey De Smet
Assigned To: Edson Tirelli
Fix For: 4.0.2
[Edson said there might be already such an issue, but I couldn't find it looking
through jira.]
Something like this should be possible:
$multipleQueensHorizontal : Long()
from accumulate(
$q1 : Queen($id : id, $y : y);
Queen(id > $id, y == $y);
, count($q1)
);
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:49 a.m.
New subject: [JBoss JIRA] Commented: (JBRULES-1040) Multi-pattern accumulate support
[ http://jira.jboss.com/jira/browse/JBRULES-1040?page=comments#action_12378192 ]
Geoffrey De Smet commented on JBRULES-1040:
-------------------------------------------
It works :) I was apparently still testing with 4.0.1.SNAPSHOT instead of
4.0.2.SNAPSHOT... rookie mistake.
Though the test times prove that backwards chaining behavior is hurting the local search
solver at the moment:
before: with the logically asserted workaround object
after: with the multipattern accumulate
nqueens08:
before: INFO Solved in 71 steps and 797 time millis spend.
after: INFO Solved in 71 steps and 1516 time millis spend.
nqueens16:
before: INFO Solved in 31 steps and 1453 time millis spend.
after: INFO Solved in 31 steps and 7625 time millis spend.
nqueens32:
before: INFO Solved in 55 steps and 11781 time millis spend.
after: didn't want to wait but the first 3 steps took around 40 seconds.
Great work for getting it fixed, but obviously I can't wait till query's can be
configured to work forward chained :)
Multi-pattern accumulate support
--------------------------------
Key: JBRULES-1040
URL: http://jira.jboss.com/jira/browse/JBRULES-1040
Project: JBoss Rules
Issue Type: Feature Request
Security Level: Public(Everyone can see)
Components: Reteoo, Drl Parser/Builder
Affects Versions: 4.0.0.GA
Reporter: Geoffrey De Smet
Assigned To: Edson Tirelli
Fix For: 4.0.2
[Edson said there might be already such an issue, but I couldn't find it looking
through jira.]
Something like this should be possible:
$multipleQueensHorizontal : Long()
from accumulate(
$q1 : Queen($id : id, $y : y);
Queen(id > $id, y == $y);
, count($q1)
);
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:57 a.m.
New subject: [JBoss JIRA] Commented: (JBRULES-1040) Multi-pattern accumulate support
[ http://jira.jboss.com/jira/browse/JBRULES-1040?page=comments#action_12378200 ]
Mark Proctor commented on JBRULES-1040:
---------------------------------------
we can't forward chain queries, not even sure if that makes sense in concept :)
queries are already lighter, as they are now stateless and don't store as much memory.
The only other idea we had was, when a query has no parameters, was to put the query
object as the last patter, instead of the first, and get it to propagate the data on
demand - the only advantage this really has is it enabled more potential node sharing.
Multi-pattern accumulate support
--------------------------------
Key: JBRULES-1040
URL: http://jira.jboss.com/jira/browse/JBRULES-1040
Project: JBoss Rules
Issue Type: Feature Request
Security Level: Public(Everyone can see)
Components: Reteoo, Drl Parser/Builder
Affects Versions: 4.0.0.GA
Reporter: Geoffrey De Smet
Assigned To: Edson Tirelli
Fix For: 4.0.2
[Edson said there might be already such an issue, but I couldn't find it looking
through jira.]
Something like this should be possible:
$multipleQueensHorizontal : Long()
from accumulate(
$q1 : Queen($id : id, $y : y);
Queen(id > $id, y == $y);
, count($q1)
);
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6587
days inactive
6642
days old
10 comments
3 participants
participants (3)
-
Edson Tirelli (JIRA) -
Geoffrey De Smet (JIRA)
-
Mark Proctor (JIRA)